00:45:22 Monster database of master branch on crawl.develz.org updated to: 0.35-a0-1345-g0f1e910ab6 01:33:33 New branch created: pull/5546 (1 commit) 13https://github.com/crawl/crawl/pull/5546 01:33:34 03Draconius02 07https://github.com/crawl/crawl/pull/5546 * 0.35-a0-1346-gc28ac9e4e3: Fix Warping/Dispersal targeting previews against monsters with Stasis 10(8 minutes ago, 1 file, 10+ 2-) 13https://github.com/crawl/crawl/commit/c28ac9e4e346 04:34:34 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 09:41:29 New branch created: pull/5547 (1 commit) 13https://github.com/crawl/crawl/pull/5547 09:41:30 03Rosstin02 07https://github.com/crawl/crawl/pull/5547 * 0.35-a0-1346-gc83b4af2e2: add runic magic mutation sprite for mountain dwarf 10(2 minutes ago, 1 file, 0+ 0-) 13https://github.com/crawl/crawl/commit/c83b4af2e21d 10:20:01 03Rosstin02 07https://github.com/crawl/crawl/pull/5547 * 0.35-a0-1347-g9d4f92fb17: edits based on regret feedback 10(59 seconds ago, 1 file, 0+ 0-) 13https://github.com/crawl/crawl/commit/9d4f92fb171b 10:55:16 03Rosstin02 07https://github.com/crawl/crawl/pull/5547 * 0.35-a0-1348-g8ccc953ec1: artefact enchanting sprite candidate 10(57 seconds ago, 1 file, 0+ 0-) 13https://github.com/crawl/crawl/commit/8ccc953ec175 11:13:26 03dolorous02 07* 0.35-a0-1346-g183b49ce94: Fix comment typo. 10(25 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/183b49ce94f2 12:00:26 New branch created: firesummon (1 commit) 13https://github.com/crawl/crawl/tree/firesummon 12:00:26 03hellmonk02 07[firesummon] * 0.35-a0-1341-gd3d1b3e8a4: New spell, Stellar Invitation 10(4 minutes ago, 18 files, 139+ 1-) 13https://github.com/crawl/crawl/commit/d3d1b3e8a4d7 12:00:27 New branch created: pull/5548 (1 commit) 13https://github.com/crawl/crawl/pull/5548 12:00:27 Branch pull/5548 updated to be equal with firesummon: 13https://github.com/crawl/crawl/pull/5548 12:31:26 03dolorous02 07* 0.35-a0-1347-gcd9465b059: Add another name to artefact spellbooks. 10(4 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/cd9465b059b1 14:16:07 03CrawlOdds02 07* 0.35-a0-1348-g273c5df028: Fix rounding to the nearest integer 10(31 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/273c5df028f9 14:16:07 03CrawlOdds02 07* 0.35-a0-1349-gcf8c9bca90: Fix some rounding of displayed delays (Hatcher) 10(29 minutes ago, 3 files, 4+ 4-) 13https://github.com/crawl/crawl/commit/cf8c9bca9065 16:43:51 Unstable branch on underhound.eu updated to: 0.35-a0-1349-gcf8c9bca90 (34) 19:25:21 <04d​racoomega> So, the attack class has a bunch of methods that wrap giving 'anonymous' names to unseen actors. (ie: "Something hits you."). See actor_name() and similar. But monster::name() already does this for unseen monsters, without any external checking (with, as far as I can tell, identical results). So does... any of this infrastructure serve any actual purpose anyone else can see? Am I missing something 19:25:53 <04d​racoomega> (I would have assumed that this predated monster::name() doing this automatically, but it doesn't seem like that was the case.) 19:26:38 <04d​racoomega> I was in the process of starting to strip this out, but I thought I'd at least ask if anyone knew otherwise 20:43:43 <04d​racoomega> Oh, on further investigation, while I said that this framework predates monster::name() handling this, I think it actually does not. It just that it was preserved as part of a major refactoring of attacks done in 0.10 at which point I think it may have already been outdated, but was first added in 0.3, when it wasn't: https://github.com/crawl/crawl/commit/0e5f00f8997011546d2010e975bcce3ccd78be91 (Among various other 20:43:44 inscrutabilities, the visibility check for printing a monster name directly only checked whether they were invisible and not whether they were in LoS.) 20:44:58 <04d​racoomega> But dear god, monsters::name() back then went through a ptr_monam(), a monam() and a moname() (the latter two of which are frightfully similarly named) 20:50:26 <04d​racoomega> I love these arguments like gmo_n and glog 20:51:05 <04d​racoomega> I think they are reused C-style string buffers? 23:13:28 Unstable branch on cbro.berotato.org updated to: 0.35-a0-1349-gcf8c9bca90 (34) 23:31:12 Unstable branch on crawl.develz.org updated to: 0.35-a0-1349-gcf8c9bca90 (34) 23:42:37 Windows builds of master branch on crawl.develz.org updated to: 0.35-a0-1349-gcf8c9bca90