03:32:00 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 05:34:24 03CrawlOdds02 07* 0.35-a0-1323-g3e59668144: Fix rendering of version in webtiles 10(25 minutes ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/3e5966814432 05:53:21 <11O​dds> @gammafunk - you were going to have a think about how to reconcile your needs for spells_path with stopping it from leaking. Did you have a chance to get round to that? 06:31:18 <11O​dds> @o____0 - just looking at https://github.com/crawl/crawl/pull/5472 (which I'm in favour of). For the glyphs change, was it deliberate not to print glyphs in dumps of ongoing games as well as morgues? 08:50:59 <08o​____0> That's not deliberate no. I meant to add glyphs to the seen monster list so if that's in the dump, the glyphs should be too. I'll take a look at today haha 08:52:12 <11O​dds> No need, I know the line that makes it so and I've got a few other premerge fixes! 09:09:22 the other day I drank a potion of mutation and it gave me some effect (weak bones?) and then immediately in the same potion took this mutation away, so after 1 potion, I had nothing. Is this expected behaviour? 09:09:42 I get it if the mutations are all just randomized, and I happened into a fluke-ish circumstance 09:10:42 <11O​dds> Yeah, that's not surprising 09:10:50 <11O​dds> Arguably it's also not great 09:14:48 it was a bit ... odd. but I won't file a bug :) 09:15:58 <11O​dds> Probably worse is https://github.com/crawl/crawl/issues/5449, where a potion does nothing at all 09:16:22 <11O​dds> Not that this precludes your thing from being odd or wrong 🙂 09:38:16 <11O​dds> I've been looking at https://github.com/crawl/crawl/pull/5425, the main effect of which is to make the monster utility show the same spell damage strings as the in-game description (which fixes a whole bunch of spells in the utility). This seems a very sensible idea to me - they are both supposed to show a readable description of the spell damage - but just wanted to check if anyone can think of a reason not to do this? (There are 09:38:16 various things to improve about that PR before merging, just looking for views on that main change) 09:57:38 03RypoFalem02 {CrawlOdds} 07* 0.35-a0-1324-g27858b1998: chardump: note the skills you start with in the skill chart 10(3 weeks ago, 7 files, 27+ 4-) 13https://github.com/crawl/crawl/commit/27858b19986d 09:57:38 03RypoFalem02 {CrawlOdds} 07* 0.35-a0-1325-gfe8228a777: chardump: list monster glyphs in morgue, next to their names 10(3 weeks ago, 3 files, 25+ 8-) 13https://github.com/crawl/crawl/commit/fe8228a77723 12:05:34 <11O​dds> @dracoomega I was looking at https://github.com/crawl/crawl/pull/5439, and thinking that egg tile bookkeeping would be nicer if it was an area_type like silence, liquefaction, etc. I don't suppose if you can remember whether there was some reason you didn't implement it that way? 14:33:47 03CrawlOdds02 07* 0.35-a0-1326-gf22a60d3d9: Remove a misleading uselessness message (roxie puddles) 10(13 minutes ago, 1 file, 3+ 0-) 13https://github.com/crawl/crawl/commit/f22a60d3d954 14:38:35 <04d​racoomega> I'm pretty sure the last time this came up, I was strongly in favor of it. (Or maybe I just said that out loud to Index??). The in-game lookup is much better-maintained than the bot's strings and it seems pretty much entirely upside to use xv's functions for this. (I think the only reason it didn't already is that the bot long predates xv showing spell damage) 14:43:36 <04d​racoomega> Would it really make the bookkeeping that much nicer? (I guess it might now with that PR's change, huh?) In any case, area_type handling was a lot messier back when I wrote seismosaur code. It also didn't need any the capability of the agrid to handle moving areas, since the egg is stationary. It was using a similar idiom to what Frozen Ramparts uses to render its own area of effect (which isn't exactly equivalent, since 14:43:36 that really is marking terrain cells, but was effectively doing a very similar thing.) (Also, a lot of agrid rendering also went through extra layers of indirection when it comes to rendering - setting additional view flags that are only later converted into a tile choice - which felt like overkill. I don't think that is strictly necessary to use it, though?) 14:44:29 <04d​racoomega> But ramparts also sets an fprop on affected cells and then removes it when it's done 14:45:43 <04d​racoomega> %git 6f7dcbe 14:45:44 <04C​erebot> DracoOmega * 0.35-a0-777-g6f7dcbefd5: Refactor and tidy a bunch of agrid handling code (3 months ago, 35 files, 181+ 370-) https://github.com/crawl/crawl/commit/6f7dcbefd5a2 14:47:27 <11O​dds> Oh right I had not realised you had made the agrid stuff nicer fairly recently (when I came to use to for summon forest stuff I found it very nice to add a new thing to) 14:50:44 <11O​dds> I do tend to think (after that area_type improvement) it would be a bit nicer even before this PR; feels more localised rather than having to be accounted for on cast and death/hatch; and the yeah the PR makes it more so as it can change per turn 14:56:10 <04d​racoomega> Possibly 15:44:14 Unstable branch on underhound.eu updated to: 0.35-a0-1326-gf22a60d3d9 (34) 15:48:57 <09g​ammafunk> I'm working on some crawl related stuff today and tomorrow, so let me get back to you before Saturday is over. qw is close to returning after some long rewrites of a few subsystems and I do need a proper way to answer questions about arbitrary ray paths. I've been using spells.path, so making any new version of that work properly is a priority for me 21:45:30 <09g​ammafunk> Due to changes in Discord's bot policies, Cerebot can no longer see chat messages in non-DM channels unless you mention the bot in your message. From now on, to perform any kind of bot command, you must mention @Cerebot somewhere in your message: @Cerebot !lg @Cerebot *??asterion @Cerebot !addrole DCSS ??test @Cerebot etc. The location of the mention in the message doesn't matter. Any Cerebot mention text will be removed 21:45:31 before processing to prevent it from interfering with the command. DMs still won't require these mentions, only Guild channels do. This change is live now, so please let me know if you have any problems running commands. If you see anyone struggling to run commands because they're not using a mention, please let them know about this change. 21:46:12 <09g​ammafunk> I just rolled this change out. It seems to be working fine, but there may be bugs, so I'm going to watch things a bit before letting people know on other servers 22:36:53 Unstable branch on crawl.develz.org updated to: 0.35-a0-1326-gf22a60d3d9 (34) 22:49:54 <11O​dds> Thanks for keeping the bot botting! 23:02:11 Windows builds of master branch on crawl.develz.org updated to: 0.35-a0-1326-gf22a60d3d9 23:41:09 Unstable branch on cbro.berotato.org updated to: 0.35-a0-1326-gf22a60d3d9 (34) 23:58:12 Monster database of master branch on crawl.develz.org updated to: 0.35-a0-1326-gf22a60d3d9