01:53:35 03WizardIke02 07* 0.35-a0-1261-g269193ad16: Fix crash on demand from crawl.random_range 10(27 minutes ago, 1 file, 11+ 3-) 13https://github.com/crawl/crawl/commit/269193ad167b 02:05:52 <07w​izardike> Do we apply fixes to crash on demand bugs to older versions to? It seems like someone could use this to prevent themself from ever dying as they could trigger it on receiving the "you die" message which I believe is printed before deleting their save file (I tested and this works offline at least) 02:24:23 <11O​dds> I don't think we usually do, and this seems OK, because it would be a very visible form of cheating 02:29:19 <07w​izardike> Not all servers report crashes here I believe. But I guess it would be obvious if went and looked it their crashlogs 02:45:25 <07w​izardike> !lm * crash noun~~"nrolls > 0" 02:45:27 <04C​erebot> No milestones for * (crash noun~~'nrolls > 0'). 02:46:47 <11O​dds> Did you check the other functions? Several certainly look like they could have bad cases 02:57:41 <07w​izardike> I did check the other random functions, but now that I've checked them again I think div_rand_round might have problems with division with zero 03:19:32 03WizardIke02 07* 0.35-a0-1262-g034f1973d3: Fix crash on demand from crawl.div_rand_round 10(6 minutes ago, 1 file, 10+ 2-) 13https://github.com/crawl/crawl/commit/034f1973d3d0 03:33:35 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 06:49:20 <05i​coson> that is the kind of fix that I would historically have backported to a few earlier stable versions, fwiw 06:51:56 <05i​coson> I'm not 100% sure that will crash on all systems / cases? 06:52:56 <05i​coson> iirc it's undefined on the c++ standard but if the args are floats it mostly won't crash. (But sometimes it will.) 06:53:22 <05i​coson> except I guess they aren't floats 10:09:23 <08n​icolae> three day weekend, at some point i should try to make a PR for my shoals decor vaults finally 11:45:01 New branch created: targepractice (1 commit) 13https://github.com/crawl/crawl/tree/targepractice 11:45:02 03hellmonk02 07[targepractice] * 0.35-a0-1245-gf4ca4327f1: New earlygame unrand, platinum targe 10(5 minutes ago, 11 files, 44+ 2-) 13https://github.com/crawl/crawl/commit/f4ca4327f1e1 11:45:02 New branch created: pull/5501 (1 commit) 13https://github.com/crawl/crawl/pull/5501 11:45:02 Branch pull/5501 updated to be equal with targepractice: 13https://github.com/crawl/crawl/pull/5501 12:02:47 04Build failed for 08targepractice @ f4ca4327 06https://github.com/crawl/crawl/actions/runs/37975374650 12:23:41 Following up my investigation from yesterday, I wanted to ask about a discrepancy in shadow creatures. Like most summon spells, shadow creatures has a summon cap (4), and monsters won't consider casting the spell unless the number of summons on the field are less than the cap. But there's a second way in which summons are "capped", which is used to 12:23:41 determine which summons should be forcibly expired when new summons arrive, and shadow creatures has special handling here in order to accommodate summoning bands, which only count as one single monster toward the cap (and the entire band gets forcibly dismissed together), but *only* for the purposes of expiration. So the question is, should the 12:23:42 logic be made more consistent between these two circumstances (choosing to cast the spell vs choosing what monsters to dismiss), which would result in an effective buff to shadow creatures by allowing it to be cast more often and have more monsters on the field? 12:40:48 I'm leaning towards the answer being "yes" 12:42:23 note that, for any single cast of shadow creatures, monsters are already limited by the number of monsters they can create in a single cast by a random2 roll that's basically their HD/5, so it would take a while to actually reach the effectively higher cap 14:23:42 New branch created: pull/5502 (4 commits) 13https://github.com/crawl/crawl/pull/5502 14:23:45 03desiderautumn02 07https://github.com/crawl/crawl/pull/5502 * 0.35-a0-1263-g80d15eb39b: Refactor logic for dismissing oldest summons 10(2 hours ago, 3 files, 45+ 43-) 13https://github.com/crawl/crawl/commit/80d15eb39b3a 14:23:45 03desiderautumn02 07https://github.com/crawl/crawl/pull/5502 * 0.35-a0-1264-g83da311dea: Address message spam from overeager summoners 10(63 minutes ago, 3 files, 40+ 3-) 13https://github.com/crawl/crawl/commit/83da311dea0c 14:23:45 03desiderautumn02 07https://github.com/crawl/crawl/pull/5502 * 0.35-a0-1265-g03c573a6f5: Add monspell entries for the strange machine 10(29 minutes ago, 1 file, 8+ 0-) 13https://github.com/crawl/crawl/commit/03c573a6f5e3 14:23:45 03desiderautumn02 07https://github.com/crawl/crawl/pull/5502 * 0.35-a0-1266-gdc8c212dc2: Consistently count bands for shadow creatures cap 10(16 minutes ago, 1 file, 19+ 2-) 13https://github.com/crawl/crawl/commit/dc8c212dc290 15:43:56 Unstable branch on underhound.eu updated to: 0.35-a0-1262-g034f1973d3 (34) 22:30:38 Unstable branch on crawl.develz.org updated to: 0.35-a0-1262-g034f1973d3 (34) 22:41:32 Windows builds of master branch on crawl.develz.org updated to: 0.35-a0-1262-g034f1973d3 23:12:24 Unstable branch on cbro.berotato.org updated to: 0.35-a0-1262-g034f1973d3 (34) 23:43:12 BAK0M (L12 OpSh) ASSERT(!invalid_monster(&mons)) in 'mon-death.cc' at line 2513 failed. (D (Sprint)) 23:45:20 Monster database of master branch on crawl.develz.org updated to: 0.35-a0-1262-g034f1973d3