03:35:51 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 03:39:11 <04dracoomega> I took a quick look at it and things seem in decent order to me. (The one quibble I have is that it should describe the earth/conj staff damage differently. I realize we're using very simple shorthand for monster staff damage since there's no room. But we're writing full sentences here, so it ought to actually mention the flying thing specifically. And 'conj' damage isn't really a thing. I think it could just say 'damage', tbh, but 03:39:11 'energy' is closer to reasonable than conj is, imo?) 03:44:39 <11Odds> We write irresistible damage for miscasts, right? 03:54:49 <04dracoomega> Apparently 03:54:57 <04dracoomega> (Shows how much I read those >.>) 09:12:54 03dolorous02 07* 0.35-a0-983-gce5df4a3ae: Add another Singing Sword line. 10(5 minutes ago, 1 file, 3+ 0-) 13https://github.com/crawl/crawl/commit/ce5df4a3aeed 09:37:29 03CrawlOdds02 07* 0.35-a0-984-g534b615f34: Fix Hep permanent ability default letters 10(6 minutes ago, 1 file, 6+ 1-) 13https://github.com/crawl/crawl/commit/534b615f3495 10:26:36 03hellmonk02 07[staffdesc] * 0.35-a0-979-g3b018bb6c1: minor description tweaks 10(68 seconds ago, 1 file, 5+ 3-) 13https://github.com/crawl/crawl/commit/3b018bb6c1b7 10:26:36 Branch pull/5403 updated to be equal with staffdesc: 13https://github.com/crawl/crawl/pull/5403 10:26:53 <09hellmonk> I elected to go with "energy" for the conj staff, I don't like "irresistible" and I think it confuses people about whether or not it checks AC 10:27:03 <09hellmonk> (in general) 10:28:04 <09hellmonk> though it's true we use it elsewhere 10:29:13 <04dracoomega> That is reasonable. (Though there's hope that the spell display actually saying things check AC may slowly whittle away at that misconception) 10:29:23 <04dracoomega> Maybe >.> 10:29:59 <09hellmonk> maybe 10:30:26 <04dracoomega> Incidentally, I was wondering if you had a reason why Hana's Scimitar cares about MP after casting the spell instead of before? It feels like 'current MP before casting' would be slightly more intuitive (to me, anyway). (The required threshold could be higher for the same equivalent power.) 10:30:49 <09hellmonk> it is a bit complicated because of the place where enhancers are checked 10:31:03 <09hellmonk> we'd have to store pre-cast mp value and pass it to the enhancer function 10:31:10 <04dracoomega> So it was less about deliberate design and more that the code makes it easier to do that way? 10:31:13 <09hellmonk> yeah 10:32:08 <04dracoomega> However, I don't think you need to save it. You can just add spell_mana(spell) back in, no? 10:32:09 <09hellmonk> I'm not sure which is "more intuitive" to the average player? I think we show the mp deduction before selecting targets, so for many conjurations it's going to be weird in the display regardless 10:32:41 <09hellmonk> oh, can we? I wasn't sure if we had a single function that accounted for cost reductions both ways 10:33:02 <09hellmonk> I wouldn't mind changing it to 80% MP before paying then 10:33:13 <04dracoomega> This is what the normal MP payment uses and seems deterministic, so it ought to be fine 10:33:43 <09hellmonk> ok, I'll make that adjustment 10:33:48 <09hellmonk> 80%/80% feels nicer 10:33:50 <04dracoomega> Also: what is this supposed to do on djinni? I think, as implemented, it may always work?? 10:34:08 <04dracoomega> (Since any multiple of zero is equal to another multiple of zero) 10:34:10 <09hellmonk> I thought I had it set to not provide the enhancer if you have no mp 10:34:18 <04dracoomega> Oh, maybe I missed that 10:34:21 <09hellmonk> if not I'll add that check, it should not function for them 10:34:36 <04dracoomega> Wait, sorry, I did yes 10:34:41 <09hellmonk> really don't need to make Dj better at universally enhancing their spells 10:35:17 <04dracoomega> I suppose... (But I might have said that 80+% HP for the bonus feels sensible enough) 10:35:53 <09hellmonk> in general I prefer to keep "things that affect MP do not do anything to Dj" as a hard rule to keep them from getting too complicated 10:36:02 <04dracoomega> That is reasonable 10:36:06 <09hellmonk> since that's one of the problems they had the first time 10:36:14 <04dracoomega> (It probably wants an equip message saying this, though, like several other artefacts have) 10:36:21 <09hellmonk> oh, sure. 11:00:50 03hellmonk02 07[bigbonk] * 0.35-a0-907-g7b38be7574: Adjust Hana's Scimitar 10(4 minutes ago, 3 files, 21+ 4-) 13https://github.com/crawl/crawl/commit/7b38be757407 11:00:50 Branch pull/5398 updated to be equal with bigbonk: 13https://github.com/crawl/crawl/pull/5398 12:12:28 03DracoOmega02 07* 0.35-a0-985-g749c9a513a: Reduce cases of allies just glaring at unreachable foes (ogregutan, Odds) 10(89 seconds ago, 1 file, 5+ 1-) 13https://github.com/crawl/crawl/commit/749c9a513a2d 12:43:36 iamserjio (L24 OpWn) ASSERT(m.alive()) in 'mon-transit.cc' at line 333 failed. (Depths:3) 13:55:39 <08o____0> !crash iamserjio 13:55:41 <04Cerebot> 36. iamserjio, XL24 OpWn, T:58628 (milestone): https://underhound.eu/crawl/morgue/iamserjio/crash-iamserjio-20260904-194335.txt 14:28:42 <11Odds> ^ Looks like a summoned monster tries to start lurking, lurking times out its summon timer, it dies, the lurking code is sad 14:34:36 <09hellmonk> presumably temp summoned monsters should not start lurking 14:35:31 <11Odds> Possibly lurkers should never be summoned? TBH I'm not really up to speed on lurking, @dracoomega will know best 🙂 14:40:53 <06dolorous_84348> I've been looking into issue #5404, and it shows that the current formula in mon-info.cc for reaching range is not always correct, although I'm currently at a loss as to how to fix it properly. If you edit Geryon to remove his Summon Sin Beast ability (so that he focuses on attacking rather than summoning) and change his starting equipment from the Horn of Geryon to the Rift unrand, his attack range in xv should be 3 (his innate 14:40:53 attack range is 2, but with the changes, he's wielding Rift with its attack range of 3). However, after that, with the current code, his attack range in xv is still listed as 2 and he won't attack with Rift at a range of 3. That's of course a hypothetical and impossible without editing the code, but something is definitely up. (I've also mentioned the hypothetical case in the issue itself, for the record.) 14:42:15 <06dolorous_84348> !issue 5404 14:42:16 <04Cerebot> https://github.com/crawl/crawl/issues/5404 14:43:15 <11Odds> Huh 14:48:00 <04dracoomega> Yeah, that seems like the right call. (Only permanently hostile monsters ever lurk, but I'd neglected to consider monster summons that can pull them.) 14:52:30 <11Odds> On the bug described in the issue itself, I think perhaps the mon-info formula just has an off by one error here: https://github.com/crawl/crawl/blob/534b615f3495fa70944e0b282616dba5dfefa314/crawl-ref/source/mon-info.cc#L1793 ? Attacks and weapons both have reach starting at 1 so I think it needs to subtract 1? 14:53:39 <06dolorous_84348> I'll test that, thanks. 14:58:28 <04dracoomega> Geryon doesn't have a weapon attack at all 14:58:42 <04dracoomega> It's not some weird reach range polearm behavior here 14:58:50 <04dracoomega> His only attack is a tail slap 15:00:01 <04dracoomega> (If he actually did have a normal hit attack with reaching, it should stack with the polearm) 15:00:24 <04dracoomega> Though no enemies currently have innate reaching on an attack that can use a weapon 15:02:05 <04dracoomega> The only actual user of monster_info::reach_range() (besides a clua function) at the moment does seem to be the part that checks if a dancing weapon is a polearm. 15:03:01 <06dolorous_84348> Oops. I was looking at the monuse_starting_equipment flag he still has set. Since Summon Sin Beast is an ability he has that he can use regardless of whether he has the Horn of Geryon in his starting equipment or not, maybe he doesn't need it set? 15:03:28 <04dracoomega> I suspect he won't actually hold onto the horn at all without it 15:03:45 <04dracoomega> Like, the game probably just won't give it to him 15:04:00 <06dolorous_84348> Another thing I can test, then. 15:11:41 <06dolorous_84348> You're right; he isn't generated with the horn without that set, even if I add "forceitem = true" to the case in mon-gear.cc that gives him the horn. 15:27:30 <06dolorous_84348> And after modifying Geryon to add a weapon attack, he does attack properly and list the proper range for the weapon attack in addition to his unarmed attack, so there's no problem there. 15:29:18 <06dolorous_84348> Yes, that appears to be it; thanks! At least I've learned some things today. 15:40:09 03dolorous02 07* 0.35-a0-986-g2c7e200ab2: Fix off-by-one in reaching range check (Odds). 10(21 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/2c7e200ab245 15:43:55 Unstable branch on underhound.eu updated to: 0.35-a0-985-g749c9a513a (34) 18:16:17 StegaS (L19 GrEE) ASSERT(mon.alive()) in 'god-conduct.cc' at line 1057 failed. (Snake:3) 18:18:25 <08o____0> !crash stegas 18:18:25 <04Cerebot> 1. StegaS, XL19 GrEE, T:31743 (milestone): https://cbro.berotato.org/morgue/StegaS/crash-StegaS-20260905-011607.txt 18:55:58 <08o____0> The only way I could see this happening is if something took damage during mons::move_to 18:56:37 <08o____0> But I don't see anything here that would do that 18:58:00 <08o____0> monster::move_to I meant 19:02:04 <08o____0> oh and even that is called with defer_finalisation=true so I don't think that would even cause it 19:02:16 <09hellmonk> At a glance it looks like it's trying to move asterions spectral demon blade after asterion dies 19:02:23 <09hellmonk> but I haven't checked closely 19:02:55 <08o____0> Yeah that's what I thought at first too 19:03:11 <08o____0> But can't reproduce that and looking at the code don't see how it would happen 19:21:15 <08o____0> > Your tendrils lash around Asterion's +1 spectral demon blade and pull it to the > ground! (amusingly that doesn't dismiss the spectral weapon but still doesn't seem to explain the crash) 20:19:23 <09hellmonk> I should probably try to get the resonance and death ego reworks in this version too. 20:19:43 <09hellmonk> Did we ever finalize what we wanted to do with those? 20:20:18 <06cao> Renew Success by crawl Success certs: crawl.akrasiac.org_ecc 22:30:39 Unstable branch on crawl.develz.org updated to: 0.35-a0-986-g2c7e200ab2 (34) 22:41:50 Windows builds of master branch on crawl.develz.org updated to: 0.35-a0-986-g2c7e200ab2 23:12:49 Unstable branch on cbro.berotato.org updated to: 0.35-a0-986-g2c7e200ab2 (34) 23:18:30 <11Odds> Ah, I think I see what’s up in that spectral crash 23:45:32 Monster database of master branch on crawl.develz.org updated to: 0.35-a0-986-g2c7e200ab2 23:50:21 <06pleasingfungus> i wonder what % of crawl crashes are spectral weapon 23:52:55 <11Odds> When you disarm something with a spectral weapon, it should probably just poof, right?