00:24:13 <11Odds> A burstshroom display bug: we don't currently store summoner_id's on monsterinfos with MF_PERSIST, so when we inspect the burstshroom we can't tell that it is a player one and shouldn't display damage (the check at https://github.com/crawl/crawl/blob/2bf1e9f634fac189f6ae45373c2fa4e362fe19bf/crawl-ref/source/describe.cc#L6826 is inert) Not 100% sure how best to fix this - we deliberately don't mark MF_PERSIST monsters as summoned so that 00:24:13 it's easy to tell which monsters will disappear with their creator, but it would feel odd to set summoner_id while summonded is false 00:33:01 <04dracoomega> I am rather surprised I never noticed this when testing it, tbh 00:34:04 <04dracoomega> I, however, am not sure there's a problem with setting summoner_id while summoned is false? So long as that isn't affecting what is normally visible in the UI. I mean, you are still the summoner internally for many purposes, and this is also 'internal' 00:35:56 <11Odds> I think the other thing it would mean that hovering over summoned things showed their summoner. But this seems probably good? 00:41:27 <04dracoomega> Is it? I'm divided on whether that is positive or confusing. (But it is surely possible to make that not be the case, by checking for a combination of summoner_id and the other MB flag) 00:44:12 <11Odds> Yeah certainly we could make that not the case if we prefer. IDK... I can imagine someone thinking "oh where does this burstshroom come from" and being glad to be pointed towards the shambler, or using it to work out out what to kill to make it go away and being misled 00:44:50 <11Odds> I suppose when I use the "point me to the parent monster" feature it's always so that I can kill the parent, so maybe it's more confusing than useful 00:45:17 <04dracoomega> That was my concern, yeah 00:45:27 <04dracoomega> That it might make things more ambiguous 00:47:01 <11Odds> Yep, I think I lean towards checking the flag 00:49:19 <11Odds> (While I'm there, probably it's friendly to show the correct damage on player burstshrooms as well, rather than just omit it as the current code intends?) 00:52:53 <04dracoomega> Trying to recall if I had a reason for doing this at the time 00:54:31 <11Odds> (It used to show nothing, and then fungal shamblers made it show something) 00:54:54 <04dracoomega> I do recall this, yes 00:55:50 <04dracoomega> (I mean, it has to derive the damage completely differently for player burstshrooms, but I'm not currently seeing a problem with showing it there. Maybe I just felt it was redundant?? I was worried for a bit that the number might lie if you weren't still in the form somehow, but that looks like it's probably not the case?) 00:56:42 <11Odds> I think the number is true, including that burstshrooms update their damage if you change shapeshifting skill 00:56:57 <04dracoomega> Yes, it seems like it 00:57:42 <11Odds> (Which is a tiny tiny oddity) 00:59:22 <04dracoomega> I'm aware of this, but it seemed an incredibly marginal thing to go to the trouble of encoding in the individual mushroom 00:59:46 <11Odds> Oh yeah absolutely 01:00:06 <11Odds> Hard to raise your shapeshifting enough mid fight to ever notice 01:06:59 <04dracoomega> It may be close enough to literally impossible to raise their average damage by even 1 01:08:18 <11Odds> Probably you can if you remove wildshape, but the chances of that actually happening are close enough to zero 01:08:29 <11Odds> Or take an Ash curse, maybe that's more likely 🙂 01:15:01 03CrawlOdds02 07* 0.35-a0-884-gae837eebe2: Fix burstshrooms damage display bug (adinsx) 10(24 minutes ago, 2 files, 12+ 5-) 13https://github.com/crawl/crawl/commit/ae837eebe2a2 01:17:06 <04dracoomega> I think you literally don't have enough time 01:17:28 <04dracoomega> Maybe if you're hasted at the time, I suppose 01:17:56 <11Odds> Oh yes... 03:34:14 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 11:43:16 New branch created: pull/5390 (10 commits) 13https://github.com/crawl/crawl/pull/5390 11:43:21 03Eivin Hatvik02 07https://github.com/crawl/crawl/pull/5390 * 0.35-a0-885-g17a2ea972f: Add Android morgue statistics screen 10(13 days ago, 12 files, 727+ 0-) 13https://github.com/crawl/crawl/commit/17a2ea972f68 11:43:21 03Eivin Hatvik02 07https://github.com/crawl/crawl/pull/5390 * 0.35-a0-886-g8a74c05cf1: Provide a separately installable morgue stats build 10(13 days ago, 3 files, 25+ 5-) 13https://github.com/crawl/crawl/commit/8a74c05cf16e 11:43:21 03Eivin Hatvik02 07https://github.com/crawl/crawl/pull/5390 * 0.35-a0-887-gae1481fea9: Parse Gale Centaur morgues 10(3 days ago, 2 files, 13+ 1-) 13https://github.com/crawl/crawl/commit/ae1481fea9ec 11:43:21 03Eivin Hatvik02 07https://github.com/crawl/crawl/pull/5390 * 0.35-a0-888-gebfeda8906: Keep unrecognized morgue combos in statistics 10(3 days ago, 2 files, 40+ 11-) 13https://github.com/crawl/crawl/commit/ebfeda890644 11:43:21 03Eivin Hatvik02 07https://github.com/crawl/crawl/pull/5390 * 0.35-a0-889-g85dc37256c: Expand Android morgue statistics with V2 insights 10(2 days ago, 8 files, 321+ 53-) 13https://github.com/crawl/crawl/commit/85dc37256c12 11:43:21 03Eivin Hatvik02 07https://github.com/crawl/crawl/pull/5390 * 0.35-a0-890-g6bf67783f9: Recognize constriction deaths in morgue statistics 10(2 days ago, 2 files, 17+ 1-) 13https://github.com/crawl/crawl/commit/6bf67783f95e 11:43:21 03Eivin Hatvik02 07https://github.com/crawl/crawl/pull/5390 * 0.35-a0-891-g668eecf1bf: Use core morgue metadata for statistics 10(2 days ago, 4 files, 43+ 18-) 13https://github.com/crawl/crawl/commit/668eecf1bf24 11:43:21 03Eivin Hatvik02 07https://github.com/crawl/crawl/pull/5390 * 0.35-a0-892-gd472bae63f: Track achievement species against the game roster 10(2 days ago, 7 files, 39+ 5-) 13https://github.com/crawl/crawl/commit/d472bae63f47 11:43:21 03Eivin Hatvik02 07https://github.com/crawl/crawl/pull/5390 * 0.35-a0-893-g6d62201b83: Measure all morgue achievements against game rosters 10(2 days ago, 7 files, 70+ 13-) 13https://github.com/crawl/crawl/commit/6d62201b8367 11:43:21 03Eivin Hatvik02 07https://github.com/crawl/crawl/pull/5390 * 0.35-a0-894-gab4522dee2: Add morgue stats 10(22 hours ago, 13 files, 336+ 294-) 13https://github.com/crawl/crawl/commit/ab4522dee2ce 11:48:03 <08o____0> can't help but think that would be better if it parsed the logfile instead of the morgue and worked for local console/tiles as well 11:50:03 <08o____0> Maybe a web interface is also justificed though the bots and stat sites cover that pretty well 11:59:29 03Brian Power02 {dolorous} 07* 0.35-a0-885-ge179a33248: Spelling: Change AmE Duelist to AusE Duellist 10(13 hours ago, 3 files, 5+ 5-) 13https://github.com/crawl/crawl/commit/e179a33248ef 12:09:17 03dolorous02 07* 0.35-a0-886-g6844b005cd: Fix spelling. 10(4 minutes ago, 1 file, 4+ 4-) 13https://github.com/crawl/crawl/commit/6844b005cd63 15:45:56 Unstable branch on underhound.eu updated to: 0.35-a0-886-g6844b005cd (34) 22:30:50 Unstable branch on crawl.develz.org updated to: 0.35-a0-886-g6844b005cd (34) 22:42:04 Windows builds of master branch on crawl.develz.org updated to: 0.35-a0-886-g6844b005cd 23:12:55 Unstable branch on cbro.berotato.org updated to: 0.35-a0-886-g6844b005cd (34) 23:45:43 Monster database of master branch on crawl.develz.org updated to: 0.35-a0-886-g6844b005cd