03:34:45 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 07:48:14 <08nicolae> tbh i forgot &L existed, i just use &P all the time... 08:05:17 <04dracoomega> &P doesn't really seem to function in the Abyss 08:50:49 <08nicolae> yeah it's been a minute since i've done abyss vaults 09:00:07 <08wormsofcan> got a weird crash 09:00:55 <08wormsofcan> identified a scroll of brand weapon and dropped them, then the game crashed 09:01:08 <08wormsofcan> ERROR in 'prompt.cc' at line 387: slot not a letter: � (-125) 09:02:12 <08wormsofcan> looks like the crash happens when I attempt to read the scroll while it's on the ground 09:06:20 <04dracoomega> Don't suppose you can link an actual crashlog? 09:09:02 <04dracoomega> (I am not sure this will be particularly enlightening, since the real question is how the inventory letter of that item ended up as that, which might not be hinted at in the crashlog, but maybe there's something.) 09:10:15 <08wormsofcan> yeah here's the crash and the save 09:10:15 <08wormsofcan> https://cdn.discordapp.com/attachments/747522859361894521/1540392597388787843/crash-Ratan-20260821-120156.txt?ex=6a89c9e6&is=6a887866&hm=e6876c097a5db797b3d0675d4dae5d411216c2c73ba5507af48990bb50b3c900& 09:10:16 <08wormsofcan> https://cdn.discordapp.com/attachments/747522859361894521/1540392598076657755/Ratan.cs?ex=6a89c9e6&is=6a887866&hm=3e6756032052e205eeac8b6b4ca7a8a378fef9eb7c5b19328fb775e6cefb198a& 09:10:44 <08wormsofcan> identify the scroll in the inventory, drop that and the enchant weapon scroll, then press R to read 09:18:44 <04dracoomega> Thanks 09:21:23 <04dracoomega> Well, good news. It doesn't crash in trunk. 09:21:36 <04dracoomega> (But does if I use the save file in 0.34 and do what you said) 09:23:03 <04dracoomega> I'm not immediately recalling a relevant change on this subject, but it seems plausible it might have gotten incidentally fixed in the meantime 09:29:06 <04dracoomega> ...actually, wait a moment 09:31:07 <04dracoomega> No, it looks like it's more confusing than that. It crashes in the local windows tiles 0.34 I have, but not if I build the 0.34 branch and run it there (since WSL can give me an actual stack trace) 09:35:39 <04dracoomega> "Surely there can't be platform-specific effects in how inventory letters are assigned?" she says. 09:36:06 <04dracoomega> (But I am too close to sleep right now to debug anything cryptic. I'll have to take a look later.) 09:36:44 03dolorous02 07* 0.35-a0-858-g2b7da36901: Add another pattern name and glowing adjective. 10(7 minutes ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/2b7da36901a8 09:36:44 03dolorous02 07* 0.35-a0-859-gbeb8c678c6: Add another unique-related comment to graffiti. 10(5 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/beb8c678c6b9 11:15:14 03dolorous02 07* 0.35-a0-860-g50cf9bef6c: Add another unlikely hybrid to artefacts. 10(7 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/50cf9bef6cf0 14:40:46 03CrawlOdds02 07* 0.35-a0-861-g348c77e6f1: Fix the resists checked by monster strikes 10(4 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/348c77e6f1e9 15:44:19 Unstable branch on underhound.eu updated to: 0.35-a0-861-g348c77e6f1 (34) 15:51:23 -!- OnASnoop1hone is now known as OnASnoopPhone 16:58:10 -!- The topic of #crawl-dev is: Crawl Development | https://github.com/crawl/crawl | Logs: http://s-z.org/crawl-dev/, temporarily http://crawl.akrasiac.org/logs/cheibriados/ | People with +v have commit access, devs on bridged discord as well | General Crawl-related chat to #crawl | Long stuff to a pastebin service, please 17:22:18 <04dracoomega> @Odds Wow, thanks for the catch there T.T (I audibly wailed when I read it ^^; ) 18:37:20 03dolorous02 07* 0.35-a0-862-g446c6fe01d: Fix indentation. 10(62 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/446c6fe01d91 18:40:50 <04dracoomega> I believe I found the underlying cause of this crash (which was, in fact, incorrect on either platform), but I'm trying to figure out now why it crashes on windows but not linux (which is somewhat obnoxious given that I have to use cross-compilation outside my dev environment for it >.>) 18:50:06 <04dracoomega> Okay, solved that too, I think. (isalpha() has locale-dependent behaviour, which was resulting in it sometimes thinking an out of range character was a letter that could be converted into an inventory index and it should be isaalpha() instead. Which is surely not confusing at all.) 18:50:12 <04dracoomega> (Though not the first time this problem has come up) 18:52:40 yeh, this is programmer expectations colliding with i18n 18:52:45 in both directions 18:57:42 03DracoOmega02 07* 0.35-a0-863-g1579eca794: Fix dropped consumables getting garbage internal item slots (canofworms) 10(3 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/1579eca79485 18:57:42 03DracoOmega02 07* 0.35-a0-864-g23377c5232: Remove locale-specific behavior of the soft_item_slot comparator 10(41 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/23377c5232f0 18:57:43 <08wormsofcan> incredible bug 18:58:57 <04dracoomega> Thanks again for that save file. Without it, I might have been stuck in the limbo of "Well, I can't get it to happen on my system." 19:00:17 <04dracoomega> And I guess this was one of the underlying causes of what I thought I fixed here, but never found the source of before 19:00:18 <04dracoomega> %git b117d8a 19:00:19 <04Cerebot> DracoOmega * 0.34-a0-403-gb117d8a9e7: More thoroughly prevent some crashes with inventory menus (1 year, 1 month ago, 1 file, 1+ 1-) https://github.com/crawl/crawl/commit/b117d8a9e7f2 19:01:15 <04dracoomega> Which was apparently an adequate band-aid for webtiles, but not some local installs 19:02:00 <04dracoomega> But getting at (hopefully!) the underlying cause is nice 19:05:03 betting they had an ISO locale instead of a UTF8 one 19:05:13 New branch created: pull/5382 (5 commits) 13https://github.com/crawl/crawl/pull/5382 19:05:16 03dolorous02 07https://github.com/crawl/crawl/pull/5382 * 0.35-a0-863-gb5575f60a4: Add egos.txt to the descriptions database. 10(4 hours ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/b5575f60a41d 19:05:16 03dolorous02 07https://github.com/crawl/crawl/pull/5382 * 0.35-a0-864-gaaf450f29d: Allow lookup-help searches of weapon egos. 10(2 hours ago, 4 files, 85+ 0-) 13https://github.com/crawl/crawl/commit/aaf450f29d14 19:05:16 03dolorous02 07https://github.com/crawl/crawl/pull/5382 * 0.35-a0-865-gb499b06b84: Allow lookup-help searches of armour egos. 10(4 hours ago, 4 files, 87+ 0-) 13https://github.com/crawl/crawl/commit/b499b06b84da 19:05:16 03dolorous02 07https://github.com/crawl/crawl/pull/5382 * 0.35-a0-866-g484612a182: Allow determining missile ego w/o an item. 10(3 hours ago, 3 files, 15+ 9-) 13https://github.com/crawl/crawl/commit/484612a182cd 19:05:16 03dolorous02 07https://github.com/crawl/crawl/pull/5382 * 0.35-a0-867-gca844b1b49: Allow lookup-help searches of missile egos. 10(2 hours ago, 4 files, 87+ 0-) 13https://github.com/crawl/crawl/commit/ca844b1b4932 19:05:43 (C char-based tests won't work with multibyte characters) 19:12:08 Or a Windows code page 20:03:48 03dolorous02 07https://github.com/crawl/crawl/pull/5382 * 0.35-a0-865-g71b16a0948: Add egos.txt to the descriptions database. 10(5 hours ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/71b16a0948a5 20:03:48 03dolorous02 07https://github.com/crawl/crawl/pull/5382 * 0.35-a0-866-g008cec7c40: Allow lookup-help searches of weapon egos. 10(2 hours ago, 4 files, 85+ 0-) 13https://github.com/crawl/crawl/commit/008cec7c4025 20:03:48 03dolorous02 07https://github.com/crawl/crawl/pull/5382 * 0.35-a0-867-g8b42d451e1: Allow lookup-help searches of armour egos. 10(5 hours ago, 4 files, 87+ 0-) 13https://github.com/crawl/crawl/commit/8b42d451e1c6 20:03:48 03dolorous02 07https://github.com/crawl/crawl/pull/5382 * 0.35-a0-868-gdb047b03b5: Allow determining missile ego w/o an item. 10(4 hours ago, 3 files, 15+ 9-) 13https://github.com/crawl/crawl/commit/db047b03b5cd 20:03:48 03dolorous02 07https://github.com/crawl/crawl/pull/5382 * 0.35-a0-869-g1bc7503b6b: Allow lookup-help searches of missile egos. 10(3 hours ago, 4 files, 87+ 0-) 13https://github.com/crawl/crawl/commit/1bc7503b6bf7 20:31:41 03dolorous02 07https://github.com/crawl/crawl/pull/5382 * 0.35-a0-866-gcf331c616a: Allow lookup-help searches of weapon egos. 10(3 hours ago, 4 files, 87+ 0-) 13https://github.com/crawl/crawl/commit/cf331c616a4b 20:31:41 03dolorous02 07https://github.com/crawl/crawl/pull/5382 * 0.35-a0-867-ge27faf58e5: Allow lookup-help searches of armour egos. 10(5 hours ago, 4 files, 89+ 0-) 13https://github.com/crawl/crawl/commit/e27faf58e559 20:31:41 03dolorous02 07https://github.com/crawl/crawl/pull/5382 * 0.35-a0-868-g8733465ed8: Allow determining missile ego w/o an item. 10(4 hours ago, 3 files, 15+ 9-) 13https://github.com/crawl/crawl/commit/8733465ed8cd 20:31:41 03dolorous02 07https://github.com/crawl/crawl/pull/5382 * 0.35-a0-869-g69a93a9d6a: Allow lookup-help searches of missile egos. 10(4 hours ago, 4 files, 89+ 0-) 13https://github.com/crawl/crawl/commit/69a93a9d6a80 21:56:14 03dolorous02 07https://github.com/crawl/crawl/pull/5382 * 0.35-a0-870-g0ddfa78342: Fix green colouring of ego-based menu titles. 10(6 minutes ago, 1 file, 8+ 3-) 13https://github.com/crawl/crawl/commit/0ddfa78342d4 22:03:26 <06dolorous_84348> The solution I found to the green color problem is a bit hackish, but it's either that or figure out how to rewrite the regex in dat/defaults/menu_colours.txt to not trigger on every instance of a line's containing "ego" (thankfully case-sensitive). 22:05:50 <06dolorous_84348> Or maybe come up with a utility function to capitalize the initial character of every word in a title instead of just the first one, but I don't know how useful it'd be. 22:07:13 <06dolorous_84348> Because the ego entries are now the only lookup-help entries with two-word titles. 22:07:28 <06dolorous_84348> In any case, it works, and I'm a bit burned out on the problem for the moment. 22:10:52 <11Odds> Ha. I happened to stumble over it while looking at displaying resists on spells 🙂 22:11:12 <04dracoomega> Big whoops 22:11:42 <11Odds> Easily done, and hard to notice 22:12:10 <04dracoomega> Yeah 22:12:59 <11Odds> Is it just gastronok who benefits? 22:14:24 <04dracoomega> I mean, wouldn't every sleetstrike user have benefitted and every airstrike user suffered some amount? 22:14:50 <11Odds> Yeah but do other monsters use airstrike? 22:16:16 <11Odds> BTW on showing resists - I’m not so sure the right way to do this is flags… so much of this is derivable via zaps that doing that and then having a smaller list of spells where the information is manual feels perhaps better 22:23:44 <04dracoomega> There's also spriggan air mages, wind drakes, Sojobo, and titans! 22:26:27 <04dracoomega> It's possible, but there's also a lot of things-that-aren't-damage-flavour that can't be derived this way. (Like which spells ignore AC, but also a lot of which have, say, an HD check on a secondary effect, like Mercury Arrow). I can't say off the top of my head how many that accounts for. 22:27:30 <11Odds> Yep, definitely is going to need some duplication 22:29:47 <11Odds> But I reckon “derive things from zaps and then have overrides” is going to be quite a lot less manual labelling to make mistakes in 🙂 22:30:25 <04dracoomega> That is probably reasonable, yeah 22:31:05 Unstable branch on crawl.develz.org updated to: 0.35-a0-864-g23377c5232 (34) 22:31:05 <04dracoomega> (It just felt tidy to have it 'all in one place', but I hadn't really considered deriving some and then specifying the rest) 22:35:34 <11Odds> 👍 I’ll see how this way looks when it’s more done 22:42:06 Windows builds of master branch on crawl.develz.org updated to: 0.35-a0-864-g23377c5232 23:12:58 Unstable branch on cbro.berotato.org updated to: 0.35-a0-864-g23377c5232 (34) 23:45:41 Monster database of master branch on crawl.develz.org updated to: 0.35-a0-864-g23377c5232