03:33:33 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 10:00:43 <11Odds> @dracoomega - there's some oddities caused by the recent changes to make eldritch tentacle deaths revert their portals; it can make beams penetrate through the portal when the targeter said they wouldn't, and currently crashes if the death happens on the portal. I reckon perhaps we should delay the terrain reversion to a fineff? 10:33:17 03CrawlOdds02 07* 0.35-a0-842-gca5ed2dcc3: Fix marshalling and unmarshalling of stack flags 10(11 minutes ago, 1 file, 10+ 8-) 13https://github.com/crawl/crawl/commit/ca5ed2dcc3ed 12:50:26 03geekosaur02 {CrawlOdds} 07* 0.35-a0-843-g5f7d476cd6: fix sound conditional in initfile.cc 10(2 days ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/5f7d476cd649 12:55:47 03CrawlOdds02 07* 0.35-a0-844-gd6d3d6370e: Fix listing of sound in features on ?V 10(5 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/d6d3d6370ec3 14:15:22 <08o____0> Maps used (successful, placed incl. vetoed, tried): 0, 19, 19: nicolae_overflow_hidden_temple Caught my eye looking at a mapstat, the vault might be broken. Does transparent take into account stairs? 14:17:12 <11Odds> Hmmmm that is odd, could be related to some recentish map stuff I did. By my understanding it should place but there may be a bug somewhere. Will take a look 14:26:35 <11Odds> (And yeah, transparent vaults should be fine with isolated areas with stairs - it really just makes it as if there's no vault there for connectivity purposes) 14:53:25 <04dracoomega> Strange. A bit surprised this wouldn't have come up before, since even if the old version was buggy in other ways, it did still revert the portal in some cases. I'm taking a look myself now. ...oddly, it doesn't seem to crash per se, but seems to be causing an infinite loop somehow when I kill it with a piercing beam that crosses the portal (but not a non-piercing one) 14:53:47 <11Odds> Ah yeah I did understand that loop 14:54:00 <11Odds> Here 14:54:19 <04dracoomega> Oh, it's a wall monster thing 14:54:43 <11Odds> (But even when fixing this, the case where the beam pierces through the wall still seems probably-wrong to me) 14:54:50 <04dracoomega> I'll be honest: until today, I didn't even realize the portal was 'solid'. (Like, I knew you couldn't step into it, but that's not actually the same thing. It already has a separate habitability check.) 14:55:01 <11Odds> Yeah nor did I until this bug 14:55:10 <04dracoomega> It... seems fine to me to just make it non-solid? 14:55:20 <04dracoomega> While retaining the 'only tentacles can stand here' property 14:55:34 <04dracoomega> Like, starburst not passing through the portal tile feels unexpected to me 14:55:51 <04dracoomega> And this conveniently also fixes this bug, right? 14:56:07 <04dracoomega> It's only a problem specifically because it's a 'wall' 14:56:14 <11Odds> Personally it feels neither expected nor unexpected, and yep it fixes this 14:56:32 <11Odds> (Like, I don't even know what I'd have guessed here) 14:57:26 <04dracoomega> I guess we already have multiple 'a portal is on this tile' features that very much aren't solid (transporters and passages of Golubria) 14:57:55 <11Odds> Yeah, although this is the only one you can't walk into 14:59:07 <11Odds> But I certainly don't think making it non-solid is either weirder or at all important gameplaywise 14:59:13 <04dracoomega> Yeah 14:59:23 <04dracoomega> I think I would be in favor of that approach here 14:59:35 <11Odds> Sound good to me 15:00:38 <04dracoomega> Also, regarding ca5ed2d : what in the world was I thinking when I wrote it that way?? Like, at first glance I was like "What was wrong with it?" followed by "How did I ever think that was right?" (Presumably my brain got tricked into just doing what the existing flag did, by analogy, as wrong as that was >.>) 15:01:45 <11Odds> The first half was a very reasonable operator precedence thing. The other bit... yeah I was a little surprised 🙂 15:03:11 <04dracoomega> I guess it was overlooked since the visible map flags for out of LoS areas are persisted in a different way (and remain). And in LoS, it's reconstructed immediately. 15:03:19 <04dracoomega> So it looks correct 15:03:25 <04dracoomega> Except for autoexplore behavior 15:03:54 <11Odds> Makes sense (I didn't really work out the surrounding stuff tbh) 15:04:21 <11Odds> So yeah looks like I did break the hidden temple when I made it transparent, it falls foul of yet another connectivity check about vaults not breaking up levels 15:04:30 <04dracoomega> (There's an intermediate layer, where the stash flags are turned into map_cell flags, which is what is used to actually render the stack tiles from) 15:04:48 <04dracoomega> Anyway, my apologies and thanks for fixing it 15:05:28 <11Odds> Not at all 15:12:01 <08o____0> Blah I should have included that bit. That mapstat was just d3-10 because I was looking at overflow vaults but I ran a longer one including non-extended non-portal branches and 3 more suspicious vaults came up. I can share and look at it further when I am back at computer 15:12:34 <11Odds> There's one other likely one the same commit probably broke, but certainly interested in the list 15:13:32 <08o____0> Yeah a few more with 0 successes despite double digit tries. Also some with triple digit tries and single digit successes 15:13:57 <11Odds> One solution might be to mark some vaults as exempt from the rule that they can't break up the level. The reason I made them transparent is that we do want them counted in connectivity checks - it's bad if this overflow vault loses its stair and can't be reached (which happened occasionally before this) 15:43:25 Unstable branch on underhound.eu updated to: 0.35-a0-844-gd6d3d6370e (34) 17:18:04 <08o____0> https://gist.github.com/RypoFalem/4f7396104e6ae716309bc09b18c6703c I put it in a gist to accommodate to irc readers. I picked out the suspicious looking stats at the top and the rest is the full mapstat log enter_ziggurat_f needs ' added to the kmask I maybe? I don't understand what ' even does here. Is it vestigial? grunt_spider_rune_island has suspicious stats but hasn't changed recently and has appeared in games somewhat recently. 17:18:04 Something about it is likely to veto the level I guess? 17:46:18 <08o____0> But that spider rune vault placing 19/100 times and the level getting vetoed every time needs looking into heh 17:48:22 <08o____0> Well I guess it's wrong to say /100 18:45:48 <08o____0> heh gonna keep looking into it but I wonder how many other rune endings are this tilted against the weights 18:45:48 <08o____0> https://cdn.discordapp.com/attachments/747522859361894521/1537275946304929812/j3svx1x.png?ex=6a7e734a&is=6a7d21ca&hm=820e1a765df696ccf88d345fd27698934927a7c172085d0029f36ef90e3c5a9a& 22:30:47 Unstable branch on crawl.develz.org updated to: 0.35-a0-844-gd6d3d6370e (34) 23:04:05 Windows builds of master branch on crawl.develz.org updated to: 0.35-a0-844-gd6d3d6370e 23:12:41 Unstable branch on cbro.berotato.org updated to: 0.35-a0-844-gd6d3d6370e (34) 23:45:26 Monster database of master branch on crawl.develz.org updated to: 0.35-a0-844-gd6d3d6370e