00:37:50 <Discord|> <11O​dds> Yes this is 100% right. invalid_monster() is true at exactly the same times as before (i.e. after monster_cleanup is called), but callers actually want three things from it: * To check if the monster is alive (should really always just have been an alive() check) * To use monster names, stats, etc - the check should now just be removed * To check if monster_die has been called (often/always to gate monster_die) - the check is still the
00:37:50 <Discord|> right one.  The thinking here (which I comment in the commit message) is that this gets the main change in while minimising behaviour change; once that's in and running smoothly I plan to do a pass on the uses of invalid_monster().
03:22:15 <NotCheibriados> 03noncinque02 {GitHub} 07https://github.com/crawl/crawl/pull/5317 * 0.35-a0-756-gae4f35547f: Merge branch 'crawl:master' into master 10(26 seconds ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/ae4f35547f00
03:33:17 <Lantell> Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b
04:02:47 <NotCheibriados> 03noncinque02 {GitHub} 07https://github.com/crawl/crawl/pull/5317 * 0.35-a0-757-ga4b00175ed: Update branches.txt 10(59 seconds ago, 1 file, 14+ 16-) 13https://github.com/crawl/crawl/commit/a4b00175edd5
04:55:01 <NotCheibriados> New branch created: pull/5336 (1 commit) 13https://github.com/crawl/crawl/pull/5336
04:55:01 <NotCheibriados> 03Zhang Haocheng02 07https://github.com/crawl/crawl/pull/5336 * 0.35-a0-690-gb4a8e9a184: Break an infinite loop in handle_monsters (#3975) 10(21 hours ago, 1 file, 12+ 10-) 13https://github.com/crawl/crawl/commit/b4a8e9a1846f
14:03:07 -!- Discord|1 is now known as Discord|
15:22:12 <Discord|> <04d​racoomega> This makes sense to me. (And I don't think I have anything else to add, at the moment.)
15:43:03 <Lantell> Unstable branch on underhound.eu updated to: 0.35-a0-690-g744d22ced1 (34)
16:13:32 -!- TAS-2012v is now known as TAS_2012v
16:22:29 <NotCheibriados> 03Zhang Haocheng02 {WizardIke} 07* 0.35-a0-691-gc2c2f96fae: Break an infinite loop in handle_monsters (#3975) 10(33 hours ago, 1 file, 12+ 10-) 13https://github.com/crawl/crawl/commit/c2c2f96faed6
16:24:39 <NotCheibriados> 03Perry Fraser02 {WizardIke} 07* 0.35-a0-692-g93e4083ba9: fix: make spectator label singular when applicable 10(3 months ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/93e4083ba97a
22:36:08 <Gretell> Unstable branch on crawl.develz.org updated to: 0.35-a0-692-g93e4083ba9 (34)
23:00:16 <Gretell> Windows builds of master branch on crawl.develz.org updated to: 0.35-a0-692-g93e4083ba9
23:12:22 <Cbrotell> Unstable branch on cbro.berotato.org updated to: 0.35-a0-692-g93e4083ba9 (34)
23:56:20 <Gretell> Monster database of master branch on crawl.develz.org updated to: 0.35-a0-692-g93e4083ba9