02:28:56 New branch created: pull/5317 (45 commits) 13https://github.com/crawl/crawl/pull/5317 02:29:09 03noncinque02 {GitHub} 07https://github.com/crawl/crawl/pull/5317 * 0.35-a0-503-g48de8c64a3: Create ability.txt 10(2 weeks ago, 1 file, 1111+ 0-) 13https://github.com/crawl/crawl/commit/48de8c64a328 02:29:09 03noncinque02 {GitHub} 07https://github.com/crawl/crawl/pull/5317 * 0.35-a0-504-g59db369b4e: Update ability.txt 10(2 weeks ago, 1 file, 15+ 15-) 13https://github.com/crawl/crawl/commit/59db369b4e44 02:29:09 03noncinque02 {GitHub} 07https://github.com/crawl/crawl/pull/5317 * 0.35-a0-505-g107f553c15: Create background.txt 10(2 weeks ago, 1 file, 130+ 0-) 13https://github.com/crawl/crawl/commit/107f553c1589 02:29:09 03noncinque02 {GitHub} 07https://github.com/crawl/crawl/pull/5317 * 0.35-a0-506-gbdfafc5683: Update background.txt 10(2 weeks ago, 1 file, 17+ 15-) 13https://github.com/crawl/crawl/commit/bdfafc5683fc 02:29:09 03noncinque02 {GitHub} 07https://github.com/crawl/crawl/pull/5317 * 0.35-a0-507-g4dbcee911b: done background.txt 10(2 weeks ago, 1 file, 31+ 29-) 13https://github.com/crawl/crawl/commit/4dbcee911b13 02:29:09 03noncinque02 {GitHub} 07https://github.com/crawl/crawl/pull/5317 * 0.35-a0-508-gea28993c91: fix typos 10(2 weeks ago, 1 file, 14+ 13-) 13https://github.com/crawl/crawl/commit/ea28993c9107 02:29:09 03noncinque02 {GitHub} 07https://github.com/crawl/crawl/pull/5317 * 0.35-a0-509-gffb107666b: Create cards.txt 10(2 weeks ago, 1 file, 174+ 0-) 13https://github.com/crawl/crawl/commit/ffb107666b14 02:29:09 03noncinque02 {GitHub} 07https://github.com/crawl/crawl/pull/5317 * 0.35-a0-510-g76319158e0: Update cards.txt 10(2 weeks ago, 1 file, 9+ 4-) 13https://github.com/crawl/crawl/commit/76319158e0de 02:29:09 03noncinque02 {GitHub} 07https://github.com/crawl/crawl/pull/5317 * 0.35-a0-511-gc88e0725a2: Update cards of escape.txt 10(2 weeks ago, 1 file, 18+ 19-) 13https://github.com/crawl/crawl/commit/c88e0725a255 02:29:09 03noncinque02 {GitHub} 07https://github.com/crawl/crawl/pull/5317 * 0.35-a0-512-ge592c9ae05: Update cards.txt 10(2 weeks ago, 1 file, 8+ 8-) 13https://github.com/crawl/crawl/commit/e592c9ae0540 02:29:09 ... and 35 more commits 03:29:21 <11Odds> Following up on the stairs in vaults discussion yesterday, it looks like it does actually happen that vaults lose critical stairs. minmay_isolated_rectangles_in_corner is the example I've seen in a big mapstat - it probably helps that it places two isolated stairs 03:32:47 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 03:34:50 <04dracoomega> I wonder if that sort of structure should get the veto-if-disconnected tag (which I think was floated) rather than doing automatic fixup. Since it's basically leaving the whole vault out. 03:36:23 <11Odds> Yeah masking this one is better than not doing so but it should just fail to generate 03:36:52 <11Odds> But I think transparent might just be enough, if I understand that tag correctly 03:37:25 <04dracoomega> Oh, probably, right 03:37:34 <04dracoomega> transparent does care about stairs, right? 03:37:42 <04dracoomega> I keep thinking it doesn't, but that's possibly false 03:38:21 <11Odds> Yeah a transparent vault will place just fine as long as it's stair-connected, if I've understood things 03:38:49 <11Odds> So I think these vaults that have load-bearing stairs should just be transparent and then they'll work nicely 03:39:50 <04dracoomega> That makes sense to me 07:21:31 chain lightning looks cooler when cast on far away groups of enemies, so what if chain lightning damage was proportional to distance instead of inversely proportional? 07:21:52 it would also sort of make it the antithesis of polar vortex 07:22:15 instead of just tier 3 static discharge electric(lol) boogaloo 07:25:53 thematically makes sense with plasma beam targeting the furthest enemy and CBL (preferrably) detonating at edge of LOS 07:28:17 03CrawlOdds02 07[teleport-closet] * 0.35-a0-593-g56cfdfe4e3: Fix an MSVC build thingy (maybe) 10(17 hours ago, 1 file, 4+ 3-) 13https://github.com/crawl/crawl/commit/56cfdfe4e330 07:28:17 03CrawlOdds02 07[teleport-closet] * 0.35-a0-594-g0ed0c00ffc: Count permanent tele traps as escapes 10(4 hours ago, 1 file, 6+ 2-) 13https://github.com/crawl/crawl/commit/0ed0c00ffcae 07:28:17 03CrawlOdds02 07[teleport-closet] * 0.35-a0-595-g0258fdd950: Move pool fixup earlier 10(7 hours ago, 1 file, 9+ 9-) 13https://github.com/crawl/crawl/commit/0258fdd950e4 07:28:17 03CrawlOdds02 07[teleport-closet] * 0.35-a0-596-g55cf707661: Make some vaults which rely on stairs transparent 10(4 hours ago, 2 files, 3+ 1-) 13https://github.com/crawl/crawl/commit/55cf7076619e 07:28:17 03CrawlOdds02 07[teleport-closet] * 0.35-a0-597-gfc984480bd: Log teleport closets masked during level generation 10(17 hours ago, 1 file, 10+ 1-) 13https://github.com/crawl/crawl/commit/fc984480bd64 07:28:17 03CrawlOdds02 07[teleport-closet] * 0.35-a0-598-ga55afe64b6: Create a tag to allow tele closets 10(3 hours ago, 6 files, 22+ 4-) 13https://github.com/crawl/crawl/commit/a55afe64b6ea 07:36:49 New branch created: pull/5319 (10 commits) 13https://github.com/crawl/crawl/pull/5319 07:36:52 03Amelia02 07https://github.com/crawl/crawl/pull/5319 * 0.35-a0-547-g5d94e9f4b9: Jessica Modified 10(9 days ago, 3 files, 17+ 3-) 13https://github.com/crawl/crawl/commit/5d94e9f4b9fc 07:36:52 03Amelia02 07https://github.com/crawl/crawl/pull/5319 * 0.35-a0-548-gab0625cd59: Update mon-gear.cc 10(9 days ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/ab0625cd59c5 07:36:52 03Amelia02 07https://github.com/crawl/crawl/pull/5319 * 0.35-a0-549-g39714843b5: Update mon-gear.cc 10(9 days ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/39714843b539 07:36:52 03RoGGa02 {GitHub} 07https://github.com/crawl/crawl/pull/5319 * 0.35-a0-559-gfcb7cde2c6: Merge pull request #4 from AmeliaGryffon/Jessica-Modified 10(6 days ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/fcb7cde2c6ec 07:36:52 03RoGGa02 {GitHub} 07https://github.com/crawl/crawl/pull/5319 * 0.35-a0-564-gdbd24358d6: Merge branch 'crawl:master' into master 10(6 days ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/dbd24358d655 07:36:52 03RoGGa02 {GitHub} 07https://github.com/crawl/crawl/pull/5319 * 0.35-a0-577-g8dd1c3c4c5: Merge branch 'crawl:master' into master 10(4 days ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/8dd1c3c4c5d7 07:36:52 03Lucien-main02 {GitHub} 07https://github.com/crawl/crawl/pull/5319 * 0.35-a0-585-gd54d7d30a2: Merge branch 'crawl:master' into master 10(3 days ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/d54d7d30a2ea 07:36:52 03RoGGa02 {GitHub} 07https://github.com/crawl/crawl/pull/5319 * 0.35-a0-586-ga3022414e8: Update .gitignore with additional file patterns 10(15 hours ago, 1 file, 56+ 0-) 13https://github.com/crawl/crawl/commit/a3022414e800 07:36:52 03Bennett Novak02 07https://github.com/crawl/crawl/pull/5319 * 0.35-a0-587-g907616d1ec: adds regal patch 10(13 hours ago, 12 files, 213+ 0-) 13https://github.com/crawl/crawl/commit/907616d1ec4f 07:36:52 03Bennett Novak02 07https://github.com/crawl/crawl/pull/5319 * 0.35-a0-588-g82e721fcba: feat: New Unique Regal and New Monster Spell Charming Aura 10(11 hours ago, 6 files, 67+ 61-) 13https://github.com/crawl/crawl/commit/82e721fcba5d 07:56:02 New branch created: pull/5320 (8 commits) 13https://github.com/crawl/crawl/pull/5320 07:56:02 Branch pull/5320 updated to be equal with teleport-closet: 13https://github.com/crawl/crawl/pull/5320 08:02:19 <11Odds> ^ I'm fairly happy with where this is now. The main risk of it is that I've missed some vaults which deliberately generate tele closets, in which case they'll get those closets masked. I don't know that there's a systematic way to find those. Attached to that PR is a CSV of vaults which generate tele closets; many of these would be fixable, some of them very easily (but also plenty are highly procedural and probably aren't feasible to 08:02:19 fix) 08:07:59 <04dracoomega> Looks very comprehensive. (Honestly, all of this seems very nice. I haven't had a chance to look at the code closely yet, but I trust your thoroughness here. I am not really familiar enough with that part of the codebase myself to skim over it quickly with any confidence.) 08:11:38 <11Odds> Yeah, I'm going to do one more run of mapstat to see if I find and straggling vaults and then put it in 08:13:46 <11Odds> Oh one more type of vault to highlight is these ones in tar that are so blatantly teleport traps that I'm confused as to their intent 08:13:46 <11Odds> https://cdn.discordapp.com/attachments/747522859361894521/1521171829077840012/image.png?ex=6a43dd2a&is=6a428baa&hm=0d4141325cdc65bc3a4e8103e779f94274d36106cdda73d734d0fa5f986a75e0& 08:15:01 <11Odds> They don't really do anything except be a teleport closet... but I think even in Tar we shouldn't assume the player can't possibly run out of teleport 08:16:50 <04dracoomega> That is a bit odd (though there are a few Tar endvaults that feel very... old. Ones that used to be full of secret doors and I guess here just require digging?) 08:19:52 <11Odds> Ahhhh, ancient secret doors could well be an answer 08:22:42 <06regret-⸸nde※> The Tar:7 endvaults have been doing a combination of "secret doors were a thing" and "Crawl used to have and still doesn't really have almost anything to work with for the themes of necromancy branch, so here, just dig up unmarked graves for treasure and monsters". 08:24:32 <06regret-⸸nde※> (...As soon as I describe it like this, I'm loosely imagining some actual gravestone markers for this, though that's sort of weird theming since undead are walking around in the hells anyway.) 08:25:38 <11Odds> IDK, burial chambers that some of the undead failed to get out of seems reasonable theming 08:54:23 <06regret-⸸nde※> (Belatedly scanning through #5320's spreadsheet, the procedural closet generation being handled via standard arrangements is fine with some mild documentation updates to mention it. The occasional glass / grate isolated closet thing is something I want to address in my own fashion in the future- there's a lot of vaults doing this sort of thing that should be cleaned up anyway- but automatically handling it as a fallback is much 08:54:24 better as in principle anyway.) 09:01:12 <11Odds> Ah yeah, I've documented the new tag but I should also explain the masking system a bit in the docs 09:02:04 <11Odds> (And yeah, definitely where possible it would be great for vaults to be cleaned up so they aren't relying on this fallback) 13:08:08 03CrawlOdds02 07* 0.35-a0-591-ga4b7e4764a: Support pasting into line input in local tile 10(34 hours ago, 2 files, 18+ 0-) 13https://github.com/crawl/crawl/commit/a4b7e4764a9d 13:08:08 03CrawlOdds02 07* 0.35-a0-592-gd09647f039: Detect and mask teleport closets during level generation 10(31 hours ago, 5 files, 162+ 13-) 13https://github.com/crawl/crawl/commit/d09647f03928 13:08:08 03CrawlOdds02 07* 0.35-a0-593-g0b8d903635: Create a tag to allow tele closets 10(9 hours ago, 7 files, 23+ 4-) 13https://github.com/crawl/crawl/commit/0b8d90363503 13:08:08 03CrawlOdds02 07* 0.35-a0-594-g15e5880f3b: Move pool fixup earlier 10(13 hours ago, 1 file, 9+ 9-) 13https://github.com/crawl/crawl/commit/15e5880f3bd2 13:08:08 03CrawlOdds02 07* 0.35-a0-595-g3b09176573: Make some vaults which rely on stairs transparent 10(9 hours ago, 2 files, 3+ 1-) 13https://github.com/crawl/crawl/commit/3b09176573db 15:23:36 ash is boring i hate ash, ash is now the bane/doom/curse god, dartboard: 15:24:06 also makes endless viable 15:34:22 also cassandra makes more sense now 15:42:47 Unstable branch on underhound.eu updated to: 0.35-a0-595-g3b09176573 (34) 20:42:59 03WizardIke02 07* 0.35-a0-596-g975d5ebfbe: Fix _tension_door_closed setting some squares as changed 10(19 minutes ago, 1 file, 4+ 14-) 13https://github.com/crawl/crawl/commit/975d5ebfbe06 20:57:54 New branch created: traitorfix (1 commit) 13https://github.com/crawl/crawl/tree/traitorfix 20:57:54 03hellmonk02 07[traitorfix] * 0.35-a0-596-g40bc63e9bb: Fix a bug with penance titles 10(5 minutes ago, 1 file, 4+ 1-) 13https://github.com/crawl/crawl/commit/40bc63e9bb74 20:58:59 New branch created: pull/5321 (1 commit) 13https://github.com/crawl/crawl/pull/5321 20:58:59 Branch pull/5321 updated to be equal with traitorfix: 13https://github.com/crawl/crawl/pull/5321 21:17:05 03WizardIke02 07* 0.35-a0-597-g2e6e51eef2: Fix placing a vault in mizmode not marking in view terrain changed 10(28 minutes ago, 1 file, 1+ 2-) 13https://github.com/crawl/crawl/commit/2e6e51eef242 21:23:41 <07wizardike> @hellmonk We also give a penance title when abandoning Ru even though you don't get wrath. This is mainly for consistency with how the good gods work, although it is also the only way to get Ru's penance title 22:35:32 Unstable branch on crawl.develz.org updated to: 0.35-a0-597-g2e6e51eef2 (34) 22:42:15 03WizardIke02 07* 0.35-a0-598-g2bbbe158dc: Fix xom scenery changes sometimes not being noticable 10(6 minutes ago, 3 files, 23+ 18-) 13https://github.com/crawl/crawl/commit/2bbbe158dc1c 22:58:42 Windows builds of master branch on crawl.develz.org updated to: 0.35-a0-598-g2bbbe158dc 23:30:57 Unstable branch on cbro.berotato.org updated to: 0.35-a0-598-g2bbbe158dc (34) 23:55:37 Monster database of master branch on crawl.develz.org updated to: 0.35-a0-598-g2bbbe158dc