00:17:47 <11Odds> (Also I need to work out if "unclean" is a real conduct distinct from "evil or chaotic") 03:34:42 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 06:06:46 <12ge0ff> re: the 80 chars limit for source code. Do you develop in a single window and w/o vertical tabs? 🙀 Having multiple pages side-by-side helps when you compare code, search for something, read docs, watch funny cats videos, and so on. I don't know how often you need to deal with merge conflicts, but I can't imagine resolving them w/o having 3 pages on the screen: "yours", "theirs", and the result in the middle. Also, about readability. 06:06:47 It might feel subjective, but we have eyes and brains that are good at digesting information from narrow columns of text. A very long line could be a symptom of code issues: unnecessarily long names or functions with dozens of parameters. The latter is a source of bugs, because it's easy to mess up and hard to notice. 06:07:01 <12ge0ff> checks if there's a "why" section in the DCSS coding conventions, and there is!: > Why: clean diffs, consistent readability patterns across a large codebase, and making life easier for others: e.g. contributors with low vision or other accessibility constraints… 06:11:43 <11Odds> Very long lines are certainly bad, but personally I think 80 characters is quite low and doesn't hit the sweet spot in terms of readability 06:15:30 <11Odds> There are a lot of tradeoffs here of course, and we should not expect to agree 🙂 06:16:10 <12ge0ff> ^--- that's exactly 80 chars long! 06:16:11 <11Odds> Though on digesting information - I certainly don't think it's an objective truth that my latest 81 character line is more readable when split: type_wanted = _find_acquirement_subtype(class_wanted, quant, agent); 06:16:27 <11Odds> Force of habit 😛 06:17:53 <12ge0ff> it could be cpp type_wanted = _find_acquirement_subtype(class_wanted, quant, agent); 06:18:47 <12ge0ff> or wanted = ... 06:19:00 <12ge0ff> (since it's already clear that the function returns a subtype) 06:19:56 <11Odds> It could! And, very much IMO, it would be less readable that way. 06:20:25 <12ge0ff> anyway, it's too bike-shedingly and I don't expect to change how you write code 06:21:14 <11Odds> But yeah more strongly than this I do feel that projects should have coding conventions and mostly stick to them, so I will be splitting up my 81 character lines except in extreme cases 🙂 07:39:22 <11Odds> Argh I am not enjoying the skill menu code at all 14:31:36 03CrawlOdds02 07[remove-penance] * 0.35-a0-489-g32b1c4dd38: [SQUASH] Style/clarity fixes to branch 10(14 hours ago, 14 files, 72+ 72-) 13https://github.com/crawl/crawl/commit/32b1c4dd38f7 14:31:36 03CrawlOdds02 07[remove-penance] * 0.35-a0-490-g3f9ae3ef5a: Allow scrolls of amnesia under Trog 10(14 hours ago, 1 file, 0+ 4-) 13https://github.com/crawl/crawl/commit/3f9ae3ef5acf 14:31:36 03CrawlOdds02 07[remove-penance] * 0.35-a0-491-gf380df8afa: [SQUASH] Make Zin forbid mutation potions and reorganise conducts 10(9 hours ago, 9 files, 46+ 127-) 13https://github.com/crawl/crawl/commit/f380df8afa20 14:31:36 03CrawlOdds02 07[remove-penance] * 0.35-a0-492-gd20f1fdcf2: Remove a redundant array 10(6 hours ago, 10 files, 18+ 36-) 13https://github.com/crawl/crawl/commit/d20f1fdcf254 14:31:36 03CrawlOdds02 07[remove-penance] * 0.35-a0-493-g19507d5cfd: Remove some state from skill management 10(6 hours ago, 19 files, 84+ 218-) 13https://github.com/crawl/crawl/commit/19507d5cfd18 14:31:36 03CrawlOdds02 07[remove-penance] * 0.35-a0-494-gdf6f28f180: Don't show gaps in the show-all skill menu 10(4 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/df6f28f180d1 14:31:36 03CrawlOdds02 07[remove-penance] * 0.35-a0-495-g875a717b80: Forbid training magic skills under Trog 10(6 hours ago, 11 files, 62+ 76-) 13https://github.com/crawl/crawl/commit/875a717b804b 14:31:36 03CrawlOdds02 07[remove-penance] * 0.35-a0-496-g9137580853: Forbid mirroring monsters your god hates 10(68 minutes ago, 2 files, 12+ 0-) 13https://github.com/crawl/crawl/commit/91375808535d 14:31:36 Branch pull/5289 updated to be equal with remove-penance: 13https://github.com/crawl/crawl/pull/5289 14:33:48 <11Odds> The thing I'm most uncertain about there having done it is phantom mirrors... while it makes a lot of sense for gods to ban hated monster clones, I think that it can be a bit of a surprise which monsters are evil (especially for casters with an evil spell) 14:36:01 <06pleasingfungus> SQUASH 14:36:13 <06pleasingfungus> I learned about fixup the other day and it really made my life much better 14:36:35 <06pleasingfungus> please don't ask how many years i've been doing interactive git rebases for. 14:37:37 <11Odds> Oh nice, thanks! 14:51:39 <09gammafunk> hah, that's funny. Way back in the day, when I had been using git for maybe a year or so. I didn't even realize you could reorder commits in the interactive rebase. Grunt pointed this out to me when I talked of how I was doing various branch creation and manipulations to effectively do the same thing...and I said...dang... 15:13:51 <06pleasingfungus> dang 15:13:55 <06pleasingfungus> rip 15:13:57 <04Cerebot> rip 15:42:24 Unstable branch on underhound.eu updated to: 0.35-a0-477-gf82e3c0534 (34) 16:10:27 03CrawlOdds02 07[remove-penance] * 0.35-a0-497-g2f56685ea9: Clean up the deliberate mutating conduct 10(2 minutes ago, 5 files, 7+ 28-) 13https://github.com/crawl/crawl/commit/2f56685ea915 16:10:27 Branch pull/5289 updated to be equal with remove-penance: 13https://github.com/crawl/crawl/pull/5289 16:17:53 03CrawlOdds02 07* 0.35-a0-478-g324fca1d4c: Fix a build warning by making something const 10(3 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/324fca1d4cae 22:35:27 Unstable branch on crawl.develz.org updated to: 0.35-a0-478-g324fca1d4c (34) 22:58:20 Windows builds of master branch on crawl.develz.org updated to: 0.35-a0-478-g324fca1d4c 23:12:23 Unstable branch on cbro.berotato.org updated to: 0.35-a0-478-g324fca1d4c (34) 23:55:23 Monster database of master branch on crawl.develz.org updated to: 0.35-a0-478-g324fca1d4c