03:34:14 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 09:41:34 03gammafunk02 07* 0.35-a0-476-g0cef555855: Add rudimentary Makefile support for profiling 10(11 minutes ago, 1 file, 6+ 0-) 13https://github.com/crawl/crawl/commit/0cef555855b1 13:43:55 New branch created: pull/5288 (1 commit) 13https://github.com/crawl/crawl/pull/5288 13:43:56 03Aliscans02 07https://github.com/crawl/crawl/pull/5288 * 0.35-a0-473-g884b9290be: Say dragon-coil talismans turn low level draconians into golden dragons 10(22 hours ago, 2 files, 10+ 4-) 13https://github.com/crawl/crawl/commit/884b9290be4b 14:24:22 New branch created: remove-penance (16 commits) 13https://github.com/crawl/crawl/tree/remove-penance 14:24:26 03CrawlOdds02 07[remove-penance] * 0.35-a0-473-g340e1f93b5: Fix displaying messages when destroying melded equipment 10(5 days ago, 2 files, 103+ 63-) 13https://github.com/crawl/crawl/commit/340e1f93b542 14:24:26 03CrawlOdds02 07[remove-penance] * 0.35-a0-474-g36807d214f: Fix a few artefact properties to message on meld/unmeld 10(5 days ago, 1 file, 7+ 13-) 13https://github.com/crawl/crawl/commit/36807d214fc6 14:24:26 03CrawlOdds02 07[remove-penance] * 0.35-a0-475-gf198905e80: Show useless armour in wear menu 10(4 days ago, 1 file, 2+ 5-) 13https://github.com/crawl/crawl/commit/f198905e8031 14:24:26 03CrawlOdds02 07[remove-penance] * 0.35-a0-476-g0e49ceee9b: Make god_hates_monster a boolean 10(2 days ago, 2 files, 13+ 18-) 13https://github.com/crawl/crawl/commit/0e49ceee9b48 14:24:26 03CrawlOdds02 07[remove-penance] * 0.35-a0-477-g1a23b999cd: Forbid equipment hated by your god. 10(4 days ago, 17 files, 224+ 180-) 13https://github.com/crawl/crawl/commit/1a23b999cd55 14:24:26 03CrawlOdds02 07[remove-penance] * 0.35-a0-478-gab05b2436d: Forbid (most) scrolls and potions hated by your god 10(3 days ago, 4 files, 43+ 24-) 13https://github.com/crawl/crawl/commit/ab05b2436d62 14:24:26 03CrawlOdds02 07[remove-penance] * 0.35-a0-479-g06cc892e1c: Forbid evoking items hated by your god 10(3 days ago, 5 files, 25+ 6-) 13https://github.com/crawl/crawl/commit/06cc892e1c49 14:24:26 03CrawlOdds02 07[remove-penance] * 0.35-a0-480-g176b5d73ac: Forbid hated spells rather than applying penance 10(3 days ago, 14 files, 57+ 129-) 13https://github.com/crawl/crawl/commit/176b5d73ac89 14:24:26 03CrawlOdds02 07[remove-penance] * 0.35-a0-481-g847d260f10: Forbid throwing items hated by your god 10(15 minutes ago, 3 files, 18+ 12-) 13https://github.com/crawl/crawl/commit/847d260f10fe 14:24:26 03CrawlOdds02 07[remove-penance] * 0.35-a0-482-g683f9595ca: Forbid animating weapons hated by your god 10(15 minutes ago, 2 files, 23+ 32-) 13https://github.com/crawl/crawl/commit/683f9595ca98 14:24:26 ... and 6 more commits 14:34:00 New branch created: pull/5289 (16 commits) 13https://github.com/crawl/crawl/pull/5289 14:34:00 Branch pull/5289 updated to be equal with remove-penance: 13https://github.com/crawl/crawl/pull/5289 14:39:48 <11O​dds> I'd love a second pair of eyes on that some time - especially for if there's any cases of penance removed that seem important to keep, or surprising ways you can now do acts that used to be penanced. 15:10:55 <02M​onkooky> Does vane still produce negative energy for tso worshippers sometimes? 15:11:12 <02M​onkooky> iirc that got removed 15:24:53 <11O​dds> Yep it got removed 15:43:38 Unstable branch on underhound.eu updated to: 0.35-a0-476-g0cef555855 (34) 16:09:39 03CrawlOdds02 07* 0.35-a0-477-gf82e3c0534: Don't highlight ancestors in discord targeter (Emily Bunny) 10(16 minutes ago, 1 file, 3+ 1-) 13https://github.com/crawl/crawl/commit/f82e3c053449 17:32:40 <04d​racoomega> Well, I have read over basically all the code in this (though not done any significant testing of it myself yet). Looks pretty good! But I have a few comments/corrections. C++ // Only faith does anything when destroyed from melded (not that amulets can // actually be melded at time of writing; rings can be, e.g. in spider form). Rings aren't melded in spider form (but amulets are currently melded as a wisp.) C++ string 17:32:40 rejection_message = cannot_join_god_reason(altar_god, true, false); There are a number of cases here where you wrap something that is very barely over 80 characters onto two lines. While I think some style guide somewhere technically says that our policy is to always wrap at 80, I think it just hurts readability in many cases for no good reason. (Is anyone really developing in a window that 17:32:41 stops at 80 characters these days??) And lots of code we have (written by multiple authors) is more flexible than that. (This is a minor thing, but it's just a bit of a pet peeve, is all. I wouldn't want you to think we'd consider it required.) --- A lot of places (like can_equip_item() use is_divine as an outparam for whether a rejection is god-related. I think the name is slightly ambiguous (ie: 'Is it asking whether the item is divine?') and 17:32:41 would be more unambiguous if named something like god_forbids (personally) 17:32:59 <04d​racoomega> C++ * If the player cannot use this item, set to whether * the reason is god-based. Otherwise set to garbage. (This seems misleading. It sets it to false, no?) --- I don't think I'm fond of there being a single exception to the new rules here to let Zin worshippers drink !mutation potions while still docking them piety for doing so. It's unexpected (I certainly would not 17:32:59 expect Zin to allow it when every other god disallows everything), and the player isn't permanently trapped since they can just get enough piety to cleanse their mutations the 'proper' way later on (which is what Zin 'expects' them to do, anyway. Yes, in very narrow circumstances this may be mean to the player, but it feels like Part of the Conduct to me, and not something we should go to extra lengths to support. Many other god conducts are already 17:33:00 meaner than this. --- I realize this was apparently already the case, but why are we forbidding ?amnesia under Trog? They are already effectively useless (heck, Trog might even be happy for you to forget any magic you somehow already knew.) --- Surely we don't need both god_forbids_memorising_spells() and god_hates_spellcasting() as two separate things? They both return 'Trog' (except one does so in a more complicated way). And I can't imagine any 17:33:01 future god allowing one but not the other - that wouldn't even make sense. --- If you're forbidden from using Tukima's on an evil weapon, I wonder now if you should be forbidden from using mirror on an evil monster? (I realize at some point in the past, doing so while worshipping a good god made the summon hostile to you, which is a fair bit weirder. However, Zin being perfectly happy with you mirroring a Zykzyl also feels odd to me, and it seems 17:33:01 we could use the same methodology to ban those targets, right?) 17:33:08 <04d​racoomega> Also: Trog appears to still allow you to train magic skills, but dock you piety for doing so. Feels like this should simply also be forbidden? 17:48:12 80 characters is quite easy to hit if you like to view stuff with vertical window splits. Being able to know that you aren't gonna be cutting anything off at 80 characters then lets you size those appropriately. 17:50:46 oh, it's also a pretty big boon to visually impaired people since you can zoooooooom 18:08:46 <06p​leasingfungus> string rejection_message = cannot_join_god_reason(altar_god, true, false); a happier wrap 18:08:56 <06p​leasingfungus> (no idea how that comes out on irc) 18:10:00 all jammed onto a single line 18:10:13 <06p​leasingfungus> ah, rip 18:10:19 <06p​leasingfungus> imagine a linebreak after the = 18:10:35 <06p​leasingfungus> (as opposed to a linebreak after true,) 18:13:14 I inferred two linebreaks from spacing: that, and after the semicolon 20:06:46 <06p​leasingfungus> bold 22:35:13 Unstable branch on crawl.develz.org updated to: 0.35-a0-477-gf82e3c0534 (34) 22:58:37 Windows builds of master branch on crawl.develz.org updated to: 0.35-a0-477-gf82e3c0534 23:12:26 Unstable branch on cbro.berotato.org updated to: 0.35-a0-477-gf82e3c0534 (34) 23:40:44 <11O​dds> @dracoomega - thanks, great feedback! All the stylistic points are well taken and I'll do them. On the functional stuff: * Yes I think Trog should allow amnesia * Yes I think we should ban phantom mirroring evil enemies under good gods (and chaotic/unclean under Zin, but nothing under Chei) * Yes I think Trog should ban training spell skills. Possibly this one will be slightly more involved to do. * Potions of mutation are an interesting 23:40:45 one... it's one case where the price is currently definitely worth paying. I do worry about a character worshipping Zin, the god of dealing with terrible mutation sets, ends up with their terrible mutation set locked in for a fairly long time. But it would certainly be nice both from a surprise and code perspective to remove the one exception to the rule, and I agree it's not that harsh a conduct, especially now bad mutations are not so very bad. 23:40:45 So yeah, overall I was a bit on the fence but happy to forbid these. (I've tested this really quite a lot, so was mostly looking for the sort of review you've done there about wrong or missing functionality and style - obviously testing is also very welcome) 23:55:27 Monster database of master branch on crawl.develz.org updated to: 0.35-a0-477-gf82e3c0534