00:34:22 Unstable branch on cbro.berotato.org updated to: 0.35-a0-117-g239433bcb3 (34) 00:55:59 Monster database of master branch on crawl.develz.org updated to: 0.35-a0-117-g239433bcb3 02:12:42 New branch created: pull/5107 (4 commits) 13https://github.com/crawl/crawl/pull/5107 02:12:45 03Nicholas Wilson02 07https://github.com/crawl/crawl/pull/5107 * 0.35-a0-118-g8e4af8069b: [art-data.pl] don't require `TILE_EQ`s for artefact talismans 10(71 minutes ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/8e4af8069bc7 02:12:45 03Nicholas Wilson02 07https://github.com/crawl/crawl/pull/5107 * 0.35-a0-119-g3c0708342f: [target.cc] un-hardcode the targeter for `targeter_siphon_essence` 10(48 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/3c0708342f60 02:12:45 03Nicholas Wilson02 07https://github.com/crawl/crawl/pull/5107 * 0.35-a0-120-gd17d2584e7: [player-equip.cc] fix `you.unrand_equipped` for talismans 10(46 minutes ago, 1 file, 8+ 2-) 13https://github.com/crawl/crawl/commit/d17d2584e773 02:12:45 03Nicholas Wilson02 07https://github.com/crawl/crawl/pull/5107 * 0.35-a0-121-g3055f59fe2: Add a new Fixedart "Malkavia's Phylactery" 10(15 minutes ago, 5 files, 100+ 11-) 13https://github.com/crawl/crawl/commit/3055f59fe280 02:26:51 03Nicholas Wilson02 07https://github.com/crawl/crawl/pull/5107 * 0.35-a0-121-g07876d3142: Add a new Fixedart "Malkavia's Phylactery" 10(29 minutes ago, 5 files, 99+ 11-) 13https://github.com/crawl/crawl/commit/07876d314235 03:24:11 03CrawlOdds02 07https://github.com/crawl/crawl/pull/5007 * 0.34-a0-1933-g5edf3c2743: Make Okawaru piety a bit less random. 10(2 days ago, 3 files, 4+ 5-) 13https://github.com/crawl/crawl/commit/5edf3c274394 03:26:22 03CrawlOdds02 07https://github.com/crawl/crawl/pull/5007 * 0.34-a0-1933-g4324928453: Make Okawaru piety a bit less random. 10(2 days ago, 3 files, 4+ 5-) 13https://github.com/crawl/crawl/commit/43249284538c 04:35:35 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 05:36:45 Unstable branch on crawl.akrasiac.org updated to: 0.35-a0-117-g239433b (34) 08:24:53 DracoOmega: re: Allow the 'F'ire menu to remember the last item the player fired (4 hours ago, 7 files, 34+ 2-) https://github.com/crawl/crawl/commit/d5aae33c1d99 -- Will this also work when using ` (CMD_PREV_CMD_AGAIN) after 'F', firing at the same target with the same item? 12:14:28 <04d​racoomega> Dossy: That works by repeating the last key sequence the player input, and so always at least somewhat worked (though it can be temperamental with targeting, as a consequence) 13:41:06 I mean, will it use the previously chosen missile now with this change? It "worked" before in that it would throw the quivered missile, kind of like `f.` ... 13:41:48 But, if you used F and chose a different missile, using ` would fire the quivered one, not remembering the selected missile from the original F. 13:42:18 Always catches me off-guard (I'm still new at this game) since I want it to just "repeat the last action" but, it's not quite right. 13:43:47 <04d​racoomega> That... doesn't seem to be the behavior I observed when quickly testing prior to this change. Using F to pick a missile to throw, and then pressing ` would still throw the same missile, even in previous versions. (Since it should be repeating the key sequence of F + [whatever letter the missile was on]). Not sure how/why it would be using specifically the quivered missile for you 13:49:28 Yeah, I can see if it was user error on my part or if it's reproducible. 14:39:29 Okay, yup, definitely reproducible. I have stones quivered. Have poison darts in my inventory. I use F, select the darts, and throw them at an adder. I then press `, and it throws a stnoe. 14:39:34 *stone 14:39:46 This is on 0.34 on CDI. 14:40:00 Curious to see if the commit we're discussing "fixes" this on trunk. 14:45:52 <04d​racoomega> Very strange. If I do that same thing in 0.34, it continues to throw darts 14:46:35 You aren't quivering the darts, right? Stones quivered, and you use F to throw the non-quivered dart, and then using ` throws another dart? 14:47:19 <04d​racoomega> Yes 14:47:46 Bizarre. Are the darts in an earlier slot than the stones? 14:47:51 <04d​racoomega> It is possible webtiles is different, I suppose, though I'm not sure how 14:48:05 <04d​racoomega> They're in a later slot 14:48:16 Yes, I'm on webtiles, and I have stones in slot e, and darts in slot f. 14:51:30 But, yeah, I only play on webtiles; I could try grabbing the macOS app and see if it's reproducible there. 14:52:29 Where does the macOS app look for custom .rc files? Somewhere in ~/Library/Application Support/ ... like most Mac apps, or ... ? 15:14:38 Okay, figured it out. Hm, macOS version doesn't seem to like the utf-8 ♦ in autopickup. Can't even wrap it in an `if crawl.is_tiles() then ... end`, it must fail at parse time. 15:27:59 Yup, at least macOS tiles version 0.34 does what you describe/what I expected (` repeats F with the selected non-quivered missile), and webtiles does not. 17:27:31 03DracoOmega02 07* 0.35-a0-118-g3e11f872c3: Don't Whirlwind against the same target more than once per movement 10(3 hours ago, 4 files, 11+ 2-) 13https://github.com/crawl/crawl/commit/3e11f872c335 17:27:31 03DracoOmega02 07* 0.35-a0-119-g432ec66a8c: Allow stampede movements to properly Whirlwind against targets you pass by 10(3 hours ago, 3 files, 15+ 5-) 13https://github.com/crawl/crawl/commit/432ec66a8cf6 17:27:31 03DracoOmega02 07* 0.35-a0-120-ga10752e07a: Fix ranged autofight behavior regarding bushes (Kab) 10(3 hours ago, 1 file, 4+ 1-) 13https://github.com/crawl/crawl/commit/a10752e07abe 17:27:31 03DracoOmega02 07* 0.35-a0-121-gf73908f27d: Fix Duel/banishment on top of a portal entrance expiring that entrance 10(2 hours ago, 1 file, 5+ 1-) 13https://github.com/crawl/crawl/commit/f73908f27d26 17:27:31 03DracoOmega02 07* 0.35-a0-122-ga7a852e538: Make sure Blorkula wakes up after recombining from bats 10(2 hours ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/a7a852e5388f 17:27:31 03LiciTheCrawler02 {DracoOmega} 07* 0.35-a0-123-gc3a491a8fe: Add Horn of Geryon to autopickup 10(7 days ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/c3a491a8fe07 17:27:31 03DracoOmega02 07* 0.35-a0-124-gd5ebf81aa8: Remove a debugging statement accidentally left in 10(2 hours ago, 1 file, 0+ 3-) 13https://github.com/crawl/crawl/commit/d5ebf81aa89f 17:27:31 03DracoOmega02 07* 0.35-a0-125-g93cc0ea6f2: Fix a specific case of being able to get two active winds at once 10(2 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/93cc0ea6f26a 17:27:31 03LiciTheCrawler02 {DracoOmega} 07* 0.35-a0-126-g16ea0c675f: Display Acid Splash in monster description 10(7 days ago, 1 file, 7+ 0-) 13https://github.com/crawl/crawl/commit/16ea0c675f18 17:27:31 03Anders Papitto02 {DracoOmega} 07* 0.35-a0-127-gaf5baf9f4c: Bugfix minimum range description for several monster spells 10(11 days ago, 2 files, 4+ 3-) 13https://github.com/crawl/crawl/commit/af5baf9f4c36 17:27:31 ... and 2 more commits 17:43:49 04Build failed for 08master @ cbf2863a 06https://github.com/crawl/crawl/actions/runs/22532255747 17:47:48 <04d​racoomega> Yet another test suite crash that I can't reproduce locally and which we don't have any crashlog for -.- 17:50:15 I need to find time to submit a PR to record crash logs and core dumps as artifacts 17:50:47 (gamma and I discussed that a few weeks back and I know what needs to be done) 17:54:54 <04d​racoomega> I would appreciate it immensely 17:55:01 <04d​racoomega> I really have no idea where to even start going about doing that myself 18:19:31 03regret-index02 07* 0.35-a0-130-g81124d8845: New short blade base type: Athame 10(82 minutes ago, 46 files, 214+ 85-) 13https://github.com/crawl/crawl/commit/81124d884508 18:19:31 03regret-index02 07* 0.35-a0-131-g2737fa4c34: Change the outside border of V:5 from rock to metal (#5901) 10(27 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/2737fa4c34a7 18:19:31 03regret-index02 07* 0.35-a0-132-g45c81ee204: Fix an overflow altar using a second Trog altar (#5103) 10(27 minutes ago, 1 file, 5+ 3-) 13https://github.com/crawl/crawl/commit/45c81ee2045d 18:19:31 03regret-index02 07* 0.35-a0-133-g7fc84518e5: Fix troves weapons accidentally trying for ranged distortion (rypofalem) 10(25 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/7fc84518e514 18:19:31 03regret-index02 07* 0.35-a0-134-g5722069ed3: Give Josephina (the late one) Dominate Undead 10(17 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/5722069ed3a1 18:19:31 03regret-index02 07* 0.35-a0-135-g7be77ddb67: Fix a few recent interface tiles 10(17 minutes ago, 2 files, 1+ 1-) 13https://github.com/crawl/crawl/commit/7be77ddb6709 20:56:18 New branch created: pull/5110 (1 commit) 13https://github.com/crawl/crawl/pull/5110 20:56:19 03geekosaur02 07https://github.com/crawl/crawl/pull/5110 * 0.35-a0-115-gc9eb665fae: Upload an artifact on Linux test failure 10(2 minutes ago, 1 file, 16+ 1-) 13https://github.com/crawl/crawl/commit/c9eb665fae3c 20:56:45 \o/ 20:57:25 \o/ 21:00:16 not marking it ready until I have verified that finicky GHA is happy with it (but I don't see any errors from it, which should have been immediate) and have introduced a dummy crash to make sure it works 21:20:07 03geekosaur02 07https://github.com/crawl/crawl/pull/5110 * 0.35-a0-116-g7193e6571f: Force a core dump in the arena for testing 10(61 seconds ago, 1 file, 5+ 0-) 13https://github.com/crawl/crawl/commit/7193e6571fe1 21:27:43 03geekosaur02 07https://github.com/crawl/crawl/pull/5110 * 0.35-a0-115-g0906361bdc: Upload an artifact on Linux test failure 10(33 minutes ago, 1 file, 16+ 1-) 13https://github.com/crawl/crawl/commit/0906361bdceb 21:27:43 03geekosaur02 07https://github.com/crawl/crawl/pull/5110 * 0.35-a0-116-g910586ad56: Force a crash to test artifact saving 10(48 seconds ago, 1 file, 5+ 0-) 13https://github.com/crawl/crawl/commit/910586ad56f8 21:51:32 03geekosaur02 07https://github.com/crawl/crawl/pull/5110 * 0.35-a0-116-g0a6530a344: Force a crash to test artifact saving 10(25 minutes ago, 2 files, 8+ 0-) 13https://github.com/crawl/crawl/commit/0a6530a34483 21:54:48 03geekosaur02 07https://github.com/crawl/crawl/pull/5110 * 0.35-a0-116-g6514e0450e: Force a crash to test artifact saving 10(28 minutes ago, 2 files, 6+ 0-) 13https://github.com/crawl/crawl/commit/6514e0450e1c 22:03:45 unrelated crash during testing: https://github.com/crawl/crawl/actions/runs/22536296735/job/65284436940?pr=5110#step:12:117 "/home/runner/work/crawl/crawl/crawl-ref/source/dat/des/portals/trove.des:1415: Ego 'holy_wrath' is incompatible with item 'demon blade'." 22:06:42 03geekosaur02 07https://github.com/crawl/crawl/pull/5110 * 0.35-a0-116-ga99c4f4dde: Force a crash to test artifact saving 10(40 minutes ago, 2 files, 7+ 1-) 13https://github.com/crawl/crawl/commit/a99c4f4ddee9 22:17:32 03geekosaur02 07https://github.com/crawl/crawl/pull/5110 * 0.35-a0-115-g90be10711f: Upload an artifact on Linux test failure 10(83 minutes ago, 1 file, 18+ 1-) 13https://github.com/crawl/crawl/commit/90be10711f7c 22:20:38 okay, got core dumps sorted out and added the saves directory to the artifact 22:20:47 ready to go 22:22:25 rebase failing PRs on top of this (or wait until merge and rebase on master) to get the artifact; it'll be in the build log, in the collapsed log of the actions/upload-artifact step 22:25:34 (or cherrypick 90be107) 22:26:11 <04d​racoomega> Yeah, I actually had a look earlier at one of those 'example' crashes to see how to access the crashlogs 22:26:15 <04d​racoomega> So it's all ready to go now, then? 22:27:06 yep. I stuck a raise(SIGABRT) in the arena main loop to force a crash and verified that the artifact was saved with all relevant information 22:27:27 morgue, save, core file, crawl executable matching the core file 22:29:38 (well, none of the test crashes have the save file, it occurred to me that it might be nice to add it after the most recent one, just in case) 22:30:07 <04d​racoomega> I'm going to go ahead and merge right now, then. 22:30:09 <04d​racoomega> Thanks so much 22:30:13 np 22:30:16 👀 22:30:33 that's clever 22:30:40 the hardest part was figuring out how to get GHA to make a core file <.< 22:31:12 <04d​racoomega> Actually, one question. Does it uploads all this on every test failure and not just crashes? 22:31:27 geekosaur: beyond `ulimit -c unlimited` ? 22:32:02 yes, because unless someone rewrites the logic in the makefile / the test harness / possibly fake_pty to distinguish between them, there's nothing I can do 22:32:20 <04d​racoomega> Since the non-crash ones generally are more transparent about the specific issue already. (I have no idea how storage for this is handled, I guess. But it feels silly to save part of the directory structure for a checkwhite failure, for instance) 22:32:40 Dossy, since GHA is using a mostly unmodified Ubuntu, I had to hack /proc/sys/kernel/core_pattern to steal core files back from apport 22:32:46 <04d​racoomega> Ah, well, if there's no easy way to distinguish, I guess... 22:33:07 they expire after a few days, information in the upload-artifact log 22:33:22 I think it's 15 days by default? we can tune it if needed 22:33:56 dracoomega: GitHub artifact storage for public repos is free and I think limited to 10 GB per artifact? 22:34:42 geekosaur: mmm, yeah, make sure the corefile gets written to someplace you have permissions/access? 22:35:22 yes, it does that now. apport is a utility that generates crash reports and sends them to Canonical, which is singularly unhelpful for testing apps in GHA 22:35:29 default retention is set in repo settings 22:35:35 I was surprised GitHub didn't already disable it 22:36:00 <04d​racoomega> Oh, well if they're fairly short-lived, it probably doesn't matter to be superfluous, I suppose 22:36:22 <04d​racoomega> Unimportant ones will clean up after themselves 22:38:05 03geekosaur02 {DracoOmega} 07* 0.35-a0-136-g7f86954083: Upload an artifact on Linux test failure 10(2 hours ago, 1 file, 18+ 1-) 13https://github.com/crawl/crawl/commit/7f86954083fc 22:57:17 maybe I can poke at some improvements tomorrow: drop retention to 7 days, see if upload-artifact can fail unless all files exist (default succeeds if any files exist) which means no core dump would stop it. (with continue-on-error: true) 23:00:37 <09g​ammafunk> is the saves dir relevant to that? I assumed you were including that dir only in case any save was generated (which means it'd be conditionally present), but wasn't sure 23:04:02 <04d​racoomega> Actually, do any of the tests generate a save file in the first place, thinking on it? 23:05:36 <09g​ammafunk> don't think they would normally, but I did notice saves was included in the job def. To be honest though, I have no idea if we have a test that messes with saves 23:35:54 Unstable branch on crawl.develz.org updated to: 0.35-a0-136-g7f86954083 (34) 23:59:58 Windows builds of master branch on crawl.develz.org updated to: 0.35-a0-136-g7f86954083