00:45:13 Monster database of master branch on crawl.develz.org updated to: 0.35-a0-53-g511dc2e70d 04:36:44 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 12:11:26 BrunoBer1942 (L9 MiFi) Crash caused by signal #6: Aborted (D:6) 12:59:10 New branch created: buffarchery (1 commit) 13https://github.com/crawl/crawl/tree/buffarchery 12:59:10 03hellmonk02 07[buffarchery] * 0.35-a0-54-gde46330661: buff archery ego 10(66 seconds ago, 2 files, 2+ 2-) 13https://github.com/crawl/crawl/commit/de463306619c 13:02:26 New branch created: pull/5095 (1 commit) 13https://github.com/crawl/crawl/pull/5095 13:02:26 Branch pull/5095 updated to be equal with buffarchery: 13https://github.com/crawl/crawl/pull/5095 13:06:23 <04d​racoomega> What in the world is going on with that crash? 20:46:40 03WizardIke02 07* 0.35-a0-54-ge4a09507ca: Fix final effects merging with others of a different type 10(25 minutes ago, 1 file, 91+ 53-) 13https://github.com/crawl/crawl/commit/e4a09507ca95 20:46:40 03WizardIke02 07* 0.35-a0-55-g1926f35598: Remove unused members from pyromania_fineff 10(3 minutes ago, 1 file, 0+ 3-) 13https://github.com/crawl/crawl/commit/1926f3559844 20:48:53 03WizardIke02 07[stone_soup-0.34] * 0.34.0-7-g5724e70bac: Fix final effects merging with others of a different type 10(27 minutes ago, 1 file, 91+ 53-) 13https://github.com/crawl/crawl/commit/5724e70bacfc 20:48:53 03WizardIke02 07[stone_soup-0.34] * 0.34.0-8-gffe83251ae: Remove unused members from pyromania_fineff 10(5 minutes ago, 1 file, 0+ 3-) 13https://github.com/crawl/crawl/commit/ffe83251aea0 20:51:08 <04d​racoomega> @wizardike If every single mergeable() call is going to check first that the type of fineff is the same, shouldn't that check be done just a single time upstream, before mergeable() is even called? (Like, is there any example where we'd ever want to merge fineffects of different types?) 20:51:18 <07w​izardike> That should probably fix this bug. Although I'm not sure we should be letting scorch target dead monsters 20:54:40 <07w​izardike> That's probably a good idea. There isn't any situation where we would want to merge different types of final effects currently and I very much doubt we would ever want to do that 20:55:09 <04d​racoomega> Yeah, I can't imagine a scenario where that would make sense 20:55:44 <04d​racoomega> So the issue here was that the pyromania trigger 'ate' Nobody's revival fineff, right? 20:58:01 <04d​racoomega> Scorch's targeting (which is used for several other things) doesn't specifically exclude dead monsters, but I think it shouldn't be possible for there to be dead monsters on the grid at the time it (or any of these other spells) are cast without some other bug (such as this one). All that stuff is supposed to be cleaned up by the time proper actions can take place. 20:58:02 <07w​izardike> Yeah. The pyromania trigger was hadn't first then when trying to add Nobody's revival fineff it was eaten by the existing pyromania fineff 21:00:49 <07w​izardike> I guess. So long as we never want to use scorch as some out of retaliation effect it should be fine 21:02:15 * geekosaur 's spidey sense tingles 21:03:46 <04d​racoomega> (The thing is, I suspect there's actually quite a lot of effects that look for monsters within a given range and assume any they find are currently alive >.>) 21:05:26 <04d​racoomega> Generally once you start hurting or otherwise doing things to a list of monsters, it can be good to double-check if they're all still alive (summoner deaths killing summons that were seen earlier is a classic bug), but the initial sweep should be safe. (Both in the sense of 'usually is' and probably also 'code should try to enforce that it is') 21:27:06 <07w​izardike> Yeah I guess there isn't really any reason to change this as we can just change it if we ever decide to implement something like mothkin or spell retaliation (which we probably won't) 21:27:48 do comment it so someone knows it needs to be done… 22:05:03 03DracoOmega02 07* 0.35-a0-56-g58ae5a1fc0: Fix a crash with chaoslaced monster attacks 10(6 hours ago, 1 file, 3+ 1-) 13https://github.com/crawl/crawl/commit/58ae5a1fc036 22:05:03 03DracoOmega02 07* 0.35-a0-57-g7b04bc261b: Fix banished orb guardians not activating tesseracts 10(6 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/7b04bc261bc5 22:05:03 03DracoOmega02 07* 0.35-a0-58-gf0d4fc607c: Fix a typo (Snakku) 10(6 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/f0d4fc607ca1 22:05:03 03DracoOmega02 07* 0.35-a0-59-g40fb4cd29f: Fix the force_more for seeing a dancing distortion weapon (Lici) 10(6 hours ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/40fb4cd29fd7 22:05:03 03DracoOmega02 07* 0.35-a0-60-g118dc0aa31: Use a slightly more specific message channel for a warning 10(6 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/118dc0aa31d5 22:05:03 03DracoOmega02 07* 0.35-a0-61-g117f65c6ef: Allow deconstructing forgecraft allies with a ranged weapon (sed_no_one) 10(5 hours ago, 1 file, 9+ 0-) 13https://github.com/crawl/crawl/commit/117f65c6ef65 22:05:03 03DracoOmega02 07* 0.35-a0-62-gc9b9d1db90: Properly mark unidentified talismans evil/chaotic as appropriate (Colgate) 10(4 hours ago, 1 file, 11+ 6-) 13https://github.com/crawl/crawl/commit/c9b9d1db90be 22:05:03 03DracoOmega02 07* 0.35-a0-63-ge33c9a7d7b: Remove some unused code 10(4 hours ago, 1 file, 0+ 23-) 13https://github.com/crawl/crawl/commit/e33c9a7d7b9b 22:05:03 03DracoOmega02 07* 0.35-a0-64-g21a1b92885: Remove a validation check for ghosts with rElec- 10(4 hours ago, 1 file, 0+ 6-) 13https://github.com/crawl/crawl/commit/21a1b928853d 22:05:03 03DracoOmega02 07* 0.35-a0-65-gb7ba641fff: Fix anacondas taking no damage from cactus giant spines 10(3 hours ago, 1 file, 3+ 2-) 13https://github.com/crawl/crawl/commit/b7ba641fff69 22:05:03 ... and 3 more commits 22:05:13 03DracoOmega02 07[stone_soup-0.34] * 0.34.0-9-g339c3afa14: Fix a crash with chaoslaced monster attacks 10(6 hours ago, 1 file, 3+ 1-) 13https://github.com/crawl/crawl/commit/339c3afa1485 22:05:13 03DracoOmega02 07[stone_soup-0.34] * 0.34.0-10-g5dba04e428: Fix banished orb guardians not activating tesseracts 10(6 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/5dba04e4283e 22:05:13 03DracoOmega02 07[stone_soup-0.34] * 0.34.0-11-g1df70fe941: Fix a typo (Snakku) 10(6 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/1df70fe9410d 22:05:13 03DracoOmega02 07[stone_soup-0.34] * 0.34.0-12-g86cec2364e: Fix the force_more for seeing a dancing distortion weapon (Lici) 10(6 hours ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/86cec2364ebe 22:05:13 03DracoOmega02 07[stone_soup-0.34] * 0.34.0-13-g447db5a75b: Use a slightly more specific message channel for a warning 10(6 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/447db5a75b01 22:05:13 03DracoOmega02 07[stone_soup-0.34] * 0.34.0-14-g952d488edf: Allow deconstructing forgecraft allies with a ranged weapon (sed_no_one) 10(5 hours ago, 1 file, 9+ 0-) 13https://github.com/crawl/crawl/commit/952d488edf7f 22:05:13 03DracoOmega02 07[stone_soup-0.34] * 0.34.0-15-ga9ed76d55d: Properly mark unidentified talismans evil/chaotic as appropriate (Colgate) 10(4 hours ago, 1 file, 11+ 6-) 13https://github.com/crawl/crawl/commit/a9ed76d55dfd 22:05:13 03DracoOmega02 07[stone_soup-0.34] * 0.34.0-16-g1032f01f93: Remove some unused code 10(4 hours ago, 1 file, 0+ 23-) 13https://github.com/crawl/crawl/commit/1032f01f93e8 22:05:13 03DracoOmega02 07[stone_soup-0.34] * 0.34.0-17-gb4b4edc637: Remove a validation check for ghosts with rElec- 10(4 hours ago, 1 file, 0+ 6-) 13https://github.com/crawl/crawl/commit/b4b4edc63730 22:05:13 03DracoOmega02 07[stone_soup-0.34] * 0.34.0-18-gbe39189af6: Fix anacondas taking no damage from cactus giant spines 10(3 hours ago, 1 file, 3+ 2-) 13https://github.com/crawl/crawl/commit/be39189af6f4 22:05:13 ... and 3 more commits 22:26:48 04Build failed for 08master @ b5d556b3 06https://github.com/crawl/crawl/actions/runs/22250815689 23:35:48 Unstable branch on crawl.develz.org updated to: 0.35-a0-68-gb5d556b375 (34) 23:48:00 <04d​racoomega> I really, really wish we got crashlogs from those CI crashes T.T 23:59:01 Windows builds of master branch on crawl.develz.org updated to: 0.35-a0-68-gb5d556b375