00:32:22 <04d​racoomega> The latter seems fine to me. (It's possible there's some scenario I'm forgetting about, but in general it seems fine to me.) 00:59:39 -!- indigaz27 is now known as indigaz2 03:31:32 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 03:58:52 03Medrano8302 07* 0.34-a0-929-gbe1bb89a5e: Android UI adjustments 10(13 days ago, 2 files, 11+ 13-) 13https://github.com/crawl/crawl/commit/be1bb89a5ee3 03:58:52 03Medrano8302 07* 0.34-a0-930-g08d3286d27: Android: Calculate scale ignoring the navigation bar 10(74 minutes ago, 4 files, 32+ 3-) 13https://github.com/crawl/crawl/commit/08d3286d276e 05:26:43 Unstable branch on crawl.akrasiac.org updated to: 0.34-a0-930-g08d3286 (34) 07:19:22 <09h​ellmonk> fr: 'warp slimes' with warding, af_contam, af_blink_with to make players fear slime again 07:19:42 <09h​ellmonk> put em in abyss too 07:24:10 <03i​mplojin> !clap make players fear again 07:24:11 <04C​erebot> 👏 make 👏 players 👏 fear 👏 again 👏 08:06:57 03regret-index02 07* 0.34-a0-931-gc2d90bad4c: New vault tile sets + adjacent vault review 10(7 minutes ago, 108 files, 1234+ 909-) 13https://github.com/crawl/crawl/commit/c2d90bad4cd3 10:38:16 <06m​umra> Surely they should be able to abyss you (maybe a new af_drag_to_abyss where they come along for the ride) 10:42:15 <06m​umra> (could they rather be called "phase phlegm"?) 10:44:20 <12a​sciiphilia> @regret-⸸nde※ https://github.com/crawl/crawl/commit/c2d90bad4cd3743fee020872e4b8845556e3d880 https://github.com/search?q=repo%3Acrawl%2Fcrawl%20TILE_WALL_STONE_CRACKLE_1&type=code in dungeon_renderer.js - bg_idx (X) base_bg (O) in dungeon_renderer, base_bg is not defined so, that condition statement occur error when its function called 10:46:22 <09h​ellmonk> yuck 10:46:32 <09h​ellmonk> the spatial snot engulfs you 10:46:33 <12a​sciiphilia> It’s part of the refactoring domain, but since the implementations of tileview.cc and dungeon_renderer.js are closely related, it would be better to use the same variable names. This was probably a mistake that happened during a copy-paste operation. 10:50:53 03regret-index02 07* 0.34-a0-932-gfd4178987c: Fix a bad copy-paste for Webtiles (ASCIIPhillia) 10(33 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/fd4178987cec 10:54:05 <12a​sciiphilia> ASCIIPhillia v.s. ASCIIPhilia 10:57:58 <12a​sciiphilia> Thinking that the typo will remain in the commit history forever feels kind of glorious, haha TCG card packs with misprints even sell for higher prices! 10:58:06 <06m​umra> i'm unreasonably pleased with this name 11:07:11 <06m​umra> the irony that the commit message is "fix a bad copy-paste" containing a typo caused by not copy pasting 🤣 11:09:03 <06m​umra> there are too many examples unfortunately of "slightly different naming in js vs c" 11:10:21 <06m​umra> something which could be fixable in the process of committing fully to an emscripten client build but it's sadly still too big a job to fit on my plate 🙂 11:33:28 <12a​sciiphilia> @regret-⸸nde※ js || (base_bg >= dngn.ARCANE_CONDUIT && base_bg < dngn.STORM_CONDUIT) || (base_bg >= TILE_WALL_STONE_CRACKLE_1 && base_bg <= TILE_WALL_STONE_CRACKLE_4) TILE_WALL_STONE_CRACKLE_1 >>> dngn.WALL_STONE_CRACKLE_1 TILE_WALL_STONE_CRACKLE_4 >>> dngn.WALL_STONE_CRACKLE_4 11:33:49 <12a​sciiphilia> VM1440:65 ReferenceError: TILE_WALL_STONE_CRACKLE_1 is not defined at cell_is_animated (eval at mapper (dwem.js:175:51), :11:339) at DungeonViewRenderer.animate (eval at mapper (dwem.js:175:51), :227:48) at HTMLDocument.eval (eval at mapper (dwem.js:175:51), :288:14) at HTMLDocument.dispatch (jquery.js:2:38007) at HTMLDocument.h (jquery.js:2:33868) at Object.trigger 11:33:50 (jquery.js:2:36601) at HTMLDivElement. (jquery.js:2:44372) at p.each (jquery.js:2:14477) at init.each (jquery.js:2:11151) at init.trigger (jquery.js:2:44348) 11:44:00 03DracoOmega02 07* 0.34-a0-933-g22c0543b7e: Actually fix the aforementioned issue properly (ASCIIPhilia) 10(15 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/22c0543b7eb1 11:48:15 <12a​sciiphilia> https://cdn.discordapp.com/attachments/747522859361894521/1426642560612438076/a8t93a.png?ex=68ebf7ec&is=68eaa66c&hm=87aae94c87af04625a239977613d13a452fc5805036f6c193429d9908fa9d0ea& 12:13:41 <09g​ammafunk> asciphilia 12:23:37 03Medrano8302 07* 0.34-a0-934-g5b29d69663: Update description for tile_use_small_layout option 10(3 minutes ago, 1 file, 3+ 2-) 13https://github.com/crawl/crawl/commit/5b29d696637d 15:40:03 Unstable branch on underhound.eu updated to: 0.34-a0-934-g5b29d69663 (34) 17:43:34 -!- TAS-2012v is now known as TAS_2012v 18:46:31 New branch created: pull/4830 (1 commit) 13https://github.com/crawl/crawl/pull/4830 18:46:31 03brianfaires02 07https://github.com/crawl/crawl/pull/4830 * 0.34-a0-935-g48c1824053: Protect chk_lua_save from functions returning nil. 10(7 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/48c18240539b 22:31:01 03DracoOmega02 07* 0.34-a0-935-g04fd3a23e9: Fix wall monster pathfinding considering walls opaque (gammafunk, various) 10(52 seconds ago, 2 files, 14+ 14-) 13https://github.com/crawl/crawl/commit/04fd3a23e9b4 22:35:25 Unstable branch on crawl.develz.org updated to: 0.34-a0-934-g5b29d69663 (34) 22:58:11 Windows builds of master branch on crawl.develz.org updated to: 0.34-a0-935-g04fd3a23e9 23:05:25 <06r​egret-⸸nde※> My opinions on vault design talk I've overheard have come up in #dcss: 23:05:29 <06r​egret-⸸nde※> * I've never been an advocate for all runed door chambers being no_tele_into. Using one of the most prominent gimmick comparisons in the whole game in two Lair ends, I’m not sure there’s any real argument to how it's been perfectly fine to teleport into two non-pre-Lair dragons in the open in guppyfry_lair_end_dragon for a decade, but we need to hold off anybody teleporting onto one in cheibrodos_lair_end_hotspot. In 23:05:30 broader terms, autoexploring into out-of-depths pre-Lair has been prominently possible for quite a long while, but we’re not reshaping development around the existence of the_grid. (Transporter arenas are something I'm fairly more amenable towards assessing in this context- I sure can espy teleporting next to a D:13 juggernaut right now- but runed doors are explicitly a design that are meant to interact with the rest of the level when one opts to open 23:05:30 them, and with Necropolis’s existence I’d be happy for most of them to be quite rare.) 23:05:35 <06r​egret-⸸nde※> * With Necropolis having moved most of the runed door and transporter vaults into portals, meant to reduce the inherent issue of runed door + transporter vaults mostly advocating for backtracking only when they're harmless, I'm not greatly convinced there's a lot of pressure to make sure rockfish can't leave sealed vaults. Nearly all sealed vaults are specifically themed nowadays, so they won't even matter for most uses (and I 23:05:36 can only see four whole non-ghost transporter vaults using 098s or random zombie calls still left after in all of Crawl's history, with one of them using permarock so rock fish still can’t escape). Without using 9s or 8s pre-Temple (which has had and still has large difficulty spike problems for most of Crawl's development, like D:5 unseen horrors) or 0 band calls (which tend to be wildly inconsistent in threat level and thus something I'm regularly 23:05:36 concerned about outside of e.g. Vaults:1-4, the bands branch), an individual rock fish isn't any scary anyway, and is reasonably comparable to a mildly-weaker bullfrog with non-zero AC and rElec. 23:05:43 <06r​egret-⸸nde※> * For the other two wallwalking monsters: I did a large amount of vault review to keep earth elementals outside of Elf / Abyss behind lava / runed doors / permaglass as they can’t escape, and as regular spawns they’re are definitely not a notable threat in the dancing weapon branch. Undertakers being exclusive to Tartarus + explicit Crypt end vault placement means they should practically never be interacting with 23:05:43 transporters or runed door vaults anyway. 23:05:50 <06r​egret-⸸nde※> * I don't particularly care about people complaining about shafting or being teleport trapped into the Hall of Blades, and other devs would argue it is a beneficial piece of identity to the branch. By the time one is doing Elf at all, they should already be a character that can survive teleport rouletting through Blade to escape, especially with the non-vault difficulty of Elf having continued to go up notably over time since 23:05:51 deep elf zephyrmancers and thermic dynamoes were split off + deep elf elementalists got further revised. 23:08:40 <04d​racoomega> other devs would argue it is a beneficial piece of identity to the branch I am one of them, for the record. Getting shafted/teleported into the Hall of Blades is iconic (and I feel actually a genuinely interesting problem to have to solve, when it happens.) 23:10:54 <04d​racoomega> Would definitely be opposed to this changing. 23:29:07 Unstable branch on cbro.berotato.org updated to: 0.34-a0-935-g04fd3a23e9 (34) 23:55:20 Monster database of master branch on crawl.develz.org updated to: 0.34-a0-935-g04fd3a23e9