00:58:51 -!- indigaz20 is now known as indigaz2 03:33:19 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 05:10:12 Unstable branch on crawl.akrasiac.org updated to: 0.34-a0-683-g1e59046 (34) 07:32:40 Midpoint (L16 DsFw) ASSERT(abs(armour_plus) <= 30) in 'monster.cc' at line 770 failed. (Orc:2) 07:34:40 Midpoint (L16 DsFw) ASSERT(abs(armour_plus) <= 30) in 'monster.cc' at line 770 failed. (Orc:2) 09:23:49 <04dracoomega> Well, that's an amusing bug 09:24:33 <04dracoomega> Cigotuvi's embrace has too many plusses for the game to think it's legit 09:24:49 <04dracoomega> (When put on a monster) 09:25:10 <04dracoomega> Via Awaken Armour in this case 09:25:55 03nicolae02 07* 0.34-a0-684-g2ad57854a0: Hopefully fix a small but nonzero chance for a teleport closet 10(39 seconds ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/2ad57854a09b 09:26:30 <04dracoomega> (Sanity check just needs to be less aggressive, I guess) 10:05:08 03nicolae02 07* 0.34-a0-685-g2490ed292b: Add a few more options for 22-altar temples 10(3 minutes ago, 1 file, 40+ 8-) 13https://github.com/crawl/crawl/commit/2490ed292b58 10:34:49 03nicolae02 07* 0.34-a0-686-g872437d217: Add another 22-altar temple layout. 10(2 minutes ago, 1 file, 32+ 4-) 13https://github.com/crawl/crawl/commit/872437d217c6 10:40:35 04Build failed for 08master @ 872437d2 06https://github.com/crawl/crawl/actions/runs/17178274222 10:42:06 <08nicolae> i checked my whites, that's not on me 10:48:14 no, that's github's notworking again 11:19:28 slimify description is very misleading... if you read it in-game it should 100% work on holy monsters and demons 12:20:41 03regret-index02 07* 0.34-a0-687-g4652e73e1c: Fix up weapon-inlaid floor tiles in blades_alternative (Darby) 10(66 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/4652e73e1ca6 14:29:45 <04dracoomega> So, I am in the process of figuring out how to refactor a bunch of things related to melee attack setup and cleave/dual-wield handling (to fix an expanding pile of bugs I have found since last night...), and in the process I am wondering if anyone has an opinion on what the 'correct' behavior for attack action counting should be? (ie: the stuff that shows up in morgues saying how many times you attacked.) Since it feels like there's 14:29:46 a number of inconsistencies. Currently, it looks like each individual hit of manifold assault count as a separate attack, but targets hit by axe cleave do not. (ie: if you hit 4 things with manifold assault, it counts as 4 attacks, but hitting 4 things with an axe counts as 1 attack.) Quick blades count as two attacks (and coglins dual-wielding count as 1 attack for each weapon). Things like spellclaws count as an attack, but oni potion cleave 14:29:46 doesn't. This obviously isn't very important at all, but since I need to touch the code in the process of solving Actual Issues, I was wondering if anyone had any opinions on what makes most sense. Should it just be 'attack actions performed in the normal way' (meaning 1 per quick blade and 0 per manifold assault) as a way of tracking what the player is choosing to do, or 'every attack that happens no matter what' (in which case oni potion cleave 14:29:47 should count for at least 1, but potentially 1 per target attacked?) ...actually, there's already a CACT_RIPOSTE to count attacks caused by riposting things (even if that doesn't happen a lot these days), so maybe we're supposed to split things and have a count for 'each time you tried to attack anything (regardless of weapon used)' and another for 'every individual swing against some monster with some weapon'??? 15:02:18 <04dracoomega> To be honest, there's a bunch of things in action counts that are probably of questionable value. We lump all potions/scrolls into the same category (as if ?ew and ?blinking are somehow comparable) but have to split 'times you were hit' into a seperate line for what base type of armour you were wearing at the time it happened? 15:02:47 03nicolae02 07* 0.34-a0-688-g1ad0e0334e: Make another small edit to a hard Vaults vault 10(2 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/1ad0e0334e59 15:03:00 <04dracoomega> Is the latter even terribly helpful? 15:27:16 <09gammafunk> it is kind of useful in that you can see what armour was used over the course of the game, yeah 15:27:35 <09gammafunk> agree that it's not great to lump potions/scrolls together 15:30:21 03Matt Smith02 07https://github.com/crawl/crawl/pull/4713 * 0.34-a0-689-g3bc9b2b07e: Adds a handful of small entry vaults 10(2 weeks ago, 2 files, 84+ 0-) 13https://github.com/crawl/crawl/commit/3bc9b2b07e84 15:30:21 03Matt Smith02 07https://github.com/crawl/crawl/pull/4713 * 0.34-a0-690-g73dd8cdd0a: Use ' and " as floor tiles in entry vault. Reduce weight of sub-vaults 10(3 minutes ago, 1 file, 25+ 6-) 13https://github.com/crawl/crawl/commit/73dd8cdd0a50 15:31:31 <04dracoomega> It wouldn't be that hard to track potion/scroll use individually. My concern is mostly dump size (but it would be interesting to actually be able to look at) 15:34:54 hide the detailed one behind an option? 15:34:56 <04dracoomega> But I guess dumps are already so long at the back end that we might as well actually put useful info like that there 15:35:34 <04dracoomega> Like, it's nothing compared to notes and kill count 15:35:34 <12ge0ff> ~40 extra lines shouldn't affect the dump size too much 15:37:08 mm, yes, I forgot the kills, a few extra lines won't matter 15:38:18 <04dracoomega> I'm thinking what might make more sense for attack action counting is to have one category for 'swung at an enemy with X weapon' and another for 'performed an attack for the following reason' (ie: deliberate attack, riposte, spellclaws, etc.) and not mentioning weapon, since that's already covered in the other category. Rather than what we have now which is sort of inconsistently muddled between 'player actions' and 'result of player 15:38:19 actions' 15:39:33 <04dracoomega> So bumping into something with an axe produces one 'melee attack' action and X 'hit with an axe' actions (and manifold assault and potion cleave and so forth also produce X 'hit with an axe' actions, but no 'melee attack' since that's not what you did) 15:40:01 <04dracoomega> (Currently ripostes get their own full complete category (listing weapon) and other unusual attacks get nothing) 15:41:03 Unstable branch on underhound.eu updated to: 0.34-a0-687-g4652e73e1c (34) 15:44:08 03Matt Smith02 07https://github.com/crawl/crawl/pull/4713 * 0.34-a0-691-g478b884047: fixup 10(3 minutes ago, 1 file, 0+ 21-) 13https://github.com/crawl/crawl/commit/478b884047db 15:45:12 03Matt Smith02 07https://github.com/crawl/crawl/pull/4713 * 0.34-a0-690-gffcfa5fb84: Use ' and " as floor tiles in entry vault. Reduce weight of sub-vaults 10(18 minutes ago, 1 file, 4+ 6-) 13https://github.com/crawl/crawl/commit/ffcfa5fb8434 16:16:59 03dolorous02 07* 0.34-a0-689-g8bba17d133: Add missing Makefile title splash (Goratrix) 10(9 minutes ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/8bba17d13365 16:16:59 03dolorous02 07* 0.34-a0-690-g9a7cbd1967: Fix vault branch typo. 10(7 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/9a7cbd1967a6 16:23:50 04Build failed for 08master @ 9a7cbd19 06https://github.com/crawl/crawl/actions/runs/17181255082 17:28:03 03Matt Smith02 07https://github.com/crawl/crawl/pull/4713 * 0.34-a0-690-g3364b6a852: Use ' and " as floor tiles in entry vault. Reduce weight of sub-vaults 10(2 hours ago, 2 files, 6+ 6-) 13https://github.com/crawl/crawl/commit/3364b6a85262 17:31:14 03Matt Smith02 07https://github.com/crawl/crawl/pull/4713 * 0.34-a0-690-g2defff243e: Use ' and " as floor tiles in entry vault. Reduce weight of sub-vaults 10(2 hours ago, 1 file, 4+ 6-) 13https://github.com/crawl/crawl/commit/2defff243edf 22:35:20 Unstable branch on crawl.develz.org updated to: 0.34-a0-690-g9a7cbd1967 (34) 22:57:13 Windows builds of master branch on crawl.develz.org updated to: 0.34-a0-690-g9a7cbd1967 22:59:12 dump size> surely this is nothing compared to .lst files 23:06:48 <04dracoomega> I honestly keep forgetting those are a thing 23:13:21 Unstable branch on cbro.berotato.org updated to: 0.34-a0-690-g9a7cbd1967 (34) 23:55:08 Monster database of master branch on crawl.develz.org updated to: 0.34-a0-690-g9a7cbd1967