09:39:15 -!- The topic of #crawl-dev is: Crawl Development | https://github.com/crawl/crawl | Logs: http://s-z.org/crawl-dev/, temporarily http://crawl.akrasiac.org/logs/cheibriados/ | People with +v have commit access, devs on bridged discord as well | General Crawl-related chat to #crawl | Long stuff to a pastebin service, please 09:39:15 -!- The topic of #crawl is: Play Dungeon Crawl Stone Soup online now! Type ??online for instructions, ??lg / !lg for play stats | PM Sequell for long queries | http://crawl.develz.org | FooTV game replays: ??footv for instructions | #crawl-dev for dev discussion, #crawl-offtopic for offtopic 09:40:06 test 09:42:39 <09g​ammafunk> @ge0ff ok, I restarted notcheibriados and it appears to be logging now, but I'm not actually sure how @icoson prefers this process to be run. Possibly in screen from his account? Since I'd prefer not to mess with advil's login, if you notice this again, maybe ping advil first (unless advil prefers me to do it) 10:29:45 newbie contributor here - I was looking at adding an artifact 2h shield (mainly to explore getting more blocks/turn), but quickly realised that would probably cause a huge mess. Is something like that possible by overriding say a great mace and giving it +sh and increasing the blocks/turn? 10:32:56 <09h​ellmonk> implementing as a custom weapon type is probably the easiest way, yeah 10:34:48 looking at the blocks/turn function, it switches on shield type, which suggests its probably not easy to change 10:34:59 (also how do I chat in here via discord?) 10:40:27 <09h​ellmonk> you could just put something at the top of actor::shield_block_limit() that checks weapon slot, shouldn't be too tricky. 11:25:45 <12g​e0ff> @gammafunk cool, thanks! 11:35:39 @hellmonk good idea. Having it as a weapon though means it doesn't interact with the shields skill for scaling or spellcasting penalties 11:40:13 <09h​ellmonk> True. I wonder if the best implementation is a 1h shield that covers weapon slot and has some custom formula for melee damage. 11:40:49 <09h​ellmonk> which I think is doable and gives 2h behavior with extra steps 11:43:07 reasonance (L25 DsHW) ERROR in 'mon-util.cc' at line 3218: bogus mc (no monster data): invalid monster_type 1000 (1000) (Abyss:3) 11:52:51 yeah I was just looking at how the finger necklace changes slots, and toying with removing the weapon slot while it is equipped. Even if you can't attack while wielding it, might make for an interesting item 12:06:07 cyberm0nk (L12 CoHu) ASSERT(_valid()) in 'ray.cc' at line 229 failed. (D (Sprint)) 12:12:54 I was going to say, with vanilla's new exciting support for slot shuffling items - or even without - keeping it as a shield seems easiest 12:25:37 As a 2h weapon that gives +SH - how does it interact with Shields skill, penalties for insufficient Shields skill (yeah, I know), autotraining, basically everything in the code that checks if an item is a shield? Sounds like a nightmare. 12:29:41 speaking with zero experience it also sounds quite difficult to make it interact with the weapon skill if I go the other way and add it as a shield? 12:31:40 I'm not clear on how it would interact with the weapon skill, sorry if I missed something 12:35:54 me either, the idea is that it would be a 2h shield that you could bonk stuff with, so would probably be governed by maces + flails. Would be much worse than a regular weapon, but in return youd get a lot of SH, additional blocks/turn, maybe some other fluff to round it out 12:36:43 alternatively not allowing you to attack at all would also be an option, although then its no use at all on melee fighters which seems the most thematic fit for 14:05:42 <09h​ellmonk> I think you could override unarmed combat code somewhere to give it "weapon damage" 14:43:32 03dolorous02 07* 0.34-a0-577-g2fab65de6a: Fix typo/Clang compile warning. 10(2 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/2fab65de6a47 14:50:47 that was quick :grin: 14:51:33 (I still have one open that was only partially resolved) 14:59:28 New branch created: pull/4712 (2 commits) 13https://github.com/crawl/crawl/pull/4712 14:59:29 03mainiacjoe02 {GitHub} 07https://github.com/crawl/crawl/pull/4712 * 0.34-a0-575-g589dc2a798: Add a title splash by YLam 10(8 minutes ago, 1 file, 0+ 0-) 13https://github.com/crawl/crawl/commit/589dc2a79857 14:59:29 03mainiacjoe02 {GitHub} 07https://github.com/crawl/crawl/pull/4712 * 0.34-a0-576-g0c477235ed: Update CREDITS.txt 10(5 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/0c477235edd7 15:40:35 Unstable branch on underhound.eu updated to: 0.34-a0-577-g2fab65de6a (34) 16:34:40 do I need any sort of permissions to push a branch to raise a PR? I'm getting permission denied when trying to push a branch with a couple of arrival vaults on it 16:38:51 generally you do things the normal GitHub way: fork the repo, make the branch in your fork, when you push to it the first time you'll be offered the chance to make a PR 16:39:56 the only people who have permission to make branches against the main repo are usually the developers 16:41:46 ah thanks, didn't realise I needed to fully fork the repo 16:43:15 03DracoOmega02 07* 0.34-a0-578-g30ae0b2bbc: Fix staves of necromancy not showing up when searching rN+ (salticid) 10(4 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/30ae0b2bbca5 16:43:15 03DracoOmega02 07* 0.34-a0-579-g6930c24efb: Have the rElec- mut mention the resist in its short desc (Planckenstein) 10(4 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/6930c24efbf2 16:43:15 03DracoOmega02 07* 0.34-a0-580-ge8c28444c0: Fix new orb of pyromania timing issues and tweak (Acrobat) 10(71 minutes ago, 4 files, 63+ 40-) 13https://github.com/crawl/crawl/commit/e8c28444c033 16:43:15 03DracoOmega02 07* 0.34-a0-581-g247caf9a7c: Rework orb of stardust somewhat 10(9 minutes ago, 7 files, 42+ 29-) 13https://github.com/crawl/crawl/commit/247caf9a7cbf 16:43:15 03DracoOmega02 07* 0.34-a0-582-g15649fa837: Fix category multidrop hotkeys no longer working (Ge0FF) 10(2 minutes ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/15649fa83709 16:51:43 New branch created: pull/4713 (1 commit) 13https://github.com/crawl/crawl/pull/4713 16:51:43 03Matt Smith02 07https://github.com/crawl/crawl/pull/4713 * 0.34-a0-577-g0fdad21e1e: Adds a handful of small entry vaults 10(28 minutes ago, 2 files, 78+ 0-) 13https://github.com/crawl/crawl/commit/0fdad21e1eb6 16:52:28 ey its me 17:13:20 ms813: Hello again. 17:14:24 congrats on your first PR 17:15:29 thanks! I parked the 2h shield for now, I think it was perhaps a bit ambitious for the first contribution 17:16:51 I ah do think a 2h shield that you run around battering monsters with is not a good idea, although that's just me 17:20:22 I was hoping it would make for an interesting tradeoff, much slower to kill things but you feel fairly tanky 17:20:51 the blocks/turn mechanic that was introduced a few versions ago seems like it could have a few cool interactions 22:35:27 Unstable branch on crawl.develz.org updated to: 0.34-a0-582-g15649fa837 (34) 22:58:26 Windows builds of master branch on crawl.develz.org updated to: 0.34-a0-582-g15649fa837 23:19:39 Unstable branch on cbro.berotato.org updated to: 0.34-a0-582-g15649fa837 (34) 23:55:34 Monster database of master branch on crawl.develz.org updated to: 0.34-a0-582-g15649fa837