03:16:52 <09h​ellmonk> Huge digging buff 03:19:34 <04d​racoomega> Digging already tells you when you're at the level border, doesn't it? 03:34:12 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 03:49:35 <09h​ellmonk> don't remember 04:39:23 <02M​onkooky> I wonder if something's fucked with the marshalling and unmarshalling of constrictors 05:54:01 <02M​onkooky> It does look like the code to clean up temporary allies when you leave a level will not apply to your summon's summons- _expire_temporary_allies() checks specifically if (mons.was_created_by(you)) 05:55:00 <02M​onkooky> And it doesn't look like recalling offlevel allies cleans up their summons either 05:55:36 New branch created: pull/5201 (1 commit) 13https://github.com/crawl/crawl/pull/5201 05:55:37 03autumn02 07https://github.com/crawl/crawl/pull/5201 * 0.35-a0-269-gf4e8eea51d: Fix item method docs Ldoc was generating item methods with a self param (e.g. `item:inscribe(param)` notation), when the correct usage is `item.inscribe(param)`. 10(70 seconds ago, 1 file, 7+ 7-) 13https://github.com/crawl/crawl/commit/f4e8eea51d1d 05:56:49 <02M​onkooky> I can't follow the throughline to the crash- not clear to me how the constrictor stops existing, and I have no idea how you'd even try to replicate it either since there doesn't seem to be a good way to wizmode an apostle with a specific spell into being 05:57:53 I once lost a :(> yred soul that was offlevel in either 0.32 or 0.33, was this ever fixed (if it was unintentional?) I assume some wandering mob I missed on the (fully explored) level killed it or something 06:03:23 <02M​onkooky> you can check the commit history 06:16:13 I've never bisected with git before but I'll try 08:21:35 <08o​____0> !versions 08:21:38 <04C​erebot> Latest versions seen in milestones this week: [LLD] => 0.34.1-3-ga2c7840, [CAO] => 0.35-a0-181-g84ebf06, [CBR2 CDI CDO CNC CPO CUE CXC CBRG] => 0.35-a0-268-g36cf4e3 08:22:10 <08o​____0> !git 84ebf06 08:22:12 <04C​erebot> WizardIke * 0.35-a0-181-g84ebf0652c: Fix many cases of reaching full hp not attuning regen (yrdzrfxndfvh) (5 weeks ago, 5 files, 35+ 11-) https://github.com/crawl/crawl/commit/84ebf0652ce2 08:22:32 <08o​____0> CAO hasn't updated in about a month it would seem? 09:29:30 <09g​ammafunk> ah 09:29:34 <09g​ammafunk> let me check 09:30:20 <09g​ammafunk> well 09:30:24 <09g​ammafunk> this is certainly quite a compilation error 09:33:57 <09g​ammafunk> https://pastebin.com/dnbmHYkN 09:34:12 <09g​ammafunk> the first couple lines are just a warning about a shadowed tiles-related variable 09:37:46 <09g​ammafunk> gcc unhappy with how the mon gear data is specified now 10:51:30 <08o​____0> 89500f345 was the only commit to touch that and really fits the timing of when the updates stopped working but I don't see anything unusual with it at all 10:51:55 <08o​____0> !git 89500f345 10:51:57 <04C​erebot> regret-index * 0.35-a0-182-g89500f345a: Nudge up athame drop rates and quality (6 weeks ago, 2 files, 22+ 12-) https://github.com/crawl/crawl/commit/89500f345a58 12:03:52 <09g​ammafunk> well the data structure where it's erroring is the key thing to look at, in terms of what changed. I assume it's one of those big equip def classes that holds enum values for monsters and weapons etc 12:04:15 <09g​ammafunk> or perhaps the data hasn't changed but how its used was changed slightly 12:04:47 <09g​ammafunk> but I can't take a closer look until later. if anyone does hunt it down, PR/bug fix suggestions welcome, of copurse 18:23:21 <04d​racoomega> Weird. Another case where CAO's very old gcc is complaining about stuff none of the rest of ours is, huh? 18:25:08 <04d​racoomega> Well, they are killed at some point (usually when you return to the level), at which point their summons are cleaned up. But moreover, no matter when or how the cleanup is done, killing a constrictor is supposed to unconditionally remove constriction, and it's hard for me to tell how this could not be the case. (Even if it seemingly was in their save.) 18:26:38 <04d​racoomega> Huh... Looking at that commit, there is one brace thing that looks suspicious to me... 18:28:50 <02M​onkooky> What did you do to attempt replication? Just boot up their save? 18:33:06 <04d​racoomega> I just edited the code to ensure I got one >.> 18:33:19 <04d​racoomega> There really isn't any reasonable way to do it in wizmode alone 18:33:41 <04d​racoomega> (Okay, I actually gave myself an ancestor with StS, since that was easier, but I think they work the same way) 18:36:57 <02M​onkooky> rippo 19:19:24 03DracoOmega02 07* 0.35-a0-269-g63ac50c651: Give Vessel of Slaughter a static targeter 10(26 hours ago, 2 files, 3+ 1-) 13https://github.com/crawl/crawl/commit/63ac50c65189 19:19:24 03DracoOmega02 07* 0.35-a0-270-geed6cab612: Fix a few abilities not interacting properly with the quiver 10(26 hours ago, 2 files, 5+ 2-) 13https://github.com/crawl/crawl/commit/eed6cab612f5 19:19:24 03CrawlOdds02 {DracoOmega} 07* 0.35-a0-271-g863a6f8961: Don't use randart tiles for enchanted hammers 10(3 days ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/863a6f896110 19:19:24 03CrawlOdds02 {DracoOmega} 07* 0.35-a0-272-g09ccc81b47: Don't trigger attunement on enemy staff attacks 10(3 days ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/09ccc81b476f 19:19:24 03CrawlOdds02 {DracoOmega} 07* 0.35-a0-273-gcbca37cc1a: Do not power up Wyrmbane twice when killing dragons with convulsion 10(3 days ago, 1 file, 9+ 8-) 13https://github.com/crawl/crawl/commit/cbca37cc1acd 19:19:24 03CrawlOdds02 {DracoOmega} 07* 0.35-a0-274-g7ecd7e923a: Explore boundary walls 10(7 days ago, 1 file, 10+ 2-) 13https://github.com/crawl/crawl/commit/7ecd7e923ad0 19:19:24 03CrawlOdds02 {DracoOmega} 07* 0.35-a0-275-g261e6ac810: Stop Hep ancestors wandering off on Zot:5 10(6 days ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/261e6ac810a5 19:19:24 03CrawlOdds02 {DracoOmega} 07* 0.35-a0-276-gab1eb49602: Do not stop channelling spells on any macro 10(13 days ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/ab1eb49602d9 19:19:24 03CrawlOdds02 {DracoOmega} 07* 0.35-a0-277-gec5cf0b163: Make plasma beam useless if it will do no damage 10(3 weeks ago, 3 files, 23+ 8-) 13https://github.com/crawl/crawl/commit/ec5cf0b16395 19:19:24 03CrawlOdds02 {DracoOmega} 07* 0.35-a0-278-gf34de8fe48: Fix free detection of invisible monsters with -move (Back-form) 10(2 weeks ago, 1 file, 12+ 6-) 13https://github.com/crawl/crawl/commit/f34de8fe4810 19:19:24 ... and 6 more commits 19:27:43 <09g​ammafunk> hrm 19:27:45 <09g​ammafunk> CXX ability.o In file included from externs.h:41:0, from AppHdr.h:306, from ability.cc:6: rltiles/tiledef_defines.h: In constructor 'tile_with_flags_t::tile_with_flags_t(tileidx_t, tile_flag_t)': rltiles/tiledef_defines.h:17:67: warning: declaration of 'flags' shadows a member of 'this' [-Wshadow] rltiles/tiledef_defines.h:17:67: warning: declaration of 'tile' shadows a member of 'this' 19:27:46 [-Wshadow] rltiles/tiledef_defines.h: In member function 'void tile_with_flags_t::set_tile(tileidx_t)': rltiles/tiledef_defines.h:63:5: warning: declaration of 'tile' shadows a member of 'this' [-Wshadow] ability.cc: In constructor 'scaling_cost::scaling_cost(int, int)': ability.cc:135:9: warning: declaration of 'fixed' shadows a member of 'this' [-Wshadow] At global scope: 19:27:51 <09g​ammafunk> tons of these warnings from cao's gcc btw 19:28:15 <04d​racoomega> Now that stuff is new 19:28:32 <09g​ammafunk> not errors but warnings on most every file since the warning is from a tile header included in a lot of files 19:28:45 <04d​racoomega> %git 9a5c35d 19:28:46 <04C​erebot> WizardIke * 0.35-a0-263-g9a5c35dbd8: Refactor: move tile flags out of tileidx_t (7 days ago, 27 files, 322+ 252-) https://github.com/crawl/crawl/commit/9a5c35dbd8ad 19:29:14 <09g​ammafunk> yeah, I figured it was that commit when I saw this earlier 19:29:27 <09g​ammafunk> I'm just running compilation from interactive terminal on cao now to see if the build is fixed 19:29:45 <09g​ammafunk> we just hit describe.cc, wish cao luck 19:30:23 that thing needs more thana luck 😛 19:31:18 <09g​ammafunk> wish cao an instantaneous OS upgrade then, geekosaur! 19:32:11 <09g​ammafunk> we have a rough plan to deal with the CAO situation in terms of replacement and/or OS upgrade in the longterm, at least 19:32:32 <09g​ammafunk> with a new Western US server coming online to make any potential CAO downtime less painful etc 19:32:42 take it behind the shed and...? 19:34:30 <09g​ammafunk> well it turns out that you can upgrade the software on servers, you don't just have to decommission them 19:34:40 no, that doesn't seem right 19:35:00 <09g​ammafunk> the issue is really just that it needs an OS upgrade and doing that is non-trivial 19:35:14 <09g​ammafunk> I wouldn't expect a programmer to understand (only half joking) 19:35:54 wdym you just do do-release-upgrade and it should be fixed, no intervention required :^) 19:37:58 <09g​ammafunk> what if I told you that there was this crazy distribution that came before Ubuntu and which Ubuntu is based on and CAO runs that OS? 19:38:48 you mean Debian and not Slackware right 19:39:25 <09g​ammafunk> apparently slackware wasn't the first linux distro 19:39:32 <09g​ammafunk> I thought it was for a long time, but there was another one prior 19:39:45 <09g​ammafunk> but yes CAO runs (ancient) Debian 19:39:45 * geekosaur just watches the kids argue 19:39:55 two, actually 19:39:59 one official 19:39:59 we get it, you're OLLLLD 19:40:16 the other was MCC Interim 19:40:21 <09g​ammafunk> sigh, geekosaur is going to tell us about Unix System 5 now 19:40:21 what on earth 19:40:57 the University of Manchester did their own pseudo-distribution and made it available to thewrs with no support 19:41:00 <09g​ammafunk> @dracoomega sorry to report that your commit did not fix compilation, seems to fail with the same error 19:41:00 *others 19:41:14 <04d​racoomega> Well, it was a stab in the dark 19:41:45 <04d​racoomega> I just remembered that one CAO issue we had previously involved some empty initialization and that was one of the only things in the commit in question that caught my eye 19:41:53 <04d​racoomega> Unfortunate 19:42:19 <09g​ammafunk> well I can try to sit down and figure things out tomorrow maybe, but of course you're free to try other fixes and ping me if you want a quick test 19:42:35 <09g​ammafunk> not super high priority since it just means that CAO trunk is behind for a few more days or so 19:42:53 ... time to do some Wyrmbane runs 19:43:06 <09g​ammafunk> oh no was there a wyrmbane bug 19:43:26 <09g​ammafunk> oh I see it 19:43:58 <09g​ammafunk> looks like it shouldn't raise the enchant past the cap though, so you just get powered up faster 19:44:14 ah true 19:44:47 we need more fun exploits. Y'all should write sloppier code >:( 19:46:11 <09g​ammafunk> sorry, we use only use the most optimized and provably correct techniques from computer science, as well as the most cutting edge compilers 19:46:55 waiting for a new crawl fork that's written in Lean now 19:50:49 * geekosaur 🤣 22:36:00 Unstable branch on crawl.develz.org updated to: 0.35-a0-284-g0df9381b46 (34) 22:53:28 <11O​dds> Thanks for all the reviews @dracoomega! 22:54:08 <02D​arby> oddest commitstorm yet 22:55:54 <11O​dds> I hope nobody saw 16 new commits and got hopeful some exciting feature had landed 22:59:56 Windows builds of master branch on crawl.develz.org updated to: 0.35-a0-284-g0df9381b46 23:25:07 Unstable branch on cbro.berotato.org updated to: 0.35-a0-284-g0df9381b46 (34) 23:56:08 Monster database of master branch on crawl.develz.org updated to: 0.35-a0-284-g0df9381b46 23:58:49 <07w​izardike> It's a little late but I did find a slight problem with this PR. If there is a monster that is petrifying and a non-petrifying monster behind it, casting petrify will tell you that you have no valid target even though targeting the petrifying monster will chain to the other monster (you can still cast with uppercase Z though)