01:22:31 03WizardIke02 07* 0.35-a0-260-g030a0ecb6a: Fix a crash when returning to a level with vengeance targets (kegye) 10(3 hours ago, 10 files, 64+ 29-) 13https://github.com/crawl/crawl/commit/030a0ecb6a5a 02:16:43 03WizardIke02 07* 0.35-a0-261-gdabc3d4ed1: Give a better shoutitis message when damaged by contamination (kuniqsX) 10(9 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/dabc3d4ed190 03:27:05 03CrawlOdds02 {WizardIke} 07* 0.35-a0-262-gbae5047b40: Fix message for escaping the constriction of invisible monsters (Back-form) 10(10 days ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/bae5047b404d 03:32:32 03WizardIke02 07* 0.35-a0-263-g9a5c35dbd8: Refactor: move tile flags out of tileidx_t 10(25 hours ago, 27 files, 322+ 252-) 13https://github.com/crawl/crawl/commit/9a5c35dbd8ad 03:34:04 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 04:38:56 -!- HN-MKU_ is now known as HN-MKU 12:05:01 <06r​egret-⸸nde※> @gammafunk Can I ask for another Lua-trained eye over #5175? I can't make heads or tails of why winding_woodlands.des is coming up for entering a trove- neither it nor trove.des use any of the same functions or othersuch calls to one another- and the veto at the start of pf_index_trove_rutra is complaining about being passed nothing to you.base_skill() when it has the same formatting as the rest of the file of 12:05:01 you.base_skill("Stealth"). 12:07:54 <04d​racoomega> Yeah, I took a look at it myself and was baffled 12:24:22 New branch created: pull/5191 (1 commit) 13https://github.com/crawl/crawl/pull/5191 12:24:23 03sandertyu02 07https://github.com/crawl/crawl/pull/5191 * 0.35-a0-264-gfc722dd59c: Display Status Icons on Monster Tile in Title of Describe View 10(6 minutes ago, 1 file, 8+ 0-) 13https://github.com/crawl/crawl/commit/fc722dd59ce6 12:29:49 <09g​ammafunk> OK will look at that tonight 15:42:20 Unstable branch on underhound.eu updated to: 0.35-a0-263-g9a5c35dbd8 (34) 16:39:08 -!- HN-MKU_ is now known as HN-MKU 19:17:05 <09g​ammafunk> @regret-⸸nde※ The offending line turns out to be trove.des:1226, where you need to change "Hexes" into "hexes" in the call to trove_standard_magic() due to how you've set up a table keyed on lower-case spell school names. The strangely absent base skill string is actually happening at trove.des:342, after the loop has failed to set schname. So it in fact wasn't the veto, but from the map's lua after it passed the veto check. I 19:17:06 guess you might want to just do lua if school:lower() == sc:lower() then In that loop, to avoid these types of errors. The misdirection to winding_woodlands.des is unfortunately happening because dlua chunk rewriting is getting things very wrong in this case, both in terms of file and line number, so I need to look into that. Also fwiw the crash log dlua stacktrace is helpful here when locally recreating the bug (which I did in wizmode with &P 19:17:06 on the map while having a stealth skill of at least 1): [C], function base_skill, line -1 [string "global_prelude"], function trove_standard_magic, line 331 [string "dlmain"], function (null), line 35 dungeon.lua, function (null), line 259 ...although the line number there is also off by 11... 19:19:15 <04d​racoomega> Line numbers for lua errors consistently seem wrong, in my experience 19:19:39 <04d​racoomega> I suspect it's leaving parts of the file out during parsing and the numbers reflect this 19:21:39 <04d​racoomega> I guess this was made extra confusing by how the 'real' error was in fact still happening via a call to l_skill(), just not one from the same place 19:22:35 <09g​ammafunk> well, yes, but you could just say it was happening via a call to you.base_skill() that wasn't the one in the veto 19:23:00 <09g​ammafunk> but yeah that's the c-side function that was attempting the skill lookup 19:23:20 <09g​ammafunk> I went straight to gdb without reading the crash log dlua trace, so I wanted more time... 19:23:34 <09g​ammafunk> although gdb did reveal what was going on indirectly, at least 19:24:02 <09g​ammafunk> good to know that I spent all that time adding dlua traces and then when a use case arose where it was helpful I ignored it 19:24:58 <09g​ammafunk> but yeah the dlua "chunk rewriting" business is an unfortunately necessity given our DES system and it's very tricky to get write. Much of of headache of understading crawl's implementation of lua is reading code related to that 19:29:43 <04d​racoomega> Oh no, haha 20:01:04 03regret-index02 07* 0.35-a0-264-ge5931b7edd: Fix a Rutra trove Lua error (#5175) 10(42 seconds ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/e5931b7edd29 20:07:13 <06r​egret-⸸nde※> Thanks for looking through it! 22:35:44 Unstable branch on crawl.develz.org updated to: 0.35-a0-264-ge5931b7edd (34) 22:59:08 Windows builds of master branch on crawl.develz.org updated to: 0.35-a0-264-ge5931b7edd 23:34:31 Unstable branch on cbro.berotato.org updated to: 0.35-a0-264-ge5931b7edd (34) 23:55:52 Monster database of master branch on crawl.develz.org updated to: 0.35-a0-264-ge5931b7edd