00:13:31 Unstable branch on cbro.berotato.org updated to: 0.35-a0-0-gff61f77f9c (34) 04:35:44 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 04:54:42 03WizardIke02 07* 0.35-a0-1-g231e7417e9: Fix a crash when trying to get the slot for an item in lua 10(19 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/231e7417e9e9 04:57:57 03WizardIke02 07[stone_soup-0.34] * 0.34-b1-2-g2e857c154f: Fix a crash when trying to get the slot for an item in lua 10(23 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/2e857c154fd8 05:09:39 Unstable branch on crawl.akrasiac.org updated to: 0.35-a0-1-g231e741 (34) 05:17:31 04Build failed for 08stone_soup-0.34 @ 2e857c15 06https://github.com/crawl/crawl/actions/runs/21396255743 05:19:39 <07w​izardike> The function l_item_swap_slots hasn't survived the addition of the consumable inventory. First, consumable items still have a slot based on their letter that is between 0 and 51 inclusive but l_item_swap_slots won't swap the slot for a consumable item unless it is given a slot greater than 51. Second, the slot to swap to can be anything between 0 and 126 inclusive but anything above 51 can result in the item being assigned to an 05:19:39 invalid letter. 05:22:27 <04d​racoomega> =/ 05:26:25 <07w​izardike> I'm not sure the best way to fix this. We might need a separate slot swap function for each type of inventory or an extra argument specifying what type of inventory to swap the slot for 05:28:57 <04d​racoomega> Yeah, I guess I never noticed this enough when I was first implementing consumable inventory. (I apparently edited it slightly, but clearly didn't think it throught enough at the time >.>) 05:30:45 <04d​racoomega> If we're changing the api anyway, it probably ought to just take actual letters, too. (Is there any good reason for it not to?) 05:34:37 <07w​izardike> It should be fine for it to take letters. Although we might want to add an easier way to get the letter an item is assigned to 05:35:48 <04d​racoomega> Oh, hmm, right. 05:39:45 <07w​izardike> Its not to bad right now. You can get the slot, check that it isn't nil then convert the slot to a letter. But a way to get an item's assigned letter directly would probably be nice even without changes to l_item_swap_slots 05:47:36 <04d​racoomega> It does seem like it's a more natural mapping of what is actually used in-game in any player-visible way 05:49:00 <04d​racoomega> (But I'm never 100% confident about the best way to arrange clua functions, since I don't use them myself and thus lack the perspective of someone who actually does stuff with the api) 06:20:58 <04d​racoomega> (Have you done any work on any of this already, or should I assume responsibility for fixing this? So we don't duplicate effort and all.) 08:04:22 <07w​izardike> Feel free to fix it. I haven't started on fixing it 08:47:05 Am I misreading the https://doc.dcss.io/modules/crawl.html#grammar for "qualname"? I was surprised by this: 08:47:05 > crawl.mpr(string.format('# %s', items.inslot(0).name('qualname'))) 08:47:05 # +0 war axe 08:48:24 Also, tried this, same thing: 08:48:24 > crawl.mpr(string.format('# %s', items.inslot(0):name{desc='qualname'})) 08:48:24 # +0 war axe 08:50:00 <07w​izardike> @dracoomega Do you know what the hit_count.size() != 1 check is trying to prevent in bolt::handle_enchant_chaining? It makes it so that a reflected petrify won't spread as hit_count will contain the actor that reflected it and the caster that it was reflected back at (it also doesn't spread at the actor that reflected because handle_enchant_chaining is only called when an actor is affected) void 08:50:00 bolt::handle_enchant_chaining(coord_def centre) { // Handle ray bounces if (!(origin_spell == SPELL_PETRIFY || origin_spell == SPELL_RIMEBLIGHT) || hit_count.size() != 1) { return; } vector chain_targs; fill_chain_targets(*this, centre, chain_targs, true); if (chain_targs.empty()) return; // Bounces are at 2/3 power unwind_var ep(ench_power, ench_power * 2 / 3); for 08:50:00 (coord_def c : chain_targs) affect_actor(actor_at(c)); } 08:53:55 <04d​racoomega> I believe that's to prevent each chain from itself chaining - ie: that this is only called the first time the enchant hits anything. Clearly that's not entirely accurate, though. 08:57:11 <07w​izardike> Oh that makes sense, thanks 08:58:04 Sorry, I disconnected and missed if anyone responded to my message? 08:58:28 <04d​racoomega> But I guess what's happening is that hit_count can go up even with an actor being affected 09:01:21 <07w​izardike> hit_count is kind of more like a tried to affect count. It goes up when missing and being blocked and sometimes when the target can't be affected but not always 09:01:26 <04d​racoomega> Dossy: Are you using 0.33 or trunk? I think there was a problem in 0.33 with qualname including plusses that was fixed a while back now 09:02:22 <04d​racoomega> I guess the fact that enchantments can't miss or be blocked normally prevented me from noticing there was a failure case here. 09:04:11 I'm on trunk. 09:04:30 > Seeded DCSS version 0.35-a0-1-g231e7417e9 (webtiles) character file. 09:04:37 <07w​izardike> Yeah its very much an edge case, needing warlock's mirror to reflect or the beam to pass through a Hep ancestor etc. 09:05:40 <04d​racoomega> Possibly bolt just wants another boolean member for 'chained already' that we can use here 09:05:52 <04d​racoomega> If there's nothing else completely safe to use 09:07:19 <04d​racoomega> Dossy: Hmmm... I'll take a look in a bit 09:10:13 <04d​racoomega> Dossy: Apparently the documentation is wrong and what you want is 'qual' not 'qualname' 09:10:18 <07w​izardike> That's what I'm trying right now. I don't think there is anything else that works already 09:15:16 dracoomega: oh, damn, yeah. https://github.com/crawl/crawl/blob/master/crawl-ref/source/libutil.cc#L88 09:27:40 03WizardIke02 07* 0.35-a0-2-g2976efafa4: Fix petrify and rimeblight sometimes not chaining (knorpule3000) 10(10 minutes ago, 2 files, 6+ 1-) 13https://github.com/crawl/crawl/commit/2976efafa4b0 09:28:46 03WizardIke02 07[stone_soup-0.34] * 0.34-b1-3-gba93e64a92: Fix petrify and rimeblight sometimes not chaining (knorpule3000) 10(11 minutes ago, 2 files, 6+ 1-) 13https://github.com/crawl/crawl/commit/ba93e64a92a3 09:28:58 > crawl.mpr(string.format('# %s', items.inslot(0).name('qual'))) 09:28:58 # war axe 09:28:58 thanks! 09:37:19 <04d​racoomega> Happy to help 11:18:50 03DracoOmega02 07* 0.35-a0-3-g6f8043d9b5: Tweak slymdra splitting behavior 10(27 hours ago, 4 files, 19+ 11-) 13https://github.com/crawl/crawl/commit/6f8043d9b54a 11:18:50 03DracoOmega02 07* 0.35-a0-4-gf4267a8a47: Fix star jellies sometimes not making stars 10(26 hours ago, 1 file, 3+ 2-) 13https://github.com/crawl/crawl/commit/f4267a8a476f 11:18:50 03DracoOmega02 07* 0.35-a0-5-g176d2a21be: Don't autopickup except when moving 10(26 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/176d2a21be9d 11:18:50 03DracoOmega02 07* 0.35-a0-6-ged45ffe0fa: Fix mesmerisation daze stacking on monsters (and gently lower duration) 10(26 hours ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/ed45ffe0fa28 11:18:50 03DracoOmega02 07* 0.35-a0-7-gcde0a2ff41: Fix Vhi's being overly restrictive while mesmerised 10(26 hours ago, 1 file, 28+ 28-) 13https://github.com/crawl/crawl/commit/cde0a2ff41a8 11:18:50 03DracoOmega02 07* 0.35-a0-8-gb77665ff79: Make Slick Slippers provide immunity to Grave Claw's -Move (Lici) 10(26 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/b77665ff79bb 11:18:50 03DracoOmega02 07* 0.35-a0-9-g2731a55e82: Fix spiteful blood's mutation description not displaying 10(26 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/2731a55e829a 11:18:50 03DracoOmega02 07* 0.35-a0-10-g8a1b03b673: Make Spiteful Blood a little more impactful 10(25 hours ago, 2 files, 3+ 3-) 13https://github.com/crawl/crawl/commit/8a1b03b67300 11:18:50 03DracoOmega02 07* 0.35-a0-11-g30fa3f96ca: Nerf Bane of Multiplicity 10(25 hours ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/30fa3f96caa5 11:18:50 03DracoOmega02 07* 0.35-a0-12-gca812756a5: Increase water nymph XP somewhat 10(25 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/ca812756a5ec 11:18:50 ... and 11 more commits 11:20:09 03DracoOmega02 07[stone_soup-0.34] * 0.34-b1-4-g182fdd2a8a: Tweak slymdra splitting behavior 10(27 hours ago, 4 files, 19+ 11-) 13https://github.com/crawl/crawl/commit/182fdd2a8a62 11:20:10 03DracoOmega02 07[stone_soup-0.34] * 0.34-b1-5-g42e68bc82d: Fix star jellies sometimes not making stars 10(26 hours ago, 1 file, 3+ 2-) 13https://github.com/crawl/crawl/commit/42e68bc82df5 11:20:10 03DracoOmega02 07[stone_soup-0.34] * 0.34-b1-6-gcfe2be61d5: Don't autopickup except when moving 10(26 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/cfe2be61d58b 11:20:10 03DracoOmega02 07[stone_soup-0.34] * 0.34-b1-7-gc6bc3c3f6d: Fix mesmerisation daze stacking on monsters (and gently lower duration) 10(26 hours ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/c6bc3c3f6de7 11:20:10 03DracoOmega02 07[stone_soup-0.34] * 0.34-b1-8-g988cdcb123: Fix Vhi's being overly restrictive while mesmerised 10(26 hours ago, 1 file, 28+ 28-) 13https://github.com/crawl/crawl/commit/988cdcb123d4 11:20:10 03DracoOmega02 07[stone_soup-0.34] * 0.34-b1-9-g6429ade63d: Make Slick Slippers provide immunity to Grave Claw's -Move (Lici) 10(26 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/6429ade63d29 11:20:10 03DracoOmega02 07[stone_soup-0.34] * 0.34-b1-10-gc29d13b6fc: Fix spiteful blood's mutation description not displaying 10(26 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/c29d13b6fc2e 11:20:10 03DracoOmega02 07[stone_soup-0.34] * 0.34-b1-11-g38006e5a57: Make Spiteful Blood a little more impactful 10(25 hours ago, 2 files, 3+ 3-) 13https://github.com/crawl/crawl/commit/38006e5a5705 11:20:10 03DracoOmega02 07[stone_soup-0.34] * 0.34-b1-12-ge745a072dd: Nerf Bane of Multiplicity 10(25 hours ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/e745a072dd81 11:20:10 03DracoOmega02 07[stone_soup-0.34] * 0.34-b1-13-g5dd18ec61c: Increase water nymph XP somewhat 10(25 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/5dd18ec61c79 11:20:10 ... and 11 more commits 14:47:24 who runs/owns doc.dcss.io? "Last updated 2025-01-22 16:10:41" - unfortunately, when googling for "crawl lua" most results point there, instead of https://crawl.github.io/crawl/lua/index.html 15:04:52 <08o​____0> ??lua 15:04:53 <04C​erebot> lua[1/1]: Crawl currently uses lua 5.1 (5.4 starting in 0.34). You can find more information at http://www.lua.org/manual/5.1/manual.html For documentation on crawl's lua API for RC files, see: https://crawl.github.io/crawl/lua/index.html (trunk) or https://doc.dcss.io/ (stable). 15:05:12 <08o​____0> They document different versions of crawl 15:13:31 2025-01-22 is still more than one release behind though, isn't it? 15:16:59 New branch created: pull/5053 (1 commit) 13https://github.com/crawl/crawl/pull/5053 15:16:59 03Dossy Shiobara02 07https://github.com/crawl/crawl/pull/5053 * 0.35-a0-24-g1653cc62b6: fix: correct crawl.grammar re: qual vs. qualname 10(3 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/1653cc62b62b 15:19:33 o​____0: last stable release was 0.33 over a year ago? hm 15:21:09 oh wow. github's releases shows 0.33.1 (20250606) as the last/latest release. 15:22:18 hm, thought releases were usually-ish 6 months-ish 15:22:25 a year seems long 15:22:51 <08o​____0> Closer to 7 or 8 months usually. This one was ~9 months due to issues 15:55:14 <09g​ammafunk> you may be confusing the commit author date 15:55:19 <09g​ammafunk> with the commit date 15:55:25 <09g​ammafunk> %git 0.33.0 15:55:26 <04C​erebot> gammafunk * 0.33.0: Update the changelog for the 0.33.0 release (9 months ago, 1 file, 2+ 2-) https://github.com/crawl/crawl/commit/7d6a423d9bb0 15:55:37 <09g​ammafunk> but I'm not sure where you got over a year ago for 0.33 15:55:56 <08o​____0> ^ 15:56:17 <09g​ammafunk> ??lua 15:56:18 <04C​erebot> lua[1/1]: Crawl currently uses lua 5.1 (5.4 starting in 0.34). You can find more information at http://www.lua.org/manual/5.1/manual.html For documentation on crawl's lua API for RC files, see: https://crawl.github.io/crawl/lua/index.html (trunk) or https://doc.dcss.io/ (stable). 15:56:24 <09g​ammafunk> this is the correct url 15:56:48 it seemed to me that the claim was that doc.dcss.io was (current) stable 15:56:55 per the learndb entry 15:57:02 <09g​ammafunk> yeah, that's not really the case 15:57:07 <08o​____0> ah ok 15:57:10 <09g​ammafunk> advil ran that doc thing 15:57:14 ah 15:57:18 <09g​ammafunk> not sure if he's actually maintaining it 15:57:35 <09g​ammafunk> although it probably is useful to have a stable doc vs current 15:57:46 <09g​ammafunk> I'm just not sure how important that actually is 16:00:05 fwiw cabal uses RTD which lets you keep docs for every release and optionally current 16:43:24 Unstable branch on underhound.eu updated to: 0.35-a0-23-gca6055191c (34) 16:45:01 if you look at the footer on https://doc.dcss.io/ it says: Last updated 2025-01-22 16:10:41 - that's over 1y ago, it's now 2026-01-27 16:46:35 could publish the docs to https://crawl.github.io/crawl/x.yy/lua/index.html and https://crawl.github.io/crawl/latest/lua/index.html for the most recent CI version 16:47:51 would just be nice if google would index the github pages version too. https://www.google.com/search?q=crawl+lua+site%3Acrawl.github.io%2Fcrawl%2Flua = zero results :(