00:27:05 Unstable branch on cbro.berotato.org updated to: 0.34-a0-2090-gf52bb6b557 (34) 04:34:04 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 05:25:29 Unstable branch on crawl.akrasiac.org updated to: 0.34-a0-2090-gf52bb6b (34) 08:28:59 DavisW (L22 NaSh) ASSERT(thing.exists(SHOPPING_THING_POS_KEY)) in 'shopping.cc' at line 2683 failed. (Orc:2) 08:42:30 <11Odds> That shopping crash is confusing, it's very hard to see how anything could be in the shopping list without that key 09:22:51 <11Odds> !lg * won recent s=name 09:23:16 <04Cerebot> 24027 games for * (won recent): 492x iamserjio, 343x krsz, 342x kuniqs, 341x AutarchDCSS, 277x tswn, 271x sekai, 259x Flugkiller, 228x cornishon, 214x rig, 204x Broken26, 197x EnegeticOcto, 185x planckenstein, 184x knorpule3000, 174x Zigmound, 159x HyperOdds, 159x particleface, 148x sleepymeeple, 144x quixfox, 140x sleeves, 131x dilly, 127x Xenophilius, 126x frimble, 113x Sergey, 103x Adeiron, 10... 09:23:42 <11Odds> (Sorry wrong channel) 09:26:17 DavisW (L22 NaSh) ASSERT(thing.exists(SHOPPING_THING_POS_KEY)) in 'shopping.cc' at line 2683 failed. (Orc:2) 09:33:53 DavisW (L22 NaSh) ASSERT(thing.exists(SHOPPING_THING_POS_KEY)) in 'shopping.cc' at line 2683 failed. (Orc:2) 09:48:41 <04dracoomega> Yeah. Shopping list code is something I've rarely interacted with (and, frankly, usually over annoying obscura >.>) but I don't see how anything gets added to the shopping list without its position being stored that way. 10:20:14 <11Odds> It has made me realise that a recent I change I made has a bug with gozag excommunication, which is highly suspicious timing but seems unrelated 10:24:50 <04dracoomega> Oh? 10:26:32 <11Odds> Yeah, after https://github.com/crawl/crawl/commit/fd489b477873e9f6005df1a83d1795dda64c5228 we don't remove the features for shops covered by temporary terrain when we abandon Gozag 10:28:46 DavisW (L22 NaSh) ASSERT(thing.exists(SHOPPING_THING_POS_KEY)) in 'shopping.cc' at line 2683 failed. (Orc:2) 10:38:23 yeh, I checked that last night when the first crashes happened but no temporary terrain was involved so I concluded it couldn't be involved 10:38:51 after reviewing the commit to ensure it only affected temporary terrain code 10:43:14 <11Odds> That's a different commit to the one you were looking at if it's the one you posted here 10:43:48 <11Odds> But yeah it seems unrelated for the same reason 11:06:41 <11Odds> Well I haven't worked out anything about that shopping bug, but I have discovered that with a pet water nymph you can turn shop mimics into real shops 🎉 11:11:50 lol 11:11:57 DavisW (L22 NaSh) ASSERT(thing.exists(SHOPPING_THING_POS_KEY)) in 'shopping.cc' at line 2683 failed. (Orc:2) 11:30:28 DavisW (L22 NaSh) ASSERT(thing.exists(SHOPPING_THING_POS_KEY)) in 'shopping.cc' at line 2683 failed. (Orc:2) 12:02:34 <04dracoomega> Of course, there's no way for the player to have known it wasn't a real shop ahead of time, no? ^^; 12:03:00 <11Odds> Indeed, just a way to get 1% more shops 12:03:06 <11Odds> No spells work for this, you just get a lava mimic 🙂 12:03:18 <04dracoomega> If you can afford to cart around a water nymph at close range, you don't need shops 😛 12:03:53 <11Odds> Tethering helps too 12:04:06 <11Odds> Or whatever that general anti-silliness mechanic is called 12:04:30 <11Odds> (It's just kind of luck no spells work though, I thought bog would but it creates the wrong kind of water I guess) 12:04:59 <08o____0> Is there any way to know if you even succeeded? Should add feedback to when you turn a mimic into a shop so it feels rewarding /j 12:05:08 <11Odds> Nope 12:06:08 <11Odds> You stand next to a shop covered by an unmimicable thing (i.e. water or the floor), and we silently remove the mimic flag 12:24:07 DavisW (L22 NaSh) ASSERT(thing.exists(SHOPPING_THING_POS_KEY)) in 'shopping.cc' at line 2683 failed. (Orc:2) 12:39:41 and it's cao, which is probably too old for gdb to be useful even if it were in the chroot 13:15:09 DavisW (L22 NaSh) ASSERT(thing.exists(SHOPPING_THING_POS_KEY)) in 'shopping.cc' at line 2683 failed. (Orc:2) 13:22:29 New branch created: pull/5046 (1 commit) 13https://github.com/crawl/crawl/pull/5046 13:22:30 03CrawlOdds02 07https://github.com/crawl/crawl/pull/5046 * 0.34-a0-2091-g69236df994: Handle feature mimics and terrain change better 10(27 minutes ago, 2 files, 4+ 2-) 13https://github.com/crawl/crawl/commit/69236df9948b 13:24:05 <11Odds> The mimic tech was more powerful than I initially realised - hellfire mortar can also make shops real (due to an entirely separate bug with mimics and terrain changes. Terrain changes are generally terrifying) 13:31:02 DavisW (L22 NaSh) ASSERT(thing.exists(SHOPPING_THING_POS_KEY)) in 'shopping.cc' at line 2683 failed. (Orc:2) 13:33:39 DavisW (L22 NaSh) ASSERT(thing.exists(SHOPPING_THING_POS_KEY)) in 'shopping.cc' at line 2683 failed. (Orc:2) 13:34:25 DavisW (L22 NaSh) ASSERT(thing.exists(SHOPPING_THING_POS_KEY)) in 'shopping.cc' at line 2683 failed. (Orc:2) 13:50:54 <11Odds> https://www.reddit.com/r/dcss/comments/1qly69a/i_am_crashing_on_trunk_trying_to_swap_to_jiyva_is/ looks to be that crash, if there's anything it would be helpful to get from the player 13:53:08 <08o____0> if they make a save backup I guess a dev could actually check the state of the shopping list though I don't know if that would lead to any clues about what caused the bad state :P 13:53:20 <11Odds> Yeah I wouldn't mind getting a look at thing 13:59:32 <09gammafunk> is it cao? 13:59:40 <09gammafunk> I can get a save backup, provided that the user isn't playing 13:59:49 <09gammafunk> just need the accountname 13:59:55 <09gammafunk> (DavisW?) 14:00:10 <11Odds> Yep, CAO and DavisW 14:00:18 <09gammafunk> I can see if they're currently playing, I guess 14:02:15 DavisW (L22 NaSh) Crash caused by signal #15: Terminated (Lair:5) 14:03:11 <09gammafunk> they call me the terminator 14:03:20 <09gammafunk> they were idle for 26 minutes, so 14:03:39 <09gammafunk> Here's the file for anyone who wants to take a look 14:03:40 <09gammafunk> https://cdn.discordapp.com/attachments/747522859361894521/1464727372942147790/DavisW.cs?ex=6976852b&is=697533ab&hm=8290bd1bd97a00db7299d262aca0fe877ec429e4dc3b255d681de96c68b4adc8& 14:04:12 <09gammafunk> I'd put it in the admin dir but then only devs could look at it; it should work fine ifyou download directly from discord 14:04:39 <09gammafunk> 0.34-a0-2090-gf52bb6b is the version 14:05:11 <11Odds> Awesome thanks. The crash replicates easily from that save 14:23:44 03regret-index02 07* 0.34-a0-2091-g2053b306b6: Changelog update through f52bb6b 10(32 seconds ago, 1 file, 37+ 3-) 13https://github.com/crawl/crawl/commit/2053b306b62e 14:52:55 <11Odds> Making decent progress on that shopping thing I think. It looks to me like the issue stems from us deleting items from the shopping list in remove_dead_shops - that deletion happens via dungeon_change_base_terrain and unnotice_feature. So this is probably a consequence of https://github.com/crawl/crawl/commit/c078dd7f9235 after all. 14:54:18 <04dracoomega> What I find weird is that the failure sounds like it would require deleting part of the item and not all of it, though, wouldn't it? 14:54:48 <11Odds> Is it possible the item's memory is freed up? 14:57:36 <04dracoomega> Then wouldn't it crash (or do some other undefined behavior) rather than assert that the CrawlHashTable was missing some value? 14:57:45 <04dracoomega> Which sounds like we otherwise have a functional reference to one 14:58:09 <04dracoomega> (But I don't actually have useful theories to contribute and haven't dived into debugging any of this in earnest) 14:58:11 <11Odds> Yeah that sounds right 15:00:57 <11Odds> This is from the save file - what I'm sure of is that the crash happens during this loop which is deleting items, and that just before the crash the shopping list consists of 3 valid-looking items (down from 4 before the loop) 15:03:23 <11Odds> I agree it's mysterious that we crash on something that looks like an empty map, rather than on nonsense. 15:11:36 <07wizardike> I'm working on a fix to the crash. Basically removing a shopping list entry while iterating causes us to iterate into a destroyed value and then an implicit conversion from CrawlStoreValue& to CrawlHashTable& creates a default constructed CrawlHashTable in the destructed value 15:14:19 <07wizardike> Implicit conversions with side effects are such fun /s 15:17:23 ~~c++~~ 15:17:56 (I should have done that with unicode but I CBA) 15:41:37 DavisW (L22 NaSh) ASSERT(thing.exists(SHOPPING_THING_POS_KEY)) in 'shopping.cc' at line 2683 failed. (Orc:2) 15:51:48 DavisW (L22 NaSh) ASSERT(thing.exists(SHOPPING_THING_POS_KEY)) in 'shopping.cc' at line 2683 failed. (Orc:2) 16:42:30 Unstable branch on underhound.eu updated to: 0.34-a0-2091-g2053b306b6 (34) 19:12:58 03WizardIke02 07* 0.34-a0-2092-g8ba9187331: Don't leak memory when adding an item to the shopping list 10(16 hours ago, 1 file, 5+ 5-) 13https://github.com/crawl/crawl/commit/8ba91873317b 19:12:58 03WizardIke02 07* 0.34-a0-2093-gc6afee0a9b: Fix env.shop becoming filled with useless shops 10(13 hours ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/c6afee0a9b4b 19:12:58 03WizardIke02 07* 0.34-a0-2094-g21d91b71d4: Fix wizmode placed shop and trap mimics not being mimics 10(2 hours ago, 1 file, 29+ 18-) 13https://github.com/crawl/crawl/commit/21d91b71d4ce 19:12:58 03WizardIke02 07* 0.34-a0-2095-g4d7c6441a3: Fix temporary terrain expiring making mimics into real features 10(2 hours ago, 8 files, 94+ 77-) 13https://github.com/crawl/crawl/commit/4d7c6441a3f9 19:12:58 03WizardIke02 07* 0.34-a0-2096-g10d8026e12: Fix a crash when abandoning Gozag 10(79 minutes ago, 3 files, 40+ 21-) 13https://github.com/crawl/crawl/commit/10d8026e128c 19:16:12 03WizardIke02 07* 0.34-a0-2097-gc69c41b5cd: Checkwhite 10(72 seconds ago, 2 files, 2+ 2-) 13https://github.com/crawl/crawl/commit/c69c41b5cdbd 19:32:17 04Build failed for 08master @ 10d8026e 06https://github.com/crawl/crawl/actions/runs/21325303091 19:37:20 04Build failed for 08master @ c69c41b5 06https://github.com/crawl/crawl/actions/runs/21325347729 20:16:38 Nonny (L20 MfFi) ASSERT(!targets.empty()) in 'mon-cast.cc' at line 3431 failed. (No push space from (10,32)) (Vaults:4) 20:38:46 <09gammafunk> that's a new one 21:57:43 <09gammafunk> chat, explain this crawlcode. you have sixty seconds: cpp // must not produce the magic value (-1) int seed = ((static_cast(you.where_are_you) << 8) + you.depth) ^ (you.game_seed & 0x7fffffff); 22:24:20 <08o____0> wow ok that took me ~10 minutes to sort of understand. Branch enum value shifted up 8 bits to make space for + depth, with a bitmask of the lower ~half of the game_seed... I am not sure why the 7 23:12:18 <09gammafunk> can I point out just how bad of a member name where_are_you is