00:34:00 <Cbrotell> Unstable branch on cbro.berotato.org updated to: 0.34-a0-2062-g69c9decb0d (34)
02:29:48 <Henzell> winrateplayers (L14 FeBe) Crash caused by signal #15: Terminated (Lair:5)
04:35:51 <Lantell> Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b
05:35:28 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.34-a0-2062-g69c9dec (34)
05:42:41 <Discord|> <04d​racoomega> @gammafunk I just noticed that I was pinged directly about https://github.com/crawl/crawl/issues/4707 and this really isn't enough in my wheelhouse to be able to give them a worthwhile response (or even properly contextualize half of what they're saying, if I'm honest >.>) Do you think you could give it a look over when you have time to spare? ^^;
08:05:05 <Discord|> <09g​ammafunk> yeah, I saw that. It's a rather strange request,  to be honest. I can respond at some point in near term
08:05:36 <Discord|> <04d​racoomega> (You see? I'm not even familiar enough with some of the underlying architecture to tell ^^; )
08:54:54 <NotCheibriados> 03DracoOmega02 07* 0.34-a0-2063-gbb8035fab5: Allow spellmotor to benefit from aqua form's reaching 10(5 hours ago, 1 file, 5+ 2-) 13https://github.com/crawl/crawl/commit/bb8035fab52a
08:54:54 <NotCheibriados> 03DracoOmega02 07* 0.34-a0-2064-g40507f9771: Fix a few redundant artprops being able to generate on talismans 10(5 hours ago, 1 file, 3+ 2-) 13https://github.com/crawl/crawl/commit/40507f9771cd
08:54:54 <NotCheibriados> 03DracoOmega02 07* 0.34-a0-2065-gb9c0c7a1e4: Prevent having hooves and talons at the same time (Speedwagon) 10(5 hours ago, 1 file, 4+ 1-) 13https://github.com/crawl/crawl/commit/b9c0c7a1e401
08:54:54 <NotCheibriados> 03DracoOmega02 07* 0.34-a0-2066-gd9aa244d15: Correct the Evoke Invisibility description (Necromancer23) 10(5 hours ago, 1 file, 1+ 3-) 13https://github.com/crawl/crawl/commit/d9aa244d150f
08:54:54 <NotCheibriados> 03DracoOmega02 07* 0.34-a0-2067-g2b47bf1078: Properly prevent Orb of Stardust from working on djinni 10(5 hours ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/2b47bf1078ca
08:54:54 <NotCheibriados> 03DracoOmega02 07* 0.34-a0-2068-g07036d49a5: Don't grow burstshrooms when hitting firewood or allies 10(5 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/07036d49a524
08:54:54 <NotCheibriados> 03DracoOmega02 07* 0.34-a0-2069-g3ac2f9dc84: Don't allow making multiple vampire thralls at once 10(5 hours ago, 1 file, 11+ 3-) 13https://github.com/crawl/crawl/commit/3ac2f9dc8463
08:54:54 <NotCheibriados> 03DracoOmega02 07* 0.34-a0-2070-gf98ad71682: Don't frenzy protected allies with an orb of Mayhem (Szymekc) 10(4 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/f98ad716825a
08:54:54 <NotCheibriados> 03DracoOmega02 07* 0.34-a0-2071-g13570ff70c: Explicate that the Reckless mutation only affects melee weapons (dilly) 10(4 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/13570ff70c48
08:54:54 <NotCheibriados> 03DracoOmega02 07* 0.34-a0-2072-gc4ca8e905a: Mention that draconians cannot wear helmets in-game 10(2 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/c4ca8e905aa5
09:02:28 <dcss-ci> 04Build failed for 08master @ c4ca8e90 06https://github.com/crawl/crawl/actions/runs/21216253661
09:14:00 <iocaneimmunity> Hello! I am trying to add a new talisman (something similar to the Protean talisman but for higher tier talismans) to the game but can't seem to get it to show up in my inventory. Here's what I've done:
09:14:00 <iocaneimmunity> Added an entry in the enum talisman_type
09:14:01 <iocaneimmunity> Added an entry in talisman_type_name
09:14:01 <iocaneimmunity> Added logic for the talisman in cannot_put_on_talisman_reason and use_talisman
09:14:02 <iocaneimmunity> Added an image for it to the same folder as the protean one and added an entry to connect it in _tileidx_talisman
09:14:02 <iocaneimmunity> Added an entry in tile-main.html
09:14:03 <iocaneimmunity> Added an entry in dc-item.txt
09:14:03 <iocaneimmunity> Added a description entry in items.txt (the english one)
09:14:04 <iocaneimmunity> Confirmed that the entry shows up in the autogenerated files tileinfo-main.js and tiledef-main.cc, though in the latter it shows up in *_tile_main_name but not main_name_pairs[] and I don't know why. 
09:14:04 <iocaneimmunity> And as a test I added it to a background/job so I could start with it and make sure it works. I'm not sure if I'm calling it the right thing since I don't know where it connects the readable name to the item type/subtype.
09:14:05 <iocaneimmunity> So after all that the item just never shows up in my inventory and I'm at a loss for how to debug it or what I could have missed. Here are some thoughts as to what might be happening:
09:14:05 <iocaneimmunity> As I said above there is no name pair showing up for my new item in the generated file tieldef-main.cc. The name pair would be in main_name_pairs[]. Does anyone know what I need to do to get my item to generate an entry here?
09:14:06 <iocaneimmunity> I might be using the wrong string when specifying it in equipment in the job. I've confirmed my overall syntax is correct by adding other items to the starting equipment successfully. Where does this string get connected to the item? Is it in talisman_type_name?
09:14:06 <iocaneimmunity> General question, what does the entry in dc-item.txt do?
09:14:07 <iocaneimmunity> And of course, is there anything you can see that I just haven't done that I need to do?
09:14:07 <iocaneimmunity> Thank you for any help you can give!
09:14:34 <iocaneimmunity> Hello! I am trying to add a new talisman (something similar to the Protean talisman but for higher tier talismans) to the game but can't seem to get it to show up in my inventory. Here's what I've done:
09:14:34 <iocaneimmunity> - Added an entry in the enum talisman_type
09:14:35 <iocaneimmunity> - Added an entry in talisman_type_name
09:14:35 <iocaneimmunity> - Added logic for the talisman in cannot_put_on_talisman_reason and use_talisman
09:14:36 <iocaneimmunity> - Added an image for it to the same folder as the protean one and added an entry to connect it in _tileidx_talisman
09:14:36 <iocaneimmunity> - Added an entry in tile-main.html
09:14:37 <iocaneimmunity> - Added an entry in dc-item.txt
09:14:37 <iocaneimmunity> - Added a description entry in items.txt (the english one)
09:14:38 <iocaneimmunity> - Confirmed that the entry shows up in the autogenerated files tileinfo-main.js and tiledef-main.cc, though in the latter it shows up in *_tile_main_name but not main_name_pairs[] and I don't know why. 
09:14:38 <iocaneimmunity> - And as a test I added it to a background/job so I could start with it and make sure it works. I'm not sure if I'm calling it the right thing since I don't know where it connects the readable name to the item type/subtype.
09:14:39 <iocaneimmunity> So after all that the item just never shows up in my inventory and I'm at a loss for how to debug it or what I could have missed. Here are some thoughts as to what might be happening:
09:14:39 <iocaneimmunity> - As I said above there is no name pair showing up for my new item in the generated file tieldef-main.cc. The name pair would be in main_name_pairs[]. Does anyone know what I need to do to get my item to generate an entry here?
09:14:40 <iocaneimmunity> - I might be using the wrong string when specifying it in equipment in the job. I've confirmed my overall syntax is correct by adding other items to the starting equipment successfully. Where does this string get connected to the item? Is it in talisman_type_name?
09:14:40 <iocaneimmunity> - General question, what does the entry in dc-item.txt do?
09:14:41 <iocaneimmunity> - And of course, is there anything you can see that I just haven't done that I need to do?
09:14:41 <iocaneimmunity> Thank you for any help you can give!
09:15:22 <iocaneimmunity> (sorry for the double post, I thought I was editing it but that's apparently not how this works. I'm new to this type of chat. The second post has dashes as bullets in an attempt to make it easier to read)
09:20:11 <iocaneimmunity> (also, the TLDR is I'm trying to add a new talisman and it's never showing up in my inventory, and the bold parts are the questions I have.)
09:21:38 <Discord|> <06r​egret-⸸nde※> I've deleted the first unformatted version of the double-post on Discord, though I have no idea what this looks like from the IRC client.
09:28:17 <Discord|> <04d​racoomega> So, first of all, the entry in dc-item.txt is the tile (and what is used to generate tiledef-main.cc and all the other header files and such regarding tiles)  For associating a tile with a given talisman, you want to look at _tileidx_talisman() in tilepick.cc, the name comes from talisman_type_name() in item-prop.cc. (And without that, trying to create an item by name in a background start will fail.)
09:29:04 <Discord|> <04d​racoomega> If you're unsure why the item isn't showing up on a background, you can try generating it by name in wizmode using &% which may give a more useful error
09:42:30 <Discord|> <09g​ammafunk> Looks like the fail for fulldebug build is a legit fail
09:45:06 <Discord|> <04d​racoomega> Oh, I didn't even notice. I'll take a look.
09:51:59 <Discord|> <04d​racoomega> Ah. For once, I think the problem is with the test. (In the assumptions it made are no longer true, and a different example needs to be picked)
09:55:19 <Discord|> <04d​racoomega> Funny. When I last edited this, the choice of which body slot to use as an example was arbitrary, but it looks like it may have also been the only one that even would have worked (due to an inconsistency with the rest of them)
09:55:32 <Discord|> <04d​racoomega> Which is no longer the case
09:56:46 <iocaneimmunity> dracoomega, this is the entry for protean in those two spaces:
09:56:46 <iocaneimmunity> case TALISMAN_PROTEAN:  return "protean talisman";
09:56:47 <iocaneimmunity> case TALISMAN_PROTEAN:  return TILE_TALISMAN_PROTEAN;
09:56:47 <iocaneimmunity> and this is the entry for mine in those two spaces:
09:56:48 <iocaneimmunity> case TALISMAN_VAULT_MAGIC_MINOR:    return "magic vault (minor)";
09:56:48 <iocaneimmunity> case TALISMAN_VAULT_MAGIC_MINOR: return TILE_TALISMAN_VAULT_MAGIC_MINOR;
09:56:49 <iocaneimmunity> Which looks like I'm following the format to me.
09:56:49 <iocaneimmunity> Also, trying to give myself the item I'm again not sure what to type, but trying "vault" or "vault magic" instantly crash the game and "vault magic (minor)" fails as a "not real item".
09:57:53 <iocaneimmunity> It's worth mentioning that I have a "minor" and "major" version of this item, so I'm not sure if it's an ambiguity thing that's going wrong.
09:59:52 <iocaneimmunity> I thought it might be that I've got multiple words with spaces so I tried to give myself the dragon talisman, the only one that isn't cleanly 1 word in the item-prop.cc talisman_type_name func, and that also crashes in much the same way when I try to give myself either "dragon" or "dragon-coil" in wiz mode.
10:00:36 <NotCheibriados> 03DracoOmega02 07* 0.34-a0-2073-gac8383b74f: Fix a failing test 10(60 seconds ago, 1 file, 8+ 8-) 13https://github.com/crawl/crawl/commit/ac8383b74f2b
10:01:52 <Discord|> <04d​racoomega> crashes in much the same way when I try to give myself either "dragon" or "dragon-coil" in wiz mode  Can you say exactly what you're doing, since this does not seem right
10:02:46 <iocaneimmunity> Yup
10:03:26 <iocaneimmunity> Repro steps:
10:03:26 <iocaneimmunity> Make new character
10:03:27 <iocaneimmunity> Go into wiz mode
10:03:27 <iocaneimmunity> Hit: &, then o, then % to start giving a talisman
10:03:28 <iocaneimmunity> Type "dragon" or "dragon-coil" (without the quotes) and hit enter
10:03:28 <iocaneimmunity> Crash
10:03:54 <Discord|> <06r​egret-⸸nde※> One should be using &% for this sort of thing....
10:04:38 <Discord|> <04d​racoomega> Okay, first of all, &% reflects closer what the species yaml will be using than &o% does. However, using &o% and using "dragon" or "dragon-coil" or anything else also does not crash on mainline builds
10:05:00 <Discord|> <04d​racoomega> Suggesting you may have broken something more deeply somewhere in what you're doing locally
10:06:11 <iocaneimmunity> That seems likey.
10:06:12 <Discord|> <04d​racoomega> (It is difficult for me to guess what, from anything you'd said here)
10:07:35 <iocaneimmunity> What is weird is I can give myself the protean talisman without issue
10:08:36 <iocaneimmunity> I'm currently working without source control but what I really need is to see all the changes I've made. I'm fairly new to git, but does it have built in functionality for diffs?
10:08:46 <iocaneimmunity> Or maybe the better question, what do you all use?
10:10:55 <Discord|> <04d​racoomega> Git can display and make diffs in a couple ways. (And generally integrates with most IDEs so that you can actually see in-editor what bits have been changed since last commit and what they used to look like). I can't imagine operating without it, tbh.
10:12:08 <iocaneimmunity> For sure. I only didn't set it up because I'm less familiar with it and wanted to see if I could change something quickly while I had momentum on wanting to. I'm in deep enough now that setting it up is the right call I think.
10:12:40 <iocaneimmunity> Last bit of info on my crash in case it sparks anything for anyone: I can give myself a protean talisman, but all other talismans crash the game when I try to give myself one in wiz mode.
10:12:47 <iocaneimmunity> With &% now
10:12:53 <Discord|> <09g​ammafunk> wow, can you.mutate() really not take a level of a mutation to apply
10:13:18 <iocaneimmunity> Protean is a bit different than the others, so I suspect that's the clue I need.
10:13:53 <iocaneimmunity> Also, unrelated question, I see ya'lls messages being posted from Discord|. Is there a way of interfacing with this chat through discord that I could do instead of Libera.Chat?
10:13:59 <iocaneimmunity> Because that would be great.
10:14:46 <Discord|> <09g​ammafunk> the discord is invite-only. We do extend invites to regular contributors, but you have to be around an contribute for a while
10:15:29 <iocaneimmunity> That makes sense. Thanks!
10:22:20 <Discord|> <04d​racoomega> For what it's worth, the fact that protean doesn't crash on generation and other things do is almost certainly not related to its functionality, which I think is never checked or interacted with in any way in this process.
10:26:19 <Discord|> <04d​racoomega> All it really is doing is string-matching against the reported dbname of each subtype of talisman
11:14:55 <NotCheibriados> 03regret-index02 07* 0.34-a0-2074-g0383675d46: A batch of Darby's vaults 10(3 hours ago, 6 files, 1413+ 0-) 13https://github.com/crawl/crawl/commit/0383675d46c4
11:14:55 <NotCheibriados> 03regret-index02 07* 0.34-a0-2075-g53b3710f56: Some lingering 0.34 tile clean-up work 10(9 minutes ago, 21 files, 14+ 1-) 13https://github.com/crawl/crawl/commit/53b3710f56de
16:41:04 <Lantell> Unstable branch on underhound.eu updated to: 0.34-a0-2075-g53b3710f56 (34)
16:46:11 <NotCheibriados> 03Darby02 07* 0.34-a0-2076-g507ca58132: Minor vault tile edits 10(55 minutes ago, 1 file, 4+ 3-) 13https://github.com/crawl/crawl/commit/507ca581325c