00:33:44 Unstable branch on cbro.berotato.org updated to: 0.34-a0-1955-g0f66c09651 (34) 00:49:49 ohados (L12 OnFi) ERROR: range check error (-1 / 2000) (Volcano) 00:52:37 ohados (L12 OnFi) ERROR: range check error (-1 / 2000) (Volcano) 00:55:47 cornishon (L21 DrHs) ASSERT(_valid()) in 'ray.cc' at line 229 failed. (Depths:4) 01:17:46 03CrawlOdds02 07https://github.com/crawl/crawl/pull/5007 * 0.34-a0-1932-g23e01e9fa6: Make sure we excommunicate on piety 0 10(27 minutes ago, 1 file, 5+ 3-) 13https://github.com/crawl/crawl/commit/23e01e9fa63e 01:37:51 cornishon (L23 DrHs) ASSERT(_valid()) in 'ray.cc' at line 229 failed. (Vaults:5) 01:45:06 cornishon (L24 DrHs) ASSERT(_valid()) in 'ray.cc' at line 229 failed. (Vaults:5) 02:44:15 cornishon (L24 DrHs) ASSERT(_valid()) in 'ray.cc' at line 229 failed. (Vaults:5) 02:50:12 cornishon (L24 DrHs) ASSERT(_valid()) in 'ray.cc' at line 229 failed. (Vaults:5) 02:55:03 <12g​e0ff> ^--- the player says that the game crashes when monsters shoot at them. The char is worshipping Ru, so it might be because of attack redirection 02:55:33 <12g​e0ff> https://underhound.eu/crawl/morgue/cornishon/crash-cornishon-20260107-094414.txt 02:55:46 <12g​e0ff> > You encounter a yaktaur. It is carrying a +0 arbalest. > You redirect the yaktaur's attack! > The yaktaur shoots a bolt. <--- and here the crash happens 04:16:28 <04d​racoomega> For the record, I ran those tests (I always do before pushing any complex/scary work) and it definitely did not complain about anything. 04:17:26 <04d​racoomega> Anyway, I did overlook the melee interaction there for some reason, but the statement you removed causes a different bug instead (admittedly a much more minor one): if you are prompted when bumping into a monster with a launcher, and choose to cancel, you'll clumsily bash them instead. I'll need to minorly rearrange that. 04:19:42 <04d​racoomega> Also, I think that crash is from it being redirected to itself while having stop_at_allies set. I realize now that this works very badly with Ru redirection and am not entirely sure the best way to fix that (since even if it didn't crash, it would still fail to shoot them) 04:21:37 <04d​racoomega> (I think there is not an obvious way to know by this point that the attack has been redirected) 04:32:40 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 04:40:27 03DracoOmega02 07* 0.34-a0-1956-ga874272245: Fix ranged attacks caused by movement auto-cancelling if they would prompt 10(8 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/a87427224589 04:40:27 03DracoOmega02 07* 0.34-a0-1957-g0913d0b2e5: Fix aborted ranged attacks in melee automatically bashing instead 10(6 minutes ago, 1 file, 9+ 11-) 13https://github.com/crawl/crawl/commit/0913d0b2e5a2 04:40:27 03DracoOmega02 07* 0.34-a0-1958-gc547702c78: Fix Ru-redirected ranged attacks 10(2 minutes ago, 3 files, 8+ 5-) 13https://github.com/crawl/crawl/commit/c547702c78ae 05:36:29 Unstable branch on crawl.akrasiac.org updated to: 0.34-a0-1958-gc547702 (34) 06:50:01 Elsrick (L7 GrMo) ASSERT(wpn && (wpn->base_type == OBJ_MISSILES || is_range_weapon(*wpn))) in 'ranged-attack.cc' at line 37 failed. (D:5) 07:39:29 03DracoOmega02 07* 0.34-a0-1959-ge88a74dfdf: Fix Dithmenos shadow shoot triggering off darts and throwing nets 10(50 seconds ago, 1 file, 5+ 1-) 13https://github.com/crawl/crawl/commit/e88a74dfdf0a 08:04:47 <09g​ammafunk> It's good that you ran make test, but I think you didn't do a webtiles build and hence didn't see that build error? I do think CI gives a level of coverage that's comprehensive enough to warrant its use. Keep in mind that all you have to do is push to a branch to run it; you don't have to formally make a PR. In this case, the nastiness would have arose if the build hadn't broken and the melee breaking commit had been live. We'd 08:04:47 have gotten a lot of extra error reports and admins likely would get pinged etc. In pushing CI, I'm just trying to make less work for them (and myself). Unfortuantely it seems that our make tests don't even cover the case where melee literally doesn't work.... 08:06:10 <09g​ammafunk> Yeah I just pushed a quick fix that seemed reasonable at quick glance and allowed the game to be playable again, due to time constraints 08:09:40 <09g​ammafunk> And by "warrants its use" I mean as a pre-trunk safety measure. Obviously trunk it self is under CI and we will see errors from that (note to self, fix irc permissions so irc notifications work again). But when trunk is broken, CDI breaks right away and other servers can break not long after depending on timing 08:10:37 <09g​ammafunk> I'm guessing it'd not be too hard to make a simple "melee and ranged combat (and maybe spell casting and evocations) work at a basic level" test 08:15:00 Searched issues but nothing. "The water nymph's watery aura covers the stone staircase leading down." "You fly downwards." I would expect this to stop me transiting the stairs. Should I submit an issue, or is this by design? A hardy perennial that's impossible to fix? Just a confusing message order? 08:15:15 (it's not a new bug, it happens in Stoat Soup too) 08:30:37 <04d​racoomega> I did build and test in webtiles locally, actually. Though looking at the CI, it seems that it was specifically with USE_DGAMELAUNCH and not just webtiles builds in general. I'm not sure I've seen this specific case where 'local' webtiles works and that doesn't, but it must just have been a coincidence of what headers get included at different points along the road. (ie: it wasn't included directly, but 'somewhere down the line' in a 08:30:38 way that somehow the DGAMELAUNCH builds didn't include) 08:33:20 <04d​racoomega> Pinkbeast: I think it's deliberate that it doesn't stop you once you're already in transit? (By the same reasoning that it definitely was deliberate that warden stair-sealing can't stop the player if they've already started taking the stairs. 08:34:18 Huh. Well, if it's deliberate, I'll leave it be as a pleasant surprise for the player. :-) 08:36:12 <04d​racoomega> Also, now that I notice, the channel didn't get a message about the build failing yesterday, or I probably would have found and fixed that before going to bed 08:36:51 <04d​racoomega> (Which, as mentioned, may have been worse in this particular case, but in general....) 08:39:11 <08o​____0> ^ the bot couldn't connect ever since the irc raid incident since the channel was set to require an account 😅 08:39:51 <04d​racoomega> Oh, ha 09:29:58 New branch created: pull/5015 (1 commit) 13https://github.com/crawl/crawl/pull/5015 09:29:59 03robbiemu02 07https://github.com/crawl/crawl/pull/5015 * 0.34-a0-1959-g051010bbb3: add stop/pickup grouping name for talismans 10(6 minutes ago, 5 files, 67+ 14-) 13https://github.com/crawl/crawl/commit/051010bbb39c 09:37:19 confidenceinterval (L11 DsFw) ASSERT(_valid()) in 'ray.cc' at line 229 failed. (D:11) 10:18:41 cornishon (L15 DrAr) ASSERT(wpn && (wpn->base_type == OBJ_MISSILES || is_range_weapon(*wpn))) in 'ranged-attack.cc' at line 37 failed. (D:14) 10:41:18 <09g​ammafunk> yeah, that's a tricky situation because the DGL webtiles build is the "most" important one in that most live servers use DGL, but webtiles without DGL is also used for some online servers, maybe only CPO? But CI does cover both of these, of course 10:41:35 <09g​ammafunk> let me go yet again remember how to get ops and change the channel mode 11:00:44 ok, that should do it 11:52:23 cornishon (L16 DrAr) ASSERT(wpn && (wpn->base_type == OBJ_MISSILES || is_range_weapon(*wpn))) in 'ranged-attack.cc' at line 37 failed. (Snake:2) 11:53:10 RoGGa (L13 MDFi) ERROR: range check error (-1 / 2000) (Volcano) 11:54:50 New branch created: pull/5016 (1 commit) 13https://github.com/crawl/crawl/pull/5016 11:54:51 03CrawlOdds02 07https://github.com/crawl/crawl/pull/5016 * 0.34-a0-1960-gb967a5ce60: Correctly set tile flavours with multiple terrain changes 10(5 minutes ago, 1 file, 4+ 2-) 13https://github.com/crawl/crawl/commit/b967a5ce6093 16:25:56 meatstix (L27 DsCj) ASSERT(_valid()) in 'ray.cc' at line 229 failed. (Zig:25) 16:40:55 Unstable branch on underhound.eu updated to: 0.34-a0-1959-ge88a74dfdf (34) 17:13:15 yidoboi (L12 FoFi) ERROR: range check error (-1 / 2000) (Volcano) 17:13:24 yidoboi (L12 FoFi) ERROR: range check error (-1 / 2000) (Volcano) 20:20:26 <06c​ao> Renew Success by crawl Success certs: crawl.akrasiac.org_ecc 21:39:59 <09g​ammafunk> wooooooo! 21:48:06 03DracoOmega02 07* 0.34-a0-1960-g75d9d1cd66: Don't crash on throwing missiles into lava 10(3 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/75d9d1cd66b2 21:48:06 03DracoOmega02 07* 0.34-a0-1961-g964c6d7466: Fix exiting Pan through the Abyss not using the correct depth (Hammock) 10(3 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/964c6d7466ea 21:48:06 03DracoOmega02 07* 0.34-a0-1962-g99aa80d3ce: Make default Abyss depth depend on skill_cost_level instead of XL 10(3 hours ago, 4 files, 12+ 10-) 13https://github.com/crawl/crawl/commit/99aa80d3ceb1 21:48:06 03DracoOmega02 07* 0.34-a0-1963-g8865f5c8a7: Warn the player of their default Abyss depth before entering (Ge0FF) 10(2 hours ago, 5 files, 23+ 3-) 13https://github.com/crawl/crawl/commit/8865f5c8a702 21:48:06 03DracoOmega02 07* 0.34-a0-1964-gbe59399d3f: Reduce the speed with which the Abyss rune can be found on depth 4 and 5 10(2 hours ago, 1 file, 2+ 4-) 13https://github.com/crawl/crawl/commit/be59399d3f85 21:48:06 03DracoOmega02 07* 0.34-a0-1965-g211a50b041: Make hostile monsters no longer aware of all player immunities 10(2 hours ago, 1 file, 5+ 1-) 13https://github.com/crawl/crawl/commit/211a50b0416e 21:48:06 03DracoOmega02 07* 0.34-a0-1966-ga61296fdad: Fix monster Manifold Assault changing how long a turn took (Darby) 10(2 hours ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/a61296fdadbf 21:48:06 03DracoOmega02 07* 0.34-a0-1967-g46b4082e56: Cap player sphinx form AF_AIRSTRIKE damage at 7 open spaces 10(2 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/46b4082e56a7 21:48:06 03DracoOmega02 07* 0.34-a0-1968-g232e81ce3b: Fix a crash with involuntary forms expiring over deep water (Sloweel) 10(87 minutes ago, 6 files, 14+ 15-) 13https://github.com/crawl/crawl/commit/232e81ce3b47 21:48:06 03DracoOmega02 07* 0.34-a0-1969-g43dcba86e6: Prevent +Blink on artefact spider talismans (tekkud) 10(85 minutes ago, 1 file, 3+ 1-) 13https://github.com/crawl/crawl/commit/43dcba86e6eb 21:48:06 03DracoOmega02 07* 0.34-a0-1970-g241dbe38a3: Fix/tweak the jewellery_prompt option (rypofalem) 10(31 minutes ago, 2 files, 12+ 20-) 13https://github.com/crawl/crawl/commit/241dbe38a3c1 22:03:49 <08o​____0> Oh I was working on the jewelry prompt option yesterday and wondering if it should be removed haha 22:52:19 zenocrate (L10 GnWn) ASSERT(_valid()) in 'ray.cc' at line 229 failed. (D:9) 23:08:56 applic (L6 GnSh) ERROR: range check error (-1 / 2000) (D:4) 23:09:31 applic (L6 GnSh) ERROR: range check error (-1 / 2000) (D:4) 23:40:54 03DracoOmega02 07* 0.34-a0-1971-gbbcbbbde35: Make Bane of Claustrophobia count all solid features and also affect spells 10(73 minutes ago, 4 files, 9+ 4-) 13https://github.com/crawl/crawl/commit/bbcbbbde3524 23:40:54 03DracoOmega02 07* 0.34-a0-1972-g202409afd0: Cap how many things can be affected by Bane of Warding at once 10(63 minutes ago, 1 file, 19+ 4-) 13https://github.com/crawl/crawl/commit/202409afd0bb 23:40:54 03DracoOmega02 07* 0.34-a0-1973-g1d6cdb0edc: Greatly increase activation chance of the elemental side-effect banes 10(43 minutes ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/1d6cdb0edc51 23:40:54 03DracoOmega02 07* 0.34-a0-1974-ge2f8220cfa: Make Bane of Mortality less likely to do nothing at random 10(24 minutes ago, 2 files, 3+ 10-) 13https://github.com/crawl/crawl/commit/e2f8220cfa43 23:40:54 03DracoOmega02 07* 0.34-a0-1975-g332d4de64d: Remove warding/paradox buffs from orc apostles after challenges are won 10(16 minutes ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/332d4de64dae