00:25:42 03dolorous02 07* 0.34-a0-1265-g0ebab00e9d: Fix wording. 10(2 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/0ebab00e9d11 00:34:30 Unstable branch on cbro.berotato.org updated to: 0.34-a0-1264-gf19d277d5e (34) 00:42:04 04Build failed for 08master @ 0ebab00e 06https://github.com/crawl/crawl/actions/runs/19386416551 00:55:43 Monster database of master branch on crawl.develz.org updated to: 0.34-a0-1265-g0ebab00e9d 01:55:05 New branch created: pull/4912 (1 commit) 13https://github.com/crawl/crawl/pull/4912 01:55:06 03CrawlOdds02 07https://github.com/crawl/crawl/pull/4912 * 0.34-a0-1266-g4cd1ee58d2: Make teleport other prefer not to cancel teleports 10(5 minutes ago, 2 files, 12+ 0-) 13https://github.com/crawl/crawl/commit/4cd1ee58d24e 01:59:49 -!- indigaz23 is now known as indigaz2 02:07:00 Jarek1 (L7 FoGl) Crash caused by signal #11: Segmentation fault (D:5) 02:07:21 Jarek1 (L7 FoGl) Crash caused by signal #11: Segmentation fault (D:5) 02:07:33 Jarek1 (L7 FoGl) Crash caused by signal #6: Aborted (D:5) 02:07:52 Jarek1 (L7 FoGl) Crash caused by signal #11: Segmentation fault (D:5) 02:08:02 Jarek1 (L7 FoGl) Crash caused by signal #6: Aborted (D:5) 02:08:11 Jarek1 (L7 FoGl) Crash caused by signal #6: Aborted (D:5) 02:08:22 Jarek1 (L7 FoGl) Crash caused by signal #6: Aborted (D:5) 02:08:37 Jarek1 (L7 FoGl) Crash caused by signal #6: Aborted (D:5) 02:08:53 Jarek1 (L7 FoGl) Crash caused by signal #11: Segmentation fault (D:5) 02:09:14 Jarek1 (L7 FoGl) Crash caused by signal #11: Segmentation fault (D:4) 02:10:04 Jarek1 (L7 FoGl) Crash caused by signal #11: Segmentation fault (D:4) 02:10:10 03WizardIke02 07* 0.34-a0-1266-g4f49a6db60: Fix clear_to_end_of_line crashing on windows 10(14 minutes ago, 1 file, 5+ 2-) 13https://github.com/crawl/crawl/commit/4f49a6db601a 02:48:59 03WizardIke02 07* 0.34-a0-1267-g4e275ff57a: Fix Vaults:4 down stairs description (acrobat3) 10(2 days ago, 4 files, 19+ 19-) 13https://github.com/crawl/crawl/commit/4e275ff57a24 03:08:10 Jarek1 (L8 FoGl) Crash caused by signal #11: Segmentation fault (D:6) 03:09:11 Jarek1 (L8 FoGl) Crash caused by signal #11: Segmentation fault (D:6) 03:09:52 Jarek1 (L8 FoGl) Crash caused by signal #11: Segmentation fault (D:6) 03:15:02 Jarek1 (L10 FoGl) Crash caused by signal #11: Segmentation fault (D:8) 03:15:35 Jarek1 (L10 FoGl) Crash caused by signal #11: Segmentation fault (D:7) 03:15:44 Jarek1 (L10 FoGl) Crash caused by signal #11: Segmentation fault (D:7) 03:55:44 feta (L9 DjIE) Crash caused by signal #6: Aborted (D:8) 03:56:10 feta (L9 DjIE) Crash caused by signal #6: Aborted (D:8) 04:09:18 Kantor (L2 MDMo) ASSERT(!you.turn_is_over) in 'movement.cc' at line 938 failed. (D:1) 04:29:39 considersuicide (L8 DgFi) Crash caused by signal #11: Segmentation fault (D:7) 04:29:55 considersuicide (L8 DgFi) Crash caused by signal #11: Segmentation fault (D:7) 04:30:07 considersuicide (L8 DgFi) Crash caused by signal #11: Segmentation fault (D:7) 04:30:23 considersuicide (L8 DgFi) Crash caused by signal #11: Segmentation fault (D:7) 04:30:40 considersuicide (L8 DgFi) Crash caused by signal #11: Segmentation fault (D:7) 04:32:11 considersuicide (L9 DgFi) Crash caused by signal #11: Segmentation fault (D:7) 04:34:53 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 04:43:02 HyperOdds (L18 DgWr) Crash caused by signal #11: Segmentation fault (Elf:3) 04:58:38 Hasart (L11 DjEE) Crash caused by signal #11: Segmentation fault (D:10) 05:09:16 Hasart (L12 DjEE) Crash caused by signal #6: Aborted (Orc:2) 05:35:56 Unstable branch on crawl.akrasiac.org updated to: 0.34-a0-1267-g4e275ff (34) 06:35:02 djonin (L8 MDBe) ASSERT(!you.turn_is_over) in 'movement.cc' at line 937 failed. (D:6) 07:21:32 watfoo (L13 ReIE) Crash caused by signal #11: Segmentation fault (Lair:5) 08:04:36 crabbyslav (L12 GrMo) Crash caused by signal #11: Segmentation fault (D:11) 08:11:50 <04dracoomega> I'm working on these, in case it's unclear. (Well, a bunch of them are probably the constriction bug that is already fixed, but some are not) 08:28:35 cornishon (L10 DrSh) Crash caused by signal #6: Aborted (D:9) 09:08:27 03DracoOmega02 07* 0.34-a0-1268-g4c60dd1033: Slightly reorder trap triggering in finalise_movement() 10(35 minutes ago, 2 files, 20+ 9-) 13https://github.com/crawl/crawl/commit/4c60dd1033b7 09:08:27 03DracoOmega02 07* 0.34-a0-1269-ge05568b291: Don't trigger Golubria passages that you just exited 10(7 minutes ago, 4 files, 7+ 3-) 13https://github.com/crawl/crawl/commit/e05568b291ec 09:10:11 <04dracoomega> Well, that's another issue fixed. I'm still very unused what's going on with the ASSERT(!you.turn_is_over) crashes (and nothing in the crashlogs looks particularly illuminating) 09:11:51 <04dracoomega> Like, I'm pretty sure I never changed any circumstances in which the function in question can be called. 09:25:01 <04dracoomega> It doesn't seem like any changes to when/how you.turn_is_over is set withing player_move_action() could affect this (since the results of it are still handled outside by code that I'm sure was touched by nothing 09:25:52 <04dracoomega> Presumably I am wrong about some part of this, but not obvious what 09:47:37 considersuicide (L12 OnGl) Crash caused by signal #11: Segmentation fault (Lair:2) 09:48:23 considersuicide (L12 OnGl) Crash caused by signal #11: Segmentation fault (Lair:2) 09:50:25 Seems a radical response to the game crashing! 10:07:00 Bug report: When I use Passage of Golubria and enter the portal, the game crashes 10:07:02 https://archive.nemelex.cards/saves/malfuriongg-crawl-git-4e275ff57a-251115-1654.tar.bz2 10:10:42 03dolorous02 07* 0.34-a0-1270-ge49427c560: Fix warnings. 10(16 minutes ago, 1 file, 6+ 13-) 13https://github.com/crawl/crawl/commit/e49427c560d9 10:19:25 sbaton (L9 BaSh) Crash caused by signal #11: Segmentation fault (D:8) 10:35:56 cornishon (L11 DrSh) Crash caused by signal #11: Segmentation fault (D:10) 10:36:50 Silva (L8 CoHu) Crash caused by signal #11: Segmentation fault (D:6) 10:37:46 dertzug (L5 MiDe) Crash caused by signal #11: Segmentation fault (D:3) 10:37:56 dertzug (L5 MiDe) Crash caused by signal #11: Segmentation fault (D:3) 10:38:06 dertzug (L5 MiDe) Crash caused by signal #11: Segmentation fault (D:2) 10:38:35 <04dracoomega> Sigh... wish there was some way to force a rebuild there >.> 10:39:05 dertzug (L5 MiDe) Crash caused by signal #11: Segmentation fault (D:3) 10:42:13 Silva (L8 CoHu) Crash caused by signal #11: Segmentation fault (D:6) 10:42:39 dertzug (L9 MiDe) Crash caused by signal #6: Aborted (Bailey) 11:04:28 djonin (L7 MiBe) ASSERT(!you.turn_is_over) in 'movement.cc' at line 937 failed. (D:4) 11:09:29 Silva (L11 CoHu) Crash caused by signal #11: Segmentation fault (D:9) 11:10:58 Silva (L11 CoHu) Crash caused by signal #6: Aborted (D:9) 11:11:33 Silva (L11 CoHu) Crash caused by signal #11: Segmentation fault (D:9) 11:13:29 Silva (L11 CoHu) Crash caused by signal #11: Segmentation fault (D:10) 11:17:58 Silva (L11 CoHu) Crash caused by signal #11: Segmentation fault (D:10) 11:24:17 Silva (L11 CoHu) Crash caused by signal #11: Segmentation fault (D:10) 11:37:20 Silva (L12 CoHu) Crash caused by signal #11: Segmentation fault (D:12) 11:37:47 Silva (L12 CoHu) Crash caused by signal #11: Segmentation fault (D:12) 11:38:15 Silva (L12 CoHu) Crash caused by signal #11: Segmentation fault (D:12) 11:38:41 Silva (L12 CoHu) Crash caused by signal #11: Segmentation fault (D:12) 11:41:02 Silva (L12 CoHu) Crash caused by signal #11: Segmentation fault (D:12) 11:44:03 Silva (L12 CoHu) Crash caused by signal #11: Segmentation fault (D:12) 11:45:44 Silva (L12 CoHu) Crash caused by signal #11: Segmentation fault (D:12) 11:54:48 03dolorous02 07* 0.34-a0-1271-g2d68f2b6bc: Rename the two versions of name_zombie(). 10(12 minutes ago, 4 files, 8+ 8-) 13https://github.com/crawl/crawl/commit/2d68f2b6bca4 11:54:56 Silva (L12 CoHu) Crash caused by signal #11: Segmentation fault (D:12) 12:05:33 Silva (L12 CoHu) Crash caused by signal #11: Segmentation fault (D:12) 12:06:56 Silva (L12 CoHu) Crash caused by signal #11: Segmentation fault (D:12) 12:08:36 Silva (L12 CoHu) Crash caused by signal #6: Aborted (D:12) 12:13:52 Gesren (L15 OpSh) ASSERT(!you.turn_is_over) in 'movement.cc' at line 938 failed. (Lair:5) 12:18:52 Greiscor (L10 TrMo) Crash caused by signal #11: Segmentation fault (D:9) 12:21:05 Greiscor (L11 TrMo) Crash caused by signal #6: Aborted (D:10) 12:22:00 Silva (L12 CoHu) Crash caused by signal #11: Segmentation fault (D:12) 12:23:12 Silva (L12 CoHu) Crash caused by signal #11: Segmentation fault (D:12) 12:26:24 Silva (L12 CoHu) Crash caused by signal #11: Segmentation fault (D:15) 12:27:44 Silva (L12 CoHu) Crash caused by signal #11: Segmentation fault (D:15) 12:37:40 experimilk (L11 TrWr) Crash caused by signal #6: Aborted (D:11) 12:41:41 Omniraptor (L12 TeAE) Crash caused by signal #11: Segmentation fault (Lair:3) 13:00:43 djonin (L11 MiBe) ASSERT(!you.turn_is_over) in 'movement.cc' at line 937 failed. (D:10) 13:01:34 djonin (L11 MiBe) ASSERT(!you.turn_is_over) in 'movement.cc' at line 937 failed. (D:10) 13:28:50 djonin (L3 MiBe) ASSERT(!you.turn_is_over) in 'movement.cc' at line 937 failed. (D:2) 13:34:38 gimp (L19 DsEE) Crash caused by signal #11: Segmentation fault (Vaults:1) 13:53:20 gimp (L19 DsEE) Crash caused by signal #11: Segmentation fault (Vaults:3) 14:08:18 Omniraptor (L14 TeAE) Crash caused by signal #6: Aborted (Lair:5) 14:55:08 gimp (L24 DsEE) Crash caused by signal #11: Segmentation fault (Depths:3) 14:59:36 Salticid (L26 GnEE) Crash caused by signal #6: Aborted (Crypt:3) 15:08:09 djonin (L4 MDBe) ASSERT(!you.turn_is_over) in 'movement.cc' at line 938 failed. (D:2) 15:18:32 Salticid (L26 GnEE) Crash caused by signal #6: Aborted (Crypt:3) 15:24:01 djonin (L2 MiBe) ASSERT(!you.turn_is_over) in 'movement.cc' at line 938 failed. (D:1) 15:24:27 djonin (L1 MiBe) ASSERT(!you.turn_is_over) in 'movement.cc' at line 938 failed. (D:1) 15:33:36 just another hour, I think 15:33:46 <04dracoomega> This one person has run into that !you.turn_is_over bug like 5 times in a row here, and I wish I could tell what they are doing. It seems highly conspicuous, given how rare it is overall. 15:33:53 <04dracoomega> (That one is not fixed, since I still have no idea how it happens) 15:35:57 <04dracoomega> They're not even all the same character, but now that I notice, 3 of them seem to involve attacking an invisible monster 15:36:09 <04dracoomega> Suspicious 15:36:40 watfoo (L18 ReIE) Crash caused by signal #11: Segmentation fault (Vaults:2) 15:39:20 <08o____0> I asked them in webchat but didn't get an answer (they were probably afk, on the character select screen until I left :P) 15:40:24 <08o____0> The only thing that remotely stuck out to me from the crashlog is that they seemed to clicked to move when it happened but I couldn't get it to crash by clicking 15:40:45 <04dracoomega> Yeah, I noticed that earlier and tried a whole bunch of clicking things also, to no avail 15:41:22 <04dracoomega> (The invisible thing is probably also coincidence. The only visibility checks in this code are for printing warnings and are 'safe' if completely ignored or broken in some way. 15:41:44 <04dracoomega> It would be great if I could catch this before the next server rebuild, but I still have no ideas 15:41:53 <08o____0> The two I looked at didn't seem to have anything invisible haha 15:43:35 <04dracoomega> The thing is, move_player_action() is only called from process_command() which - while callable by a few different codepaths - should surely have normal turn cleanup and processing after any of these or there are wider, older bugs, right? 15:59:03 <04dracoomega> Okay, looking a little closer and one thing does surprise me: this assert wasn't in the previous version of this function at all. I... I don't remember adding it at all and am not sure how it got there. 15:59:16 <04dracoomega> It seems like it should be correct 16:00:07 <04dracoomega> But maybe this means that the cause of being able to end up in move_player_action() when your turn is theoretically already over wasn't actually caused by my refactoring? 16:00:27 <04dracoomega> And it's just now asserting when it previously would not have? 16:01:26 <04dracoomega> (I could be wrong, but it seems like an error to reach this function with you.turn_is_over = true) 16:05:59 03dolorous02 07* 0.34-a0-1272-g4fe8c44f3a: Remove has_corpse from some more monsters. 10(38 minutes ago, 6 files, 0+ 6-) 13https://github.com/crawl/crawl/commit/4fe8c44f3ac5 16:17:24 <06dolorous_84348> I'm trying to fix the naming bugs, and it's mostly going well, but I'm switching gears from it for a bit to clear my head. One thing I've noticed is that the insubstantial wisp monster isn't used anywhere and doesn't spawn; it's only around because its tile is used when the player's polymorphed into wisp form. Are there any future plans for the insubstantial wisp monster, or can I just remove it, move its tile into the 16:17:24 transformations section, and use its tile for the wisp transformation directly? 16:19:38 <04dracoomega> No plans for such a thing from me (and it's not like it would be hard to revive in future if that ever changed) 16:19:59 <06dolorous_84348> Okay. Good to know. 16:33:22 Silva (L10 CoHu) Crash caused by signal #11: Segmentation fault (D:8) 16:40:09 Unstable branch on underhound.eu updated to: 0.34-a0-1271-g2d68f2b6bc (34) 16:44:36 03dolorous02 07* 0.34-a0-1273-g5a87bae979: Remove insubstantial wisps. 10(52 minutes ago, 6 files, 4+ 17-) 13https://github.com/crawl/crawl/commit/5a87bae97972 17:06:48 Numeracy (L12 PoNe) Crash caused by signal #11: Segmentation fault (Lair:1) 17:34:00 03dolorous02 07* 0.34-a0-1274-g27e3a25e67: And #ifdef out insubstantial wisp enum (oops). 10(5 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/27e3a25e6713 18:05:08 Omnilove (L27 CoHu) Crash caused by signal #11: Segmentation fault (Arena) 18:22:35 <07wizardike> There are in fact older bugs. I was able to reproduce this crash in local tiles (I'm yet to test webtiles). It's the classic the player can do multiple things with the mouse in one turn bug. Basically, _getch_mul reads in one keycode or if there is more keyboard input after reading this keycode it reads in keycodes until there is no keyboard input. However, mouse input is handled immediately when getting a keycode and a generic 18:22:35 keycode is returned like CK_MOUSE_CMD (see TilesFramework::await_input and TilesFramework::_receive_control_message in tileweb.cc and TilesFramework::getch_ck() and TilesFramework::handle_mouse in tilesdl.cc). This means that if you queue up multiple mouse commands to move and then one keyboard input, the game will read in all of the mouse commands and process them without the normal end turn stuff happening and then then process all the CK_MOUSE_CMD 18:22:36 keys it received (which would handle end of turn properly between them if these were proper keycodes that actually did anything). 18:23:45 Pokonic1 (L6 DsMo) ASSERT(!you.turn_is_over) in 'movement.cc' at line 937 failed. (D:3) 18:24:32 Pokonic1 (L6 DsMo) ASSERT(!you.turn_is_over) in 'movement.cc' at line 937 failed. (D:4) 18:24:41 <04dracoomega> That sounds... concerning 18:27:26 <07wizardike> I've known about this bug for a while, but thought it only affected local tiles mouse input. However, looking at the webtiles code after this crash makes me think it affects webtiles to 18:31:58 <07wizardike> In fact here's my old PR to fix this in local tiles (it's very hacky and outdated so not useful as is) https://github.com/crawl/crawl/pull/3873 18:46:20 <04dracoomega> Ah yes, I do remember this now. (I meant to review it at the time, but it was quite complex and I never got to giving it proper attention with all the other things I was working on) 19:08:30 03DracoOmega02 07* 0.34-a0-1275-gf6cdf2f81c: Fix ?summoning band members disappearing instantly (tekkud) 10(63 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/f6cdf2f81c1d 19:55:48 03dolorous02 07* 0.34-a0-1276-gf62dfb2e50: Fix zombified Gehenna SoH losing its name (#4908) 10(15 minutes ago, 1 file, 3+ 1-) 13https://github.com/crawl/crawl/commit/f62dfb2e50a0 19:56:26 <06dolorous_84348> Finding that little corner case was a pain. 20:16:20 03WizardIke02 07* 0.34-a0-1277-ga7bf8d8ed5: Fix show_update_at setting a square as not in view 10(14 minutes ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/a7bf8d8ed579 20:40:18 ZugAddict (L24 BaDe) Crash caused by signal #6: Aborted (Vaults:5) 22:37:03 03dolorous02 07* 0.34-a0-1278-g8682a6176f: Fix some monster naming wrt MF_NOCORPSE (#4908). 10(12 hours ago, 2 files, 19+ 6-) 13https://github.com/crawl/crawl/commit/8682a6176fa5 22:37:03 03dolorous02 07* 0.34-a0-1279-g7d23ca1161: Improve _make_derived_undead()'s naming (#4908). 10(11 hours ago, 1 file, 17+ 11-) 13https://github.com/crawl/crawl/commit/7d23ca11617e 23:35:34 Unstable branch on crawl.develz.org updated to: 0.34-a0-1279-g7d23ca1161 (34) 23:35:54 Bananafish1988 (L27 DsHs) Crash caused by signal #6: Aborted (Abyss:3) 23:46:04 jalala (L13 DECj) Crash caused by signal #6: Aborted (Lair:4) 23:55:25 03dolorous02 07* 0.34-a0-1280-g2aef843f5c: Properly name uniques wrt derived undead (#4908). 10(25 minutes ago, 1 file, 7+ 19-) 13https://github.com/crawl/crawl/commit/2aef843f5cac 23:58:50 Windows builds of master branch on crawl.develz.org updated to: 0.34-a0-1279-g7d23ca1161