00:13:26 Unstable branch on cbro.berotato.org updated to: 0.34-a0-1150-gb1a7a50d98 (34) 00:55:41 Monster database of master branch on crawl.develz.org updated to: 0.34-a0-1150-gb1a7a50d98 01:59:42 -!- indigaz24 is now known as indigaz2 04:31:58 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 05:10:14 Unstable branch on crawl.akrasiac.org updated to: 0.34-a0-1150-gb1a7a50 (34) 10:54:43 <09gammafunk> so I'm looking to improving the state of lua debugging in terms of dlua in particular, but there are a couple questions to answer 10:55:04 <09gammafunk> one is how you handle crashes vs just layout vetoes and other non-fatal errors 10:55:46 <09gammafunk> I need to remind myself what the crash log even shows in terms of lua, I think it might have something already, but for non-crashing games we have nothing, so I was thinking of adding a kind of "dlua diagnostics" table that we could leave enabled for trunk 10:56:47 <09gammafunk> it would presumably be a backtrace in the style of debug.traceback() for any lua-side error. If it can have file names and line numbers, it will be tremendously helpful at uncovering otherwise hard to notice bugs 10:57:04 <09gammafunk> vetoes in particular are normally silence afaik when a lua error is involved 10:57:26 <09gammafunk> we can't really directly use debug.traceback() because I don't believe dlua loads that, although I should confirm this 10:58:57 <09gammafunk> but even if we can't use that, we can use the implementation in crawl.stack() to get a decent one 11:43:52 03dolorous02 07* 0.34-a0-1151-g2f27fca2f5: Tweak formerly outdated comment again. 10(88 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/2f27fca2f599 12:25:51 New branch created: pull/4899 (3 commits) 13https://github.com/crawl/crawl/pull/4899 12:25:53 03Ethan Thompson02 07https://github.com/crawl/crawl/pull/4899 * 0.34-a0-724-ge39fa54d28: feat: implement in-game pause menu and functionality 10(3 days ago, 13 files, 744+ 2-) 13https://github.com/crawl/crawl/commit/e39fa54d2842 12:25:53 03crutke402 {GitHub} 07https://github.com/crawl/crawl/pull/4899 * 0.34-a0-725-g64617beb38: Merge pull request #1 from ethanAtRogerThat/crawl-001 10(3 days ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/64617beb381a 12:25:53 03crutke402 07https://github.com/crawl/crawl/pull/4899 * 0.34-a0-726-ge4717f0d9a: feat: add keybinds display to pause menu and implement corresponding command 10(2 minutes ago, 5 files, 67+ 0-) 13https://github.com/crawl/crawl/commit/e4717f0d9a26 12:35:50 <12ge0ff> ^-- it's another ai-generated PR 12:37:23 is there an official policy for these ? 12:37:48 <02Darby> they're not getting merged, I can sure say that much 12:37:55 good 12:38:20 <12ge0ff> Regardless of a policy, this specific pr tries to implement something that's already in the game 12:38:34 yeah, it looks pretty nonsensical 12:48:26 <09hellmonk> is this the same guy as the last ai pr 12:49:48 <12ge0ff> the PR is named "Crawl-002" and the style is similar, but the 1st one was from another GH account 12:50:25 <12ge0ff> https://github.com/crawl/crawl/pull/4888 <-- the 1st one 13:00:15 03dolorous02 07* 0.34-a0-1152-g8a1c8ea48e: Improve handling of monsters with "the " names. 10(4 hours ago, 11 files, 26+ 40-) 13https://github.com/crawl/crawl/commit/8a1c8ea48e77 13:00:15 03dolorous02 07* 0.34-a0-1153-gdc246fff1a: Revert "Fix the message naming unique simulacra (#3887)." 10(5 hours ago, 1 file, 1+ 6-) 13https://github.com/crawl/crawl/commit/dc246fff1ad7 13:00:15 03dolorous02 07* 0.34-a0-1154-g04421dc4fa: Reorder polymorphed unique checks a bit. 10(36 minutes ago, 1 file, 6+ 6-) 13https://github.com/crawl/crawl/commit/04421dc4fa4f 13:08:33 <08o____0> https://cdn.discordapp.com/attachments/747522859361894521/1438259193864786072/sRgIIbX.png?ex=69163ac1&is=6914e941&hm=41d65c5d249266820270871cd1267c94310df0145a67e2d5e60824f8570460d7& 13:11:40 <08o____0> It looks like the vaults need updates to remove the "the" from those uniques after 8a1c8ea? 13:13:35 <02Darby> hm, I wonder how many such vaults there are, I guess that's just lerny and TRJ? 13:13:40 04Build failed for 08master @ 04421dc4 06https://github.com/crawl/crawl/actions/runs/19310176026 13:14:58 <02Darby> maybe the serpent of hell? 13:21:40 <02Darby> oh right enchantress, should've known I'd forgotten someone 13:21:48 03dolorous02 07* 0.34-a0-1155-gbf86f010d4: Update DES files for "the " uniques (oops). 10(2 minutes ago, 15 files, 35+ 35-) 13https://github.com/crawl/crawl/commit/bf86f010d473 13:29:20 03dolorous02 07* 0.34-a0-1156-g8f2be1da97: Properly add "the " for single monsters in view. 10(5 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/8f2be1da9784 13:36:04 04Build failed for 08master @ bf86f010 06https://github.com/crawl/crawl/actions/runs/19310736203 13:43:52 <06pleasingfungus> i wonder if the AI PRs are the result of another college class 13:44:01 <06pleasingfungus> "take an open source project and generate AI improvements for it" 13:44:59 <06pleasingfungus> this new one is extremely funny, though 13:45:13 <06pleasingfungus> "implement a pause button and menu system" 13:45:25 <06pleasingfungus> why don't we have one of those? 13:46:59 04Build failed for 08master @ 8f2be1da 06https://github.com/crawl/crawl/actions/runs/19310947514 13:47:32 03dolorous02 07* 0.34-a0-1157-gdf6b5afb82: Update more "the Serpent of Hell" refs I missed. 10(5 minutes ago, 2 files, 4+ 4-) 13https://github.com/crawl/crawl/commit/df6b5afb8257 13:54:27 <09hellmonk> pausechamp 13:56:16 <02Darby> The two types of games are- 13:56:28 <08o____0> I was thinking the same thing! I asked about it and hoping they'll answer if it's something like that 13:59:31 04Build failed for 08master @ df6b5afb 06https://github.com/crawl/crawl/actions/runs/19311397323 14:01:33 03dolorous02 07* 0.34-a0-1158-ga303eb1cfa: Update refs to "the " monsters in the tests. 10(2 minutes ago, 2 files, 6+ 6-) 13https://github.com/crawl/crawl/commit/a303eb1cfa15 14:01:33 03dolorous02 07* 0.34-a0-1159-g33d5737683: Update refs to "the " monsters in the database. 10(7 minutes ago, 8 files, 20+ 20-) 13https://github.com/crawl/crawl/commit/33d5737683ab 14:08:09 <05icoson> if you follow some links from those commits you do get to repo clone owned by a uky student, which is where |amethyst is (though iirc he passed that class on to someone else?) 14:08:22 <05icoson> "those commits" = the potentially ai generated ones 14:08:49 <05icoson> so I think it is definitely students from a class, last time this happened they were not really intending to commit to upstream 14:09:07 03dolorous02 07* 0.34-a0-1160-gfbe7a93f4e: Disallow zombifying Grunn, since he's undead. 10(5 minutes ago, 1 file, 1+ 2-) 13https://github.com/crawl/crawl/commit/fbe7a93f4e59 14:29:46 <06dolorous_84348> So many little pieces all over the place. The ironic part was I was trying to do this because it's a bit easier than trying to fix the zombie naming code for monsters killed by fineffs in mon-death.cc. Long story short, no name_zombie() equivalent there, so names there go wrong, and redefined monsters' names are sometimes wrong, too. (tekkud mentioned the "goblin zombie"? You can get one by zombifying the goblin sharper from one 14:29:46 of my Nemelex vaults with it; it has "suffix" and "no_corpse", but the latter makes it lose the suffix when it dies, and the former is still set on the zombie, so the space is for the now-nonexistent suffix.) 14:31:18 <06dolorous_84348> Working on that still, and it's mostly working, but I don't know if it's the best approach, plus base types for zombies are a bit broken with it although everything else seems to work. I'll put it in a PR soon in case anyone else wants to look at it and see what might be wrong. 14:31:35 <06dolorous_84348> Because I'm stumped at the moment. 14:47:45 03dolorous02 07* 0.34-a0-1161-g7925ddab22: Add flag mask for all name-related flags. 10(4 minutes ago, 2 files, 4+ 5-) 13https://github.com/crawl/crawl/commit/7925ddab227d 14:55:18 03dolorous02 07* 0.34-a0-1162-g7e2540d371: Simplify all-name-related mask handling a bit. 10(4 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/7e2540d371eb 15:44:43 03regret-index02 07* 0.34-a0-1163-gb7cf73b23f: Move fire bats out of Depths lava and into D lava 10(2 days ago, 1 file, 4+ 4-) 13https://github.com/crawl/crawl/commit/b7cf73b23f64 15:44:43 03regret-index02 07* 0.34-a0-1164-g25542d231b: Another small targeted vault batch 10(78 minutes ago, 3 files, 183+ 0-) 13https://github.com/crawl/crawl/commit/25542d231b09 15:44:43 03regret-index02 07* 0.34-a0-1165-g655ffec7b1: Micro vault review 10(20 minutes ago, 6 files, 17+ 10-) 13https://github.com/crawl/crawl/commit/655ffec7b152 16:40:15 Unstable branch on underhound.eu updated to: 0.34-a0-1165-g655ffec7b1 (34) 17:40:50 <06mumra> Adding a pause feature to a turn-based game that is by definition already paused between turns? Very interesting... 17:41:02 <06mumra> Unfortunately probably going to see this kind of nonsense with increasing frequency 17:45:15 <06mumra> (At least until about 5 years from now when AI code surpasses human code to such an extent that AI PRs are indistinguishable from geniune devteam ones, at which point crawl enters the singularity and becomes Skynet) 17:52:11 <09hellmonk> betting on total economic collapse and nuclear annihilation of humanity occurring first 18:03:09 03WizardIke02 07* 0.34-a0-1166-ge6352ea329: Show actual feature tile flavour in more menus 10(3 days ago, 9 files, 316+ 320-) 13https://github.com/crawl/crawl/commit/e6352ea329d9 18:04:15 <09gammafunk> what if the badness of crawlcode protects us from skynet 18:04:15 <09gammafunk> like a firewall 18:26:33 <06mumra> i'm more thinking that crawl is the direct cause of all that 18:27:10 <06mumra> yes, or the saviour. sort of a firecrawl 18:27:55 <06mumra> definitely one or the other. crawl is the endgame 19:35:33 03WizardIke02 07* 0.34-a0-1167-g75fabc873b: Fix looking up rock walls in Pandemonium 10(32 minutes ago, 4 files, 14+ 7-) 13https://github.com/crawl/crawl/commit/75fabc873b1e 20:20:45 03regret-index02 07* 0.34-a0-1168-ge2fda637c3: Some banishment + Doom Xom adjustments (adelrune) 10(39 seconds ago, 3 files, 31+ 21-) 13https://github.com/crawl/crawl/commit/e2fda637c3f8 21:02:12 <08nicolae> ah, nothing like having a stupid idea for a vault and making it work after an hour or two of fucking with it 21:06:56 New branch created: pull/4900 (1 commit) 13https://github.com/crawl/crawl/pull/4900 21:06:56 03WizardIke02 07https://github.com/crawl/crawl/pull/4900 * 0.34-a0-1168-g9363cdd93c: Fix Vaults:4 down stairs description (acrobat3) 10(31 minutes ago, 4 files, 22+ 19-) 13https://github.com/crawl/crawl/commit/9363cdd93ce3 21:27:21 New branch created: pull/4901 (1 commit) 13https://github.com/crawl/crawl/pull/4901 21:27:21 03dolorous02 07https://github.com/crawl/crawl/pull/4901 * 0.34-a0-1167-g25edec26d9: Add testing vault for zombified monster names. 10(10 minutes ago, 1 file, 50+ 0-) 13https://github.com/crawl/crawl/commit/25edec26d957 21:41:06 <06dolorous_84348> I decided this was a better idea than trying to clean up my attempt at hacking around the zombified names problem. There are currently a lot more than just the "goblin zombie" problem with e.g. the goblin sharper (this PR has the goblin non-grumbler with "suffix" and "nocorpse" set, which works the same way). That particular "goblin zombie" problem is rooted in code in mon-info.cc, where MB_SUFFIX remains set even for a zombie 21:41:06 spawned from a "nocorpse" monster, so its displayed suffix is blank and given space anyway. I'm short on time at the moment to report the exact number of naming bugs I found while testing (as I said above, a lot more than I thought), but if you take the vault in this PR and kill and zombify all the goblins there in all the ways you can, you'll find them, which I hope is at least of some use. (It would be nice if there was an always_zombify flag to make 21:41:07 it even easier.) 21:42:23 New branch created: pull/4902 (1 commit) 13https://github.com/crawl/crawl/pull/4902 21:42:23 03RypoFalem02 07https://github.com/crawl/crawl/pull/4902 * 0.34-a0-1161-g40804a7fe0: fix: Faulty feedback when paralyzing sleeping enemies (qwarkbark) 10(29 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/40804a7fe03f 22:05:05 -!- daethoven137189 is now known as daethoven13718 22:05:06 -!- TAS-2012v is now known as TAS_2012v 22:05:06 -!- indigaz23 is now known as indigaz2 22:49:58 03dolorous02 07* 0.34-a0-1169-gab067d3732: Add another triumphant Terence line. 10(3 minutes ago, 1 file, 3+ 0-) 13https://github.com/crawl/crawl/commit/ab067d373215 23:35:33 Unstable branch on crawl.develz.org updated to: 0.34-a0-1169-gab067d3732 (34) 23:58:48 Windows builds of master branch on crawl.develz.org updated to: 0.34-a0-1169-gab067d3732