00:08:05 New branch created: pull/4887 (1 commit) 13https://github.com/crawl/crawl/pull/4887 00:08:06 03RypoFalem02 07https://github.com/crawl/crawl/pull/4887 * 0.34-a0-1113-g6eaad0607d: fix: Hepliaklqana's ancestor names checking the wrong database 10(6 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/6eaad0607d3f 00:13:23 Unstable branch on cbro.berotato.org updated to: 0.34-a0-1123-g7c3e7ee1c7 (34) 00:15:37 03dolorous02 07* 0.34-a0-1124-g77d263c096: Adjust punctuation in a god message. 10(8 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/77d263c0967d 00:39:13 03RypoFalem02 {dolorous} 07* 0.34-a0-1125-gfab7be54b3: fix: Hep's ancestor names checking the wrong DB 10(37 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/fab7be54b341 00:55:42 Monster database of master branch on crawl.develz.org updated to: 0.34-a0-1125-gfab7be54b3 01:59:00 -!- indigaz22 is now known as indigaz2 02:10:22 New branch created: pull/4888 (1 commit) 13https://github.com/crawl/crawl/pull/4888 02:10:23 03Claude02 07https://github.com/crawl/crawl/pull/4888 * 0.34-a0-1126-g93c35ebbdf: Add DCSS autocombat integration plan 10(2 minutes ago, 1 file, 1695+ 0-) 13https://github.com/crawl/crawl/commit/93c35ebbdfa4 02:17:07 <02M​onkooky> this is ai generated slop 04:31:38 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 05:11:27 Unstable branch on crawl.akrasiac.org updated to: 0.34-a0-1125-gfab7be5 (34) 08:20:20 <06p​leasingfungus> > Trying to fork and learn and accidentally submitted this pr. Sorry about that. 09:39:37 New branch created: pull/4891 (1 commit) 13https://github.com/crawl/crawl/pull/4891 09:39:38 03Zhang Haocheng02 07https://github.com/crawl/crawl/pull/4891 * 0.34-a0-1087-gda22dc1fb0: Consider corrosion in some descriptions 10(2 hours ago, 9 files, 48+ 47-) 13https://github.com/crawl/crawl/commit/da22dc1fb0f9 09:45:00 03Zhang Haocheng02 07https://github.com/crawl/crawl/pull/4891 * 0.34-a0-1087-gfeeb4a6e87: Consider corrosion in some descriptions 10(2 hours ago, 9 files, 48+ 47-) 13https://github.com/crawl/crawl/commit/feeb4a6e8723 11:26:57 03dolorous02 07* 0.34-a0-1126-gc8256e9c32: Change now-gone scythes'/hammers' internal names. 10(54 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/c8256e9c324e 11:51:39 03dolorous02 07* 0.34-a0-1127-g48a9863432: Change other now-gone weapons' names internally. 10(23 minutes ago, 1 file, 4+ 4-) 13https://github.com/crawl/crawl/commit/48a9863432b2 11:51:47 -!- jds_ is now known as jds 11:52:44 03dolorous02 07* 0.34-a0-1128-gc7442039ac: Remove unneeded blank line. 10(68 seconds ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/c7442039ac90 12:50:42 New branch created: pull/4892 (1 commit) 13https://github.com/crawl/crawl/pull/4892 12:50:43 03brianfaires02 07https://github.com/crawl/crawl/pull/4892 * 0.34-a0-1129-g51d7159be5: Create lua func you.movement_cost() 10(2 minutes ago, 1 file, 11+ 0-) 13https://github.com/crawl/crawl/commit/51d7159be53c 14:31:43 03gammafunk02 07[lua5.4] * 0.34-a0-1061-g56c1fa0a84: Lua 5.4: Update the Lua contrib 10(7 days ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/56c1fa0a84ec 14:31:43 03gammafunk02 07[lua5.4] * 0.34-a0-1062-g41654184cf: Lua 5.4: Update the MSVC project file 10(20 hours ago, 1 file, 4+ 2-) 13https://github.com/crawl/crawl/commit/41654184cf73 14:31:43 03gammafunk02 07[lua5.4] * 0.34-a0-1063-g66bfce10b7: Lua 5.4: Update CI, debian, and documentation 10(23 hours ago, 4 files, 6+ 6-) 13https://github.com/crawl/crawl/commit/66bfce10b7b1 14:31:43 03Vsevolod Kozlov02 {gammafunk} 07[lua5.4] * 0.34-a0-1064-g85a6347a95: Lua 5.4: Adjust the Lua version in the Makefile 10(2 years ago, 1 file, 9+ 9-) 13https://github.com/crawl/crawl/commit/85a6347a9511 14:31:43 03Vsevolod Kozlov02 {gammafunk} 07[lua5.4] * 0.34-a0-1065-g6f87f7bfe2: Lua 5.4: Support the new Lua C API 10(2 years ago, 32 files, 165+ 101-) 13https://github.com/crawl/crawl/commit/6f87f7bfe284 14:31:43 03Vsevolod Kozlov02 {gammafunk} 07[lua5.4] * 0.34-a0-1066-gd26294802a: Lua 5.4: Add a crawl.setfenv function 10(2 years ago, 1 file, 7+ 0-) 13https://github.com/crawl/crawl/commit/d26294802ad2 14:31:43 03Vsevolod Kozlov02 {gammafunk} 07[lua5.4] * 0.34-a0-1067-g04b1e83a6a: Lua 5.4: Update Lua code for compatibility 10(2 years ago, 13 files, 20+ 20-) 13https://github.com/crawl/crawl/commit/04b1e83a6adb 14:31:43 03gammafunk02 07[lua5.4] * 0.34-a0-1068-ged93a95d55: Lua 5.4: Use a safe integer check function 10(23 hours ago, 1 file, 4+ 4-) 13https://github.com/crawl/crawl/commit/ed93a95d5550 14:31:43 03gammafunk02 07[lua5.4] * 0.34-a0-1069-g0add21ae6e: Lua 5.4: Update a Lua test 10(23 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/0add21ae6eff 14:31:43 03gammafunk02 07[lua5.4] * 0.34-a0-1070-g7e004fc84d: Lua 5.4: Improve usage of integers in the API 10(23 hours ago, 22 files, 221+ 221-) 13https://github.com/crawl/crawl/commit/7e004fc84d55 16:06:10 New branch created: pull/4893 (1 commit) 13https://github.com/crawl/crawl/pull/4893 16:06:11 03CrawlOdds02 07https://github.com/crawl/crawl/pull/4893 * 0.34-a0-1129-g8e41ba2d3c: Fix typo 10(78 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/8e41ba2d3c55 16:15:52 03gammafunk02 07* 0.34-a0-1129-gfd4135b882: Fix a DES typo (Odds) 10(70 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/fd4135b882e3 16:40:48 Unstable branch on underhound.eu updated to: 0.34-a0-1128-gc7442039ac (34) 17:22:21 03dolorous02 07* 0.34-a0-1130-g02ecae1eed: Add another name for Hexes spellbooks. 10(11 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/02ecae1eed74 17:22:21 03dolorous02 07* 0.34-a0-1131-g7f5ec7c178: Add another instrumental and weapon noise. 10(9 minutes ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/7f5ec7c178f8 18:31:02 03WizardIke02 07* 0.34-a0-1132-g1aad769bac: Fix bane of succour sometimes clearing xp tracking 10(22 minutes ago, 1 file, 5+ 1-) 13https://github.com/crawl/crawl/commit/1aad769bac01 20:20:22 <06c​ao> Renew Success by crawl Success certs: crawl.akrasiac.org_ecc 20:54:48 <09g​ammafunk> @mumra I've found what looks like our first "win" for the possible upgrade to lua 5.4. It seems to be an error in some of your layout code for vaults that's been present for a long time. In lua 5.1, if you try to remove an index from a table with table.remove() and that index is invalid, it fails silently, but in lua 5.4 it throws an error. This was causing a ton of level vetoes here in v_paint.lua under my lua 5.4 branch when doing 20:54:48 crawl -test vault_catalog.lua (one of our standard lua tests). These errors weren't happening in lua 5.1, due to the difference in behaviour of table.remove() mentioned above. However with the following test code insertion shows that the problem is still happening under lua 5.1: diff diff --git a/crawl-ref/source/dat/dlua/v_paint.lua b/crawl-ref/source/dat/dlua/v_paint.lua index e79813a54f..dcc6974abf 100644 --- a/crawl-ref/source/dat/dlua/v_paint.lua 20:54:49 +++ b/crawl-ref/source/dat/dlua/v_paint.lua @@ -63,6 +63,9 @@ local function set_usage(usage_grid,x,y,usage) -- Check existing usage, remove it from eligibles if it's there local current = usage_grid[y][x] if current.eligibles_index ~= nil then + if current.eligibles_index > #usage_grid.eligibles then + print("current.eligibles_index: " .. tostring(current.eligibles_index) .. "; #usage_grid.eligibles: " .. 20:54:50 tostring(#usage_grid.eligibles)) + end table.remove(usage_grid.eligibles,current.eligibles_index) end -- Add to the eligibles list if it's eligible This produces output like: $ ./crawl -test vault_catalog.lua Running test #1: 'vault_catalog.lua'. Testing seed 1. . current.eligibles_index: 1140; #usage_grid.eligibles: 1093 current.eligibles_index: 1152; #usage_grid.eligibles: 1093 There are many instances of this error condition 20:54:50 triggering 20:58:46 03Implojin02 07* 0.34-a0-1133-g41f2f78647: Remove a duplicate dlua function 10(2 minutes ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/41f2f7864738 21:01:00 <09g​ammafunk> From my reading of the code, it looked like the assumption that the relevant usage_grid.eligibles array would have stable indices has always been wrong. Since entries seem to get removed in a non-linear way, storing an entries index (e.g. at current.eligibles_index) wouldn't be a valid way to reference the index of an entry in the usage_grid.eligibles array. I'm pinging you because you may be able to make sense of exactly why and 21:01:00 where the mismatch is happening faster than I can, and of course you might have a good fix in mind. I would tend to use a hash on the coordinates to provide a stable key into the table instead of using the table as an array. The code in question definitely needs some cleanup in general, since there are local an global copies of the relevant function and seemingly multiple implementations of the same or similar functions (c.f. set_usage() in 21:01:01 v_paint.lua and another implementation of it dat/dlua/layout/hyper_usage.lua). Anyhow, if you have time to take a look for yourself before I go about fully investigating and fixing myself, that would be appreciated 21:06:25 <09g​ammafunk> There's another set of related errors 5.4 has seemingly uncovered: Fatal lua error: ...awl-ref/source/dat/dlua/layout/procedural_primitives.lua:33: attempt to call a nil value (field 'pow') Builder VETO on fatal lua error: Zot:3: Vault placement failure for 'layout_onion'. ...awl-ref/source/dat/dlua/layout/procedural_primitives.lua:33: attempt to call a nil value (field 'pow') Fatal lua error: 21:06:25 ...awl-ref/source/dat/dlua/layout/procedural_primitives.lua:33: attempt to call a nil value (field 'pow') Builder VETO on fatal lua error: Tar:1: Vault placement failure for 'layout_catacombs'. ...awl-ref/source/dat/dlua/layout/procedural_primitives.lua:33: attempt to call a nil value (field 'pow') 21:06:35 <09g​ammafunk> I need to look into this, maybe it'll be more straightforward 21:07:15 <09g​ammafunk> oh 21:08:30 <09g​ammafunk> well dangit, it's because we don't have math.pow() unless we add a define to our lua compilation, apparently 21:08:56 <09g​ammafunk> that's easilly fixed, at least 21:10:11 <09g​ammafunk> oh better yet we can just use an operator in the language now 21:23:34 <03i​mplojin> as a side note on the topic of lua things unrelated to 5.4, we have a bunch of logic errors in lua parameter checks where we're using lua_isstring and lua_isnumber incorrectly, including some uses in dlua. (crawlcode often expects these to distinguish between string or number which they don't, lua treats them as convertible: https://www.lua.org/manual/5.1/manual.html#lua_isstring) 21:24:59 <03i​mplojin> aliscans did a PR that spotted and fixed one case of this a while back, but apparently it's more widespread 21:29:09 <09g​ammafunk> well, do these cases actually care whether the argument originally was a number/string? The fix may not lie in the use of lua_isstring() or lua_isnumber() but in performing the right transformation on the parameter (e.g. lua_tostring()). But if they want a hard check on the argument, they should use lua_type() (or a string check on lua_typename()) 21:29:35 <03i​mplojin> some of them do, some of them don't 21:29:49 <09g​ammafunk> sounds like some need to do conversion and some need to check type 21:29:53 <03i​mplojin> yep 21:30:27 <09g​ammafunk> I do type checks a lot in qw with the lua-side type checking, but I have more guarantees that my caller is sane. Lua api functions aren't so lucky, obviously 21:32:22 <09g​ammafunk> (regarding that math.pow thing, I'm actually going to rewrite the few instances to just use lua's ^ exponentiation operator. Perhaps the code in question was copying older code using older lua versions that didn't have ^, but it's present in 5.1 as well) 21:48:12 03gammafunk02 07* 0.34-a0-1134-ge1e2a20661: Don't use the deprecated `math.pow()` function 10(12 minutes ago, 3 files, 3+ 3-) 13https://github.com/crawl/crawl/commit/e1e2a2066194 23:35:33 Unstable branch on crawl.develz.org updated to: 0.34-a0-1134-ge1e2a20661 (34) 23:58:45 Windows builds of master branch on crawl.develz.org updated to: 0.34-a0-1134-ge1e2a20661