00:35:16 Unstable branch on cbro.berotato.org updated to: 0.34-a0-1121-g4f141f716d (34) 00:55:42 Monster database of master branch on crawl.develz.org updated to: 0.34-a0-1121-g4f141f716d 01:18:47 03dolorous02 07* 0.34-a0-1122-g1844fab789: Fix indentation. 10(5 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/1844fab7898e 01:41:20 New branch created: pull/4884 (1 commit) 13https://github.com/crawl/crawl/pull/4884 01:41:21 03dolorous02 07https://github.com/crawl/crawl/pull/4884 * 0.34-a0-1123-g34d6501f6e: Adjust description of the book of Transmutation. 10(12 minutes ago, 1 file, 5+ 3-) 13https://github.com/crawl/crawl/commit/34d6501f6ec4 01:58:56 -!- indigaz24 is now known as indigaz2 02:24:17 03CrawlOdds02 07https://github.com/crawl/crawl/pull/4847 * 0.34-a0-1007-g082ddde770: Prevent hiding from your past 10(13 days ago, 2 files, 20+ 20-) 13https://github.com/crawl/crawl/commit/082ddde7704e 02:25:40 <11Odds> @implojin - you mentioned yesterday you thought the above pull request was a bit scary. I think that's very reasonable, but also stilll think it's correct 🙂 . I've adjusted the commit message to be clearer on the implications of the change (the code is unchanged) 02:26:57 <11Odds> (To summarise, currently ally behaviour changes quite a lot if we have a pet_target that isn't a valid target, and this seems bad) 04:32:35 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 05:36:18 Unstable branch on crawl.akrasiac.org updated to: 0.34-a0-1122-g1844fab (34) 08:35:50 03dolorous02 07https://github.com/crawl/crawl/pull/4884 * 0.34-a0-1123-gdfac9de4bb: Adjust description of the book of Transmutation. 10(7 hours ago, 1 file, 5+ 3-) 13https://github.com/crawl/crawl/commit/dfac9de4bb07 08:40:09 03dolorous02 07https://github.com/crawl/crawl/pull/4884 * 0.34-a0-1123-g3256d5750a: Adjust description of the book of Transmutation. 10(7 hours ago, 1 file, 5+ 3-) 13https://github.com/crawl/crawl/commit/3256d5750adc 11:15:39 <06mumra> @dolorous_84348 I wonder if the "strange obsession with becoming a spider" line feels a bit outdated now there is the talisman 11:31:56 <06dolorous_84348> I wondered that myself. That part of the description was actually added after talismans were put into the game (although not the spider talisman specifically, which was added later). I thought it was a reference to the old Spider Form spell, and to how using magic to change one's form (aside from a few odd cases like wands of polymorph) is no longer possible now that talismans are used for that. 12:02:54 03dolorous02 07* 0.34-a0-1123-g7c3e7ee1c7: Search for/display created items w/DESC_DBNAME. 10(74 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/7c3e7ee1c7a7 12:21:48 <06mumra> Yeah i assume that as well, but with spider form existing it seems strange to say they never achieved that aim 12:23:14 <06dolorous_84348> Maybe I should change it to, say, a hydra obsession? The author is supposed to be a skilled alchemist, and hydra form is no longer a thing. 12:25:28 <06mumra> I was thinking about something rather more whimsical but similarly unavailable: a butterfly 12:25:41 <06dolorous_84348> That works too. 12:27:59 <06mumra> Would it be weird to have a randomised string in a book description that's expected to be static i wonder 12:30:24 <06dolorous_84348> Maybe. Some book descriptions are slightly different depending on player characteristics, but nothing picks a random form that there's no talisman/bauble for. (Not that I think the possibility isn't cool, though.) 12:31:12 <06dolorous_84348> For now, I'll put the butterfly in; thanks. 12:31:55 03dolorous02 07https://github.com/crawl/crawl/pull/4884 * 0.34-a0-1124-g89e8a3a776: Adjust description of the book of Transmutation. 10(11 hours ago, 1 file, 5+ 3-) 13https://github.com/crawl/crawl/commit/89e8a3a776f7 12:57:59 <06mumra> (Would be interesting to have a system like "randomise this text the first time it's rendered in a game but subsequently remember what we chose". Then have a choice here like hydra|butterfly|chocobo|centaur|elephant|whatever...) 12:59:41 <06dolorous_84348> The closest analogue to that which I can think of off the top of my head would be how Jiyva's second name is handled. 13:02:18 <06mumra> Am assuming that's a specific thing handled in C rather than a general thing available in language files which is more what I'm thinking 13:03:26 <06dolorous_84348> Wouldn't it still have to be saved in a saved game in a similar fashion, if it's supposed to persist the entire game after being set once? 13:20:21 <06dolorous_84348> Setting it the way a Pan lord description would be simpler, but that still requires a constant seed, and that seed is generated based on the random name a Pan lord gets. The new monster leashing code might be used the same way, but the only potentially random information it provides is the original level the monster is on, so a monster that starts on a certain level will always get the same result. 13:35:52 <06dolorous_84348> Maybe get the seed number the game started with (which is set only once, has a bunch of possibilities, and doesn't change within the current game), and use that number mod however many text options there are? That way, nothing would need to be saved, and the text chosen would start off effectively random and not change afterward. The same seed number would produce the same results, but that's how seed numbers are supposed to work 13:35:52 anyway. 13:41:55 <06dolorous_84348> And with that, I'm out of ideas on this front. 15:41:50 <09gammafunk> woot all the crawl lua tests now pass with 5.4 15:42:46 :thumb_up: 15:42:51 bah 15:43:26 :thumbs_up: 15:43:35 it doesn't like me today 😕 15:53:12 <02Monkooky> you didn't use enough thumb 16:40:14 Unstable branch on underhound.eu updated to: 0.34-a0-1123-g7c3e7ee1c7 (34) 19:11:08 <09gammafunk> let's see if this fixes all the build issues 19:12:05 03gammafunk02 07[lua5.4] * 0.34-a0-1061-gc2758cc1ff: Lua 5.4: Update the Lua contrib 10(6 days ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/c2758cc1ffa7 19:12:05 03gammafunk02 07[lua5.4] * 0.34-a0-1062-g651146a71d: Lua 5.4: Update the MSVC project file 10(52 minutes ago, 1 file, 4+ 2-) 13https://github.com/crawl/crawl/commit/651146a71d15 19:12:05 03gammafunk02 07[lua5.4] * 0.34-a0-1063-gfc5568d8be: Lua 5.4: Update CI, debian, and documentation 10(4 hours ago, 4 files, 6+ 6-) 13https://github.com/crawl/crawl/commit/fc5568d8becf 19:12:05 03Vsevolod Kozlov02 {gammafunk} 07[lua5.4] * 0.34-a0-1064-g1da24a9215: Lua 5.4: Adjust the Lua version in the Makefile 10(2 years ago, 1 file, 9+ 9-) 13https://github.com/crawl/crawl/commit/1da24a921542 19:12:05 03Vsevolod Kozlov02 {gammafunk} 07[lua5.4] * 0.34-a0-1065-g0c2d89f750: Lua 5.4: Support the new Lua C API 10(2 years ago, 32 files, 165+ 101-) 13https://github.com/crawl/crawl/commit/0c2d89f75097 19:12:05 03Vsevolod Kozlov02 {gammafunk} 07[lua5.4] * 0.34-a0-1066-g9145d53c50: Lua 5.4: Add a crawl.setfenv function 10(2 years ago, 1 file, 7+ 0-) 13https://github.com/crawl/crawl/commit/9145d53c50ff 19:12:05 03Vsevolod Kozlov02 {gammafunk} 07[lua5.4] * 0.34-a0-1067-g6a224fc947: Lua 5.4: Update Lua code for compatibility 10(2 years ago, 13 files, 20+ 20-) 13https://github.com/crawl/crawl/commit/6a224fc94778 19:12:05 03gammafunk02 07[lua5.4] * 0.34-a0-1068-g3dae9c3e15: Lua 5.4: Use a safe integer check function 10(4 hours ago, 1 file, 4+ 4-) 13https://github.com/crawl/crawl/commit/3dae9c3e1531 19:12:05 03gammafunk02 07[lua5.4] * 0.34-a0-1069-g5e6d1d7b12: Lua 5.4: Update a Lua test 10(4 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/5e6d1d7b12d5 19:12:05 03gammafunk02 07[lua5.4] * 0.34-a0-1070-g8b304f9f9c: Lua 5.4: Improve usage of integers in the API 10(4 hours ago, 22 files, 221+ 221-) 13https://github.com/crawl/crawl/commit/8b304f9f9c3e 19:34:28 <09gammafunk> nice, build passed. now I have to make sure I understand that the setfenv approach actually works and that the clua allocator and throttle also work. 19:35:19 <09gammafunk> I was thinking that it might be best to modify the Makefile for linux builds so that we check the pkgconfig lua version and use the lua contrib automatically if pkgconfig doesn't have 5.4 19:36:59 <09gammafunk> there's also the question of luajit. I'm not sure if anyone is using this, but we've "officially" supported its use for a long time 20:27:10 <07acrobat> https://cdn.discordapp.com/attachments/747522859361894521/1436557634303037661/1762572302.gif?ex=69100a0d&is=690eb88d&hm=714758ac52af07bfcb271d5c00b79675d6fcd409b5da497c01ba389a96c163e2& 20:27:30 <07acrobat> @dracoomega someone found that when monsters die from rimeblight's instant-kill effect and turns into pillar of rime, gozag's goldify passive doesn't work, causing permanent gold loss for the player. I thought you would want to know. 23:35:34 Unstable branch on crawl.develz.org updated to: 0.34-a0-1123-g7c3e7ee1c7 (34) 23:51:55 <09gammafunk> oh, it seems that our makefile already does use the lua contrib if it can't find the appropriate version of lua 23:58:49 Windows builds of master branch on crawl.develz.org updated to: 0.34-a0-1123-g7c3e7ee1c7