00:07:35 Stable (0.33) branch on underhound.eu updated to: 0.33.1-9-gc92837dd87 00:13:24 Unstable branch on cbro.berotato.org updated to: 0.34-a0-1086-g12d9f381c8 (34) 00:46:19 Monster database of master branch on crawl.develz.org updated to: 0.34-a0-1062-g464970fc77 01:35:11 Stable (0.33) branch on cbro.berotato.org updated to: 0.33.1-9-gc92837dd87 01:59:33 -!- indigaz29 is now known as indigaz2 04:53:03 <09gammafunk> @wizardike nice emoji use in the commit title! (and thanks for the fix, I didn't get around to it last night) 05:28:36 -!- rozlav3 is now known as rozlav 05:32:41 Stable (0.33) branch on crawl.akrasiac.org updated to: 0.33.1-9-gc92837d 05:43:08 Unstable branch on crawl.akrasiac.org updated to: 0.34-a0-1086-g12d9f38 (34) 08:08:59 <09gammafunk> looks like CAO is able to build trunk again 09:42:38 <08nicolae> @regret-⸸nde※ i apologize for asking this Yet Again, having to move on short notice has kind of fried my circuits. aside from necropoleis, what else you want? there's the bazaar overhaul which i kept having second thoughts on, i will get back to thinking about it, i might just end up doing something similar to what you did with troves and just cut down on the existing bazaar layouts heavily, mush them together and whatnot 10:01:06 <06regret-⸸nde※> Reviewing over things a little, I'd appreciate more god-specific overflow altars (we've downplayed them for more generic overflow vaults in the past, but there's plenty of new material now that can help raise the average per-god), as well as more Depths themed monster minivaults (after fixing up the Depths:1 minivault placement, I've noticed it skews mostly towards the 098 types of vaults, and we've gotten a bunch of new 10:01:06 monsters for the branch that can reasonably get themed minivaults to themselves). 10:02:29 <08nicolae> right, you've mentioned the god-specific altars, i remember now. will think about depth themed monsters. 10:03:04 <08nicolae> will need to review the new depth monsters but that's what mon pick data dot h is for. 10:03:24 <08nicolae> thank you, i know i've been more than a little scatterbrained for a while 10:06:32 <06regret-⸸nde※> Don't push yourself if you need more breaks. Your efforts are already a massive proportion of any new vault submissions these past few years, as is. 10:06:57 <06regret-⸸nde※> (I do wish I was making more vaults myself, but so much time is spent making the parts for them now, I guess...) 10:07:33 <08nicolae> which i appreciate also, the decor features help make it easier to make decor vaults 11:37:56 -!- Changesite1 is now known as Changesite 12:06:56 03regret-index02 07* 0.34-a0-1087-ga086fab39d: Yet more catch-up vault review 10(6 minutes ago, 33 files, 351+ 430-) 13https://github.com/crawl/crawl/commit/a086fab39dd5 13:20:02 03WizardIke02 07* 0.34-a0-1088-gc492a03308: Unify status icon sizes between web and local tiles 10(3 days ago, 9 files, 224+ 181-) 13https://github.com/crawl/crawl/commit/c492a03308da 14:02:57 New branch created: pull/4878 (1 commit) 13https://github.com/crawl/crawl/pull/4878 14:02:58 03RypoFalem02 {GitHub} 07https://github.com/crawl/crawl/pull/4878 * 0.34-a0-1089-g7640476e91: fix: overflow vault cloud typo (srcrip) 10(54 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/7640476e9108 14:06:13 03RypoFalem02 {GitHub} 07* 0.34-a0-1089-g7640476e91: fix: overflow vault cloud typo (srcrip) 10(4 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/7640476e9108 14:06:13 03Index02 {GitHub} 07* 0.34-a0-1090-g46577a27f7: fix: overflow vault cloud typo (srcrip) (#4878) 10(19 seconds ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/46577a27f749 14:38:20 <07wizardike> I think I understand how we ended up trying to draw an invalid parchment. The foreground tiles for squares in view are stored in tile_env.fg, however, the coordinates used to access tile_env.fg are effectively relative to the player. So if for example you get the tile one above the player and then move the player without updating tile_env.fg and then get the tile one above the player again it will always return the same value even 14:38:25 though there should be a different tile one above the player. The crash happened as a result of the player being knocked back which uses a player movement function that doesn't call viewwindow and thus doesn't update tile_env.fg. Moving the player calls tiles.update_minimap to remove the old player marker from the minimap which results in the square being marked for redraw in webtiles. tiles.redraw was then called before viewwindow would have next been 14:38:25 called as a result of the animation delay on the force lance that pushed the player, this resulted in the square that got marked for redraw being redrawn using the foreground from tile_env.fg (which was incorrectly a parchment from another square) and the map knowledge of whatever item was actually on the square 14:41:37 <04dracoomega> Ugh -.- 14:41:50 <04dracoomega> I hate it ^^; 14:42:19 <04dracoomega> (Presumably, in reality, it wouldn't even be seen anyway before being replaced by the 'real' one) 14:44:39 <07wizardike> It would have been seen because it happened as a result of a delay 14:46:00 <07wizardike> But the tiles look bad after knock back anyway before the next viewwindow call, so it didn't really matter how it looked 14:46:42 <04dracoomega> Hmmm... I do maybe have very vague memories of knockback looking weird/worse on webtiles than local tiles? Like, some things not being in the right places. 14:53:24 <04dracoomega> (Like, I fully admit that the parchment rendering code is very brittle and a massive hack, but this sounds like an issue that extends further than just that, right? Like, surely we shouldn't be drawing the screen after state has changed without updating the tiles properly to reflect that state, if I'm understanding correctly?) 14:55:08 <07wizardike> Yes, this isn't really an issue with parchments, it just causes crashes there instead of things looking bad 15:03:32 <07wizardike> Also, I think we can probably just remove tile_env.fg, tile_env.bg and tile_env.cloud and just use the full map versions everywhere instead with only minor changes. This would also make fixing animations not updating outside of max los radius easier to 15:16:17 <06mumra> if any of this work can incidentally fix the "ghosts randomly change their appearance on every render" issue you get a special prize 15:20:25 <07wizardike> It wouldn't fix this unfortunately. The monster_info entries in the map knowledge are still going to be recreated every frame for monsters in sight as the underlying monster might have had some changes 15:39:31 03dolorous02 07* 0.34-a0-1091-ge1813ad4d6: Fix missing brackets. 10(4 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/e1813ad4d6de 15:39:31 03dolorous02 07* 0.34-a0-1092-g50789deb7c: Remove unneeded brackets and breaks. 10(3 minutes ago, 1 file, 0+ 6-) 13https://github.com/crawl/crawl/commit/50789deb7c81 15:51:55 <06mumra> @regret-⸸nde※ Part way through some review of ancient layout code. As well as various layouts that have been set to weight 0, there's a whole bunch of unused stuff hidden away in lua code. I am thinking an immediate candidate for Pan might be layout_twisted_forest (and a comment from yourself there: # TODO: This layout needs some shrinking and a home. Lair? Crypt?) 15:54:18 <06regret-⸸nde※> https://ptb.discord.com/channels/735056636644687913/747522859361894521/1433076911554433044 15:55:12 <06mumra> Oh right. I did read that yesterday, then apparently forgot that you specifically named that layout 15:55:40 <06mumra> (I recently started a new job, and exhaustion levels are fairly high) 15:59:54 <06mumra> I'm digging through a bunch of the other unused layouts to see what might be usable with some tweaks, and how some trees/water can be added (some further detail on the new terrain types could be useful to think how watery areas could be replaced with areas of varying patches of these new terrains?) 16:01:33 <06mumra> (I have a fairly specific idea for a completely new generator as well, but I think repurposing and cleaning up some existing code along the way is a good first step and slightly refamiliarising myself with everything there) 16:02:16 <04dracoomega> The new terrain types are mostly still in the 'skeletal concept' stage. General ideas, but nothing precisely nailed down yet. (For my own part, I've been focusing more design energy on the stuff that's landing earlier, and all ^^; ) 16:02:58 <04dracoomega> (Though perhaps it would be helpful to spend a little more time on my part actively brainstorming in the near-ish future, I suppose.) 16:26:44 03dolorous02 07* 0.34-a0-1093-gc2427cda9c: Properly use pink crystal wall desc. 10(3 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/c2427cda9cbc 16:37:28 03dolorous02 07* 0.34-a0-1094-gf7b759ce7b: Add another Orb of Zot greatness adjective. 10(87 seconds ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/f7b759ce7b5b 16:40:25 Unstable branch on underhound.eu updated to: 0.34-a0-1092-g50789deb7c (34) 17:42:52 New branch created: pull/4879 (1 commit) 13https://github.com/crawl/crawl/pull/4879 17:42:53 03WizardIke02 07https://github.com/crawl/crawl/pull/4879 * 0.34-a0-1089-ga43d26f483: Remove a no longer needed tile cache 10(3 days ago, 6 files, 46+ 115-) 13https://github.com/crawl/crawl/commit/a43d26f4839b 17:53:20 -!- meatpath1 is now known as meatpath 18:00:09 -!- meatpath1 is now known as meatpath 18:03:17 03WizardIke02 07https://github.com/crawl/crawl/pull/4879 * 0.34-a0-1089-g1396f8d936: Remove a no longer needed tile cache 10(3 days ago, 6 files, 47+ 116-) 13https://github.com/crawl/crawl/commit/1396f8d936da 18:36:27 03WizardIke02 07https://github.com/crawl/crawl/pull/4879 * 0.34-a0-1089-g1cd46fd1d9: Remove a no longer needed tile cache 10(3 days ago, 6 files, 50+ 116-) 13https://github.com/crawl/crawl/commit/1cd46fd1d9ed 19:18:20 New branch created: pull/4880 (1 commit) 13https://github.com/crawl/crawl/pull/4880 19:18:20 03RypoFalem02 07https://github.com/crawl/crawl/pull/4880 * 0.34-a0-1095-g878e1ec931: art: Make exclusions more readable 10(30 minutes ago, 2 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/878e1ec93152 19:19:26 03WizardIke02 07* 0.34-a0-1095-gb2c792946c: Remove a no longer needed tile cache 10(3 days ago, 6 files, 50+ 116-) 13https://github.com/crawl/crawl/commit/b2c792946cc8 19:53:47 03dolorous02 07* 0.34-a0-1096-g619a04b5ed: Don't hardcode max rune count in title checks. 10(64 minutes ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/619a04b5edd5 19:53:47 03dolorous02 07* 0.34-a0-1097-gf5dcfa5417: Properly use #defines for rune counts. 10(28 minutes ago, 8 files, 16+ 13-) 13https://github.com/crawl/crawl/commit/f5dcfa5417f5 19:59:10 03dolorous02 07* 0.34-a0-1098-g840e72858f: Fix warning. 10(2 minutes ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/840e72858f5c 20:02:52 <06dolorous_84348> Now changing the number of runes needed to enter Zot, or the maximum number of runes you can get (not counting how Sprint overrides it in certain of its games) should be a matter of just changing a number in defines.h. Aside from some weird bits regarding the former (mostly with Xom), anyway. 20:16:39 <09hellmonk> wasn't aware we had that function. Thanks. 20:46:23 03dolorous02 07* 0.34-a0-1099-gc674a984dc: Adjust the Zot minimum rune message. 10(3 minutes ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/c674a984dc9f 20:52:51 03WizardIke02 07* 0.34-a0-1100-g87cdf11214: Fix clearing some remembered foreground tiles 10(6 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/87cdf11214e9 21:02:14 04Build failed for 08master @ c674a984 06https://github.com/crawl/crawl/actions/runs/19124117693 21:10:03 03dolorous02 07* 0.34-a0-1101-gb63a3c07f7: Add assert for now regarding Zot runes. 10(4 minutes ago, 1 file, 3+ 0-) 13https://github.com/crawl/crawl/commit/b63a3c07f793 21:40:11 03gammafunk02 07[lua5.4] * 0.34-a0-1061-g600ac2fdef: Update the lua 5.4 contrib 10(4 days ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/600ac2fdef3a 21:40:11 03Vsevolod Kozlov02 {gammafunk} 07[lua5.4] * 0.34-a0-1062-ga39e19f85b: Lua 5.4 support: Adjust Lua version in Makefile 10(2 years ago, 1 file, 9+ 9-) 13https://github.com/crawl/crawl/commit/a39e19f85b58 21:40:11 03Vsevolod Kozlov02 {gammafunk} 07[lua5.4] * 0.34-a0-1063-gc3d91fd08b: Lua 5.4 support: Support the new Lua C API 10(2 years ago, 32 files, 165+ 101-) 13https://github.com/crawl/crawl/commit/c3d91fd08b43 21:40:11 03Vsevolod Kozlov02 {gammafunk} 07[lua5.4] * 0.34-a0-1064-ge85db447a9: Lua 5.4 support: Add crawl.setfenv function 10(2 years ago, 1 file, 7+ 0-) 13https://github.com/crawl/crawl/commit/e85db447a98e 21:40:11 03Vsevolod Kozlov02 {gammafunk} 07[lua5.4] * 0.34-a0-1065-g10a1b65c04: Lua 5.4 support: Update Lua code for 5.4 compatibility 10(2 years ago, 13 files, 20+ 20-) 13https://github.com/crawl/crawl/commit/10a1b65c04fc 21:40:11 03gammafunk02 07[lua5.4] * 0.34-a0-1066-g773378d711: More updates for the switch to Lua 5.4 10(4 days ago, 5 files, 10+ 10-) 13https://github.com/crawl/crawl/commit/773378d71158 21:56:23 04Build failed for 08lua5.4 @ 773378d7 06https://github.com/crawl/crawl/actions/runs/19125016307 22:09:01 <09gammafunk> ooh 22:09:05 <09gammafunk> we got further that time 22:09:51 <09gammafunk> oh boy I get to update msvc project files? 23:48:55 New branch created: pull/4881 (1 commit) 13https://github.com/crawl/crawl/pull/4881 23:48:56 03WizardIke02 07https://github.com/crawl/crawl/pull/4881 * 0.34-a0-1101-gcb9eaa5c85: Don't leak info about polar vortex casters 10(20 minutes ago, 10 files, 74+ 39-) 13https://github.com/crawl/crawl/commit/cb9eaa5c858e 23:57:32 03WizardIke02 07https://github.com/crawl/crawl/pull/4881 * 0.34-a0-1101-g93ae0ff5f8: Don't leak info about polar vortex casters 10(28 minutes ago, 10 files, 74+ 39-) 13https://github.com/crawl/crawl/commit/93ae0ff5f833