00:00:12 <09h​ellmonk> definitely something to do with the sprint specification part, if you comment out the if (mon.exp > 0) return mon.exp; the bug seems to go away 00:00:28 <09h​ellmonk> which leads me to believe that this value is getting set by something that shouldn't be setting it 00:00:41 <09h​ellmonk> but I couldn't immediately figure out what 00:00:59 <09h​ellmonk> and I don't want to leave the game broken overnight 00:01:11 <04C​gettys> Yeah, definitely the right call 00:01:18 <04C​gettys> even if I'm enjoying the brokenness a little personally 😛 00:03:32 <04C​gettys> Not the bug, but a bug, I think: monster::init_with does not set exp 00:03:42 <04C​gettys> it clears it in reset, but does not setit in init_with 00:03:48 <04C​gettys> so it'll be 0 sometimes it shouldn't be, perhaps? 00:05:05 <04C​gettys> _place_monster_aux also sets mon->exp 00:05:05 <04C​gettys> if (mg.exp != 0) mon->exp = mg.exp; 00:07:13 <04C​gettys> ah, that's the only place / must be the sprint bit 00:24:33 <04C​gettys> Suspicious things: mgen_data does not zero initialize exp 00:37:12 <04C​gettys> Yeah, there's your problem 00:39:10 <04C​gettys> https://cdn.discordapp.com/attachments/747522859361894521/1360881987476521041/image.png?ex=67fcbb9d&is=67fb6a1d&hm=445ccc19321e1193efe3f025e1ffe68a7f43d07d554b23cf1865d9d26453f64a& 00:39:38 <04C​gettys> _builder_monsters creates a mgen_data mg; at line 4141 in dungeon.cc 00:39:50 <04C​gettys> since mgen-data's constructor does not zero initialize it 00:39:57 <04C​gettys> and mg.exp is not written 00:40:05 <04C​gettys> you get whatever happened to be on the stack there 00:48:32 New branch created: pull/4477 (1 commit) 13https://github.com/crawl/crawl/pull/4477 00:48:33 03Cgettys02 07https://github.com/crawl/crawl/pull/4477 * 0.33-a0-1377-g624aa7e99b: Assert to catch issue, minimal bandaid (but bandaid seems wrong) 10(7 minutes ago, 3 files, 10+ 4-) 13https://github.com/crawl/crawl/commit/624aa7e99b13 00:48:34 <04C​gettys> There you go 🙂 01:02:32 <04C​gettys> But yeah, that explains the weirdness I saw 01:02:57 <04C​gettys> any monsters generated out of that function, got whatever happened to be on the stack there, so not totally random, but not too far off 😄 03:35:13 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 05:22:29 Unstable branch on crawl.akrasiac.org updated to: 0.33-a0-1377-g1aa8576 (34) 06:20:04 Unstable branch on crawl.develz.org updated to: 0.33-a0-1377-g1aa8576e86 (34) 06:27:03 <06m​umra> @Cgettys Re that PR. Is there a reason it's not possible to initialise the value in the mgen_data constructor? 08:24:30 03hellmonk02 07[reexperience-rebased] * 0.33-a0-1375-gdf31a670de: fix mgen-data 10(37 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/df31a670de21 08:25:33 New branch created: pull/4480 (13 commits) 13https://github.com/crawl/crawl/pull/4480 08:25:33 Branch pull/4480 updated to be equal with reexperience-rebased: 13https://github.com/crawl/crawl/pull/4480 08:27:46 <09h​ellmonk> ??rebuild 08:27:48 <04C​erebot> rebuild[1/2]: Devs can trigger rebuilds for these servers: https://crawl.akrasiac.org/rebuild https://cbro.berotato.org/rebuild https://crawl.dcss.io/rebuild https://archive.nemelex.cards/rebuild Bug gammafunk, advil, or Nap.Kin for CDO. Use your powers wisely. 08:44:23 <04d​racoomega> Well, I seem to have slept through something fun 08:44:42 <04d​racoomega> (I guess it happened on whatever rebasing happened after I looked at the branch, since it seemed fine to me?) 08:45:03 <04d​racoomega> And I was actually testing it in-game 08:46:07 <09h​ellmonk> somehow mgen-data got messed up, the initialization of exp there got deleted leading to undefined behavior 08:46:31 <09h​ellmonk> reverted, pushing fix soon, then need to rebuild it off the servers 08:46:32 <04d​racoomega> Yeah, I've read through the backscroll about it 08:54:53 <09h​ellmonk> ok here we go again! 08:55:12 03Hellmonk02 {GitHub} 07* 0.33-a0-1378-gfa0adff925: Fixed xp overhaul (#4480) 10(26 seconds ago, 611 files, 838+ 677-) 13https://github.com/crawl/crawl/commit/fa0adff9258f 08:55:23 <09g​ammafunk> What about exp_is_mult 08:55:40 <09g​ammafunk> Does it need init to false? 08:55:42 <09h​ellmonk> is that in mgen-data as well? 08:55:50 <09g​ammafunk> Not sure 08:55:56 <09g​ammafunk> Maybe not 08:56:07 <09h​ellmonk> I think that's in the yaml only 08:56:30 <09h​ellmonk> but I will check 08:57:01 <09h​ellmonk> seems to not be in mgen-data 08:57:07 <09h​ellmonk> do you mind rebuilding cbro? 08:57:24 <09h​ellmonk> @napkin0815 can I get a rebuild on CDO? 09:00:45 <09h​ellmonk> need someone to rebuild cbro please, it won't let me do it 09:04:22 <09g​ammafunk> I rebuilt after your earlier revert 09:04:30 <09h​ellmonk> oh, ok 09:04:32 <09g​ammafunk> So cdo should be ok 09:04:33 <09h​ellmonk> no rush then 09:05:02 <09g​ammafunk> I think cbro also didn't get bug? 09:05:35 <09g​ammafunk> Ah it did 09:05:38 <09g​ammafunk> Big rip 09:07:26 <06p​leasingfungus> epic bugs?? 09:07:28 <04C​erebot> if (you.religion = GOD_XOM)... (This bug was later re-implemented as "if (crawl_state.type = GAME_TYPE_CUSTOM_SEED)".) 09:10:42 cgettys/asan> oh good, I've been using it myself but kind of forgot to send you an issue 09:13:58 <09g​ammafunk> !cmd version 09:13:59 <04C​erebot> No command !version 09:14:11 <09g​ammafunk> &versions 09:14:18 <09g​ammafunk> !lm * cbro current alpha x=vlong 09:14:38 <04C​erebot> CAO: 0.33-a0-1377-g1aa8576, CBR2: 0.33-a0-1376-gbf948c632c, CDI: 0.33-a0-1377-g1aa8576e86, CDO: 0.33-a0-1376-gbf948c632c, CNC: 0.33-a0-1377-g1aa8576e86, CPO: 0.33-a0-1377-g1aa8576e86, CUE: 0.33-a0-1374-g31d52f885e, CXC: 0.33-a0-1375-ged448ded6d, LLD: 0.32.1-6-ge8736a44df 09:14:55 <09g​ammafunk> %git bf948c632c 09:14:55 <04C​erebot> Hellmonk {GitHub} * 0.33-a0-1376-gbf948c632c: Specify monster exp values directly (#4474) (11 hours ago, 611 files, 837+ 676-) https://github.com/crawl/crawl/commit/bf948c632cc5 09:15:16 <04C​erebot> No milestones for * (cbro current alpha). 09:15:25 <09g​ammafunk> er 09:15:36 <09g​ammafunk> doesn't matter 09:16:24 <09g​ammafunk> @hellmonk do you have access to the cbr2 rebuild url at https://cbro.berotato.org/rebuild ? If so, I might need you to babysit that and check it like 20 mins from now when the lock expires 09:16:40 <09h​ellmonk> I don't 09:17:03 <09g​ammafunk> either that or maybe you can ping Zureal for a manual intervention. Sadly the cbr2 proxy doesn't work great with the rebuild CGI thing 09:17:20 <09g​ammafunk> you start a rebuild and the output is buffered and browser just stops the connection after a while 09:17:36 <09g​ammafunk> then you have to keep reloading it to resume build, but there's a lock file since the build is ongoing 09:19:53 <04d​racoomega> I can babysit it 09:35:46 Unstable branch on cbro.berotato.org updated to: 0.33-a0-1378-gfa0adff925 (34) 12:08:51 <04C​gettys> It can be yeah. But we probably don't want it to just be zero when it should be something from the yaml 12:25:07 <04C​gettys> @hellmonk - it won't cause nearly so drastic issues (because it'll result in t he monster just havign xp=0 But monster::init_with also doesn't copy over exp (it resets it in monster::reset, bu tnever copies it over). This is used e.g. in the copy constructor 12:25:38 <04C​gettys> maybe that's fine/intended, just making sure you know 13:06:09 <06m​umra> mgen_data isn't generated from yaml. exp is only set there is you're overriding the default xp, for instance vault-defined monsters that have a different xp to their base monster 13:06:44 <06m​umra> (hellmonk seems to have fixed it by setting it to zero in the constructor anyway) 13:13:18 <04C​gettys> Clearly I'm missing something about where the exp value comes from in the normal case then 13:15:29 <09g​ammafunk> direclty from the monsterentry 13:16:33 <09g​ammafunk> yaml -> monsterentry via code generated from yaml 13:16:44 <09g​ammafunk> but maybe a different question is being asked 14:24:32 <04C​gettys> That's what I was missing I think yeah 14:29:01 <04C​gettys> I'm surprised clang didn't warn 14:29:15 <04C​gettys> Maybe because it's a struct? 14:30:53 for whatever reason, clang in CI doesn't catch a nuumber of things that my clang18-on-ubuntu local builds do (e.g. https://github.com/crawl/crawl/issues/4468, which sadly was before this went in) 14:31:55 (the fun happened while I was asleep, so I wouldn't have seen it anyway) 14:33:37 <04C​gettys> https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2024/p2795r5.html Will at least make this predictable instead of whatever is on the stack in c++26... Someday 14:34:27 <04C​gettys> There's also h -ftrivial-auto-var-init=zero but not sure if it would have covered this 15:40:37 Unstable branch on underhound.eu updated to: 0.33-a0-1378-gfa0adff925 (34) 18:05:56 03DracoOmega02 07* 0.33-a0-1379-g26292d7fe4: Allow monsters to cast Launch Clockwork Bee 10(2 days ago, 13 files, 132+ 35-) 13https://github.com/crawl/crawl/commit/26292d7fe488 18:05:56 03DracoOmega02 07* 0.33-a0-1380-gcd0ef4900c: Add monster-castable version of Percussive Tempering 10(2 days ago, 10 files, 110+ 3-) 13https://github.com/crawl/crawl/commit/cd0ef4900c36 18:05:56 03DracoOmega02 07* 0.33-a0-1381-g60505af82c: Monster implementation of Forge Phalanx Beetle 10(8 hours ago, 9 files, 52+ 16-) 13https://github.com/crawl/crawl/commit/60505af82cb9 18:05:56 03DracoOmega02 07* 0.33-a0-1382-g8605e2f772: New monster: Ironbound Mechanists (regret-index) 10(3 hours ago, 12 files, 85+ 13-) 13https://github.com/crawl/crawl/commit/8605e2f7721f 18:05:56 03DracoOmega02 07* 0.33-a0-1383-gf25bf0be4a: New Unique: Sprozz, Inventive Apiarist 10(17 minutes ago, 11 files, 137+ 0-) 13https://github.com/crawl/crawl/commit/f25bf0be4a31 18:05:56 03DracoOmega02 07* 0.33-a0-1384-g4cf1b8d64d: Uncoglin-ify Ijyb 10(12 minutes ago, 2 files, 1+ 4-) 13https://github.com/crawl/crawl/commit/4cf1b8d64da4 18:05:56 03DracoOmega02 07* 0.33-a0-1385-g1d25703c72: Don't have monsters check if they can swap with themselves 10(8 hours ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/1d25703c727a 18:05:56 03DracoOmega02 07* 0.33-a0-1386-ga6f6b54981: Fix grey draconians keeping their +5AC in forms that melded scales (Lici) 10(9 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/a6f6b549813c 18:05:56 03DracoOmega02 07* 0.33-a0-1387-g388da27881: Make some forgecraft allies have better timeout messages than "fades away" 10(8 hours ago, 1 file, 6+ 1-) 13https://github.com/crawl/crawl/commit/388da27881ef 18:28:13 04Build failed for 08master @ 388da278 06https://github.com/crawl/crawl/actions/runs/14435259982 18:30:43 main.o? that's a new one. it's usually species.o 18:31:11 either way, it's a blip 18:34:34 03WizardIke02 {GitHub} 07* 0.33-a0-1388-gf6ac00e180: Fix arrow animation sometimes sticking around to long (#4472) 10(11 seconds ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/f6ac00e180cd 18:46:14 03DracoOmega02 07* 0.33-a0-1389-g53ce29fbc7: Fix monsters being unable to temper Hoarfrost Cannons (regret-index) 10(53 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/53ce29fbc7ae 18:55:48 03WizardIke02 {GitHub} 07* 0.33-a0-1390-gc73dd887b5: Fix a local tiles menu crash (#4453) 10(15 seconds ago, 1 file, 19+ 15-) 13https://github.com/crawl/crawl/commit/c73dd887b5e0 19:00:04 03DracoOmega02 07* 0.33-a0-1391-g562d655eb3: Fix Sprozz being able to use jewellery 10(27 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/562d655eb323 19:43:33 03WizardIke02 {GitHub} 07* 0.33-a0-1392-gf4463b9b3a: Stop at target with damnation if doing so avoids allies (Kab) (#4448) 10(35 seconds ago, 1 file, 40+ 24-) 13https://github.com/crawl/crawl/commit/f4463b9b3ae1 19:45:40 New branch created: pull/4481 (1 commit) 13https://github.com/crawl/crawl/pull/4481 19:45:41 03WizardIke02 07https://github.com/crawl/crawl/pull/4481 * 0.33-a0-1341-gd2b361724e: Fix an invalid comparator being passed to std::sort 10(7 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/d2b361724e84 22:35:29 Unstable branch on crawl.develz.org updated to: 0.33-a0-1392-gf4463b9b3a (34) 22:58:36 Windows builds of master branch on crawl.develz.org updated to: 0.33-a0-1392-gf4463b9b3a 23:35:39 Unstable branch on cbro.berotato.org updated to: 0.33-a0-1392-gf4463b9b3a (34) 23:55:34 Monster database of master branch on crawl.develz.org updated to: 0.33-a0-1392-gf4463b9b3a