00:55:34 Monster database of master branch on crawl.develz.org updated to: 0.33-a0-1133-gf708817d99 03:16:27 Hello ! I would like to contribute to DCSS and have never contributed to any open source software. Is trying to solve any github issue that grab my interest a good way to start ? 03:16:43 (In addition to reading the contributor guide, naturally :) ) 03:23:38 <06mumra> Hi, yes thatis one way, although be aware that github issues are not regularly triaged and there is no guarantee that something is an issue/feature that is actually desirable unless it's a clearly obvious bug/crash, but please ask if you're not sure. Traditionally we have a "beginner" tag for issues that are ready to be picked up and worked on exactly for this situation but nobody has really been keeping up with this. Another easy way to 03:23:39 start contributing is to design vault maps and working on these can be quite a good introduction to how the game works. 03:26:28 Okay ! I'll look into this. Thanks for the suggestion. 03:33:11 <06mumra> This is some helpful reference on that: https://crawl.develz.org/wiki/doku.php?id=dcss:help:maps And plenty of info in the docs in the source repo too 03:58:28 letruta (L24 MiFi) ASSERT(desc) in 'describe.cc' at line 5180 failed. (Crypt:1) 04:33:32 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 05:07:20 Unstable branch on crawl.akrasiac.org updated to: 0.33-a0-1133-gf708817 (34) 08:53:16 Thanks @mumra ! 11:32:47 trollnunna (L5 TrBe) ASSERT(!in_bounds(you.pos()) || !cell_is_solid(you.pos()) || you.wizmode_teleported_into_rock) in 'movement.cc' at line 798 failed. (D:2) 12:11:13 <09gammafunk> still need to make the bridge escape markdown 12:11:34 <09gammafunk> still need to check out that irc bridge geekosaur mentioned a while back, in fact 12:11:42 <12ge0ff> no one can escape markdown! :kobold: 12:11:49 <09gammafunk> so I don't have to code in javascript 😫 12:12:05 <09gammafunk> !say -h 12:12:05 <04Cerebot> usage: !say -h [-c CHANNEL] message positional arguments: message optional arguments: -h, --help show this help message and exit -s SERVER -c CHANNEL 12:12:45 <09gammafunk> !echo || I CAN ESCAPE MARKDOWN JUST FINE, MORTAL! || 12:12:46 <04Cerebot> || I CAN ESCAPE MARKDOWN JUST FINE, MORTAL! || 12:13:11 <09gammafunk> (I was going to do that with !say but then I remembered that doesn't escape markdown) 12:14:25 the real fun part is when people paste code snippets because they get smashed into as few messages as the bridge can, and completely mangled 12:15:09 <09gammafunk> yeah, not sure what an ideal situation for code blocks looks like in terms of a bridge 12:15:32 <09gammafunk> automatic pastebin service for any code block and past the url to irc??? 12:15:52 pastebinning, like my matrix bridge does, but ideally formatting markdown in the paste which heisenbridge sadly doesn't 12:24:35 <02Monkooky> egads, my attempts to seal cerebot away with markdown have failed! 12:55:37 03WizardIke02 {DracoOmega} 07* 0.33-a0-1134-g122d78936f: Fix a crash when casting phantom blitz (Colgate) 10(13 hours ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/122d78936f4b 12:56:42 <04dracoomega> I spent a lot of time trying to track down a seemingly much more cryptic manifestation of this from the original crashlog. Since it was properly calling a method of monster and so it couldn't be doing so on a null object, meaning the 'real' cause of the crash was something else. ...except that apparently it doesn't automatically segfault to call a method on a null object if the method itself doesn't reference member variables of 12:56:42 that object directly. And so I spent over an hour chasing a phantom issue that almost certainly didn't exist (since it stopped being locally reproducible as I put in more debugging statements) 12:58:41 <04dracoomega> (Though I did discover that most methods of monster creation will stop at 697 monsters on the floor instead of the 700 we're supposed to be able to get, though cloning monsters can go beyond that) 12:59:21 <04dracoomega> Since for some reason the general monster placement function is counting ANON_FRIENDLY_MONSTER and YOU_FAULTLESS as real monsters (even though they exist in the array beyond MAX_MONSTERS 12:59:53 <04dracoomega> Probably worth fixing, if only to be less internally confusing, but of exceedingly little practical impact 13:06:42 <09hellmonk> is there a reason the monster limit is 700 13:14:53 <04dracoomega> Not really. Just that all monsters are stored in a fixed-length array (that is repeatedly reused) and some number had to be chosen for its size 13:15:22 <06mumra> > except that apparently it doesn't automatically segfault to call a method on a null object if the method itself doesn't reference member variables of that object directly yes I also reached that conclusion looking at this. since the methods aren't really on the object, they're just static methods being run in the scope of the object. (crashes in a language like javascript or python are quite a bit more sensible in this regard 😂 13:15:22 ) 13:15:23 <04dracoomega> The exact choice of 700 is very old and probably fairly arbitrary 13:15:32 <04dracoomega> "High enough that it doesn't matter" 13:15:40 <04dracoomega> (99.999% of the time, anyway >.>) 13:16:05 <04dracoomega> Yes, the end result of me wasting an 70 minutes on that was to curse C++ once more >.> 13:16:39 <04dracoomega> Like, perhaps I had been mislead by the bug where different methods of monster creation disagree one where the limit is 13:17:00 <04dracoomega> So for a while I had wondered if the high indexes weren't actually safe to use for unclear reasons, but no 14:53:12 Tinttamiau (L6 OnSu) ASSERT(m.alive()) in 'mon-transit.cc' at line 71 failed. (D:4) 15:34:22 <06mumra> today javascript made me waste a lot longer than that tbh and i was probably cursing it even more 😂 15:36:54 <04dracoomega> Every language has its sources of pain, but I do feel like C++'s is much larger than many of them ^^; 15:45:35 New branch created: pull/4406 (1 commit) 13https://github.com/crawl/crawl/pull/4406 15:45:35 03mumra02 07https://github.com/crawl/crawl/pull/4406 * 0.33-a0-1134-g0ad9350c8d: Increasingly re-roll low quality shop items deeper in the dungeon 10(74 seconds ago, 1 file, 147+ 3-) 13https://github.com/crawl/crawl/commit/0ad9350c8dff 15:47:00 <06mumra> For consideration. Possibly not a good idea to merge without a bit of adjustment to the overall number of shops (specifically reducing the huge variance between "too many shops" and "not enough shops") 15:49:58 <04dracoomega> Hmm... that 'shop pricing adjustment' branch still hadn't been merged, had it? 15:50:15 <06mumra> no i think not 15:52:49 <06regret-⸸nde※> (Not entirely sure how I feel about this versus the plan to make Crypt:$ have a high-quality money-sink shop with all of its very long branch-themed items, though I probably would need to wait for said price adjustments and was most likely going to wait for undertakers / bone dragon rework / draugr / death knight rework pieces first anyway.) 15:57:05 <06mumra> the thinking here is that when you get shops later in game, it's just a bit disappointing if half of the inventory is daggers/stones/leather armour (except for specific joke vaults of course). the average number of shops can be brought down a bit if the ones you find are more meaningful. these aren't money-sink shops, it's more just raising the lower end of the quality than making everything amazing quality 15:58:35 <06mumra> bringing down the average number while slightly raising the minimum somehow anyway. i think serial_shops needs looking at, it's what's mainly responsible for games with an extremely high number of shops. it can generate in all kinds of branches (even orc) and multiple times in a game 16:08:55 03mumra02 07https://github.com/crawl/crawl/pull/4406 * 0.33-a0-1135-gb4c3ce4deb: Let vault spec shops still stock trash 10(49 seconds ago, 1 file, 6+ 0-) 13https://github.com/crawl/crawl/commit/b4c3ce4debb0 16:15:38 <09hellmonk> Interesting 16:16:14 <09hellmonk> might be worthwhile to do a bigger item placement rework in tandem with this and the new portal vaults 16:37:58 Unstable branch on underhound.eu updated to: 0.33-a0-1134-g122d78936f (34) 18:04:25 <06mumra> Reworking in what way in particular? 18:06:33 <08nicolae> tbh i'm not sure there's many joke shops that explicitly place low-tier stuff in late-game shops 18:07:27 * geekosaur eyes nicolae suspiciously 18:11:17 <08nicolae> a joke shop that only ever places crap is a joke that's funny once, even ea-nasir occasionally has something you might actually want and isn't late-game anyway 18:52:51 <09hellmonk> To avoid adding more loot as number of portal vaults goes up, might want to cut some of the loot from floor and monsters. I think it might be interesting to push even further in that direction; it risks power spiral but I think the early portals especially give a good exploration incentive so it might be fun to have more of that. 18:53:41 <09hellmonk> I'm also curious if the bane system will open up some cool options for trove or a trove-adjacent portal. 18:54:31 <09hellmonk> More broadly, I'm thinking about timed mechanics as an exploration incentive, but more on the "carrot" side than my last big post about level feelings 20:12:10 03hellmonk02 07* 0.33-a0-1135-g4c332b3a82: Adjust hexagon encompass 10(2 minutes ago, 1 file, 42+ 37-) 13https://github.com/crawl/crawl/commit/4c332b3a82f3 20:40:05 New branch created: pull/4407 (1 commit) 13https://github.com/crawl/crawl/pull/4407 20:40:05 03Cgettys02 07https://github.com/crawl/crawl/pull/4407 * 0.33-a0-1130-g6a4dc9b922: feat: rework packed_cell::add_overlay 10(2 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/6a4dc9b92270 20:41:02 <04Cgettys> geeoksaur: I don't think this is likely to be the problem, but can you try this branch out and tell me if it makes the hitching/lagging go away? https://github.com/crawl/crawl/pull/4407 23:13:23 Unstable branch on cbro.berotato.org updated to: 0.33-a0-1135-g4c332b3a82 (34) 23:35:36 Unstable branch on crawl.develz.org updated to: 0.33-a0-1135-g4c332b3a82 (34) 23:58:58 Windows builds of master branch on crawl.develz.org updated to: 0.33-a0-1135-g4c332b3a82