00:55:33 Monster database of master branch on crawl.develz.org updated to: 0.33-a0-1101-g285c9414cd 04:33:49 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 05:07:06 Unstable branch on crawl.akrasiac.org updated to: 0.33-a0-1101-g285c941 (34) 07:30:41 <13mcursa> trying stoatsoup 07:30:42 <13mcursa> https://cdn.discordapp.com/attachments/747522859361894521/1351563467420733644/image.png?ex=67dad511&is=67d98391&hm=ad1e0f25678f1e59e90afefd5cba1b5793d935ee1ee6be2d7fc0d9a52588a4b7& 09:43:40 404 not found, alas, so er if that's a bug please tell me about it 09:45:39 (oh but maybe it's the thing in Discord PMs in which case thanks) 10:31:37 <06mumra> where's a 404? 11:02:05 Videorelaxant888 (L2 DjCj) ASSERT(you.hp) in 'player.cc' at line 3663 failed. (D:1) 11:33:12 <06mumra> that seems like a slightly silly assert 11:33:19 <06mumra> !crashlog Videorelaxant888 11:33:22 <04Cerebot> 1. Videorelaxant888, XL2 DjCj, T:488 (milestone): https://cbro.berotato.org/morgue/Videorelaxant888/crash-Videorelaxant888-20250318-180157.txt 11:34:58 <06mumra> i think it's searing ray in combination with MUT_HP_CASTING reducing the player to 0hp 11:36:14 <06mumra> oh, and they were targetting themselves with the ray for some reason too 11:37:33 <06mumra> there's no check around pay_mp to check a djinni actually has enough hp so i'm not sure how this hasn't come up loads 11:38:55 <06mumra> i suppose they can't normally cast at all without enough hp, but for channelling spells i think there's no check on the subsequent turns 11:58:37 <04dracoomega> I am pretty sure this is specfically only happening because they are injuring themselves with the same cast 11:59:08 <04dracoomega> I tested otherwise running out of HP via channelled spells when I refactor that earlier in this version (but didn't think to be channelling the spell at yourself) 12:04:39 <06mumra> oh yeah, there's an enough_mp check in handle_channelled_spell before it actually calls handle_searing_ray 12:05:50 <06mumra> it seems you also have to land on exactly zero to trigger the assert, otherwise you'd just die from the blast 12:06:40 <06mumra> the assert should prob be hp>0 rather than !hp 15:34:17 <06mumra> Not sure the best way to fix this ... should the player be prevented from firing it at themselves? Should we just prevent them firing any offense spell at themselves? 15:34:51 <04dracoomega> No. (I mean, it isn't terribly useful to fire searing ray at yourself, but in some rare situations some other spells, like fireball, make sense) 15:35:12 <04dracoomega> And it feels silly to ban it specifically because of a niche djinn situation 15:35:36 <06mumra> So in this situation it should just kill them without crashing really 15:35:38 <04dracoomega> Honestly, looking at this myself now, I am leaning towards removing the assert and just never lowering the player's health below 1 this way 15:36:11 <04dracoomega> (Or kill them, I guess?) 15:36:32 <06mumra> If you deducted the MP cost and then the searing ray damage, they'd be dead 15:37:46 <04dracoomega> I am just slightly worried that it may otherwise be possible (if not now, but in the future) to call pay_mp in a way that would immediately kill a djinn (which seems to be what the assert is maybe trying to catch) 15:38:10 <04dracoomega> And that if we're taking that guard off, then maybe it is fine to just never kill them this way. It's a more player-friendly sort of fail state. 15:38:12 <06mumra> Damage sharing could also trigger this 15:38:24 <04dracoomega> What do you mean? 15:39:03 <06mumra> Actually no that's a fineff and won't reduce below 1hp 15:39:45 <06mumra> i meant deferred_damage_fineff 15:41:26 <04dracoomega> I don't think there's any way that is ever used for damage directed at a player 15:41:47 <04dracoomega> Oh, oops 15:41:50 <04dracoomega> Spectral weapons. My bad. 15:42:05 <06mumra> Yeah the code definitely has a path for is_player 15:42:06 <04dracoomega> (But yes, that's explicitly non-fatal, regardless) 15:43:37 <04dracoomega> Like, pay_mp also being non-fatal here means that technically if a djinn fireballs themselves, they will take potentially a couple of points less damage from it if that would be the difference between living and dying. I'm not sure that matters? Even if it is a bit weird. 15:44:06 <06mumra> It's funny, I was just testing this locally, and got the crash first time, even though it literally has to land exactly on zero to work 15:44:56 <06mumra> But if the ray damage already takes you to zero or negative, you just die 15:46:29 <06mumra> (Another bug, you have to confirm twice if you really want to aim at yourself) 15:50:24 <06mumra> It definitely doesn't seem like it matters ... but if the player is actively trying to damage themselves then it's already a risk that they're taking so it also seems fair that they'd die 15:51:05 <04dracoomega> I mean, I am fine with them dying in this case. It's more like "Is this the only situation where we'd accidentally call pay_mp for more than their health?" Maybe it is! 15:52:59 <06mumra> In all other cases currently it's behind some check that they had enough hp, however it'd be easy enough for someone to miss this by accident on some new spell, especially as that check is a few functions removed from the pay_mp call in several cases 16:11:26 03DracoOmega02 07* 0.33-a0-1102-g36a277cbe7: Fix Nobody sometimes immediately losing their new spells (cool3) 10(86 minutes ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/36a277cbe722 16:11:26 03DracoOmega02 07* 0.33-a0-1103-g3a960af9c8: Don't give Trickster AC for debuffs applied TO friendlies (particleface) 10(84 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/3a960af9c80e 16:11:26 03DracoOmega02 07* 0.33-a0-1104-gf5e40d3f22: Buff Nobody a little 10(56 minutes ago, 3 files, 22+ 10-) 13https://github.com/crawl/crawl/commit/f5e40d3f22aa 16:11:26 03DracoOmega02 07* 0.33-a0-1105-g85c0d3feac: Fix a Nobody / phantom mirror crash 10(44 minutes ago, 1 file, 7+ 2-) 13https://github.com/crawl/crawl/commit/85c0d3feac16 17:00:16 03mumra02 07* 0.33-a0-1106-gd685d6802f: Fix some Deep Elf tile offsets 10(57 seconds ago, 1 file, 40+ 23-) 13https://github.com/crawl/crawl/commit/d685d6802fc1 17:02:32 <06mumra> How did nobody notice this for seven years 😂 17:08:31 c84e800f13c701249b42b7bd0b973ebb697477b0 broke the rolling boulder beetle traps in 2012 and they made it to 2016 before removal... 17:48:17 <04Cgettys> Cause we don't have an easy way to visualize all the offsets? 17:48:24 <04Cgettys> or we do, but almost nobody uses it? 18:13:10 <06pleasingfungus> we do?! 18:37:20 <04Cgettys> worded poorly 18:37:31 <04Cgettys> fixed 18:37:32 <04Cgettys> Sure, it's called wizard mode, and it's not all that easy 😄 18:38:35 <04Cgettys> But what I was actually trying tos ay is "it's entirely possible it exists outside my limited knowledge" 20:27:33 <06mumra> Sure but it was actually crazy obvious if anyone looked closely at an elf wielding a weapon 20:29:18 <06mumra> once i saw it i couldn't unsee 20:33:39 <06mumra> i think orcs may suffer a similar issue 21:38:18 <04Cgettys> Bug? 21:38:26 <04Cgettys> Spatial malevolence can move you even w/ mountain boots on 21:44:20 <06pleasingfungus> ??mountain boots 21:44:21 <04Cerebot> mountain boots[1/1]: Unrand +3 boots of rC+ that prevent unwilling physical movement. This includes trampling, harpooning, shafting, sirening, and some other stuff. New in 0.29. 21:44:29 <06pleasingfungus> spatial malevolence? 21:44:51 <06pleasingfungus> my intuition is that would be magical (not physical), and hence not blocked by mountain boots 21:44:54 <06pleasingfungus> but i'm not sure what it is 21:50:21 <09hellmonk> do they prevent dispersal dart blink 21:50:45 <09hellmonk> assume they don't but idk what the list looks like 21:54:27 <04Cgettys> It's supposed to block magic 21:55:12 <04Cgettys> https://cdn.discordapp.com/attachments/747522859361894521/1351781027441283092/image.png?ex=67db9faf&is=67da4e2f&hm=34236d12e6291c085298f65bbb6f11e609545bb966b1ee1e60217a880dee08e4& 21:55:19 <04Cgettys> I guess maybe it counts as "teleportation" 21:55:29 <04Cgettys> but I though t that was as in "if you read scroll still works" 21:57:17 <09hellmonk> hmm, do we have a function for increase duration that's in aut instead of turns 21:59:20 <09hellmonk> I guess I can just set it directly 22:04:00 <09hellmonk> ok, this spell is ready other than the part where I have to refactor ignition so as to not duplicate 40 lines of code 22:04:44 <06dolorous_84348> Quick question: Since Okawaru is now blocked from gifting reaping weapons, should they be blocked from gifting the Skull of Zonguldrok as well (since it's reaping armour)? On the one hand, the skull's main offensive capability of reaping won't work under Okawaru, but on the other hand, the extra hat slot the skull grants might be useful in other capacities. 22:07:25 03dolorous02 07* 0.33-a0-1107-g3039f5625e: Fix comment typo. 10(8 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/3039f5625e27 23:14:07 Unstable branch on cbro.berotato.org updated to: 0.33-a0-1107-g3039f5625e (34) 23:35:28 Unstable branch on crawl.develz.org updated to: 0.33-a0-1107-g3039f5625e (34) 23:58:49 Windows builds of master branch on crawl.develz.org updated to: 0.33-a0-1107-g3039f5625e