00:03:16 Unstable branch on cbro.berotato.org updated to: 0.33-a0-1066-gd3ab83ea69 (34) 00:55:33 Monster database of master branch on crawl.develz.org updated to: 0.33-a0-1066-gd3ab83ea69 04:34:39 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 05:05:09 <12g​e0ff> Tried the wasm port for 10 min, and there's only one way to describe the experience: 🙀. It's amazing! It even feels more responsive than playing on a webtiles server with ~90ms ping. 05:07:30 Unstable branch on crawl.akrasiac.org updated to: 0.33-a0-1066-gd3ab83e (34) 05:18:07 <12g​e0ff> Also, having a copy of the message log in the dev console kinda fixes the local tile's problem of being unable to copy game messages to the clipboard. It'd be ideal if the dungeon view were rendered via wasm, but the rest of the ui (the message log, all the stats, monster list, maybe minimap too?) were done in js. 05:27:20 <06m​umra> That's awesome! Obviously there's zero latency in your keypress being sent or receiving the response since there's no server roundtrip involved. I think with 90ms latency on webtiles you actually suffer 180ms because responses are sent as separate messages, plus your wait for the game engine to handle things, and possibly plus some cost for sending updates to spectators. (Sorry if anyone misunderstood that this is not a client/server 05:27:20 thing yet, it's just full desktop build running directly in the browser right now) 05:29:18 <06m​umra> Really it should be possible to improve webtiles latency as I've discussed a bit but it's a slightly tangential issue. 05:29:50 <06m​umra> Certainly once I removed travel and rest delays in this build it's really snappy (with the default settings it was definitely pretty sluggish) 05:33:46 <06m​umra> It'd definitely be possible to do this; there is already a React UI that renders the loading spinner and is interacting with the wasm module. At the same time the aim here is to avoid a maintenance issue. What could work is to just push font rendering over to the browser, we could be rendering the deja vu font in absolute divs and the game engine controls where to place them. So it'd be fully automatic and not require reimplementing 05:33:47 every dialogue (would also likely be more performant letting the browser handle this, browsers are really good at text rendering, we could maybe remove freetype from the build then as well). 05:35:05 <06m​umra> (I'm not sure why webtiles doesn't use Deja Vu already tbh; probably predates browsers having robust support for webfonts, but would be a quick win to get webtiles looking a bit more like desktop) 05:35:45 <06m​umra> Rendering fonts in the browser would be good for a11y too 05:37:01 <06m​umra> (For editing your crawlrc I was going to pop up a React overlay at least) 05:39:38 <06m​umra> (Btw the message log in the console I initially did just to debug stuff when I was still having rendering issues, but yeah I like it so left it there. Am thinking for a DEBUG build the debug messages could just go in the console, so the main message window stays clean but you can still access all the debug stuff) 06:54:28 03DracoOmega02 07* 0.33-a0-1067-g9575c84de6: Let antimagic weapons work for Trickster (not_that_greg) 10(58 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/9575c84de6c3 07:36:20 i would _love_ to get webtiles running and get into a feedback loop where i can ... work on things 07:36:52 but i do not spend hte effort 10:18:28 I finally won a vampire wohoo https://jmp.sh/s/ADRBIImnmi5ZKecF21CB 11:00:56 -!- The topic of #crawl-dev is: Crawl Development | https://github.com/crawl/crawl | Logs: http://s-z.org/crawl-dev/, temporarily http://crawl.akrasiac.org/logs/cheibriados/ | People with +v have commit access, devs on bridged discord as well | General Crawl-related chat to #crawl | Long stuff to a pastebin service, please 11:00:56 -!- The topic of #crawl is: Play Dungeon Crawl Stone Soup online now! Type ??online for instructions, ??lg / !lg for play stats | PM Sequell for long queries | http://crawl.develz.org | FooTV game replays: ??footv for instructions | #crawl-dev for dev discussion, #crawl-offtopic for offtopic 11:23:08 'SUMMARY: AddressSanitizer: 212252 byte(s) leaked in 1438 allocations.' if I can reproduce this sort of memory leak in vanilla, do you care enough for a github issue? 11:47:32 <06m​umra> Memory leaks are generally a good idea to look into 11:49:54 I'll see what I can do 13:57:23 Definitely would be interested in looking into leaks, yeah 14:00:51 <12g​e0ff> @gammafunk, it's no longer possible to search for traps after this commit. Traps like shafts, tele and alarm traps are not boring features! 14:05:17 <12g​e0ff> (and you can't search for free xp traps, i mean pressure plate traps, too!) 14:34:37 Pinkbeast: I've repro'd some of thse locally 14:34:47 The SkillMenu is definitely leaking a fair bit 14:35:23 cgettys: I'll maybe hang fire and see if some commits come through before looking. 15:12:05 03Aliscans02 {GitHub} 07* 0.33-a0-1068-g4f4ccd14fd: Dead lemures give no thanks. (#3964) 10(23 seconds ago, 2 files, 34+ 29-) 13https://github.com/crawl/crawl/commit/4f4ccd14fd86 16:10:50 <09h​ellmonk> looking at this monster -cast gear pr and I think this should go earlier in mon-act 16:11:00 <09h​ellmonk> possibly in _mons_take_special_action 16:18:56 <09g​ammafunk> we're down to 103, hellmonk 16:18:59 <09g​ammafunk> sub 100 soon 16:19:18 <09g​ammafunk> I can get one or two tonight, but they'll be small ones probably 16:19:33 <09g​ammafunk> I think there's a lot of ancient ones that are essentially low-hanging fruit in terms of closure 16:19:48 <09h​ellmonk> gonna review the nicloae vaults vaults pr and then maybe close down some old stuff 16:20:09 <09h​ellmonk> what's your opinion on the monster -cast stuff 16:20:24 <09g​ammafunk> oh, my rule for dev prs was to let the dev deal with it, but it's true that nicolae does want vault reviews 16:20:27 <09g​ammafunk> let me see about -cast 16:20:34 <09h​ellmonk> I agree w/ mumra's comment that just not generating spellcasters with -cast is ideal, but that seems hard 16:20:55 <09g​ammafunk> well, that and monsters also pick up items 16:21:03 <09g​ammafunk> although I guess they could refuse to pick up a -cast one 16:22:16 <09h​ellmonk> spellcasters already do this 16:22:34 <09h​ellmonk> or at least, are supposed to 16:22:56 <09g​ammafunk> I see; isn't there already code for monsters who check if an item is useful and if so they refuse it? 16:23:01 <09g​ammafunk> I guess the problem there is one of generation 16:23:12 <09g​ammafunk> they'll just get a -cast generated and then drop it without a reroll? 16:23:46 <09h​ellmonk> I don't think we have any way to prohibit artifact properties from monster starting gear currently 16:24:06 <09g​ammafunk> well, we do have fixedprops now 16:24:28 <09g​ammafunk> and for that code, any prop you specify as 0 is always not added to a randart 16:24:46 <09g​ammafunk> it is a bit of a hack to use that code in this way, but it could definitely work 16:24:55 <09g​ammafunk> and the item would get rerolled 16:25:04 <09h​ellmonk> I'm unfamiliar with this code but I can take a look 16:25:13 <09g​ammafunk> it's new in 0.33-a, yeah 16:25:27 <09g​ammafunk> you can see it being used in uh...mapdef.cc? 16:26:02 <09g​ammafunk> I'm not sure if using this would have any knock-on effects 16:28:11 <04d​racoomega> Like the last time this came up, in theory, I liked the idea of replacing the -Cast randart property with something else entirely (even just *-Cast would probably be an improvement, tbh) which would coincidentally also be okay for monsters to worry less about. Honestly, even if it literally couldn't trigger for monsters, I doubt any player would notice (since *Slow and such very unlikely to do so anyway) 16:29:35 <09h​ellmonk> what about *silence 16:30:02 <09h​ellmonk> (replacing the property also seems fine to me) 16:31:39 <04d​racoomega> *Silence is more interesting 16:31:56 <04d​racoomega> And applies to more characters. (And is sometimes positive, even, cutely) 16:32:09 <09h​ellmonk> I can probably get that working without too much trouble 16:32:19 03DracoOmega02 07* 0.33-a0-1069-g13e890bdef: Fix Enkindle description (Patrick2011b) 10(87 seconds ago, 1 file, 5+ 5-) 13https://github.com/crawl/crawl/commit/13e890bdef73 16:34:08 <09h​ellmonk> hmm, but do we change maxwell's funny platemail 16:36:40 <04d​racoomega> I feel like the only unrandart that ought to actually keep -Cast is Mad Mages Maulers, really 16:38:22 <09h​ellmonk> is it possible for a monster to generate wearing those? Don't remember if any uniques start with gloves 16:39:30 <04d​racoomega> Nikola 16:39:57 Unstable branch on underhound.eu updated to: 0.33-a0-1068-g4f4ccd14fd (34) 16:40:13 <04d​racoomega> (I am not sure if it's possible for them to get upgraded or not? Can everything technically?) 16:40:45 <04d​racoomega> Honestly, I feel like if some unique spawns with those specifically, we probably don't need to prevent anything 16:41:01 <04d​racoomega> Nikola just decided that this day, he was the mad mage 16:41:13 <04d​racoomega> It might happen to a single person in the entire lifetime of Crawl 16:41:30 <04d​racoomega> (But -Cast robes on, say, Boris are actually fairly common) 16:42:59 <09h​ellmonk> alright, but when it happens and there's a new bug report opened, I will make a funny joke about this conversation 16:44:02 <04d​racoomega> Haha 16:44:07 <04d​racoomega> I am prepared 19:00:26 <09h​ellmonk> hmm, tried to add the new prop to art-data.pl but I'm still off by 1 when generating unrands 19:49:33 New branch created: asterisksilence (1 commit) 13https://github.com/crawl/crawl/tree/asterisksilence 19:49:34 03hellmonk02 07[asterisksilence] * 0.33-a0-1070-g46ef554695: Replace -Cast with *Silence 10(8 minutes ago, 14 files, 72+ 13-) 13https://github.com/crawl/crawl/commit/46ef554695dd 19:50:40 New branch created: pull/4359 (1 commit) 13https://github.com/crawl/crawl/pull/4359 19:50:40 Branch pull/4359 updated to be equal with asterisksilence: 13https://github.com/crawl/crawl/pull/4359 19:50:41 <09h​ellmonk> for your viewing pleasure 20:00:39 <09h​ellmonk> closing this pr but I think the core concept is Cool and someone should do something with it 20:01:11 <09h​ellmonk> maybe a different slow projectile variation than just "weaker ood" idk 20:08:02 New branch created: pull/4360 (13 commits) 13https://github.com/crawl/crawl/pull/4360 20:08:16 03Cgettys02 07https://github.com/crawl/crawl/pull/4360 * 0.33-a0-1070-g28a43efbee: Make it easier to enable ASAN 10(6 hours ago, 1 file, 5+ 0-) 13https://github.com/crawl/crawl/commit/28a43efbee21 20:08:16 03Cgettys02 07https://github.com/crawl/crawl/pull/4360 * 0.33-a0-1071-g9b0e7b9f9f: Fix a use after scope 10(6 hours ago, 1 file, 9+ 2-) 13https://github.com/crawl/crawl/commit/9b0e7b9f9f03 20:08:16 03Cgettys02 07https://github.com/crawl/crawl/pull/4360 * 0.33-a0-1072-ge57f12610b: Identify leaks 10(5 hours ago, 4 files, 15+ 2-) 13https://github.com/crawl/crawl/commit/e57f12610bfb 20:08:16 03Cgettys02 07https://github.com/crawl/crawl/pull/4360 * 0.33-a0-1073-ge110b92e03: Shrink MenuItem by about 8 bytes 10(5 hours ago, 1 file, 8+ 8-) 13https://github.com/crawl/crawl/commit/e110b92e0308 20:08:16 03Cgettys02 07https://github.com/crawl/crawl/pull/4360 * 0.33-a0-1074-g5e411c3049: Shrink MenuItem by 32 bytes by removing unused field 10(5 hours ago, 2 files, 0+ 5-) 13https://github.com/crawl/crawl/commit/5e411c304947 20:08:16 03Cgettys02 07https://github.com/crawl/crawl/pull/4360 * 0.33-a0-1075-g0c674b4710: Fix order of init to suppress warning, also back out bitfield as reference is taken 10(5 hours ago, 2 files, 9+ 8-) 13https://github.com/crawl/crawl/commit/0c674b4710e4 20:08:16 03Cgettys02 07https://github.com/crawl/crawl/pull/4360 * 0.33-a0-1076-g1caa13c890: more TODO 10(5 hours ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/1caa13c8908a 20:08:16 03Cgettys02 07https://github.com/crawl/crawl/pull/4360 * 0.33-a0-1077-g3b47099074: Overhaul menus 10(4 hours ago, 12 files, 118+ 111-) 13https://github.com/crawl/crawl/commit/3b4709907410 20:08:16 03Cgettys02 07https://github.com/crawl/crawl/pull/4360 * 0.33-a0-1078-gf0cfa8e10e: Overhaul menus part 2 10(4 hours ago, 8 files, 41+ 42-) 13https://github.com/crawl/crawl/commit/f0cfa8e10e0c 20:08:16 03Cgettys02 07https://github.com/crawl/crawl/pull/4360 * 0.33-a0-1079-gc6fdeb9313: Overhaul menus part 3 10(33 minutes ago, 10 files, 92+ 93-) 13https://github.com/crawl/crawl/commit/c6fdeb931358 20:08:16 ... and 3 more commits 20:29:14 This needs some more work, I may need to make a lot of these unique_ptr shared_ptr instead 20:29:18 but it's a start 20:29:59 PinkBeast: I haven't touched it much, but there's a branch that at least identifies most of them and fixes some 20:38:21 *I haven't tested it much rather 20:55:46 <09h​ellmonk> Does anyone have an opinion on #4096 21:33:39 03Hellmonk02 {GitHub} 07https://github.com/crawl/crawl/pull/3695 * 0.33-a0-1072-g1ff0c9ba6f: Merge branch 'master' into aux-lash-fix 10(10 seconds ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/1ff0c9ba6f83 21:53:14 03SentientSupper02 {GitHub} 07* 0.33-a0-1070-g34610d1a4b: Allow aux attacks to receive lash bonuses (#3695) 10(57 seconds ago, 2 files, 6+ 4-) 13https://github.com/crawl/crawl/commit/34610d1a4b6b 21:53:14 03hellmonk02 07* 0.33-a0-1071-g5af9d733ea: checkwhite 10(31 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/5af9d733ea01 22:01:58 I feel like 4096 might be better done additively 22:02:32 like, a oni who is mechanically v similar to Erolcha 22:02:35 cool, more flavor 22:03:01 but I'm not sure how the new flavor is better than the old flavor? 22:03:34 Idk, ambivalent personally 22:08:50 04Build failed for 08master @ 34610d1a 06https://github.com/crawl/crawl/actions/runs/13757117527 22:09:20 that's just the pre-checkwhite one 23:13:42 Unstable branch on cbro.berotato.org updated to: 0.33-a0-1071-g5af9d733ea (34) 23:35:40 Unstable branch on crawl.develz.org updated to: 0.33-a0-1071-g5af9d733ea (34) 23:55:19 Cindrix (L3 DECj) ASSERT(!you.turn_is_over) in 'state.cc' at line 199 failed. (D:1) 23:59:26 Windows builds of master branch on crawl.develz.org updated to: 0.33-a0-1071-g5af9d733ea