00:06:34 New branch created: crabclaws (1 commit) 13https://github.com/crawl/crawl/tree/crabclaws 00:06:35 03hellmonk02 07[crabclaws] * 0.33-a0-1052-g56bf31a7a9: Updated ghost crab claws unrand. 10(7 minutes ago, 8 files, 54+ 1-) 13https://github.com/crawl/crawl/commit/56bf31a7a955 00:07:09 <09h​ellmonk> thanks again for reworking equipment slots so making items like this isn't awful 00:07:41 New branch created: pull/4350 (1 commit) 13https://github.com/crawl/crawl/pull/4350 00:07:41 Branch pull/4350 updated to be equal with crabclaws: 13https://github.com/crawl/crawl/pull/4350 00:09:19 <04d​racoomega> My pleasure! ^^ 00:10:29 <04d​racoomega> (Cute item) 00:11:28 <09h​ellmonk> sometimes "work on prs" can mean "look at a 3 year old unrand pr and try to reimplement it" 00:11:40 <09h​ellmonk> now it is 1am and I need to sleep 00:11:45 <09h​ellmonk> sadge 00:12:19 <04d​racoomega> The woes of a physical form 00:12:31 <04d​racoomega> Night! 00:23:54 Unstable branch on cbro.berotato.org updated to: 0.33-a0-1053-gd93d3284e2 (34) 00:45:18 Monster database of master branch on crawl.develz.org updated to: 0.33-a0-1024-g4ee2c7fec9 01:08:36 <03w​heals> i think that comment is now talking about Summon Forest 01:09:12 <04d​racoomega> Oh, oops, you're right. 01:09:56 <04d​racoomega> However, I don't think that's correct, either 01:12:27 <04d​racoomega> (Funnily enough, it looks like Summon Forest uses the malign gateway placement code to find out where to optionally place a pond of water, but the spell itself affects your whole LoS and only cares about the player not being adjacent to any walls) 01:57:54 <06m​umra> Ovaloid is a word by itself, so I don't think trapezoid/trapezium matters in this context 02:38:37 @gammafunk: not sure if anyone already mentioned it, but CDI daily trunk builds seem to be broken again. 02:45:08 <04d​racoomega> CDI looks up to date to me 02:45:20 <04d​racoomega> (Also: it rebuilds much more often than daily) 02:45:31 <04d​racoomega> But it seems to have the most recent trunk updates right now 02:46:06 <04d​racoomega> CAO, on the other hand, now that you mention it... 03:18:02 @dracoomega: not online, but offline windows builds :) The ones that appear in this channel as this message: "23:59:04 Windows builds of master branch on crawl.develz.org updated to: 0.33-a0-1024-g4ee2c7fec9" and are then available for download here: https://crawl.develz.org/trunk/ 03:18:37 <04d​racoomega> (That's CDO, not CDI) 03:18:51 ah yeah sorry, mixed those up 03:19:03 <04d​racoomega> But it does seem to also be behind for some reason, yes 03:20:30 usually in the past there was something specific in a commit that broke these builds, the CDO toolchain is probably weird/outdated in some ways, so this happens a few times a year. 03:29:18 <04d​racoomega> Yeah, I do recall this happening periodically for unclear reasons. (Alas, it's out of my hands to fix it) 04:35:11 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 04:54:08 <09g​ammafunk> %git 04:54:09 <04C​erebot> WizardIke {GitHub} * 0.33-a0-1053-gd93d3284e2: Simplify malign gateway targeting (#4045) (7 hours ago, 5 files, 99+ 14-) https://github.com/crawl/crawl/commit/d93d3284e220 05:00:38 <09g​ammafunk> oh, this is somethign weird with cdo's repo, it seems 05:00:42 <09g​ammafunk> will have to investigate more later 05:47:18 03DracoOmega02 07* 0.33-a0-1054-gdb6124fe53: Fix a small bug with fishtail/multislot boot items 10(19 minutes ago, 1 file, 7+ 6-) 13https://github.com/crawl/crawl/commit/db6124fe5339 05:47:18 03DracoOmega02 07* 0.33-a0-1055-g86570bf2c2: Don't print superfluous messages when merfolk change forms in water 10(17 minutes ago, 2 files, 14+ 4-) 13https://github.com/crawl/crawl/commit/86570bf2c277 05:47:18 03DracoOmega02 07* 0.33-a0-1056-gdcb4e7fafb: Remove salmon 10(10 minutes ago, 2 files, 2+ 2-) 13https://github.com/crawl/crawl/commit/dcb4e7fafb02 06:28:11 <06d​olorous_84348> Good to know. 08:47:15 Good Morning -- I'm handling some of the Crawl Cosplay Tournament community/communications logistics for Rogga and we wanted to see if we can get 100% server coverage for it, which would include CAO. I was advised by the dev listed as the contact for CAO (advil) that he doesn't manage it anymore -- rather, it's a devteam server. Since this is the 08:47:16 only listed collective devteam contact method, I'm following up here to see if we can coordinate on getting the tourney advertised there. 08:57:54 <12g​e0ff> %git 3de618130a 08:57:56 <04C​erebot> DracoOmega * 0.33-a0-877-g3de618130a: Fix bits of monster weapons visibly trailing behind in webtiles (5 weeks ago, 2 files, 16+ 0-) https://github.com/crawl/crawl/commit/3de618130a55 08:58:03 <12g​e0ff> Most (all?) graphical webtiles glitches were fixed about a month ago. I haven't seen any "weapon trail" or other glitches since. 09:00:47 <12g​e0ff> (well, there's the "sensed monster" thing, when the list of monsters shows something when there's no monsters around, but it feels more like an Ash bug than a webtiles bug) 09:38:16 <04d​racoomega> I believe there are still (much rarer) issues with webtiles sometimes not clearing away monsters that have died or moved, leaving a 'ghost' in place (that looks like a normal monster, but is purely visual). Likewise to do with cached stuff not updating properly. It happens so rarely that it's hard to track down why, though. (And there's also been some even weirder issues like it rendering the wrong floor entirely sometimes? I feel 09:38:17 at one point it was mainly Firefox on Linux, and 'solved' by disabling hardware accelleration, so it's hard to know exactly what part of that is our fault an what part might be someone else's) 10:34:45 03Isaac Clancy02 {gammafunk} 07* 0.33-a0-1057-gb0cd332cd7: Fix a crash when initializing Nobody's memories 10(6 days ago, 1 file, 1+ 2-) 13https://github.com/crawl/crawl/commit/b0cd332cd7a5 10:43:29 03gammafunk02 07* 0.33-a0-1058-g875e6274b3: Add WizardIke to the mailmap 10(23 seconds ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/875e6274b3c2 12:05:19 <06m​umra> Wondering if it's possible that a very occasional update packet gets lost or malformed ... shouldn't really happen with websockets but these are very old library versions 12:07:43 <04d​racoomega> That's quite out of my wheelhouse, I'm afraid. (I've never really tried to track the problem down, but that seems very hard with how rare it is.) 12:08:05 <04d​racoomega> Since it's not something you can use a save file for, either 12:12:21 <06m​umra> No ... if I could inspect a browser immediately after the issue happened, there might be a clue in the websocket messages history 12:17:14 <06m​umra> (If I forged further ahead with emscripten webtiles, the issue would maybe resolve itself anyway ... but realistically there's a lot to do to get it all working so it's a longer term project) 13:05:41 Unstable branch on crawl.develz.org updated to: 0.33-a0-1058-g875e6274b3 (34) 16:40:16 Unstable branch on underhound.eu updated to: 0.33-a0-1058-g875e6274b3 (34) 17:00:24 <09g​ammafunk> We fixed the repo update on CDO earlier today, and the trunk builds are now updated, thanks for the report! 17:47:38 <09g​ammafunk> oh 17:47:48 <09g​ammafunk> I just realized I meant to do that in roguelikes discord 17:49:12 <09g​ammafunk> also, is CAO out of date or something? 17:49:19 <09g​ammafunk> !cmd &version 17:49:19 <04C​erebot> Command: &version => .echo ${*:-*}: $(=version.query $*) 17:49:46 <09g​ammafunk> &version * cao current alpha 17:49:50 <04C​erebot> * cao current alpha: 0.33-a0-945-gd2bf43c 17:49:54 <09g​ammafunk> uh oh 17:50:01 <09g​ammafunk> let me go take a look at that 17:51:41 <09g​ammafunk> make[1]: Leaving directory `/home/crawl-dev/dgamelaunch-config/crawl-build/crawl-git-repository/crawl-ref/source/rltiles' CXX ability.o In file included from tilecell.h:4:0, from viewgeom.h:3, from view.h:13, from directn.h:16, from ability.cc:32: map-cell.h: In member function 'map_cell& map_cell::operator=(map_cell&&)': map-cell.h:81:8: error: invalid 17:51:41 conversion from 'unsigned char' to 'dungeon_feature_type' [-fpermissive] map-cell.h:81:8: error: invalid conversion from 'unsigned char' to 'trap_type' [-fpermissive] map-cell.h: At global scope: map-cell.h:81:8: warning: unused parameter 'o' [-Wunused-parameter] map-cell.h: In member function 'void map_cell::clear()': map-cell.h:134:26: note: synthesized method 'map_cell& map_cell::operator=(map_cell&&)' first required here ability.cc: In constructor 17:51:42 'scaling_cost::scaling_cost(int, int)': ability.cc:133:9: warning: declaration of 'fixed' shadows a member of 'this' [-Wshadow] At global scope: cc1plus: warning: unrecognized command line option "-Wno-implicit-fallthrough" [enabled by default] make: *** [ability.o] Error 1 make: Leaving directory `/home/crawl-dev/dgamelaunch-config/crawl-build/crawl-git-repository/crawl-ref/source' 18:15:52 <09g​ammafunk> looking at the header, it's not immediately clear what's going wrong according to this version of gcc 18:16:59 <09g​ammafunk> presumably it doesn't like this new definition of the (non-const) assignment operator that's just default 18:40:20 <09g​ammafunk> diff diff --git a/crawl-ref/source/map-cell.h b/crawl-ref/source/map-cell.h index 35b2690374..33bac31381 100644 --- a/crawl-ref/source/map-cell.h +++ b/crawl-ref/source/map-cell.h @@ -114,7 +114,19 @@ struct map_cell // move constructor map_cell(map_cell&& o) noexcept = default; // move assignment - map_cell& operator=(map_cell&& o) = default; +// map_cell& operator=(map_cell&& o) = default; + map_cell& 18:40:20 operator=(map_cell&& o) noexcept + { + flags = o.flags; + _feat = o._feat; + _feat_colour = o._feat_colour; + _trap = o._trap; + _cloud = std::move(o._cloud); + _item = std::move(o._item); + _mons = std::move(o._mons); + return *this; + } + 18:40:35 <09g​ammafunk> so reverting this particular change did in fact allow it to compile on CAO 18:41:16 <09g​ammafunk> (ignore the added commented out line, this is just the git diff) 18:41:50 <09g​ammafunk> I'm not sure why the default move assignment implementation would cause a type mismatch of those members 18:44:30 <09g​ammafunk> @wheals any idea why this would be happening? the compilation error on CAO was created by ec844b119431a4cabd5d559dffcbcc40fea5bcd4 18:44:33 <09g​ammafunk> %git ec844b119431a4cabd5d559dffcbcc40fea5bcd4 18:44:34 <04C​erebot> wheals * 0.33-a0-954-gec844b1194: Simplify map_cell definition (2 weeks ago, 1 file, 9+ 34-) https://github.com/crawl/crawl/commit/ec844b119431 18:45:04 <09g​ammafunk> obviously I can revert the move implementation back to the previous one, but I'm not sure why the default implementation is causing a problem 18:52:30 03dolorous02 07* 0.33-a0-1059-geb0194f0d2: Remove unused variable (#4351). 10(7 minutes ago, 1 file, 0+ 1-) 13https://github.com/crawl/crawl/commit/eb0194f0d28e 20:15:54 03gammafunk02 07* 0.33-a0-1060-g22bb8dc075: Fix compilation on older versions of gcc 10(4 minutes ago, 1 file, 13+ 1-) 13https://github.com/crawl/crawl/commit/22bb8dc075be 23:21:25 <03w​heals> how odd, the docs do claim that 4.7 fully supported default ctors but i guess it was buggy at first https://gcc.gnu.org/gcc-4.7/cxx0x_status.html 23:22:31 <09g​ammafunk> yeah, I guess the other defaulted methods worked fine? 23:22:35 <09g​ammafunk> in that class, at least 23:34:33 Unstable branch on crawl.develz.org updated to: 0.33-a0-1060-g22bb8dc075 (34) 23:51:48 Sign, old compiler gotta old compile 23:52:55 sorry about that one @wheals, I think I tempted you into that cleanup PR with my pr that removed the nasty UB 23:56:44 Windows builds of master branch on crawl.develz.org updated to: 0.33-a0-1060-g22bb8dc075