00:34:40 Unstable branch on cbro.berotato.org updated to: 0.33-a0-960-g11643a3c80 (34) 00:49:14 03dolorous02 07* 0.33-a0-961-gec4e1d79e0: Fix typo. 10(59 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/ec4e1d79e0b6 00:55:45 Monster database of master branch on crawl.develz.org updated to: 0.33-a0-960-g11643a3c80 01:45:54 <04dracoomega> I've been going around try to fix up debuffs that aren't properly attributed to the player (for poltergeist trickster bonus) and in the process needing to refactor some of how corrosion is applied to monsters. And... this has been a surprisingly tangled rabbithole for something seemingly simple 01:48:06 <04dracoomega> Even outside of the fact that we have actor::corrode_equipment(), actor::acid_corrode() and actor::splash_with_acid(), some of them check res_acid() and some res_corrode() which actually are not always the same for monsters! (And then there's the binomial chance calls that are often just a really weird way to say coinflip(), and things calling monster::acid_corrode() directly with paramters that are ignored >.> 01:49:00 <04dracoomega> (One consequence of this is that while the resistance buff reduces damage a monster takes from acid, it does not reduce corrosion chance from many sources - though it does for some of them) 01:51:58 <04dracoomega> I hadn't actually realized that a number of corroding effects can work on acid-immune enemies (though only 50% of the time) 01:52:54 <04dracoomega> Some of those cases seem reasonable and others I'm a little uncertain about (otherwise it would be nice to fold rAcid and rCorr together completely) 01:58:02 <04dracoomega> Entropy weavers can apparently corrode acid blobs (not that anyone really knows what entropic weave is doing) 02:00:09 <04dracoomega> Oh, the description on monsters affected by this still says 'covered in acid' 02:00:17 <04dracoomega> an acid blob (covered in acid) 02:00:22 <04dracoomega> Gee, you don't say 02:13:37 <04dracoomega> Debating whether it makes sense to rename that (so that it just says 'corroded' or something) and making thematically non-acid corrosion effects ignore rAcid completely (instead of still partially respect it), such as demonspawn Corrupting Presence or rust devils (which don't seem to be 'covering you with acid', certainly). Though we'd still want rCorr to affect this for players (it's already not the most exciting resist), so 02:13:37 maybe rAcid+++ monsters should just be outright immune to it regardless of source (and we can get rid of rCorr and rAcid being two (slightly) different things and just make rCorr multi-level for monsters as acid is now) 02:13:58 <04dracoomega> (Might still rename 'covered in acid', though) 03:01:14 <03wheals> i think making rCorr+ affect everything for all actors, and making rCorr+++ (inaccessible for players right?) block everything makes sense 03:01:57 <03wheals> the main effect would be to nerf corrupting presence? 03:02:10 <03wheals> but basically only in Slime 03:36:55 <04dracoomega> Yeah, this mostly isn't terribly balance-affecting, so it's largely about clarity (and making the code more readable) 03:37:45 <06regret-⸸nde※> (Technically it also nerfs the Vitriol card in Slime, but this is also relatively minor since the actual damage of the bolt didn't get to ignore rCorr+++.) 03:39:36 <04dracoomega> I mean, I think it just feels incorrect that that one worked on acid-immune enemies 03:39:41 <04dracoomega> Since it's acid 03:40:10 03regret-index02 07* 0.33-a0-962-gf251c32bc1: More green tiles (pianoman523 / LemurRobot) 10(14 hours ago, 5 files, 8+ 3-) 13https://github.com/crawl/crawl/commit/f251c32bc14b 03:40:11 <04dracoomega> But corrupting presence and so forth are fairly likely not just 'splashing something with acid'. But it doesn't really matter if acid blobs are also immune to this 03:41:16 <04dracoomega> Oklob plants (and Dispater) may be the only things that have rAcid+++ and aren't a jelly of some sort. Oh, eldritch tentacles, too. 04:34:14 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 10:01:56 03dolorous02 07* 0.33-a0-963-gd6b2ec2eef: Add Donald line about revenants. 10(3 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/d6b2ec2eefb8 14:07:46 03wheals02 07* 0.33-a0-964-g555990002e: docs: Update CREDITS.txt 10(83 seconds ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/555990002e64 15:52:41 New branch created: pull/4316 (1 commit) 13https://github.com/crawl/crawl/pull/4316 15:52:42 03Aliscans02 07https://github.com/crawl/crawl/pull/4316 * 0.33-a0-965-gb1d79db874: Use plural verbs in _xom_time_control(). 10(31 minutes ago, 1 file, 12+ 8-) 13https://github.com/crawl/crawl/commit/b1d79db87433 16:40:28 Unstable branch on underhound.eu updated to: 0.33-a0-964-g555990002e (34) 23:35:22 Unstable branch on crawl.develz.org updated to: 0.33-a0-964-g555990002e (34) 23:58:43 Windows builds of master branch on crawl.develz.org updated to: 0.33-a0-964-g555990002e