00:27:18 Unstable branch on cbro.berotato.org updated to: 0.33-a0-862-g796593f022 (34) 00:55:30 Monster database of master branch on crawl.develz.org updated to: 0.33-a0-862-g796593f022 01:14:01 <06m​umra> Something I think i've found in make_mons_weapon item_def &i = env.item[thing_created]; if (melee_only && (i.base_type != OBJ_WEAPONS || is_range_weapon(i))) { destroy_item(thing_created); return NON_ITEM; } destroy_item has an optional 2nd parameter never_created, which is true is some other cases where an item is destroyed before ever being placed in the world -- it resets unique item status to 01:14:01 UNIQ_NOT_EXISTS. 01:14:28 <06m​umra> so i think because that's not true here, if a ranged unrand is given to a monster in this phase and gets destroyed, then it'll be removed from the game 01:16:02 <06m​umra> the easy fix is just destroy_item(thing_created, true); but i'm also digging through the various connected functions and i can't actually see a case where this would happen, because on the secondary item phase (where melee_only is true), it seems to be strictly only melee weapons given out up to here 04:33:06 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5261-gd9800d219b 05:22:33 Unstable branch on crawl.akrasiac.org updated to: 0.33-a0-862-g796593f (34) 08:04:23 03DracoOmega02 07* 0.33-a0-863-g5cf9c13a7c: A couple new walking verbs for different species 10(4 weeks ago, 4 files, 6+ 0-) 13https://github.com/crawl/crawl/commit/5cf9c13a7cf3 08:04:23 03DracoOmega02 07* 0.33-a0-864-g1bbad35be4: Make a few new(-ish) monster statuses dispellable 10(4 weeks ago, 1 file, 5+ 0-) 13https://github.com/crawl/crawl/commit/1bbad35be4a0 08:04:23 03DracoOmega02 07* 0.33-a0-865-g673755988e: Remove player Vampires 10(4 weeks ago, 49 files, 80+ 763-) 13https://github.com/crawl/crawl/commit/673755988e81 08:04:23 03DracoOmega02 07* 0.33-a0-866-gf08bb6f277: New player species: Poltergeists 10(4 weeks ago, 66 files, 780+ 28-) 13https://github.com/crawl/crawl/commit/f08bb6f27714 08:04:23 03DracoOmega02 07* 0.33-a0-867-g4e3b0e0d72: Hide inscription and plusses for DESC_QUALNAME 10(3 weeks ago, 1 file, 5+ 2-) 13https://github.com/crawl/crawl/commit/4e3b0e0d72c7 08:04:23 03DracoOmega02 07* 0.33-a0-868-g38a2e2c53e: Default to using a menu for item swap prompts with 4+ options 10(3 weeks ago, 1 file, 2+ 5-) 13https://github.com/crawl/crawl/commit/38a2e2c53e20 08:04:23 03DracoOmega02 07* 0.33-a0-869-gc2044cd2ad: Remove code to make hostile dancing weapons via Tukima's and Sac Love 10(3 weeks ago, 1 file, 6+ 13-) 13https://github.com/crawl/crawl/commit/c2044cd2adc6 08:04:23 03DracoOmega02 07* 0.33-a0-870-gd0a9bed6e2: Allow examining fakemuts for longer descriptions 10(3 weeks ago, 6 files, 195+ 192-) 13https://github.com/crawl/crawl/commit/d0a9bed6e274 08:04:23 03DracoOmega02 07* 0.33-a0-871-gaebd54e673: Remove a bunch of unused webtiles code related to the mutations UI menu 10(3 weeks ago, 3 files, 0+ 206-) 13https://github.com/crawl/crawl/commit/aebd54e67385 08:04:23 03DracoOmega02 07* 0.33-a0-872-g1702625a51: Make monster forced sleep into a real enchantment, adjust durations 10(2 weeks ago, 15 files, 64+ 24-) 13https://github.com/crawl/crawl/commit/1702625a5199 08:04:23 ... and 17 more commits 08:15:20 04Build failed for 08master @ 0754acf4 06https://github.com/crawl/crawl/actions/runs/13346158065 08:18:29 03DracoOmega02 07* 0.33-a0-890-g4a08e36d24: Remove a stray bit of unremoved Vampire code 10(29 seconds ago, 1 file, 0+ 3-) 13https://github.com/crawl/crawl/commit/4a08e36d24dd 08:23:01 04Build failed for 08master @ 4a08e36d 06https://github.com/crawl/crawl/actions/runs/13346282517 08:41:15 03DracoOmega02 07* 0.33-a0-891-g9ed1df1ea5: Fix tag upgrade build (hopefully) 10(2 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/9ed1df1ea5bd 08:41:15 03DracoOmega02 07* 0.33-a0-892-g97afa80b3a: Change poltergeist genus/adjective for cooler titles (lici, regret-index) 10(88 seconds ago, 1 file, 3+ 1-) 13https://github.com/crawl/crawl/commit/97afa80b3a87 08:45:10 04Build failed for 08master @ 97afa80b 06https://github.com/crawl/crawl/actions/runs/13346446632 08:52:07 03DracoOmega02 07* 0.33-a0-893-gff4dafabf9: More tag upgrade build fixes 10(62 seconds ago, 2 files, 2+ 0-) 13https://github.com/crawl/crawl/commit/ff4dafabf98c 08:57:31 03DracoOmega02 07* 0.33-a0-894-g7c096ce8a3: Checkwhite / unbrace 10(58 seconds ago, 3 files, 4+ 2-) 13https://github.com/crawl/crawl/commit/7c096ce8a3fa 09:00:24 04Build failed for 08master @ ff4dafab 06https://github.com/crawl/crawl/actions/runs/13346509200 09:12:52 <06m​umra> Ok, that was for the prior commit 09:23:34 03regret-index02 07* 0.33-a0-895-ga774014b48: Fix Crypt zig floors (cool 3) 10(12 seconds ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/a774014b4867 09:55:05 03dolorous02 07* 0.33-a0-896-gf716cb1c98: Fix typo. 10(6 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/f716cb1c986b 09:55:05 03dolorous02 07* 0.33-a0-897-g617501e0ff: Remove erroneously readded ghoul desctiption. 10(2 minutes ago, 1 file, 0+ 13-) 13https://github.com/crawl/crawl/commit/617501e0ffe2 13:32:59 03dolorous02 07* 0.33-a0-898-g6bae641e05: Fix missing word. 10(2 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/6bae641e0575 13:41:39 03regret-index02 07* 0.33-a0-899-g969233c879: Fix Vampire Thrall status not rendering in webtiles 10(57 seconds ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/969233c87920 15:23:59 <06m​umra> Going down a HUGE rabbit hole wrangling with the code for picking monsters and zombies. This whole area could probably do with a huge overhaul, it's labyrinthine for no good reason ... and there are all kinds of weird cases in the logic that probably don't even need to be there. And redundancy and multiple paths to achieve the same thing. And properties with confusingly different names in different places (e.g. monbase vs base_type) 15:26:38 <06m​umra> Did you know, when picking monster types for random zombies: Monsters slower than 10 will be rejected, but this applies only in D. But this veto is overidden for Kiku wretches, and the veto used instead rejects Spriggan Druids. And nothing else. 15:35:46 <06m​umra> (...idea for a Rabbit Hole early portal vault in rotation with Sewer. the boss would be some version of the rabbit from Monty Python And The Holy Grail) 15:42:03 <09h​ellmonk> I think the zombie veto rule actually makes sense 15:45:54 <09h​ellmonk> You don't want slow zombies in D because kiting them is very boring. Later on they're used more as support monsters so stuff like titan zombie is fine, and players are strong enough to not need to kite them 1v1. Kiku wretches are for player ally purposes so only need to reject for death effects. 15:47:09 <09h​ellmonk> Bit surprised we don't reject like, shock serpent from kiku wretches though. 16:02:40 <06m​umra> surprised there aren't more things with undesirable death effects particularly 16:39:56 Unstable branch on underhound.eu updated to: 0.33-a0-899-g969233c879 (34) 22:26:15 <06p​leasingfungus> i think everything listed in that zombie veto comment may actually be my fault 22:28:06 <06p​leasingfungus> no one complained about shock serpents. but it seems reasonable to veto them too, sure 22:28:44 <06p​leasingfungus> also i think i agree with everything in this comment. Also noting that monster pools are smaller everywhere that's not D, so vetoing will be more painful for zombie variety tm 22:37:10 <04d​racoomega> Yes, the logic of all this makes sense to me (and I was aware of the speed thing; it's somewhat obvious in practice, imo?) I didn't know about no wretched druids, but that makes a lot of sense in retrospect ^^; 23:35:27 Unstable branch on crawl.develz.org updated to: 0.33-a0-899-g969233c879 (34) 23:58:27 Windows builds of master branch on crawl.develz.org updated to: 0.33-a0-899-g969233c879