00:14:37 <Cbrotell> Unstable branch on cbro.berotato.org updated to: 0.33-a0-658-g60181c1710 (34)
00:55:26 <Gretell> Monster database of master branch on crawl.develz.org updated to: 0.33-a0-658-g60181c1710
04:04:34 <NotCheibriados> New branch created: pull/4221 (2 commits) 13https://github.com/crawl/crawl/pull/4221
04:04:36 <NotCheibriados> 03Aliscans02 07https://github.com/crawl/crawl/pull/4221 * 0.33-a0-659-g2f4285dfe3: Add a wizard mode command to give an item to a shop. 10(6 minutes ago, 4 files, 30+ 1-) 13https://github.com/crawl/crawl/commit/2f4285dfe3f5
04:04:36 <NotCheibriados> 03Aliscans02 07https://github.com/crawl/crawl/pull/4221 * 0.33-a0-660-g59054425bb: Let wizards give spellbooks to shops. 10(6 minutes ago, 10 files, 44+ 36-) 13https://github.com/crawl/crawl/commit/59054425bb68
04:16:30 <NotCheibriados> New branch created: pull/4222 (1 commit) 13https://github.com/crawl/crawl/pull/4222
04:16:31 <NotCheibriados> 03Aliscans02 07https://github.com/crawl/crawl/pull/4222 * 0.33-a0-659-g28bced3e8c: Stop antique shops from overcharging. 10(11 minutes ago, 1 file, 21+ 18-) 13https://github.com/crawl/crawl/commit/28bced3e8cdb
04:35:03 <Lantell> Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5249-g4a8afe7061
05:08:27 <Henzell> Unstable branch on crawl.akrasiac.org updated to: 0.33-a0-658-g60181c1 (34)
06:35:48 <NotCheibriados> New branch created: pull/4223 (1 commit) 13https://github.com/crawl/crawl/pull/4223
06:35:49 <NotCheibriados> 03Flugkiller02 07https://github.com/crawl/crawl/pull/4223 * 0.33-a0-659-g1f5106024f: feat: penance title for players abandoning with an invo title (DracoOmega) 10(71 minutes ago, 3 files, 21+ 0-) 13https://github.com/crawl/crawl/commit/1f5106024f33
07:52:27 <NotCheibriados> 03Flugkiller02 07https://github.com/crawl/crawl/pull/4223 * 0.33-a0-659-gb0d9a085d6: feat: penance title for players abandoning with an invo title (DracoOmega) 10(2 hours ago, 3 files, 21+ 0-) 13https://github.com/crawl/crawl/commit/b0d9a085d632
07:52:27 <NotCheibriados> 03Flugkiller02 07https://github.com/crawl/crawl/pull/4223 * 0.33-a0-660-gf4decf6681: unbrace 10(78 seconds ago, 1 file, 0+ 2-) 13https://github.com/crawl/crawl/commit/f4decf6681f0
09:52:24 <Discord|> <05i​coson> re the CI arch error on macos, what that build target is doing is building an x86 version, cross-compiling an arm version, and then combining them to make a multi-arch binary. What appears to have happened is that the second build pass didn't generate a new species.o for some reason (not obvious to me), so the file from the first build pass remained behind
09:52:47 <Discord|> <05i​coson> it's probably a bug somehow in the build process, which is very brute force
10:26:53 <NotCheibriados> 03advil02 07* 0.33-a0-659-ga5f79bb512: fix: don't assume the existence of nproc in Makefile 10(2 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/a5f79bb51279
10:30:21 <Discord|> <05i​coson> not really obvious to me why a .o would be skipped on the rebuild pass
10:30:57 <Discord|> <05i​coson> 🤷
10:31:20 <Discord|> <05i​coson> I guess it's transient, whatever it is
11:52:23 <Discord|> <08n​icolae> : O
12:07:36 <Discord|> <09g​ammafunk> why do wizards get to do everything?
12:09:46 <Discord|> <08n​icolae> because they're wizards
12:54:16 <cgettys> @icoson - my guess is that ccache is to blame for the CI arch error on macos
12:54:43 <cgettys> but I haven't been able to repro it in my fork with logging turned on yet....
13:02:24 <Discord|> <05i​coson> I don't think it's likely to be ccache, unless ccache is really buggy
13:09:15 <cgettys> Well, I don't think it's ccache in and of itself
13:09:34 <cgettys> my hunce is that ccache doesn't understand / isn't properly receiving the flag that controls the arch
13:09:43 <cgettys> or that we're doing something silly with where we put the .o files
13:10:26 <cgettys> So once in a while, when we restore from cache, we restore the wrong arch's .o file, and then compilation barfs
13:10:31 <cgettys> Might be wrong though, we'll see
13:33:48 <NotCheibriados> 03Flugkiller02 07https://github.com/crawl/crawl/pull/4223 * 0.33-a0-661-g15beb32e43: fix: properly track gods when betraying them (Monkooky) 10(3 hours ago, 4 files, 28+ 14-) 13https://github.com/crawl/crawl/commit/15beb32e432e
13:42:19 <cgettys> The other possibility that occurs to me isthat it could be a race condition within the two make invocations
13:42:36 <cgettys> but it basically has to be either make or ccache's fault
13:43:53 <cgettys> Or rather, we either are misusing make, or misusing ccache
13:53:17 <NotCheibriados> 03Flugkiller02 07https://github.com/crawl/crawl/pull/4223 * 0.33-a0-662-ga22e849bed: fix: move ATTR_TRAITOR to the bottom 10(61 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/a22e849bed6b
13:55:07 <Discord|> <05i​coson> actually I don't think it can be ccache at all, compilation of species.o wouldn't be skipped if it were ccache
13:56:16 <cgettys> I don't think that the problem is that it's being skipped per se
13:56:56 <cgettys> Ah, I see what you mean
13:57:05 <cgettys> Yeah, ok, so kinda
13:57:22 <cgettys> Whether make decided it wasn't necessary to build it, not clear
13:57:37 <cgettys> end result is that we still have the "other" arch's species.o
13:57:39 <cgettys> and th erefore things fail
14:00:04 <cgettys> Ok, so this is interesting-ish
14:00:08 <cgettys> In the failure case
14:00:20 <cgettys> # do these via submake so that -jn doesn't create havoc shows up way before we start the second compilation
14:01:13 <cgettys> Actually maybe not
14:01:19 <cgettys> bu tthere's something different about the two logs
14:07:09 <cgettys> I'm at a loss, I was able to repro it once, but if I look at it funny (turning on more logging etc) it goes away and doesn't come back
14:07:10 <cgettys> ah well
14:08:13 <Discord|> <09g​ammafunk> TiL I'm not a huge fan of the discord-irc relay bot incorporating markdown interpretation into its relays from irc
14:08:49 <Discord|> <09g​ammafunk> https://cdn.discordapp.com/attachments/747522859361894521/1327746058645934141/image.png?ex=67842f60&is=6782dde0&hm=38616f440ecd32f03195f4dde2fa7b775c0b8a3323b0d4aae04a4baa557863bb&
14:08:55 <geekosaur> it's not at all reliably reproduced in CI either, so you're not alone
14:24:18 <cgettys> It seeems to be highly reliable for me, but only when I'm not looking for it / sendign another PR
14:24:30 <cgettys> But that's how these things always are
15:10:40 <geekosaur> in other news, I finally found a way around my 24.04 clang build problem, only to hit another one
15:10:54 <geekosaur> stringutil.cc:19:8: error: 'strlcpy' is missing exception specification 'throw()'
15:26:38 <cgettys> Hmm, let me see if I can repro it
15:26:52 <cgettys> remind me the easiest way to force clang for htis? GCC and GXX variables?
15:27:18 <cgettys> Also, I haven't quite worked out who's who for osme GH usernames, but I think there's a bug in https://github.com/crawl/crawl/commit/a135081b66271c96c04bea8a314a81b1ae5e9791
15:30:01 <cgettys> it should have been ==, rather than &
15:30:37 <cgettys> or, the comment is wrong about what they want to do
15:32:43 <NotCheibriados> New branch created: pull/4224 (10 commits) 13https://github.com/crawl/crawl/pull/4224
15:32:53 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4224 * 0.33-a0-660-g9bb94b3d7e: Avoid an unnecessary branch and fix a todo 10(79 minutes ago, 2 files, 11+ 10-) 13https://github.com/crawl/crawl/commit/9bb94b3d7ed3
15:32:53 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4224 * 0.33-a0-661-g5da3630d7c: Dataify, initialization order issues 10(64 minutes ago, 1 file, 19+ 17-) 13https://github.com/crawl/crawl/commit/5da3630d7c9e
15:32:53 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4224 * 0.33-a0-662-gb11c976933: Dataify, initialization order issues fixed 10(61 minutes ago, 1 file, 12+ 11-) 13https://github.com/crawl/crawl/commit/b11c97693331
15:32:53 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4224 * 0.33-a0-663-gebce475f95: update_explore_stop_conditions 10(48 minutes ago, 1 file, 32+ 39-) 13https://github.com/crawl/crawl/commit/ebce475f9523
15:32:53 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4224 * 0.33-a0-664-g0d6f4d07f8: update_explore_stop_conditions 10(40 minutes ago, 1 file, 19+ 12-) 13https://github.com/crawl/crawl/commit/0d6f4d07f8c3
15:32:53 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4224 * 0.33-a0-665-gf6f3e20fb6: split enum into own header 10(26 minutes ago, 4 files, 55+ 51-) 13https://github.com/crawl/crawl/commit/f6f3e20fb61e
15:32:53 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4224 * 0.33-a0-666-ga72d1ac0a6: Fix a warning and enum classify Layer 10(16 minutes ago, 4 files, 51+ 51-) 13https://github.com/crawl/crawl/commit/a72d1ac0a629
15:32:53 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4224 * 0.33-a0-667-g4985264878: fix warning, note an error 10(5 minutes ago, 1 file, 10+ 1-) 13https://github.com/crawl/crawl/commit/4985264878e0
15:32:53 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4224 * 0.33-a0-668-g84b10f44b7: whitespace 10(4 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/84b10f44b77e
15:32:53 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4224 * 0.33-a0-669-gbabe8f716d: whitespace 10(4 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/babe8f716d4b
15:32:54 <cgettys> https://github.com/crawl/crawl/pull/4224
15:34:43 <geekosaur> solved, I think
15:35:09 <geekosaur> config.h was wrong because the headers were still missing when it was generated and nothing the Makefile could see had changed when I installed them
15:38:56 <Discord|> <09g​ammafunk> although I agree that the logic looks wrong, I don't see how the ternary should generate a warning nor why we'd want to turn it into an explicit if
15:42:02 <geekosaur> gcc/gxx: I use FORCE_CC and FORCE_CXX
15:42:41 <geekosaur> e.g.: make debug WEBTILES=y FULLDEBUG=y LTO=y FORCE_CC=clang-18 FORCE_CXX=clang++-18
15:44:01 <geekosaur> also I just looked over that bit logic and it looks to me like it is both correct and accurately described by the comment
15:47:56 <geekosaur> hm, not seeing where LAYERS_ALL is though (waiting for latest compile to finish) so maybe it's not actually a separate bit, in which case I guess it does need to be ==
15:48:09 <Discord|> <09g​ammafunk> it's not true that if _layers has any of the layers ORed in LAYERS_ALL enabled that it will return status?
15:48:37 <cgettys> the warning was a Wextra about the two branches having different types
15:48:43 <cgettys> I might be able to fix it with a static_cast instead
15:48:46 <geekosaur> isn't it supposed to be all, not any?
15:48:59 <cgettys> Right, all vs any is exaclty the question
15:49:06 <Discord|> <09g​ammafunk> yeah it's supposed to be all
15:49:10 <geekosaur> it's currently any
15:49:12 <Discord|> <09g​ammafunk> but that operation looks like it will return true if any are enabled
15:49:25 <cgettys> then it should be (_layers & LAYERS_ALL) == LAYERS_ALL
15:49:52 <geekosaur> or just `_layers == LAYERS_ALL` as is used elsewhere in the file
15:50:02 <cgettys> That's actually wrong too but in a different way
15:50:12 <cgettys> depending on the goal
15:50:21 <cgettys> MONSTER_WEAPONS and MONSTER_HEALTH are not part of LAYERS_ALL
15:50:38 <cgettys> and if either of those are on, the simpler == will return false
15:50:50 <Discord|> <09g​ammafunk> yeah
15:51:28 <Discord|> <09g​ammafunk> re the warning about types, would prefer to use a static_cast over breakup up the ternary I guess. Maybe that is in fact a bad use case of ternary since with a cast it's starting to get less concise
15:51:35 <cgettys> enum_bitfield probably needs some other methods
15:51:41 <cgettys> are_all_on
15:51:44 <cgettys> are_any_on
15:52:25 <cgettys> view.cc: In function ‘int viewmap_flash_colour()’:view.cc:939:35: warning: enumerated and non-enumerated type in conditional expression [-Wextra]  939 |     return (_layers & LAYERS_ALL) ? status : BLACK;      |            ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
15:52:29 <cgettys> this is the warning for reference
15:52:50 <cgettys> of course this functionshould maybe just return colour_t in general
15:53:24 <cgettys> status cast also does suppress
15:54:22 <cgettys> *static cast
15:54:31 <cgettys> can't type
15:58:49 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4224 * 0.33-a0-670-gac49d2508a: Make function less wordy, fix warning a nicer way 10(20 seconds ago, 2 files, 16+ 21-) 13https://github.com/crawl/crawl/commit/ac49d2508aaf
15:59:28 <cgettys> @gammafunk - I made the function even more concise. Still didn't fix the bug, because it's unclear to me if the original behavior was desired in the first place
16:01:00 <cgettys> I've literally never used the view menu... let me try to do that
16:06:24 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4224 * 0.33-a0-671-gb277f30150: Fix bug itself 10(71 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/b277f30150d4
16:07:31 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4224 * 0.33-a0-672-g677fa93c64: Comments 10(27 seconds ago, 2 files, 1+ 5-) 13https://github.com/crawl/crawl/commit/677fa93c64df
16:08:15 <cgettys> Yeah, the fix makes a lot more sense with the (_layers & LAYERS_ALL) == LAYERS_ALL as the condition
16:08:37 <cgettys> Or rather (_layers & LAYERS_ALL) != LAYERS_ALL due to how I restructured the function, but yeah
16:41:01 <Lantell> Unstable branch on underhound.eu updated to: 0.33-a0-659-ga5f79bb512 (34)
17:41:34 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4224 * 0.33-a0-673-g47128aa758: fix: bracing 10(89 seconds ago, 1 file, 0+ 12-) 13https://github.com/crawl/crawl/commit/47128aa75835
17:54:32 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4224 * 0.33-a0-660-g455ad70fb0: fix: enum related bugfix and cleanups.  * Split explore_stop_options into its own header.  * Make initfile parsing use maps instead of brute force else-ifs  * Make the layers enum a enum class  * simplify base movespeed logic in form_base_movespeed  * Fix return type of viewmap_flash_clour and fix compiler warning.  * Fix incorrect enum bitfiddling in viewmap_flash_colour. Only the last bullet point has any behavioral change. 10(4 hours ago, 11 files, 184+ 188-) 13https://github.com/crawl/crawl/commit/455ad70fb07a
17:56:01 <geekosaur> line 2 blank, please?
17:57:04 <geekosaur> https://www.freecodecamp.org/news/writing-good-commit-messages-a-practical-guide/
17:58:07 <geekosaur> git slams the lines all together if you don't make the second line blank. also the first line should ideally be no more than 50 characters, much Git tooling (including git branch -v) expects this
17:58:54 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4224 * 0.33-a0-660-g66125b0daf: fix: enum related bugfix and cleanups 10(4 hours ago, 11 files, 184+ 188-) 13https://github.com/crawl/crawl/commit/66125b0dafea
18:00:00 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4217 * 0.33-a0-660-g4adfda9f6d: Remove GLU dependency 10(2 days ago, 8 files, 100+ 17-) 13https://github.com/crawl/crawl/commit/4adfda9f6d8f
18:01:45 <cgettys> Ah, I see
18:01:49 <cgettys> fixed remove GLU dependency as well
18:01:51 <cgettys> I feel dumb
18:04:06 <geekosaur> I'm involved in a discussion elsewhere but I want to link that guide from the dev docs
18:06:55 <Discord|> <03i​mplojin> /clap
18:07:00 <Discord|> <03i​mplojin> thank you, geekosaur
18:08:40 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4211 * 0.33-a0-660-ge4559d47b8: fix: some warnings produced by header_build_tests 10(6 days ago, 3 files, 4+ 2-) 13https://github.com/crawl/crawl/commit/e4559d47b8a9
18:09:47 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4211 * 0.33-a0-660-gaff38b1788: fix: some warnings produced by header_build_tests 10(6 days ago, 3 files, 4+ 2-) 13https://github.com/crawl/crawl/commit/aff38b1788ff
18:11:47 <cgettys> The concrete part is already documented, I just apparently can't get it into my dumb brain :D
18:13:52 <geekosaur> wasn't in the quickstart guide, at least not where it should have been, so I added it
18:13:57 <geekosaur> (incoming)
18:14:07 <NotCheibriados> New branch created: pull/4225 (1 commit) 13https://github.com/crawl/crawl/pull/4225
18:14:08 <NotCheibriados> 03geekosaur02 07https://github.com/crawl/crawl/pull/4225 * 0.33-a0-657-g461ddb4de4: document git conventions 10(3 minutes ago, 1 file, 10+ 0-) 13https://github.com/crawl/crawl/commit/461ddb4de4be
18:23:54 <NotCheibriados> 03Implojin02 07* 0.33-a0-660-g5a69badbe1: Document spiny mutation constriction immunity (cool 3) 10(25 minutes ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/5a69badbe16e
18:23:54 <NotCheibriados> 03Implojin02 07* 0.33-a0-661-g4e6c6e10dc: Fix engulf immunity conditions 10(11 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/4e6c6e10dc1e
18:25:00 <NotCheibriados> 03geekosaur02 07https://github.com/crawl/crawl/pull/4225 * 0.33-a0-657-gf68ca4cbb8: document git conventions 10(14 minutes ago, 2 files, 14+ 1-) 13https://github.com/crawl/crawl/commit/f68ca4cbb843
18:25:33 <geekosaur> mentioned in contributors guide as well. I think that should be sufficient
18:25:42 <geekosaur> assuming anyone ever reads guides :grin
18:25:47 <geekosaur> (whoops)
18:25:54 <geekosaur> 🙂
18:27:12 <NotCheibriados> 03geekosaur02 {Implojin} 07* 0.33-a0-662-g9116421d5b: document git conventions 10(16 minutes ago, 2 files, 14+ 1-) 13https://github.com/crawl/crawl/commit/9116421d5b03
19:20:53 <cgettys> At least some people read them
19:21:00 <cgettys> remembering, now that's the hard part
19:38:23 <geekosaur> it's not just that, it's also having someplace to point people to
19:38:30 <geekosaur> so now we have two
19:39:39 <Discord|> <03i​mplojin> i don't even blame people for this, really, we have a lot of docs that are wildly outdated
19:40:13 <Discord|> <03i​mplojin> i wonder if there's some way for us to put up a template when creating a new PR with commit guidelines right there in your face
19:40:52 <Discord|> <09g​ammafunk> to increase visibility, we should be announcing the new docs on the crawl-ref-discuss mailing list
19:42:20 <geekosaur> PR templates are a thing, yes
19:42:34 <geekosaur> sadly they are underfeatured compared to issue templates
19:43:12 <geekosaur> https://github.com/haskell/cabal/blob/master/.github/pull_request_template.md example
19:43:32 <Discord|> <04d​racoomega> Wow, I forgot that thing even ever existed
19:44:14 <Discord|> <09g​ammafunk> used to be dpeg's favorite means of crawl dev discussion!
20:10:55 <cgettys> I can do one better
20:11:07 <cgettys> PR template won't help commit messages
20:11:11 <cgettys> though yes that's a good idea
20:11:22 <cgettys> I'm building a tiny little script that looks at all commits in branch not on head
20:11:27 <cgettys> and yells at you if they don't fit the rules :D
20:23:39 <Discord|> <09g​ammafunk> It can help commit messages
20:23:46 <Discord|> <09g​ammafunk> You make your commits, you go to make a PR
20:24:03 <Discord|> <09g​ammafunk> Then you read the template and go "oh, let's see about these coding/commit conventions"
20:24:18 <Discord|> <09g​ammafunk> and you go back and push new commits etc
20:25:10 <Discord|> <09g​ammafunk> then you finally submit your PR afterwards with the new commits
20:45:35 <cgettys> Fair
20:45:45 <cgettys> I meant in terms of won't help validate that they're formatted right
20:46:07 <cgettys> not that it doesn't have value, but that it relies on reading just like the existing docs
21:09:30 <NotCheibriados> New branch created: pull/4228 (10 commits) 13https://github.com/crawl/crawl/pull/4228
21:09:39 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4228 * 0.33-a0-663-g1ab63e7499: start adding new file 10(84 minutes ago, 1 file, 24+ 0-) 13https://github.com/crawl/crawl/commit/1ab63e7499b9
21:09:39 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4228 * 0.33-a0-664-gb76f0fe5bd: Seems to work 10(38 minutes ago, 1 file, 49+ 9-) 13https://github.com/crawl/crawl/commit/b76f0fe5bd7f
21:09:39 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4228 * 0.33-a0-665-g78949b4591: Seems to work 10(26 minutes ago, 1 file, 10+ 7-) 13https://github.com/crawl/crawl/commit/78949b459183
21:09:39 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4228 * 0.33-a0-666-g505865953c: CI 10(24 minutes ago, 1 file, 3+ 0-) 13https://github.com/crawl/crawl/commit/505865953cf9
21:09:39 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4228 * 0.33-a0-667-gf3dd976a02: demonstrate the effectiveness of the checker 10(22 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/f3dd976a027a
21:09:39 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4228 * 0.33-a0-668-gba72e2b6e8: demonstrate the effectiveness of the checker 10(22 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/ba72e2b6e8ac
21:09:39 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4228 * 0.33-a0-669-g2bd0b53326: 123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890 10(21 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/2bd0b5332604
21:09:39 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4228 * 0.33-a0-670-g172e5b4b0e: 123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890 10(20 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/172e5b4b0e51
21:09:39 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4228 * 0.33-a0-671-g802205632f: debug CI 10(18 minutes ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/802205632f4f
21:09:39 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4228 * 0.33-a0-672-g622b5dd02c: debug CI 10(12 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/622b5dd02ccc
21:12:17 <Discord|> <09g​ammafunk> Cgettys: When you finally submit a PR, strongly recommend you do a quick e.g. rebase -i and squash commits first
21:12:33 <Discord|> <09g​ammafunk> otherwise it's pretty difficult to know exactly what we're looking at commit-wise with that kind of commit history
21:13:28 <cgettys> I generally do, if I know I'm done commmitting
21:13:50 <cgettys> e.g. if doing refactoring I don't always squash because I kinda expect folks will say "but not that part" or "split it up"
21:15:05 <NotCheibriados> 03gammafunk02 07* 0.33-a0-663-gc3122fab97: Fix a shop typo (projectNoob) 10(6 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/c3122fab9711
21:16:16 <Discord|> <09g​ammafunk> Well a lot of these commits are just nothing one would ever pick out
21:17:26 <Discord|> <09g​ammafunk> On the one hand you don't need to have a perfect commit history and would like the PR to exist, but on the other the stream-of-consciousness commits are just too much fluff that will never see the light of day on their own in a final merge
21:18:47 <cgettys> Fair. I'll try to do better on that... used to ADO
21:18:52 <cgettys> which groups by push more strongly
21:19:27 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4228 * 0.33-a0-673-g913d6d0c32: feat: Automatically check commit messages against guidelines 10(6 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/913d6d0c32e8
21:22:07 <cgettys> And also doesn't post in IRC every time you push on a draft PR :D
21:22:42 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4228 * 0.33-a0-663-g176120a00d: feat: Automatically check commit messages against guidelines 10(2 hours ago, 2 files, 78+ 0-) 13https://github.com/crawl/crawl/commit/176120a00d8f
21:22:55 <cgettys> Also, keep in mind this latest one literally looks at the commit log
21:23:11 <cgettys> so I kinda had test commits that it should flag in there :)
21:24:22 <Discord|> <09g​ammafunk> one potential issue is that I'm not sure it should unconditionally run on CI unless there's actually a PR
21:24:47 <Discord|> <09g​ammafunk> the reason being that may commits are cherry-picked e.g. between trunk and stable release branches
21:24:54 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4228 * 0.33-a0-663-gbad9e71257: feat: Automatically check commit messages against guidelines 10(2 hours ago, 2 files, 78+ 0-) 13https://github.com/crawl/crawl/commit/bad9e7125738
21:25:13 <cgettys> Ooh, good point
21:25:18 <cgettys> I forgot about release branches
21:25:21 <Discord|> <09g​ammafunk> hence those cherry-picked commits will be seen as not in master etc
21:26:14 <Discord|> <09g​ammafunk> pull requests do exist in the repo as branches, as e.g. origin/pull/NNN/head
21:26:40 <Discord|> <09g​ammafunk> but I'm not sure if there are standard ways to check for corresponding PRs of branches that are CI-friendly
21:27:16 <Discord|> <03i​mplojin> also 50 chars title is something we very commonly violate when crediting bugfixes to playernames that reported them; not sure we actually want to see ci failures over this for commits to trunk
21:27:23 <Discord|> <09g​ammafunk> oh, yes, right
21:27:33 <Discord|> <03i​mplojin> 72 width is good and will help git log readbility
21:27:41 <Discord|> <09g​ammafunk> violations of that would be common in commit title
21:28:00 <cgettys> I adjusted it to 72
21:28:21 <cgettys> also not retroactive
21:29:39 <cgettys> I'm sure there's a way
21:29:44 <cgettys> the question is, do I know what that way is
21:30:06 <Discord|> <09g​ammafunk> it's a cool script idea, might take a bit more work to get it properly integrated into CI so that we're not getting e.g. false positives
21:30:50 <cgettys> Happy to hack that part back off
21:31:05 <cgettys> I think I can make it continue on error so it's just a warning, hold tight
21:31:23 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4228 * 0.33-a0-663-g4014490cc9: feat: Automatically check commit messages against guidelines 10(2 hours ago, 2 files, 79+ 0-) 13https://github.com/crawl/crawl/commit/4014490cc9dc
21:32:37 <Discord|> <09g​ammafunk> cgettys: Recommend you switch to python f strings over use of modulo: https://realpython.com/python-f-strings/#formatting-strings-with-pythons-f-string
21:34:52 <cgettys> ah yeah nice interpolated strings
21:34:54 <Discord|> <09g​ammafunk> e.g. python  print("Checking commit %s written by %s" % (commit_hash, committer_name))  becomes python  print(f"Checking commit {commit_hash} written by {committer_name}")
21:34:59 <cgettys> wasn't sure what was available on the version you have
21:35:07 <cgettys> so I copied the other python script :D
21:35:26 <Discord|> <09g​ammafunk> yeah, probably old python script, but right python3 stuff is generally fine
21:35:44 <Discord|> <09g​ammafunk> hrm, what's our formal python requirement actually
21:37:16 <Discord|> <09g​ammafunk> well f-strings are 3.6 and up and I don't think that's a problem at this point. also this only runs in CI
21:37:36 <Discord|> <09g​ammafunk> or at least it's not part of the build process, where we could potentially have an issue on older systems
21:37:41 <geekosaur> lots of stuff is still python2 but we switched to requiring python3 some versions back
21:38:00 <Discord|> <09g​ammafunk> yes, notably webtiles server itself
21:38:03 <geekosaur> think even 3.6 because of required tornado upgrades
21:38:23 <Discord|> <09g​ammafunk> yeah I couldn't really find a specific version of python3 mentioned in INSTALL
21:38:42 <Discord|> <09g​ammafunk> but maybe it's just in the webserver README since that's the only place likely to be relevant
21:39:46 <Discord|> <09g​ammafunk> but to be fair, python version requirements are actually relevant to the build itself and not just running WebTiles server, since we use python scripts to generate heads from yaml
21:40:30 <geekosaur> true but I recall Tornado as pushing the Python upgrade
21:40:51 <cgettys> SO I think i've made it successfully not fail the build
21:41:00 <cgettys> but it also doesn't show up a super nice warning when it fails
21:41:09 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4228 * 0.33-a0-663-g3ce1edbedf: feat: Automatically check commit messages against guidelines 10(2 hours ago, 2 files, 82+ 0-) 13https://github.com/crawl/crawl/commit/3ce1edbedff0
21:41:25 <cgettys> it should be possible to handle target branch, but I haven't worked out the invocation quite yet
21:42:05 <cgettys> And I fixed it to use fstrings
21:43:09 <cgettys> Think it's mergeable as is and we can make it more useful over time
21:43:38 <cgettys> But obviously my opionin doesn't really matter :P
21:48:18 <cgettys> Actually, one sec
21:48:22 <cgettys> stack overflow to the rescue
21:48:27 <cgettys> https://stackoverflow.com/a/65656616
22:05:44 <cgettys> It's definitely possible, but I think I'll save making it breaking for a future PR
22:05:50 <cgettys> it'sgonna take thought
22:06:45 <cgettys> So if you guys are happy, merge away
22:09:15 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4228 * 0.33-a0-663-g6972cbbecb: feat: Automatically check commit messages against guidelines 10(2 hours ago, 2 files, 96+ 0-) 13https://github.com/crawl/crawl/commit/6972cbbecb16
22:09:22 <cgettys> Actually, now merge away :D
22:11:57 <cgettys> arg, now good
22:12:17 <cgettys> It now reports all errors at once instead of just the first
22:12:32 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4228 * 0.33-a0-664-gd9fb25ba26: feat: Automatically check commit messages against guidelines 10(4 minutes ago, 2 files, 7+ 2-) 13https://github.com/crawl/crawl/commit/d9fb25ba2653
22:12:33 <cgettys> and uses source and target branch if github provides
22:12:38 <cgettys> but still not ready to make it blocking
22:30:14 <NotCheibriados> 03DracoOmega02 07* 0.33-a0-664-g84a917550b: A small optimisation to actor iterators. 10(4 weeks ago, 6 files, 43+ 19-) 13https://github.com/crawl/crawl/commit/84a917550bd2
22:30:14 <NotCheibriados> 03DracoOmega02 07* 0.33-a0-665-gc4e2c3447e: Fetch species_def by array lookup instead of map lookup 10(4 weeks ago, 11 files, 166+ 174-) 13https://github.com/crawl/crawl/commit/c4e2c3447e0a
22:30:14 <NotCheibriados> 03DracoOmega02 07* 0.33-a0-666-g6a727fa3a9: Improve get_mutation_level performance 10(4 weeks ago, 1 file, 10+ 4-) 13https://github.com/crawl/crawl/commit/6a727fa3a976
22:30:14 <NotCheibriados> 03DracoOmega02 07* 0.33-a0-667-gb756c04f85: Improve performance of mons_is_safe 10(4 weeks ago, 2 files, 15+ 7-) 13https://github.com/crawl/crawl/commit/b756c04f85fd
22:30:14 <NotCheibriados> 03DracoOmega02 07* 0.33-a0-668-gf03798f366: Fix a rouding issue with equipment previews 10(5 days ago, 1 file, 5+ 0-) 13https://github.com/crawl/crawl/commit/f03798f36615
22:30:14 <NotCheibriados> 03DracoOmega02 07* 0.33-a0-669-g2dbd7c1ffd: Completely rewrite how player equipment slots are handled 10(4 weeks ago, 94 files, 4015+ 5914-) 13https://github.com/crawl/crawl/commit/2dbd7c1ffd74
22:30:14 <NotCheibriados> 03DracoOmega02 07* 0.33-a0-670-gc6088a4a74: Refactor and adjust mummy death curses 10(2 days ago, 6 files, 53+ 43-) 13https://github.com/crawl/crawl/commit/c6088a4a7490
22:30:14 <NotCheibriados> 03DracoOmega02 07* 0.33-a0-671-g223a808d43: Change potions of degeneration into potions of moonshine 10(2 days ago, 25 files, 53+ 62-) 13https://github.com/crawl/crawl/commit/223a808d432b
22:30:14 <NotCheibriados> 03DracoOmega02 07* 0.33-a0-672-g13154cae79: Replace Deterioration mutation with Poor Constitution 10(2 days ago, 6 files, 29+ 22-) 13https://github.com/crawl/crawl/commit/13154cae7948
22:30:14 <NotCheibriados> 03DracoOmega02 07* 0.33-a0-673-gde2045381e: Remove all stat draining from the game 10(2 days ago, 42 files, 83+ 529-) 13https://github.com/crawl/crawl/commit/de2045381eb5
22:30:14 <NotCheibriados> ... and 9 more commits
22:35:35 <cgettys> Wow, you weren't kidding
22:41:48 <dcss-ci> 04Build failed for 08master @ 008900fb 06https://github.com/crawl/crawl/actions/runs/12730811331
22:44:07 <cgettys> macos
22:44:11 <cgettys> is also failing
22:44:16 <cgettys> but different
22:44:17 <cgettys> nearby-danger.cc:172:25: error: cannot pass object of non-trivial type 'string' (aka 'basic_string<char>') through variadic method; call will abort at runtime [-Wnon-pod-varargs]                        mon->name(DESC_PLAIN), is_safe, moving, dist,
22:44:27 <NotCheibriados> 03DracoOmega02 07* 0.33-a0-683-ga49f8ab139: Allow the elusive crimon imp to return to hiding (Cgettys) 10(73 seconds ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/a49f8ab139bb
22:44:28 <cgettys> https://github.com/crawl/crawl/actions/runs/12730811331/job/35484143324
22:44:50 <cgettys> mingw seems to be unhappy about, uh, something
22:46:41 <cgettys> Looks like only 3 bugs :)
22:46:47 <cgettys> given the compiler / targe tmatrix, not bad
22:47:01 <Discord|> <04d​racoomega> Huh. How does FULLDEBUG=1 -test catch the crimon imp problem here, but running it locally did not
22:47:09 <Discord|> <03i​mplojin> 3 things that broke ci, maybe
22:47:28 <Discord|> <03i​mplojin> guaranteed we'll be dealing with fallout from a storm like this for ~weeks but that's fine
22:47:42 <dcss-ci> 04Build failed for 08master @ a49f8ab1 06https://github.com/crawl/crawl/actions/runs/12730897376
22:47:49 <cgettys> yeah, I really don't know
22:47:57 <cgettys> the mon-> name one is quite easy
22:48:04 <cgettys> add a .c_str()
22:48:10 <cgettys> mon->name(DESC_PLAIN).c_str(), is_safe, moving, dist,
22:48:13 <cgettys> instead of
22:48:18 <cgettys> mon->name(DESC_PLAIN), is_safe, moving, dist,
22:48:55 <cgettys> that'll fix android, macos, and probably the clang targets that were canceled
22:49:02 <cgettys> think gcc lets it slide
22:49:18 <cgettys> And yeah I'm sure there will be other bugs too :D
22:49:28 <cgettys> but still, even getting C++ to compile with this many compilers is hard
22:50:14 <cgettys> @DracoOmega - were you building tiles or webtiles fulldebug? it looks like it may be console specific code,just looking at targets that failed vs didn't
22:50:25 <cgettys> or rather, only reach the function in console
22:50:28 <Discord|> <04d​racoomega> Fulldebug is only for console, I thought?
22:51:12 <Discord|> <04d​racoomega> I mean, either way, I was using the same make command that the automated test here was
22:52:22 <cgettys> player_equip.cpp I think needs a view includes tos atisfy mingw
22:52:25 <cgettys> e.g. sound.h
22:52:26 <Discord|> <08n​icolae> congrats on pushing those big changes, DO
22:52:31 <Discord|> <08n​icolae> time for a well earned rest imo
22:52:34 <Discord|> <04d​racoomega> Yeah, I'm on it
22:52:39 <Discord|> <04d​racoomega> Er, on fixing that, not on resting
22:52:42 <Discord|> <08n​icolae> no you should rest
22:52:43 <Discord|> <04d​racoomega> Let's not get ahead of ourselves 😛
22:52:45 <Discord|> <08n​icolae> D:
22:52:55 <Discord|> <08n​icolae> draco... you're going too hard... you're coding too good...
22:53:01 <cgettys> Not intended as a critique -just thought a second set of eyes m ight help
22:53:21 <cgettys> if not tell me to shove off, I'll just boot up GCC version that should work and start finding bugs :P
22:53:22 <Discord|> <04d​racoomega> No, I didn't mean that as a criticism either, just an acknowledgement
22:53:36 <cgettys> Would do thumbsup emoji, but not sure how do that from IRC :P
22:54:11 <NotCheibriados> 03gammafunk02 07* 0.33-a0-684-gd0d10d1f0b: Remove an outdated vault 10(5 minutes ago, 1 file, 0+ 68-) 13https://github.com/crawl/crawl/commit/d0d10d1f0b3f
22:55:09 <Discord|> <03i​mplojin> oh, i wasn't thinking about this commitstorm including the equipment slot refactor
22:55:17 <NotCheibriados> 03DracoOmega02 07* 0.33-a0-685-g0c33c9779a: Fix a couple more ci errors 10(34 seconds ago, 2 files, 2+ 1-) 13https://github.com/crawl/crawl/commit/0c33c9779aac
22:55:20 <Discord|> <03i​mplojin> i change my estimate to several months
22:55:27 <cgettys> test_player_fixture.cc also is quite borked
22:55:35 <cgettys> or at least a little borked
22:56:39 <Discord|> <04d​racoomega> I mean, I've done a lot of careful testing, but there's no substitute for hundreds of players playing thousands of games ^^;
22:56:50 <Discord|> <03i​mplojin> yep! and that's perfectly okay
22:57:29 <cgettys> If I'm ever bored, maybe I'll try to do some sort of fuzzing thing
22:57:44 <cgettys> automatically play thousands of games and see if I can make things crash :D
22:57:57 <Discord|> <03i​mplojin> it won't take nearly that long
22:58:08 <cgettys> but yeah, won't find all the subtle bugs wher eit works, but doesn't do what you expect
22:58:18 <Discord|> <03i​mplojin> fuzzing on crawl is going to crash, like, everywhere
22:58:33 <Discord|> <03i​mplojin> but surely that would help?
22:58:57 <cgettys> Fair, I've been impressed by how rarely it crashes, tbh
22:59:30 <cgettys> GitHub CI being free is a pretty cool thing though
22:59:54 <cgettys> imagine having to fix this half a dozen issues without a way to run on other HW other than "pretty please"
23:00:04 <cgettys> I mean I'm sure folks remember :D
23:00:09 <cgettys> but you know what I mean
23:00:17 <dcss-ci> 04Build failed for 08master @ d0d10d1f 06https://github.com/crawl/crawl/actions/runs/12730947995
23:03:29 <cgettys> equipment-type.h needs to be removed from the makefile
23:03:57 <cgettys> wait, maybe it was. DUnno what to amke of that compile error if so
23:04:22 <Discord|> <04d​racoomega> Header build tests must be using a different list or something
23:05:23 <dcss-ci> 04Build failed for 08master @ 0c33c977 06https://github.com/crawl/crawl/actions/runs/12730951587
23:05:38 <cgettys> I don't see it in the list anywhere, that's why I'm confused
23:05:40 <cgettys> make: *** No rule to make target 'equipment-type.h.cc', needed by 'equipment-type.h.o'.  Stop.
23:06:08 <NotCheibriados> 03dolorous02 07* 0.33-a0-686-g773a97d5a4: Fix missing punctuation. 10(2 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/773a97d5a4bf
23:06:08 <NotCheibriados> 03dolorous02 07* 0.33-a0-687-g0da8038b3c: Fix wording. 10(82 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/0da8038b3cb9
23:06:23 <cgettys> it's still inthe crawl.vcxproj
23:06:28 <cgettys> idk if anything uses that tho
23:10:04 <dcss-ci> 04Build failed for 08master @ 0da8038b 06https://github.com/crawl/crawl/actions/runs/12731012805
23:10:45 <cgettys> Normal compile errors are down to emplace_back for std::bector<bool>
23:10:52 <cgettys> which is probalby just "push_back instead"
23:11:07 <cgettys> vector<bool> is specialized to allow it to be 8 times smaller iirc
23:11:15 <Discord|> <04d​racoomega> Yes, probably. (I guess some compilers are okay with that and some aren't?)
23:11:25 <cgettys> STL should have just given us a bitfield type
23:11:33 <cgettys> instead of specializing std::vector<bool>
23:11:34 <Discord|> <04d​racoomega> Because, I mean, it worked locally
23:11:37 <cgettys> tho I see why it was so tempting
23:11:43 <cgettys> yeah a some compilers thing for sure
23:12:08 <Discord|> <04d​racoomega> (Anyway, yeah, I've already got those changes done, and a couple others. Just waiting on my computer to verify I haven't typoed something first ^^; )
23:12:09 <cgettys> https://en.cppreference.com/w/cpp/container/vector_bool
23:12:30 <cgettys> you can run CI on your fork if you want
23:12:38 <Discord|> <08w​ormsofcan> demonic touch and tendril mutation icons
23:12:38 <Discord|> <08w​ormsofcan> https://cdn.discordapp.com/attachments/747522859361894521/1327882910354636810/demonic_touch1.png?ex=6784aed4&is=67835d54&hm=173a5885f184a2a1275127a6d9aac0b246822aaae4b3cf32631034a7b6e946e7&
23:12:38 <Discord|> <08w​ormsofcan> https://cdn.discordapp.com/attachments/747522859361894521/1327882910669213706/demonic_touch2.png?ex=6784aed4&is=67835d54&hm=80854f74f7eb61815d9cefefd60ed0ffdbeb37d24f4aa182c3ce940c64f91808&
23:12:38 <cgettys> you just have to push the tags
23:12:39 <Discord|> <08w​ormsofcan> https://cdn.discordapp.com/attachments/747522859361894521/1327882910899896350/demonic_touch3.png?ex=6784aed4&is=67835d54&hm=75126dbc7a6458756f8f5418b541bd19213edb32b48d9be91a3b35eb887fd511&
23:12:39 <Discord|> <08w​ormsofcan> https://cdn.discordapp.com/attachments/747522859361894521/1327882911294164992/tendrils.png?ex=6784aed4&is=67835d54&hm=0db2b2e9bd4cd368bf3ca1606357c682d7af19b63ed1f80a5bbe1c4924da69ba&
23:13:32 <cgettys> emplace_back is supposed to exist even for std::vector<bool>
23:13:49 <cgettys> but it looks like it was a C++11 addition and maybe mingw version we use didn't ge the memo
23:14:06 <cgettys> oh, also, STL did end up giving us a bitset class
23:14:08 <cgettys> std::bitset
23:14:12 <cgettys> it's just... C++23 only
23:21:18 <NotCheibriados> 03DracoOmega02 07* 0.33-a0-688-g8ba66c0f68: Fix yet more CI errors 10(11 minutes ago, 3 files, 7+ 6-) 13https://github.com/crawl/crawl/commit/8ba66c0f68aa
23:22:09 <cgettys> Oh, it's still in makefile.obj
23:22:17 <cgettys> I assumed that was an auto-generated file
23:22:24 <cgettys> but that's why that  header is borked
23:22:54 <Discord|> <06p​leasingfungus> rip quasits
23:23:11 <Discord|> <06p​leasingfungus> i was planning to say 'noo quasits' but... eh
23:23:18 <Discord|> <04d​racoomega> Haha
23:23:20 <Discord|> <06p​leasingfungus> also cool to see a big set of new unrands
23:23:59 <Discord|> <04d​racoomega> Was fun writing dialogue for them ^^;
23:24:40 <cgettys> conduct-type.h:30:5: warning: "TAG_MAJOR_VERSION" is not defined, evaluates to 0 [-Wundef]
23:24:43 <cgettys> it's only a warning
23:24:54 <cgettys> but it implies a missing include
23:25:09 <cgettys> also
23:25:10 <cgettys> artefact.h:10:1: note: ‘uint8_t’ is defined in header ‘<cstdint>’; did you forget to ‘#include <cstdint>’?
23:25:39 <cgettys> player-equip.h:98:58: error: ‘item_def’ was not declared in this scope
23:26:20 <cgettys> and 7 | artefact_prop_type artp_type_from_name(const string &name);
23:26:24 <cgettys> most of the rest are noise
23:26:34 <cgettys> caused by the main ones
23:27:49 <NotCheibriados> 03dolorous02 07* 0.33-a0-689-gc877134c9c: Reorder octopodes' species_flags. 10(3 minutes ago, 1 file, 5+ 5-) 13https://github.com/crawl/crawl/commit/c877134c9c3c
23:33:30 <cgettys> uh-oh there's a small include cycle
23:35:29 <Gretell> Unstable branch on crawl.develz.org updated to: 0.33-a0-688-g8ba66c0f68 (34)
23:36:17 <cgettys> maybe not
23:41:54 <cgettys> @DracoOmega - have a PR out now that fixes all the remaining header tests
23:41:54 <cgettys> at least ong cc
23:42:04 <cgettys> https://github.com/crawl/crawl/pull/4229
23:42:59 <NotCheibriados> 03DracoOmega02 07* 0.33-a0-690-gc40ce7fcf5: Slightly buff the Macabre Finger 10(34 seconds ago, 1 file, 3+ 2-) 13https://github.com/crawl/crawl/commit/c40ce7fcf50e
23:42:59 <NotCheibriados> New branch created: pull/4229 (1 commit) 13https://github.com/crawl/crawl/pull/4229
23:43:00 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4229 * 0.33-a0-689-g1a14e14466: fix: failing header tests 10(2 minutes ago, 6 files, 18+ 1-) 13https://github.com/crawl/crawl/commit/1a14e14466dc
23:48:15 <cgettys> yeah, it passes  al the header tests
23:48:27 <NotCheibriados> 03dolorous02 07* 0.33-a0-691-gb602fafdc2: Use mpr() instead of mprf(). 10(4 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/b602fafdc22b
23:48:28 <cgettys> some of the other tests still running
23:50:09 <cgettys> linting of course, lol
23:50:38 <NotCheibriados> 03Cgettys02 07https://github.com/crawl/crawl/pull/4229 * 0.33-a0-689-gd05b0b7a53: fix: failing header tests 10(9 minutes ago, 5 files, 17+ 0-) 13https://github.com/crawl/crawl/commit/d05b0b7a536f
23:56:20 <cgettys> @DracoOmega - d05b0b7a536feb6e69250dbad721607f42c6ffee / <https://github.com/crawl/crawl/pull/4229> should get it back to fully clean in CI, if you want to merge or cherry-pick it
23:58:31 <Gretell> Windows builds of master branch on crawl.develz.org updated to: 0.33-a0-690-gc40ce7fcf5