00:45:16 <Gretell> Monster database of master branch on crawl.develz.org updated to: 0.33-a0-549-g2ebf7937d9
04:32:08 <Lantell> Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5249-g4a8afe7061
06:15:26 <NotCheibriados> 03Isaac Clancy02 07https://github.com/crawl/crawl/pull/4147 * 0.33-a0-498-gae9f63fcc0: Cast OTR with uppercase Z when all enemies resist poison (CrawlOdds) 10(13 days ago, 3 files, 17+ 10-) 13https://github.com/crawl/crawl/commit/ae9f63fcc05f
06:21:56 <NotCheibriados> 03Isaac Clancy02 07https://github.com/crawl/crawl/pull/4147 * 0.33-a0-498-gda3fc3f43e: Cast OTR with uppercase Z when all enemies resist poison (CrawlOdds) 10(13 days ago, 3 files, 13+ 9-) 13https://github.com/crawl/crawl/commit/da3fc3f43e2b
06:56:28 <NotCheibriados> 03Implojin02 07* 0.33-a0-550-ga6ff03a38b: Enable some slow-swap artps on talismans (Lici) 10(19 minutes ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/a6ff03a38b08
08:12:00 <NotCheibriados> New branch created: pull/4164 (1 commit) 13https://github.com/crawl/crawl/pull/4164
08:12:01 <NotCheibriados> 03Isaac Clancy02 07https://github.com/crawl/crawl/pull/4164 * 0.33-a0-551-gfeb7a67e2c: Fix barding being incorrectly marked permanently useless 10(19 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/feb7a67e2cc2
08:48:43 <NotCheibriados> 03Isaac Clancy02 07https://github.com/crawl/crawl/pull/4164 * 0.33-a0-551-gfe2dc9edf3: Fix barding being incorrectly marked permanently useless 10(56 minutes ago, 1 file, 2+ 7-) 13https://github.com/crawl/crawl/commit/fe2dc9edf3db
15:27:14 <Guest24> hi since quite a lot of version there are some crash bugs related to vaults where theres a lot of items - it's crash prone
15:28:35 <Guest24> i remember elven halls treasury crash quite some time ago when there was deep dwarf yet
15:29:00 <Guest24> and yesterday i had a crash in slime pits treasure vault
15:29:49 <Guest24> i had it open at full jivya piety, and it crashed browsing several items and removing amulet of faith
15:30:54 <Guest24> crashed after*
15:31:10 <Discord|> <03i​mplojin> there's very little we can do with a bug report in the form of "i'm experiencing crash bugs", to troubleshoot this we need the crashlog (you can find crashlogs in your /morgue/ directory with names like crash-charactername-date.txt), along with any information you can give about what was happening when you experienced the crash
15:33:34 <Guest24> indeed theres 6 of them including yesterday
15:35:00 <Discord|> <03i​mplojin> you could upload them as a github issue: https://github.com/crawl/crawl/issues , or upload them to a pastebin service and link them here
15:43:43 <Guest24> https://ctxt.io/2/AAB4nl5iFg
15:43:48 <Guest24> expires in 4 mins
15:44:05 <shmup> https://no.dungeon.red/8R
15:44:06 <shmup> expires never
15:45:00 <Discord|> <04d​racoomega> Well that is a weird error
15:45:05 <Guest24> its that slime pits one
15:45:26 <Discord|> <04d​racoomega> Oh, wait
15:45:48 <Discord|> <04d​racoomega> You removed it via mouse click, right?
15:45:50 <Guest24> what was weird is that it warned me several times while removing amulet of faith to confirm
15:45:58 <Guest24> probably yes
15:46:21 <Guest24> then after reloing i removed it on 1st turn after reload and there was no warnings and no crash
15:46:38 <Guest24> after reloading*
15:47:27 <Discord|> <04d​racoomega> I feel I ran into this in wizmode once
15:47:42 <Discord|> <04d​racoomega> Maybe??
15:48:22 <Discord|> <04d​racoomega> Either way, if you look at the log, it is continung to remove the amulet after it's already been removed
15:48:27 <Discord|> <04d​racoomega> Which is the ultimate source of the crash
15:48:37 <Guest24> ok
15:49:14 <Guest24> like on every piety * loss it generated a warning
15:50:36 <Guest24> but then after reload it went normally, but i removed it without browsing items, picking up gold, books, and before jellies ate anything
15:51:09 <Discord|> <04d​racoomega> Yes, the question is how does this actually happen
15:52:38 <Guest24> except some history from previous levels the only difference was some moving, picking up gold, books and browsing items
15:52:56 <Guest24> then i wanted to free a slot of the amulet and boom
15:53:49 <Discord|> <04d​racoomega> Okay, I can reproduce it
15:54:00 <Discord|> <04d​racoomega> (Partially due to this sparking an old memory)
15:54:12 <Discord|> <04d​racoomega> This issue comes from using shift+click to drop an amulet of faith that you're currently wearing
15:54:23 <Guest24> ok
15:54:35 <Discord|> <04d​racoomega> Which causes a bunch of confusing prompts, that if answered in a particular way, will cause it to queue up unequipping the item twice
15:54:44 <Discord|> <04d​racoomega> (And then crash)
15:55:45 <Guest24> ok, though id say that after reload i dropped it the same way?
15:58:33 <Discord|> <04d​racoomega> You can answer the prompts slightly differently and not cause this
15:59:23 <Discord|> <04d​racoomega> At any rate, there is definitely wrongness going on in this UI interaction specifically (trying to drop it via 'd' doesn't do this at all, for instance)
15:59:42 <Discord|> <04d​racoomega> (You probably also need to currently be worshipping a god for which =faith gives a warning upon removal)
16:04:58 <Guest24> ok great that i helped ditching a bug
16:05:15 <Guest24> if you credit bug hunting you can assign it to rutra80
16:05:16 <Guest24> :))
16:06:16 <Discord|> <04d​racoomega> Will do. (It might be a little bit before I get to fixing it, but we appreciate the report!)
16:06:51 <Guest24> thanks for all your work, until next time!
16:33:55 <NotCheibriados> 03jjjingleheimer02 {regret-index} 07* 0.33-a0-551-gbd2725d2c0: Add tile for player under Glaive of Prune curse (#3239) 10(1 year, 4 months ago, 6 files, 8+ 3-) 13https://github.com/crawl/crawl/commit/bd2725d2c0cc
16:33:55 <NotCheibriados> 03regret-index02 07* 0.33-a0-552-g1592f7d419: Set up a four-month-long gag (Darby) 10(74 seconds ago, 3 files, 8+ 0-) 13https://github.com/crawl/crawl/commit/1592f7d4194a
16:39:40 <Lantell> Unstable branch on underhound.eu updated to: 0.33-a0-550-ga6ff03a38b (34)
17:03:04 <Discord|> <04d​racoomega> I thought this amulet of faith thing might be a related bug, so I tested it against https://github.com/crawl/crawl/pull/3873 and that does also fix this issue
17:04:22 <Discord|> <04d​racoomega> (It's a frighteningly large commit to review, which I admit is why I hadn't done so properly before now. And local tiles gets a lot less live testing feedback for any issues it might have)
17:05:30 <Discord|> <04d​racoomega> But there's enough bug fixes attached to this that it really should be
17:28:56 <NotCheibriados> 03dolorous02 07* 0.33-a0-553-g146f489888: Add another mythical creature to artefacts. 10(6 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/146f489888e6
19:04:47 <Discord|> <04d​racoomega> Well, I've spent another couple hours reading over the code in the PR and testing all sorts of different mouse-related commands with it. The PR is in a sort of awkward place where the scope of what it's doing is quite large, and in a part of the codebase that I don't have a lot of familiarity with to make reviewing easy (nor, I suspect, does anyone else active). And yet, it's fixing a number of different bugs at once, including
19:04:47 <Discord|> multiple crash-on-demand bugs that might be hard-to-impossible to fix without UI code changes of this nature.  Towards the end of 0.32, I'd sort of planned to try merging it in early 0.33, just so that something of this nature could have the longest possible time for subtle bugs caused to it to become known (especially since it doesn't affect webtiles, and thus active feedback we get is likely to be a lot less). I got rather sidetracked from doing that,
19:04:48 <Discord|> but I'm feeling again like the best course of action may just be to merge it, even without fully understanding the exact flow of everything that it does to the degree I would normally like for a PR. Especially when it comes to low level UI message handling (which potentially has system-dependent effects), I'm not certain how plausible it is to verify all interactions in advance.  Or rather, I think that unless we take a merge-and-observe approach,
19:04:48 <Discord|> it's just going to end up left to rot, despite the important fixes involved. But I'd like other dev opinions on the subject before I do so.  (To be clear, I tested as many things as I could think of and compared to behavior prior to this PR, and found no bugs or weird behavior that wasn't equally weird beforehand.)
19:09:33 <geekosaur> I feel like we do in fact get a number of questions / bug reports in here from folks using the local tiles build, though
19:10:45 <geekosaur> (actually I'd be willing to bet more people run local tiles than local console)
19:11:34 <Discord|> <04d​racoomega> Oh, I didn't mean 'none'
19:11:51 <Discord|> <04d​racoomega> But I do feel it's less (especially 'heavily using the mouse interface' tiles-players, also)
19:12:09 <Discord|> <04d​racoomega> For instance, a bunch of commands I tested are ones I may have literally never tried to do with the mouse before today
19:12:21 <geekosaur> there is that, I guess
19:12:44 <geekosaur> even when I do run local tiles or webtiles, it's still heavily console command oriented instead of using the mouse
19:13:13 <Discord|> <04d​racoomega> Yeah, there's a handful of things I often use the mouse for (such as item panel stuff), but it's still mostly keyboard
19:13:21 <geekosaur> (for example, I feel like tiles/webtiles encourages doing things from the inventory menu instead of direct commands like e.g. wield/Wear/Put-on)
19:16:03 <geekosaur> (but maybe I'm just showing my age; it's not like you could do things from the inventory screen in rogue)
20:39:19 -!- The topic of #crawl-dev is: Crawl Development | https://github.com/crawl/crawl | Logs: http://s-z.org/crawl-dev/, temporarily http://crawl.akrasiac.org/logs/cheibriados/ | People with +v have commit access, devs on bridged discord as well | General Crawl-related chat to #crawl | Long stuff to a pastebin service, please
20:39:19 -!- The topic of #crawl is: Play Dungeon Crawl Stone Soup online now! Type ??online for instructions, ??lg / !lg for play stats | PM Sequell for long queries | http://crawl.develz.org | FooTV game replays: ??footv for instructions | #crawl-dev for dev discussion, #crawl-offtopic for offtopic
23:35:20 <Gretell> Unstable branch on crawl.develz.org updated to: 0.33-a0-553-g146f489888 (34)
23:58:23 <Gretell> Windows builds of master branch on crawl.develz.org updated to: 0.33-a0-553-g146f489888