00:13:32 <Cbrotell> Unstable branch on cbro.berotato.org updated to: 0.33-a0-484-ge55ba79dcc (34)
00:55:34 <Gretell> Monster database of master branch on crawl.develz.org updated to: 0.33-a0-484-ge55ba79dcc
04:33:39 <Lantell> Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5249-g4a8afe7061
05:17:26 <NotCheibriados> 03regret-index02 07* 0.33-a0-485-g18c7c0e533: New monsters: alderkings, death trees for Depths and rarely Crypt 10(12 minutes ago, 41 files, 282+ 96-) 13https://github.com/crawl/crawl/commit/18c7c0e53314
05:32:20 <dcss-ci> 04Build failed for 08master @ 18c7c0e5 06https://github.com/crawl/crawl/actions/runs/12009839772
06:05:10 <NotCheibriados> 03regret-index02 07* 0.33-a0-486-gbec97544d0: Checkwhite 10(5 seconds ago, 1 file, 19+ 19-) 13https://github.com/crawl/crawl/commit/bec97544d0fd
08:34:52 -!- TAS-2012v is now known as TAS_2012v
12:45:28 <NotCheibriados> 03Implojin02 07* 0.33-a0-487-g20f8f3c1c4: Add Robert J. Redelmeier to the credits 10(7 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/20f8f3c1c449
12:50:50 <NotCheibriados> 03dependabot[bot]02 {Implojin} 07* 0.33-a0-488-gbdf4c9db22: Bump tornado in /crawl-ref/source/webserver/requirements 10(3 days ago, 2 files, 2+ 2-) 13https://github.com/crawl/crawl/commit/bdf4c9db229c
13:51:29 <NotCheibriados> 03hellmonk02 07[doubledown] * 0.33-a0-431-gd38a5f2e37: Add extreme couponing 10(2 minutes ago, 17 files, 84+ 69-) 13https://github.com/crawl/crawl/commit/d38a5f2e37c7
13:51:29 <NotCheibriados> 03hellmonk02 07[doubledown] * 0.33-a0-432-g8d44b91d9a: checkwhite 10(52 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/8d44b91d9a3e
14:01:04 <Discord|> <08n​icolae> tell me more about extreme couponing...
14:01:08 <Discord|> <08n​icolae> wait, is this for descent
14:02:22 <dcss-ci> 04Build failed for 08doubledown @ 8d44b91d 06https://github.com/crawl/crawl/actions/runs/12018562665
14:14:55 <NotCheibriados> 03hellmonk02 07[doubledown] * 0.33-a0-433-g97b8356728: add vouchers to $ and typo fix 10(27 seconds ago, 2 files, 6+ 1-) 13https://github.com/crawl/crawl/commit/97b8356728fb
14:21:46 <dcss-ci> 04Build failed for 08doubledown @ 97b83567 06https://github.com/crawl/crawl/actions/runs/12018904936
14:28:11 <geekosaur> oh. rebase
14:28:35 <NotCheibriados> 07geekosaur02 {Implojin} * 0.33-a0-470-g0f947df1d0:  disable installation of pkg-config and libpng 10(3 days ago, 1 file, 4+ 3-) 13https://github.com/crawl/crawl/commit/0f947df1d059
14:28:35 <geekosaur> %git HEAD^^{/pkg-config}
15:48:36 <NotCheibriados> 03DracoOmega02 07* 0.33-a0-489-g66324250c4: Allow deconstructing forgecraft constructs with ctrl+direction 10(36 minutes ago, 2 files, 12+ 1-) 13https://github.com/crawl/crawl/commit/66324250c4b5
15:48:36 <NotCheibriados> 03DracoOmega02 07* 0.33-a0-490-gcfb42be0b4: Don't allow looking at spell success rate changes for unequippable items 10(13 minutes ago, 3 files, 26+ 1-) 13https://github.com/crawl/crawl/commit/cfb42be0b4d6
15:48:36 <NotCheibriados> 03DracoOmega02 07* 0.33-a0-491-gd464759a54: Don't show EV/fail rate preview when examining unID'd randart weapons 10(12 minutes ago, 1 file, 4+ 1-) 13https://github.com/crawl/crawl/commit/d464759a5480
15:48:36 <NotCheibriados> 03DracoOmega02 07* 0.33-a0-492-g77984fd6c1: Improve out of range message when aiming Paragon finisher (pisaster) 10(57 seconds ago, 1 file, 5+ 1-) 13https://github.com/crawl/crawl/commit/77984fd6c15c
16:12:51 <Discord|> <04d​racoomega> So, I noticed this code as I am looking into refactoring something else today C++ static bool _fedhas_protects_species(monster_type mc) {     return mons_class_is_plant(mc)            && mons_class_holiness(mc) & MH_PLANT; }  and was like "What's with the double-check? Under what circumstances could something be a plant and also not a plant?" So I decided to look inside the other function and uh.... C++ bool
16:12:51 <Discord|> mons_class_is_plant(monster_type mc) {     return bool(mons_class_holiness(mc) & MH_PLANT); }
16:23:49 <Discord|> <09h​ellmonk> guessing at one point these were different checks (maybe back in the dual holiness days?)
16:28:08 <Discord|> <04d​racoomega> Maybe at some point. Seems pointless now, though. (Even _fedhas_protects_species seems pointless, really)
16:36:27 <Discord|> <12g​e0ff> somewhere around 0.19, these functions were slightly more complex: cpp static bool _fedhas_protects_species(monster_type mc) {     return mons_class_is_plant(mc)            && mons_class_holiness(mc) & MH_PLANT            && mc != MONS_BALLISTOMYCETE_SPORE            && mc != MONS_SNAPLASHER_VINE            && mc != MONS_SNAPLASHER_VINE_SEGMENT; }  and cpp bool mons_class_is_plant(monster_type mc) {     return mons_genus(mc) == MONS_PLANT
16:36:32 <Discord|> || mons_genus(mc) == MONS_FUNGUS            || mons_species(mc) == MONS_BUSH            || mc == MONS_SHAMBLING_MANGROVE; }
16:37:59 <Discord|> <04d​racoomega> Looks like the holiness check was still redundant even then, though?
16:39:17 <Lantell> Unstable branch on underhound.eu updated to: 0.33-a0-492-g77984fd6c1 (34)
18:11:42 <Discord|> <09g​ammafunk> monsters could have multiple holiness at one point
18:12:33 <Discord|> <09g​ammafunk> which doesn't really explain why the code is this way but it might be related to the reason
18:14:13 <Discord|> <04d​racoomega> (It may have made more sense in an even older version, perhaps)
18:14:22 <Discord|> <04d​racoomega> No matter, it'll be gone soon 😛
18:14:24 <Discord|> <09g​ammafunk> *0.10?whithered plant
18:14:25 <Discord|> <04C​erebot>  unknown monster: "whithered plant"
18:14:31 <Discord|> <09g​ammafunk> *??whithered plant
18:14:32 <Discord|> <04C​erebot>  unknown monster: "whithered plant"
18:14:45 <Discord|> <09g​ammafunk> *0.10?withered plant
18:14:45 <Discord|> <04C​erebot>  withered plant (P) | Speed: 0 | HD: 10 | Health: 38-70 | AC/EV: 10/0 | Flags: plant, vault | Res: magic(immune), poison, drown, neg+++, torm | XP: 0.
20:33:39 <NotCheibriados> 03DracoOmega02 07* 0.33-a0-493-g1dcf16d5f2: Refactor god_protects, shoot_through_monster, and related functions 10(32 minutes ago, 25 files, 190+ 293-) 13https://github.com/crawl/crawl/commit/1dcf16d5f2f0
20:33:39 <NotCheibriados> 03DracoOmega02 07* 0.33-a0-494-g7791d1a895: Fix some illusions not being marked as summoned/temporary 10(3 minutes ago, 5 files, 26+ 7-) 13https://github.com/crawl/crawl/commit/7791d1a895b6
20:40:22 <NotCheibriados> 03Isaac Clancy02 {DracoOmega} 07* 0.33-a0-495-g41443316a5: Warn when summoning with fulsome fusillade active (Flugkiller) 10(2 weeks ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/41443316a5c6
20:45:21 <dcss-ci> 04Build failed for 08master @ 7791d1a8 06https://github.com/crawl/crawl/actions/runs/12023283578
20:48:22 <geekosaur> ruh roh
20:49:22 <geekosaur> segfault in test suite with FULLDEBUG
20:50:34 <Discord|> <04d​racoomega> I am going to guess it's an arena crash related to the god_protects refactoring
20:50:44 <Discord|> <04d​racoomega> Will look into it in a moment
20:50:58 <Discord|> <04d​racoomega> (At least, that's the usual suspect in these sorts of situations)
20:52:42 <dcss-ci> 04Build failed for 08master @ 41443316 06https://github.com/crawl/crawl/actions/runs/12023356959
20:57:04 <Discord|> <04d​racoomega> Or perhaps it isn't
20:57:12 <Discord|> <04d​racoomega> (Will have to wait a while to recompile to run tests locally)
21:36:31 <Discord|> <04d​racoomega> Well, it only took me... nearly 40 minutes to rebuild and run those tests >.>
21:37:11 <Discord|> <04d​racoomega> (There were mysterious linker errors at the end of the first one that took make clean to fix, and so I had to do it twice >.>)
21:42:30 <Discord|> <04d​racoomega> (All that for a bug that took less than 5 minutes to find and fix once I could look at an actual crash log >.>)
21:45:16 <NotCheibriados> 03DracoOmega02 07* 0.33-a0-496-g5daf8ae013: Fix a knockback-related crash 10(3 minutes ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/5daf8ae01317
23:35:33 <Gretell> Unstable branch on crawl.develz.org updated to: 0.33-a0-496-g5daf8ae013 (34)
23:58:39 <Gretell> Windows builds of master branch on crawl.develz.org updated to: 0.33-a0-496-g5daf8ae013