00:12:52 <Discord|> <04d​racoomega> Trunk builds on CDO seem to have not updated in several days again
00:13:32 <Cbrotell> Unstable branch on cbro.berotato.org updated to: 0.33-a0-455-g5fac02aaea (34)
02:08:08 <Goratrix> @gammafunk Not sure if someone already flagged this, but the daily trunk builds on CDO are not building since Wednesday.
02:08:57 <Goratrix> ah, too late, I see it was flagged earlier today, nevermind :)
04:32:28 <Lantell> Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5249-g4a8afe7061
08:20:42 -!- Fieryknight2 is now known as fieryknight2
08:23:56 <Arachnite> Hi! Question: I need to hide the feet for my Jello species, to do that I found a block of code in tilepick-p.cc for naga and armataur. Is that the correct place?
08:24:20 <Arachnite> And also if I do add my species to that it tells me: tilepick-p.cc:1058:125: error: ‘TILEP_BASE_JELLO’ was not declared in this scope;
08:24:31 <Arachnite> Which is fair enough, but where do I need to declare it?
08:24:51 <Arachnite> I tried finding TILEP_BASE_NAGA and enter TILEP_BASE_JELLO at the same places but that seems to be not enough.
08:42:20 <Discord|> <03i​mplojin> you might want to try comparing your changes to one of the more recent commits that added a species to the game:
08:42:29 <Discord|> <03i​mplojin> %git afeb8edd3b8c5a
08:42:30 <Discord|> <04C​erebot> DracoOmega * 0.31-a0-1326-gafeb8edd3b: Change player Ogres into Oni, shorten Armataur tongues (11 months ago, 35 files, 209+ 108-) https://github.com/crawl/crawl/commit/afeb8edd3b8c
08:42:46 <Discord|> <03i​mplojin> %git c3fac4b18bf8fceb
08:42:46 <Discord|> <04C​erebot> PleasingFungus * 0.27-a0-722-gc3fac4b18b: New race: Djinni (3 years, 8 months ago, 52 files, 721+ 256-) https://github.com/crawl/crawl/commit/c3fac4b18bf8
08:43:18 <Discord|> <03i​mplojin> (i didn't link coglin because coglin touched lots of files due to their game mechanics)
08:44:04 <Arachnite> Thanks
08:44:42 <Arachnite> I look at hill dwarves but that didn't have any TILEP, if I don't enter that in the "hide feet" code then it compiles but my species has feet ;)
08:45:30 <Arachnite> I thought his would do it for me too:     case SP_DJINNI:
08:45:34 <Arachnite> return TILEP_BASE_DJINNI;
08:45:53 <Arachnite> but that doesn't seem to make a difference (replacing DJINNI with JELLO)
08:46:49 <Discord|> <03i​mplojin> it's really really hard to diagnose code errors when you're posting snippets here and there
08:47:14 <Discord|> <03i​mplojin> a link to the entirety of your changes posted as a git branch or a diff would be much easier
08:48:06 <Arachnite> Ok I can do that but I haven't uploaded the changes to a git yet
08:48:11 <Arachnite> I will do that and then come back
08:48:16 <Arachnite> Thanks
15:15:16 <NotCheibriados> New branch created: dependabot/pip/crawl-ref/source/webserver/requirements/tornado-6.4.2 (1 commit) 13https://github.com/crawl/crawl/tree/dependabot/pip/crawl-ref/source/webserver/requirements/tornado-6.4.2
15:15:16 <NotCheibriados> 03dependabot[bot]02 {GitHub} 07[dependabot/pip/crawl-ref/source/webserver/requirements/tornado-6.4.2] * 0.33-a0-456-g79b353b423: Bump tornado in /crawl-ref/source/webserver/requirements 10(42 seconds ago, 2 files, 2+ 2-) 13https://github.com/crawl/crawl/commit/79b353b423b4
15:15:17 <NotCheibriados> New branch created: pull/4144 (1 commit) 13https://github.com/crawl/crawl/pull/4144
15:15:17 <NotCheibriados> Branch pull/4144 updated to be equal with dependabot/pip/crawl-ref/source/webserver/requirements/tornado-6.4.2: 13https://github.com/crawl/crawl/pull/4144
15:38:55 <Discord|> <09g​ammafunk> has the CDO issue resolved itself?
15:41:55 <Discord|> <09g​ammafunk> %git
15:41:57 <Discord|> <04C​erebot> Implojin * 0.33-a0-455-g5fac02aaea: Revert "Fix slime not showing around slime walls after reload" (28 hours ago, 2 files, 15+ 20-) https://github.com/crawl/crawl/commit/5fac02aaea41
15:42:44 <Discord|> <09g​ammafunk> > In file included from mutation.cc:93:0: > mutation-data.h:2843:1: error: braces around scalar initializer for type ‘const char*’ >  }; >  ^
15:49:25 <Discord|> <04d​racoomega> Huh?
15:52:15 <geekosaur> bzuh? what compiler is producing that confusion?
15:55:48 <Discord|> <09g​ammafunk> gcc 6.3.0
15:58:22 <geekosaur> weird. category_mut_data is braced, each element (which is a struct mutation_category_def) is braced, the contained const char * is not? what you smoking, gcc?
16:01:48 <Discord|> <09g​ammafunk> %git 8f22220ccd75e593bb1d47ba9a3c0141e9c32d39
16:01:49 <Discord|> <04C​erebot> regret-index * 0.33-a0-443-g8f22220ccd: Yet further and further additional tiles (3 days ago, 35 files, 52+ 20-) https://github.com/crawl/crawl/commit/8f22220ccd75
16:01:50 <Discord|> <04d​racoomega> I mean, gcc compiles without errors in all the github jobs. Different version?
16:02:17 <Discord|> <09g​ammafunk> different version of what? gcc runs in different versions on every server, from server to server
16:02:44 <geekosaur> I have 13.2.0 (Ubuntu 24.04)
16:02:44 <Discord|> <09g​ammafunk> there are probably no two servers that have the same version of gcc, if I had to guess
16:02:55 <geekosaur> and that, yes
16:02:58 <Discord|> <09g​ammafunk> but yeah, it compiles with my recent ubuntu and in CI
16:03:14 <Discord|> <09g​ammafunk> this is a far older version (and other servers likewise have pretty old versions)
16:03:46 <Discord|> <09g​ammafunk> so we probably can make a workaround commit...once we figure out which line is actually offending 6.3.0
16:04:11 <Discord|> <09g​ammafunk> that commit I linked is an obvious "suspect" (not that it did anything actually wrong)
16:04:23 <Discord|> <09g​ammafunk> I can probably just do some bisecting on cdo to figure it out, so let me try
16:04:51 <Discord|> <04d​racoomega> Is there any good reason a server should be running such an old version anyway?
16:05:14 <Discord|> <09g​ammafunk> well yes, the reason is: upgrading server OSes is extremely non-trivial
16:05:20 <Discord|> <04d​racoomega> (I apparently also have 13.2.0)
16:05:41 <Discord|> <09g​ammafunk> and making some sort of container in which compilation happens with a more recent toolchain has its own requirements/issues
16:06:25 <Discord|> <04d​racoomega> Maybe I don't understand. How is updating just a compiler on a server equivalent to upgrading its OS? Or is it the OS is so old it doesn't even support modern gcc?
16:07:23 <Discord|> <09g​ammafunk> it's equivalent in the sense that the OS has a packaged toolchain that can be relatively easily installed, and most servers in crawl land just compile with the OS' native toolchain
16:07:59 <Discord|> <09g​ammafunk> if you want a different toolchain for compilation, you need to set that up (it's not just gcc/clang, it's also many other supporting programs) in some standalone way that doesn't disrupt the OS one
16:10:14 <Discord|> <04d​racoomega> Wait
16:10:15 <Discord|> <09g​ammafunk> but the bottom line is that we're not going to set up a newer compiler on CDO (unless Napkin decides he wants that, which he could!)
16:10:27 <Discord|> <04d​racoomega> That commit is wrong
16:10:49 <Discord|> <04d​racoomega> In fact, it's sort of worrisome, on examination, why this doesn't cause an error elsewhere, if I'm understanding this correctly
16:11:15 <Discord|> <04d​racoomega> TILEG_MUT_INVIOLATE_MAGIC was supposed to replace that 0, not go before it
16:11:16 <Discord|> <09g​ammafunk> diff --- a/crawl-ref/source/mutation-data.h +++ b/crawl-ref/source/mutation-data.h @@ -43,6 +43,8 @@ static const mutation_def mut_data[] =    {"Your magical power and effects resist disruption.", "", ""},    {"Your magical power grows resistant to disruption.", "", ""},    {"Your magical power loses its resistance to disruption.", "", ""}, + +  TILEG_MUT_INVIOLATE_MAGIC,    0, {"Your magical power will grow resistant to disruption."}
16:11:16 <Discord|> },
16:11:19 <Discord|> <09g​ammafunk> yes
16:11:25 <Discord|> <09g​ammafunk> that looks suspicious to me
16:12:18 <Discord|> <09g​ammafunk> so I guess that's getting us the right tile but getting the empty string for the intended last message?
16:12:26 <Discord|> <04d​racoomega> Probably?
16:12:45 <Discord|> <09g​ammafunk> well, I guess I can push a fix
16:12:49 <Discord|> <09g​ammafunk> unless you have it ready
16:12:58 <Discord|> <04d​racoomega> (I wa on a branch doing other things, so no)
16:13:07 <Discord|> <09g​ammafunk> will, do thanks for looking
16:13:22 <Discord|> <09g​ammafunk> something something it's actually good to run ancient version of compilers (???)
16:13:44 <Discord|> <04d​racoomega> That feels like a stopped clock being right twice a day sort of thing
16:14:09 <Discord|> <09g​ammafunk> yes, the other time it's right is when the CAO compiler tries things (it's even older)
16:14:14 <Discord|> <04d​racoomega> (It does kind of feel like the code above should have at least caused a warning, though)
16:14:42 <Discord|> <09g​ammafunk> yeah like presumably that struct doesn't have room for the extra initialization value that the commit effectively added
16:14:48 <Discord|> <04d​racoomega> One of those "Are you really sure you meant this?" sorts of things
16:14:53 <Discord|> <09g​ammafunk> but I guess that's ignored?
16:15:07 <Discord|> <04d​racoomega> Well, the final const array can take 3 strings
16:15:15 <Discord|> <04d​racoomega> If you were to somehow be able to gain 3 levels of it
16:15:24 <Discord|> <04d​racoomega> Relevant for some mutations, but not this one
16:15:32 <Discord|> <09g​ammafunk> ah
16:15:35 <Discord|> <09g​ammafunk> yeah I see
16:15:46 <Discord|> <04d​racoomega> But being able to initialize the contents of a single array via an argument outside of braces and one inside braces seems just wrong
16:20:03 <Discord|> <06p​leasingfungus> hear me out: mutation yamlification???
16:20:27 <Discord|> <09g​ammafunk> it can't happen soon enough!
16:20:35 <Discord|> <09g​ammafunk> full yamlification of crawl imo
16:21:13 <Discord|> <06p​leasingfungus> you joke, but,
16:23:10 <geekosaur> (until that means YAML-as-code and you discover why that's a crawling horror)
16:23:17 <Discord|> <09g​ammafunk> yeah, seems largely good to maximize moving data out of code (into yaml), but I'm not sure at what point the approach runs into problems
16:23:42 <Discord|> <06p​leasingfungus> the smaller the code structure, the less compelling it is
16:24:00 <Discord|> <04d​racoomega> Mutation data is mostly strings
16:24:03 <Discord|> <06p​leasingfungus> i think even something like spl-to-zap might be net negative in yaml
16:24:21 <NotCheibriados> 03gammafunk02 07* 0.33-a0-456-g49d95937af: Fix the build (DracoOmega) 10(5 minutes ago, 1 file, 1+ 2-) 13https://github.com/crawl/crawl/commit/49d95937af09
16:24:48 <Discord|> <06p​leasingfungus> draco: i wonder if we could also dataify the mutation conflict list at the top of mutation.cc, and maybe some of the insane special cases lower down... but haven't thought about it much
16:27:06 <Discord|> <04d​racoomega> Haven't looked a mutation conflict code all that closely before, I think
16:29:59 <dcss-ci> 04Build failed for 08master @ 49d95937 06https://github.com/crawl/crawl/actions/runs/11981691600
16:30:05 <Discord|> <04d​racoomega> I will say though that yaml that auto-generates enums that are included everywhere can trigger full-recompilation for edits that previously would not have
16:30:21 <Discord|> <04d​racoomega> Since it will regenerate the enum list even if nothing in it changes
16:31:02 <Discord|> <04d​racoomega> (Like, you can't change any job's starting spells or such without doing a major recompile, which didn't used to be the case before yaml-ification, I believe)
16:31:23 <Discord|> <09g​ammafunk> is the macos CI build broken again?
16:31:33 <Discord|> <04d​racoomega> It seems to happen periodically
16:31:35 <Discord|> <04d​racoomega> Not all the time
16:32:02 <Discord|> <09g​ammafunk> oh, that CI error didn't look like something that was part of CI's periodic problems, but I certainly wouldn't really know
16:32:20 <Discord|> <04d​racoomega> (I guess I didn't look at the error, but it just feels like it happens inconsistently these days)
16:32:44 <Discord|> <09g​ammafunk> I guess if we keep seeing it, we can ping advil and ask for help
16:32:59 <Discord|> <09g​ammafunk> CDO did get through the new mutation-data.h so we should be fine there
16:33:02 <geekosaur> that's not the weird built-for-the-wrong-arch
16:34:24 <Discord|> <09g​ammafunk> although: > view.cc: In function ‘void flash_tile(coord_def, colour_t, int, tileidx_t)’: > view.cc:1523:68: warning: unused parameter ‘tile’ [-Wunused-parameter] >  void flash_tile(coord_def p, colour_t colour, int delay, tileidx_t tile) >                                                                     ^~~~
16:34:54 <Gretell> Unstable branch on crawl.develz.org updated to: 0.33-a0-456-g49d95937af (34)
16:34:59 <geekosaur> looks like you're trying to overwrite the original pkg-config package with the C rewrite?
16:35:33 <Discord|> <04d​racoomega> Oh, right, someone mentioned that to me a few days back
16:35:41 <Discord|> <04d​racoomega> And I think I forgot about it since it doesn't produce a warning on my own compiler
16:35:44 <geekosaur> which will require removing or at least unlinking the one that's installed
16:36:03 <geekosaur> likely depends on the homebrew and/or how up to date it is
16:36:14 <geekosaur> GHA's builder env does change periodically
16:36:15 <Discord|> <04d​racoomega> (Probably the answer is to ifdef the function signature on tiles versus console to comment out that unused argument)
16:36:35 <geekosaur> oh, whoops, switched subject
16:36:41 <geekosaur> yes that one was mentioned before
16:37:10 <Discord|> <04d​racoomega> (I'll get to it later today unless someone feels like handling it first ^^; )
16:51:28 <Gretell> Windows builds of master branch on crawl.develz.org updated to: 0.33-a0-456-g49d95937af
17:43:29 <Discord|> <06p​leasingfungus> draco: re mutation conflicts, believe i was thinking of mutation_activity_level
17:43:40 <Discord|> <06p​leasingfungus> which is a really powerful mess of... stuff
17:44:00 <Discord|> <06p​leasingfungus> oh nvm lol
17:44:01 <Discord|> <06p​leasingfungus> sorry
17:44:15 <Discord|> <06p​leasingfungus> actually meant physiology_mutation_conflict
17:44:16 <Discord|> <06p​leasingfungus> wrong mess!
17:45:25 <Discord|> <04d​racoomega> Ah, right, yes
17:47:20 <Discord|> <06p​leasingfungus> iirc a lot of that is in there because it's hard to dataify
17:47:47 <Discord|> <06p​leasingfungus> but it feels like there must be some way to make it at least a little less messy...
17:48:04 <Discord|> <06p​leasingfungus> esp stuff like this       // Today's guru wisdom: octopodes have no hands.     if (you.has_innate_mutation(MUT_TENTACLE_ARMS) && mutat == MUT_CLAWS)         return true;   surely this could go in the conflict data structure?
17:48:32 <Discord|> <04d​racoomega> It looks like it on first glance, at least
17:48:54 <Discord|> <04d​racoomega> I wonder if there's any reason it isn't, other than 'It got put here first'?
17:49:37 <Discord|> <04d​racoomega> (A common consequence when there's more than one functional place to put something is that it ends up effectively random what goes where)
17:51:02 <Discord|> <04d​racoomega> I guess putting it like that this is a one-directional conflict, isn't it?
17:51:28 <Discord|> <04d​racoomega> In that having MUT_CLAWS doesn't prevent gaining MUT_TENTACLE_ARMS (not that it is slightly meaningful that this is the case, I assume)
19:11:35 <Discord|> <06p​leasingfungus> my suspicion is it'd be trivial to move out, yeah
19:12:00 <Discord|> <06p​leasingfungus> i'd do it myself if i wasn't dead beat (just got out of labor and delivery a few hours ago)
19:12:18 <Discord|> <06p​leasingfungus> (well, pediatrics, i guess. labor and delivery was yesterday)
19:17:17 <Discord|> <04d​racoomega> Oh!
19:17:57 <Discord|> <04d​racoomega> Yes, this feels like an uncountably low priority by comparison ^^;
19:37:52 <Discord|> <06p​leasingfungus> unrelated, an online friend elsewhere reports:
19:37:52 <Discord|> <06p​leasingfungus> https://cdn.discordapp.com/attachments/747522859361894521/1309709473392361565/image.png?ex=6742917f&is=67413fff&hm=ff76c74142d4073798238787e54533f564577f0596ec4173d7a9d7d9b5093388&
19:46:39 <Discord|> <09g​ammafunk> I'm glad that blork's flavor got more developed, and it's extremely crawl how blork is now a fairly bizarre mashup of its very humble origins (a random old TV reference that was probably only made because it's a pun) and vampires
19:47:25 <Discord|> <06p​leasingfungus> it is yes
19:48:12 <Discord|> <06p​leasingfungus> the raves continue
19:48:12 <Discord|> <06p​leasingfungus> https://cdn.discordapp.com/attachments/747522859361894521/1309712075198562314/feedback.png?ex=674293ec&is=6741426c&hm=e6b3e910712639d3f0dead47d7be580f4e342fcbc615114c0d3e3cb6eaaa5b15&
19:50:38 <Discord|> <06p​leasingfungus> > they made a lot of otherwise "boring but effective" options seem a lot more interesting to use >  > I'm also glad the changes to summoning in general(not just the school) make your allies feel more 'focused' and not just like, a Swarm Of Dudes
19:58:31 <Discord|> <04d​racoomega> ^^
19:59:40 <Discord|> <04d​racoomega> I am always glad to know people are enjoying my work ^^;
20:07:01 <Discord|> <09g​ammafunk> give Norris a new spell to improve his killratio: Swarm of Dudes
20:15:08 <geekosaur> +1 surfboards 😛
21:05:04 <Discord|> <06p​leasingfungus> one last feedback to pass along  > eringya's surprising crocodile might be the optimal combination of spell name/mechanical execution
21:05:12 <Discord|> <06p​leasingfungus> i did not realize that spell existed (i am very behind) and wow
21:05:48 <Discord|> <06p​leasingfungus> It cannot be recast while the crocodile is still active.  the crocodile is still active..!
21:07:01 <NotCheibriados> 03regret-index02 07* 0.33-a0-457-ga727347fca: Heavily revise and revive ironbound beastmasters 10(31 minutes ago, 32 files, 179+ 18-) 13https://github.com/crawl/crawl/commit/a727347fca8b
21:07:01 <NotCheibriados> 03regret-index02 07* 0.33-a0-458-g5383b0d124: Tweak the Iceblast effect tile (DracoOmega) 10(8 minutes ago, 4 files, 2+ 0-) 13https://github.com/crawl/crawl/commit/5383b0d12402
21:19:26 <dcss-ci> 04Build failed for 08master @ 5383b0d1 06https://github.com/crawl/crawl/actions/runs/11983966812
21:24:07 <geekosaur> I think the simplest fix for that is just to remove the `brew install` command entirely; it appears to have been intended to work around missing dependencies in an older GHA image, but both are present these days
21:35:43 <NotCheibriados> New branch created: pull/4145 (1 commit) 13https://github.com/crawl/crawl/pull/4145
21:35:43 <NotCheibriados> 03geekosaur02 07https://github.com/crawl/crawl/pull/4145 * 0.33-a0-323-gcba287d7bb:  disable installation of pkg-config and libpng 10(89 seconds ago, 1 file, 4+ 3-) 13https://github.com/crawl/crawl/commit/cba287d7bbcf
21:45:57 <geekosaur> that one's successful, now for the other
21:46:23 <NotCheibriados> New branch created: pull/4146 (1 commit) 13https://github.com/crawl/crawl/pull/4146
21:46:23 <NotCheibriados> 03geekosaur02 07https://github.com/crawl/crawl/pull/4146 * 0.33-a0-459-g52448ccb9c: silence flash_tile warning on console builds 10(3 minutes ago, 1 file, 7+ 1-) 13https://github.com/crawl/crawl/commit/52448ccb9c47
23:35:19 <Gretell> Unstable branch on crawl.develz.org updated to: 0.33-a0-458-g5383b0d124 (34)
23:58:03 <Gretell> Windows builds of master branch on crawl.develz.org updated to: 0.33-a0-458-g5383b0d124