00:33:04 Unstable branch on cbro.berotato.org updated to: 0.33-a0-430-g2e717cac72 (34) 00:55:27 Monster database of master branch on crawl.develz.org updated to: 0.33-a0-430-g2e717cac72 04:34:33 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5249-g4a8afe7061 10:19:29 <08nicolae> if an oni drinks an unknown potion with delatra's gloves and gets healing, do they still get to do the drunken swing 10:40:35 <06pleasingfungus> i think it's based on potion type, not potion effect 10:50:19 <08nicolae> i figured but it would be neat 11:10:31 <06pleasingfungus> should've prefaced it with 🇫🇷 😛 11:38:57 <09gammafunk> I prefaced something once 12:16:29 03DracoOmega02 07* 0.33-a0-431-g02a2365326: Improve spell failure change description (Ge0FF) 10(31 seconds ago, 1 file, 16+ 5-) 13https://github.com/crawl/crawl/commit/02a236532649 15:12:09 03DracoOmega02 07* 0.33-a0-432-g30e30eea18: Unbreak Vanquished Vanguard / Summon Mortal Champion summon cap (Ge0FF) 10(63 minutes ago, 1 file, 6+ 1-) 13https://github.com/crawl/crawl/commit/30e30eea1891 15:14:53 <04dracoomega> You know how I said the other day that I thought it would be better to let you search by school in the normal spell lookup, instead of having a 'lookup by school' search option? Well, I went and actually implemented the former, and after using it, I think I have changed my mind. (You can get monster spells as exact-text matches for some schools, even though those are filtered from the actual school lookup. Like, you get Call Lost 15:14:53 Souls because it mentions necromancy, and a huge number obvously match 'fire' - for all the spells that fire things. And in the end, I think it's more confusing when the player thinks they've looked up a spell school, and gets a bunch of things not in that school showing up there) 15:19:08 <12ge0ff> What if there was some special syntax for searching for spell schools in the spell lookup? Like @Fire; and there were some inline help in the UI, just a line near the input field, which mentions how to use that 15:20:46 <12ge0ff> (and under the hood, @Fire would search only inside spell schools, ignoring the description text) 15:21:05 <04dracoomega> Hmm... it's a thought 15:39:35 <04dracoomega> Okay, that is definitely a lot better. Still includes a handful of spells that are technically player-castable, but not player-learnable (like draconian breaths, hurl torchlight, spells in wands, etc.) 15:39:59 <04dracoomega> Maybe I could just add a flag specifically for 'Don't show up in school searches' 15:40:06 <04dracoomega> Like 'not a book spell' 15:40:32 <04dracoomega> ...actually, if I did that, maybe we could get rid of that kind of terrible function for "Don't assert on game start, just because this spell isn't in a book, but also isn't a monster spell" 15:40:38 <04dracoomega> And have it reference this flag also 15:45:53 <12ge0ff> is it possible to use is_player_book_spell(), which already exists? 15:51:32 <04dracoomega> ....probably, yes 15:51:39 <04dracoomega> So I notice, after doing most of the conversion 15:51:54 <04dracoomega> (Maybe it still makes sense to do??) 16:35:18 03DracoOmega02 07* 0.33-a0-433-g438ea5f9f1: Allow looking up spells by school with ?/s 10(64 seconds ago, 1 file, 35+ 7-) 13https://github.com/crawl/crawl/commit/438ea5f9f1f9 16:40:09 Unstable branch on underhound.eu updated to: 0.33-a0-432-g30e30eea18 (34) 18:07:56 <02Monkooky> Should Kinetic Grapnel be marked as destructive? 18:08:08 <02Monkooky> feel like it should trigger battlesphere 19:23:21 <09gammafunk> cpp // Did we just come into view? // TODO: This doesn't seem to work right. Fix, or remove? 19:23:24 <09gammafunk> love to see it when reading monster movement code 19:27:00 <04dracoomega> Possibly. (I think I hesitated on it being half a melee enhancer, but it's probably awkward that it doesn't work with battlesphere in the same school. I'd mostly just thought about Veh at the time, I admit) 19:35:03 <08nicolae> even without the melee enhancement it still Hurts when you grapnate somebody, so i'd put it as destructive 19:47:08 03Isaac Clancy02 {DracoOmega} 07* 0.33-a0-434-gee4b17a322: Round down the displayed damage for thrown weapons (sdynet) 10(9 days ago, 4 files, 8+ 6-) 13https://github.com/crawl/crawl/commit/ee4b17a32281 19:47:08 03Isaac Clancy02 {DracoOmega} 07* 0.33-a0-435-gc7453fe8aa: Fix autofight not moving over web with slick slippers (jejorda2) 10(6 days ago, 2 files, 4+ 1-) 13https://github.com/crawl/crawl/commit/c7453fe8aa72 19:47:08 03Isaac Clancy02 {DracoOmega} 07* 0.33-a0-436-g1c2b424464: Let grey draconians keep iron scales in dragon form (kuniqsX) 10(6 days ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/1c2b424464a0 19:47:08 03Isaac Clancy02 {DracoOmega} 07* 0.33-a0-437-g9afaf516a7: Don't blame the player when a confused ally kills (BarneyGumball) 10(7 days ago, 1 file, 26+ 2-) 13https://github.com/crawl/crawl/commit/9afaf516a7fe 19:47:08 03Isaac Clancy02 {DracoOmega} 07* 0.33-a0-438-g96a7ec282a: Fix slime not showing around slime walls after reload 10(6 days ago, 2 files, 20+ 15-) 13https://github.com/crawl/crawl/commit/96a7ec282a2d 19:47:08 03Isaac Clancy02 {DracoOmega} 07* 0.33-a0-439-g51936a82b6: Fix display of GDR in wizmode 10(6 days ago, 5 files, 7+ 6-) 13https://github.com/crawl/crawl/commit/51936a82b6ee 19:47:08 03Aliscans02 {DracoOmega} 07* 0.33-a0-440-g43d13352a3: Don't let non-damaging clouds or walls stop shift+dir running. 10(3 months ago, 1 file, 2+ 6-) 13https://github.com/crawl/crawl/commit/43d13352a343 20:32:14 <06wensley> let's not lose sight of the original goal here, which is just to have a way for the player to answer the question "what spells are in this school?". it doesn't necessarily need to involve searching via ?/, if there's some other mechanism that doesn't need to resort to hacks or workarounds 20:37:34 <06wensley> for example, an alternate approach might be to add a "show all spells" mode to the I or M menus, in the same way that there's a "show all skills" mode in m. and then from there, you can add a way to sort/filter in any way the player wants but crucially you have a richer output where there's already a column showing the spell school so the cost of false positives is less and you don't have to worry about monster spells (and also M 20:37:34 already supports ctrl+f) 20:39:30 -!- The topic of #crawl-dev is: Crawl Development | https://github.com/crawl/crawl | Logs: http://s-z.org/crawl-dev/, temporarily http://crawl.akrasiac.org/logs/cheibriados/ | People with +v have commit access, devs on bridged discord as well | General Crawl-related chat to #crawl | Long stuff to a pastebin service, please 20:39:30 -!- The topic of #crawl is: Play Dungeon Crawl Stone Soup online now! Type ??online for instructions, ??lg / !lg for play stats | PM Sequell for long queries | http://crawl.develz.org | FooTV game replays: ??footv for instructions | #crawl-dev for dev discussion, #crawl-offtopic for offtopic 20:53:51 <04dracoomega> I mean, do you think there's anything importantly lacking in what I did push today on that front? 21:01:45 <06wensley> I think the commit you pushed is a good feature to have, though I don't think that people are going to intuit the @foo syntax, so it might still be good to have another way of getting this info. although perhaps the more general solution is to make the in-game knowledge base more easily browseable in a broader sense, which probably requires some thought 21:02:16 <06wensley> but it does solve my immediate question of getting an easy in-game list of all forgecraft spells 😛 22:46:25 03regret-index02 07* 0.33-a0-441-gf19855ecf0: Give Dispater AF_CORRODE 10(28 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/f19855ecf09c 22:46:25 03yrdzrfxndfvh02 {regret-index} 07* 0.33-a0-442-g3db37b140e: add monsters to ziggurat_pillar_centre_c (#4109) 10(2 weeks ago, 1 file, 18+ 14-) 13https://github.com/crawl/crawl/commit/3db37b140ebd 22:46:25 03regret-index02 07* 0.33-a0-443-g8f22220ccd: Yet further and further additional tiles 10(4 minutes ago, 35 files, 52+ 20-) 13https://github.com/crawl/crawl/commit/8f22220ccd75