00:20:15 Unstable branch on cbro.berotato.org updated to: 0.33-a0-305-g75134b2f13 (34) 00:55:16 Monster database of master branch on crawl.develz.org updated to: 0.33-a0-305-g75134b2f13 01:20:16 Stable (0.32) branch on cbro.berotato.org updated to: 0.32.1-3-gfed517dd83 04:52:21 New branch created: pull/4118 (1 commit) 13https://github.com/crawl/crawl/pull/4118 04:52:22 03Aliscans02 07https://github.com/crawl/crawl/pull/4118 * 0.33-a0-306-gc5bbddfdab: Use more nouns when a boulder pushes something into the unknown. 10(65 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/c5bbddfdab40 05:24:40 03Aliscans02 {nlavsky} 07* 0.33-a0-306-g6a9379c173: Use more nouns when a boulder pushes something into the unknown. 10(2 hours ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/6a9379c17388 06:52:52 03nlavsky02 07* 0.33-a0-307-gfd16a8b4c0: text: update the description of Bolt of Light 10(3 minutes ago, 1 file, 2+ 3-) 13https://github.com/crawl/crawl/commit/fd16a8b4c00a 06:56:30 04Build failed for 08master @ fd16a8b4 06https://github.com/crawl/crawl/actions/runs/11765728546 06:59:22 <08n​lavsky> Hmm, > Error: macOS console-universal > Process completed with exit code 2. 07:01:00 <08n​lavsky> (also, there are 30 (!) build warnings about a deprecated Node.js version) 09:20:44 <04d​racoomega> Is there any particular good reason we use mons_is_firewood() instead of something like actor::is_firewood()? It's a really common idiom to write stuff like if (targ->is_monster() && mons_is_firewood(*targ->as_monster()) and if (targ->is_firewood()) is so much shorter. 09:25:43 <04d​racoomega> I'm getting around to 'remove mons_is_object() and restructure how mons_is_conjured() is used` as some of the remaining forgecraft-related work, and the latter also has the same sort of issue 09:25:50 <04d​racoomega> So I couldn't help but wonder if I should change it 10:08:04 <09g​ammafunk> I think people have tended to make functions taking a monster pointer or ref instead of an actor method just because it's a bit easier or less "scary" to make a new stand alone function instead of a method. Also due to how coarse our class structure is in terms of actors/monsters in that a lot of stuff just gets shoved directly into those classes without any composition when certain related things in actor/monster might work better if 10:08:04 they were modeled with their own class. So at the end of the day I think it's just "your call". actor::is_firewood() seems like it should be fine but you would have lots of function calls to update 10:56:54 <04d​racoomega> Yeah, at least to me, making standalone functions seems reasonable if they're a sort of narrow use-case, not called that often, or generally only relevant in situations where you're already going to know in advance that something is a monster (or the player). But firewood checks are used an enormous number of times in places where both the player and monsters are arguments, so I think it would be more readable if they were an actor 10:56:54 method. (As I said, there's already related refactoring I need to do, so I don't mind doing this at the same time) 16:18:44 New branch created: pull/4119 (1 commit) 13https://github.com/crawl/crawl/pull/4119 16:18:44 03Isaac Clancy02 07https://github.com/crawl/crawl/pull/4119 * 0.33-a0-308-g5b9a6f71f1: Fix grow oklob not placing under the player 10(23 minutes ago, 1 file, 10+ 8-) 13https://github.com/crawl/crawl/commit/5b9a6f71f1b9 16:37:43 Unstable branch on underhound.eu updated to: 0.33-a0-307-gfd16a8b4c0 (34) 19:58:22 New branch created: pull/4120 (1 commit) 13https://github.com/crawl/crawl/pull/4120 19:58:23 03Isaac Clancy02 07https://github.com/crawl/crawl/pull/4120 * 0.33-a0-308-g263af2e446: Round down the displayed damage for thrown weapons 10(10 minutes ago, 4 files, 8+ 6-) 13https://github.com/crawl/crawl/commit/263af2e4462a 23:35:25 Unstable branch on crawl.develz.org updated to: 0.33-a0-307-gfd16a8b4c0 (34) 23:57:56 Windows builds of master branch on crawl.develz.org updated to: 0.33-a0-307-gfd16a8b4c0