00:21:21 New branch created: pull/4073 (2 commits) 13https://github.com/crawl/crawl/pull/4073 00:21:23 03heinrich02 07https://github.com/crawl/crawl/pull/4073 * 0.33-a0-213-g440f117d30: Adds current tile location to the description of aiming prompts 10(2 hours ago, 1 file, 12+ 1-) 13https://github.com/crawl/crawl/commit/440f117d3036 00:21:23 03heinrich02 07https://github.com/crawl/crawl/pull/4073 * 0.33-a0-214-g42c94764d4: Added comments for some cell description methods. 10(10 days ago, 1 file, 10+ 1-) 13https://github.com/crawl/crawl/commit/42c94764d402 00:22:29 03heinrich02 07https://github.com/crawl/crawl/pull/4073 * 0.33-a0-215-gd5c0f56545: Fix typo 10(45 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/d5c0f565456d 03:32:45 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5208-geafff8c3b6 05:27:53 Unstable branch on crawl.akrasiac.org updated to: 0.33-a0-212-g6d1de5a (34) 08:13:37 <09g​ammafunk> @dracoomega I'm going to add "summoner" information to clua by having a monster clua method (i.e. a method one calls from the monster info clua table class we use to represent monsters in clua). This method will return the player LOS coordinates of the monster's summoner, or nil if the monster doesn't meet the requirements of being reported as a summon to the player (i.e. it's a summon that's not a hostile phantom mirror summon), or 08:13:37 if its summoner isn't in LOS, or if it's summoner is the player. To do this, I'm going to move the summoner's coordinates into monster_info, since this class is the way clua likes to query information about monsters in general (as opposed to directly accessing the monster properties). I may refactor the direction_chooser methods ::highlight_summoner and ::find_summoner to use the monster_info data, but I need to look a bit more into whether this makes 08:13:38 much sense, as the monster introspection needed by these is very simple. Are there any other general gotchas I need to be aware wrt to any of this? Only asking because you've done the recent work with summons 08:15:13 <04d​racoomega> Well, I hadn't actually touched any of those methods myself (though to the best of my knowledge, they are still reporting the proper information in the UI, despite my changes) 08:16:35 <04d​racoomega> Though the game should hopefully be a lot more consistent about MB_SUMMONED for exactly those monsters which will go poof upon their summoner's death, and not any other ones they may have created (like ball lightning and such). There were a few minor inconsistencies before. 08:16:44 <09g​ammafunk> Aside from how annoyingly difficult it was to find the relevant UI code/check for reporting the summoner in the first place, I didn't see anything that looked dangerous 08:18:21 <09g​ammafunk> Yeah, the only check these methods care about are the monster being in los and that the monster not be a hostile phantom mirror (well, only monster_info actually cares about hostile or not internally for giving a monster the summoned monster flag; the UI refuses to report the summoner of any phantom mirror summon 08:18:58 <09g​ammafunk> presumably if you could make a friendly rakshasa make a phantom mirror, the UI won't show the summoner like it would for a normal friendly summon 08:19:02 <09g​ammafunk> I should test that 08:20:03 <09g​ammafunk> maybe friendly rakshasas don't even use the spell... 08:20:29 <09g​ammafunk> oh ok force lance, that confused me a for a second 08:20:35 <09g​ammafunk> they will of course use that 08:20:50 <04d​racoomega> No, you'd get to see that anyway 08:20:56 <04d​racoomega> C++ if (m->is_summoned() && !(m->flags & MF_PERSISTS) && (!m->has_ench(ENCH_PHANTOM_MIRROR) || m->friendly())) { mb.set(MB_SUMMONED); 08:20:58 <04d​racoomega> Where the flag is set 08:21:20 <09g​ammafunk> yes, that's done for the flag 08:21:29 <09g​ammafunk> but the UI doesn't examine this monster_info 08:21:40 <09g​ammafunk> it directly examines the monster 08:21:52 <09g​ammafunk> I'm specifically talking about the highlighting of the summoner in the direction_chooser UI 08:21:57 <09g​ammafunk> e.g. when using x 08:22:27 <09g​ammafunk> I had wanted to make the UI just use the monster_info since we essentially have these checks in two places 08:22:33 <04d​racoomega> For some reason, I thought that checked MB_SUMMONED 08:22:44 <09g​ammafunk> you would hope it would, but crawlcode.... 08:23:09 <09g​ammafunk> was thinking of making it do that but I'd need to look a bit more carefully at what direction_chooser is doing 08:26:28 <04d​racoomega> direction_chooser, the most pleasant of crawlcode 08:26:36 <04d​racoomega> (I mean, maybe those methods are fine for all I know) 08:28:07 <09g​ammafunk> I had to work with this class a lot for my very first crawl project (the ill-fated jump attack evocable/felid ability) since that involved a lot of UI aspects, and as someone with a C background who was still learning C++ and very new to the crawl codebase, direction_chooser was a true nightmare to work with 08:29:15 <04d​racoomega> I mean, I think it's probably awful for everyone 08:29:22 <04d​racoomega> 18 year old gotos 08:29:58 <09g​ammafunk> it is, but it's especially bad for one's first project (again, also depending on one's background) 08:30:24 <09g​ammafunk> of course I should have started with something much simpler, but "the feeling of accomplishment at the end, at least" etc 08:31:24 <09g​ammafunk> I can't see why they won't in the code without further digging, but apparently friendly rakshasa never phantom mirror (when testing) 08:32:05 <09g​ammafunk> in any case, I should probably the direction_chooser find summoner code to allow reporting of friendly phantom mirror summons, like how monster_info does, if I do nothing else with that class 08:33:50 <04d​racoomega> I think friendly rakshasa will technically cast that spell, but it's hard for it to have a valid target 08:34:04 <04d​racoomega> Since they can't use it on summons 08:34:27 <04d​racoomega> And it's hard for the player to have perma allies for them to target 08:34:55 <04d​racoomega> (It also doesn't work on uniques) 08:35:13 <04d​racoomega> I am not sure if bound souls of uniques count as unique anymore, though 08:35:23 <04d​racoomega> Because that would be one obvious way to get them to do it otherwise, I think 08:37:31 <09g​ammafunk> oh duh I wasn't thinking properly about this spell's conditions 08:38:11 <09g​ammafunk> yeah, there we go 09:07:59 03DracoOmega02 07* 0.33-a0-213-ge630d8722b: Fix fulminant prisms having incorrect summon data (aliasthespectator) 10(4 minutes ago, 2 files, 2+ 2-) 13https://github.com/crawl/crawl/commit/e630d8722bb3 09:07:59 03DracoOmega02 07* 0.33-a0-214-g4be0ea19d6: Adjust kill crediting for exploding monsters in general 10(2 minutes ago, 1 file, 9+ 11-) 13https://github.com/crawl/crawl/commit/4be0ea19d60d 10:00:44 03DracoOmega02 07* 0.33-a0-215-g74cecdf8d6: Fix Pan lords improperly using A/An when coming into view with others 10(2 minutes ago, 2 files, 2+ 2-) 13https://github.com/crawl/crawl/commit/74cecdf8d624 10:00:44 03DracoOmega02 07* 0.33-a0-216-gdcf9493a85: Better-document some methods (Ge0FF) 10(21 seconds ago, 2 files, 17+ 2-) 13https://github.com/crawl/crawl/commit/dcf9493a85f3 10:23:22 03dolorous02 07* 0.33-a0-217-g933e26f2f7: Fix typo. 10(2 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/933e26f2f724 10:29:40 <05s​astreii> reporting a bug (D10 the vault with killer bees and queen) 10:29:41 <05s​astreii> https://cdn.discordapp.com/attachments/747522859361894521/1291814510780481588/wefwef.png?ex=67017784&is=67002604&hm=23b3c60c46fee0da043a9e598d66b358435061ac71aec6c45fcaac736b996cfb& 10:37:30 <06r​egret-⸸nde※> What version is said game at? I should have fixed up special_room_bee there in ce7c55b, and on master it generates properly (though a transferred game that generated D in full might still have already made the wrong floor). 11:27:06 <05s​astreii> It’s trunk 11:33:03 <06r​egret-⸸nde※> You could provide the vlong with a dump, you could specify which server and we could look at whether or not that server has updated.... 11:42:01 <04m​elvinkitnick> Not 100% sure this is the game, but it look likes it: https://crawl.xtahua.com/crawl/morgue/sastreii/morgue-sastreii-20241004-175602.txt Anyways, Sastreii seems to only play on CXC, which is currently one commit behind your fix. Next trunk build will occurs in a few hours. 12:22:46 <05s​astreii> sorry, didn't read in time! but yeah i think the server i'm currently on (Xtahua) receives updates with longer delay (i went to another run, Lair 1, same vault, same "bug") 12:22:57 <05s​astreii> https://cdn.discordapp.com/attachments/747522859361894521/1291843018210672710/sdfsdf.png?ex=67019210&is=67004090&hm=83e1d950c6edb456fc1543f92242bdaa5bfce9118e11f9f622270a29fc7a564c& 12:23:01 <05s​astreii> !dump 12:23:03 <04C​erebot> https://crawl.xtahua.com/crawl/morgue/sastreii/sastreii.txt 12:31:57 I like that Xom is getting some much needed attention, but as long as the core issues aren't fixed, it's going to remain a terrible playing experience. 12:32:36 1. Es 12:33:06 <06r​egret-⸸nde※> ...Es? 12:34:29 <06r​egret-⸸nde※> (The majority of Xom effort done in 0.32 was to add sufficient variety and significant scaling impact to Xom effects, which I) 12:36:11 1. Easier to bore than to interest by default (inzerest decay). 2. AUTOEXPLORE = either take the malmublast boredom that w or never explore levels again... 3. Still suicide on a dumb brute because outside of a few gaffes by wasting resources ypu 12:36:47 Desperately need you will bore it super quick 12:37:08 <06r​egret-⸸nde※> (Getting cut-off myself is quite ironic, admittedly.) 12:37:10 Mages fare better. Djinn probably best 12:37:50 Sorry im on phone and have big bratwurst fingers 12:39:32 . 12:43:35 But any change to Xom at all is a massive improvement because like an anvil of IRONy, Xom was immune to change for years, forever forgotten in the void of oubil or branded with the stigma of "challenge" 12:44:04 making it the diety of total stagnation 12:47:06 <06r​egret-⸸nde※> One of my main goals for 0.33 is to rewrite Xom entirely to not have mood outside of explicit boredom, which in-and-of-itself is already rare and not that concerning (I think it's far more overestimated than people expect- boredom with no enemies in sight already has a very large chance for anything outside of malmutate already, and the random malmutations are just innate to Xom's random action choices as long as one's in the 12:47:06 bottom half of Xom's mood already). I'm not sure if you're aware outside of boredom there's not anything one can do to affect Xom's mood choices. Also, I'm not convinced that mages have it easier with Xom, as constant ally production gets in the way of mana-efficient conjurations, making one's own allies reduces effective tension for Xom's actionpicking, and resting after every combat for mp purposes takes up plenty of time in and of itself. They 12:47:07 also get far less benefits from the bazaar's spell offerings than melee characters can get from the endgame-worthy weapons + talisman offerings. (They do, admittedly, get significant benefits from translocations and debuffs that can help with running away, but that's already coming at the innate costs of relying on MP and having worse defenses.) 12:54:18 You clearly not only laugh the laugh, but honk the honk. I leave it in your capable hands. Thanks for taking this seriously 13:15:40 <08n​icolae> > You clearly not only laugh the laugh, but honk the honk. this might be the greatest sentence ever uttered in crawl-dev 15:39:22 Unstable branch on underhound.eu updated to: 0.33-a0-217-g933e26f2f7 (34) 16:22:22 03gammafunk02 07* 0.33-a0-218-g443864507a: A clua monster method for finding its summoner 10(56 minutes ago, 4 files, 41+ 12-) 13https://github.com/crawl/crawl/commit/443864507a74 19:39:18 -!- The topic of #crawl-dev is: Crawl Development | https://github.com/crawl/crawl | Logs: http://s-z.org/crawl-dev/, temporarily http://crawl.akrasiac.org/logs/cheibriados/ | People with +v have commit access, devs on bridged discord as well | General Crawl-related chat to #crawl | Long stuff to a pastebin service, please 19:39:18 -!- The topic of #crawl is: Play Dungeon Crawl Stone Soup online now! Type ??online for instructions, ??lg / !lg for play stats | PM Sequell for long queries | http://crawl.develz.org | FooTV game replays: ??footv for instructions | #crawl-dev for dev discussion, #crawl-offtopic for offtopic 22:35:30 Unstable branch on crawl.develz.org updated to: 0.33-a0-218-g443864507a (34) 22:59:04 Windows builds of master branch on crawl.develz.org updated to: 0.33-a0-218-g443864507a 23:30:06 Unstable branch on cbro.berotato.org updated to: 0.33-a0-218-g443864507a (34) 23:55:25 Monster database of master branch on crawl.develz.org updated to: 0.33-a0-218-g443864507a