03:32:42 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5208-geafff8c3b6 05:31:00 Unstable branch on crawl.akrasiac.org updated to: 0.33-a0-156-g0e69982 (34) 07:46:20 New branch created: pull/4064 (1 commit) 13https://github.com/crawl/crawl/pull/4064 07:46:21 03Brian Power02 07https://github.com/crawl/crawl/pull/4064 * 0.33-a0-157-ge41f5cd2f5: Fix bug #4063: Quad damage (Dungeon Sprint) is pluralised to "quad damagi" 10(2 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/e41f5cd2f5ab 08:04:18 <04dracoomega> I'd really hoped this project would be ready to push yesterday, but I ended up running into a cluster of bugs that didn't have the most straightforward way to fix. Still keeping my fingers crossed for today >.> 08:28:08 <06pleasingfungus> noo. don’t fix! and bring back hippogrives! 08:46:28 <09gammafunk> Da Mage 11:25:54 <09hellmonk> quad damage I 15:22:34 New branch created: pull/4065 (1 commit) 13https://github.com/crawl/crawl/pull/4065 15:22:35 03RypoFalem02 07https://github.com/crawl/crawl/pull/4065 * 0.33-a0-152-g933900389d: Extend single-day holidays to three days. 10(32 minutes ago, 1 file, 6+ 2-) 13https://github.com/crawl/crawl/commit/933900389d18 15:40:21 Unstable branch on underhound.eu updated to: 0.33-a0-156-g0e69982c27 (34) 16:00:12 03RypoFalem02 07https://github.com/crawl/crawl/pull/4065 * 0.33-a0-152-g49b0f86642: Extend single-day holidays to three days. 10(69 minutes ago, 1 file, 6+ 2-) 13https://github.com/crawl/crawl/commit/49b0f866424e 17:06:40 <04dracoomega> Well, I think I'm leaving off renaming mons_is_conjured for the moment, since I want to also do a review of how and where it's used at the time, and a bunch of that will likely lead into the refactoring of determining what you can/can't freely shoot through, which might take another while, and I'd really like to be able to push some of what I've been working on these last weeks 17:07:15 <04dracoomega> (Fun fact: did you know that IMB simply cannot kill a fire vortex and will fire through it without visible effect or message? ^^; ) 17:07:36 <06pleasingfungus> nice 17:09:04 <04dracoomega> But either way, I hope I have gotten the most major bugs out of the way in the larger summon backend overhaul and will start squashing stuff down tonight 17:09:09 <04dracoomega> 43 commits! >.>; 17:10:14 <04dracoomega> (Like, there's many more little things I'd like to do, but at some point there's no real reason not to do them over time in trunk, compared to 'rip guts out and replace them'-stye work) 17:15:11 <06pleasingfungus> i might have some time to review pre merge if you want to push it to a branch 17:15:16 <06pleasingfungus> no promises tho 17:15:37 <04dracoomega> It's like +1617/-1909 at the moment ^^; 17:16:56 <04dracoomega> I mean, I can do this if you'd prefer 17:17:22 <04dracoomega> (But I'm reasonably confident on the big-picture stuff and of course prepared to do live support for anything I inevitably missed ^^; ) 17:20:07 <09gammafunk> I have 40 commits in my branch I've been working on since july. alas, not quite ready to merge still 17:21:11 <04dracoomega> Oh? For what? 17:27:56 <09gammafunk> not for crawl, for a robot 17:28:49 <04dracoomega> Oh, ha 17:30:56 <06pleasingfungus> just thought it might be helpful in potentially catching an epic bug preemptively 17:31:05 <06pleasingfungus> but up to you 17:31:37 <06pleasingfungus> certainly not promising thorough review, but even a skim could help 17:37:09 <06pleasingfungus> would be nice if we had a way for devs to share code without shouting it to the whole community 17:37:24 <06pleasingfungus> can do like… patch diffs… but that sucks 17:38:04 git's perfectly happy to work with patches shared over email 17:38:50 see: git format-patch, git am 17:39:08 <04dracoomega> I mean, I'm not adverse to other eyes on this at this point or anything (or at least once I finish rebasing and squashing it) 17:39:58 <04dracoomega> (Though there's definitely been some points in past where I've awkwardly given very-much-more-in-flux stuff to Index in patch form for her to test, which wasn't ready to be broadcast to the playerbase at large) 17:41:55 (I know a number of people who use that normally; their issue with github/gitlab/forgejo/etc. is that git's supposed to be a distributed VCS, and those make it centralized instead) 17:42:31 <06pleasingfungus> i know git can work on that fine 17:42:58 <06pleasingfungus> i was around back before dcss switched to github, and when we regularly accepted code submissions as patches 17:43:10 <06pleasingfungus> my first submission was just such a patch! 17:43:36 <06pleasingfungus> but it’s awkward to communicate about. can’t leave line by line comments as smoothly as with github 17:43:52 true, sadly 17:44:09 although if people cared enough I could see tooling for it 17:44:11 <06pleasingfungus> (hot take) communication is good 17:44:36 the format of patches is such that tooling could easily deal with interspersed comments 17:44:47 but nobody's ever cared enough to write the tooling 17:44:57 <06pleasingfungus> one can imagine such tooling, yeah. but the siren song of github is always playing, reminding you that you could just take the easy path… 17:46:54 may happen at some point anyway, github's cracks are starting to show (https://www.mistys-internet.website/blog/blog/2024/07/12/github-is-starting-to-feel-like-legacy-software/) 17:48:54 <06pleasingfungus> i saw that post but i wasn’t particularly compelled by it 17:49:18 I'd already hit both the cited bugs, so "oh, that's not just me?" 17:49:41 <06pleasingfungus> ah, i’d hit neither, so the transition from the specific to the general was less compelling to me 🙂 17:50:14 <06pleasingfungus> i can certainly believe that eg the obsession with AI and a traditional lack of appreciation for unspectacular maintenance/improvement could cause gh to decay 17:50:34 <06pleasingfungus> i just haven’t seen any signs of that as yet, in my own usage 17:51:55 also hit a few more, like the GHA log viewer has some very odd failure modes (I had to page backwards through it once to see the actual log; going forward it was all blank lines) 17:53:32 also they were things that had been working until recently 17:53:53 so yes, I have a fairly strong feeling of "this is bitrotting right in front of my face" 17:58:00 <06pleasingfungus> rip… 18:25:31 <04dracoomega> Huh. Pleasantly surprised that the only merge conflict in all that was a trivial 'someone added an enum value right before I did' 18:29:22 <04dracoomega> (I noticed one minor thing I forgot to handle while doing that, but hopefully that doesn't take long) 18:29:46 …until you discover the real conflict wasn't caught because it was just outside the context 😛 18:29:56 (why no, this didn't happen to me recently…) 20:36:22 New branch created: summon_refactoring_0.33 (30 commits) 13https://github.com/crawl/crawl/tree/summon_refactoring_0.33 20:36:44 03DracoOmega02 07[summon_refactoring_0.33] * 0.33-a0-157-gc1dfc3470e: Remove the 'god' argument from most player summoning spells 10(9 days ago, 7 files, 119+ 142-) 13https://github.com/crawl/crawl/commit/c1dfc3470e2e 20:36:44 03DracoOmega02 07[summon_refactoring_0.33] * 0.33-a0-158-g5e005b0fb9: Refactor backend handling of summons / created monsters (Part 1) 10(9 days ago, 58 files, 548+ 630-) 13https://github.com/crawl/crawl/commit/5e005b0fb98d 20:36:44 03DracoOmega02 07[summon_refactoring_0.33] * 0.33-a0-159-g83df71b1dc: Add M_UNSTABLE flag to handle removing some monsters on level change 10(7 days ago, 8 files, 14+ 16-) 13https://github.com/crawl/crawl/commit/83df71b1dc38 20:36:44 03DracoOmega02 07[summon_refactoring_0.33] * 0.33-a0-160-g6dd8f5c692: Don't use KILL_MISC for tentacle cleanup deaths 10(6 days ago, 4 files, 18+ 11-) 13https://github.com/crawl/crawl/commit/6dd8f5c69268 20:36:44 03DracoOmega02 07[summon_refactoring_0.33] * 0.33-a0-161-gbb55b65bec: Rename KILL_MISC to KILL_NON_ACTOR 10(6 days ago, 20 files, 36+ 34-) 13https://github.com/crawl/crawl/commit/bb55b65bec2c 20:36:44 03DracoOmega02 07[summon_refactoring_0.33] * 0.33-a0-162-gfcac7313b5: Remove KILL_MISCAST and replace with KILL_NON_ACTOR 10(6 days ago, 5 files, 7+ 4-) 13https://github.com/crawl/crawl/commit/fcac7313b58f 20:36:44 03DracoOmega02 07[summon_refactoring_0.33] * 0.33-a0-163-gedde8bb6e5: Fix a minor message issue with Fugue and wretches 10(6 days ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/edde8bb6e578 20:36:44 03DracoOmega02 07[summon_refactoring_0.33] * 0.33-a0-164-g0bed177477: Use KILL_TIMEOUT for ENCH_SLOWLY_DYING and reorganize death messages 10(6 days ago, 5 files, 65+ 77-) 13https://github.com/crawl/crawl/commit/0bed17747703 20:36:44 03DracoOmega02 07[summon_refactoring_0.33] * 0.33-a0-165-g9fccf0a789: Remove the 'wizard' argument from monster_die() 10(5 days ago, 11 files, 39+ 45-) 13https://github.com/crawl/crawl/commit/9fccf0a7891d 20:36:44 03DracoOmega02 07[summon_refactoring_0.33] * 0.33-a0-166-g8adee6343d: Rename KILL_DISMISSED to KILL_RESET_KEEP_ITEMS and use it less 10(5 days ago, 22 files, 47+ 78-) 13https://github.com/crawl/crawl/commit/8adee6343d94 20:36:44 ... and 20 more commits 20:36:54 <04dracoomega> @pleasingfungus Well, here it is, when/if you have time ^^; 20:45:28 <06pleasingfungus> @dracoomega thanks! 🙂 will hopefully look soon, updates when and as 20:45:52 <04dracoomega> Appreciated! 22:02:19 <06pleasingfungus> looked through some of it and didn't find any issues. may look more tomorrow 22:02:24 <06pleasingfungus> thanks for uploading! 22:03:27 <04dracoomega> Glad to hear it. (And I like to hope that I've made things moderately less confusing for future generations here :P) 22:03:37 <04dracoomega> (And also myself >.>) 22:52:27 -!- gdown is now known as floyza 23:45:36 Monster database of master branch on crawl.develz.org updated to: 0.33-a0-156-g0e69982c27