00:30:31 Stable (0.32) branch on cbro.berotato.org updated to: 0.32.0-21-g8347d05f80 03:34:48 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5208-geafff8c3b6 05:01:55 Stable (0.32) branch on crawl.akrasiac.org updated to: 0.32.0-21-g8347d05 05:08:40 Unstable branch on crawl.akrasiac.org updated to: 0.33-a0-132-gd0a131f (34) 10:48:52 <04dracoomega> Despite the existence of a little bit of save compat code, I... don't think anything about killer_type actually needs this or depends on a fixed ordering in any way, does it? A couple of them are used to generate milestones, but the milestones themselves don't seem to preserve this numeric value in any fashion. They just convert it into a string. 10:50:29 <04dracoomega> So I'd like to tidy this up while I'm at it, but if anyone wants to lend a second pair of eyes to this question at some point, it would be appreciated. 10:50:43 <04dracoomega> It seems fairly straightforward to me 11:47:41 <06pleasingfungus> looking 11:47:51 <06pleasingfungus> i see we unmarshall killer_type in two places? 11:48:26 <06pleasingfungus> for clouds and cloud info 11:49:54 <06pleasingfungus> so i think we'd have to get rid of cloud.killer before we could remove save compat support for killer_type ordering 11:50:00 <06pleasingfungus> (no idea how practical that is) 11:50:07 <06pleasingfungus> does that sound right to you? 11:50:50 <06pleasingfungus> clouds also have an agent, so i'm not sure how much the killer is needed 11:51:02 <06pleasingfungus> i wonder what happens when a monster makes a cloud and then dies... 11:57:20 <04dracoomega> Oh, I did I overlook this somehow. Hmmm 11:57:58 <06pleasingfungus> it's surprising to me that we can currently call agent() on a cloud from a dead monster (afaik) 11:58:00 <06pleasingfungus> i wonder how that works 11:58:03 <06pleasingfungus> or if i'm misreadin git 11:58:49 <04dracoomega> You can call agent() on mon_enchants with dead sources also. In some cases, it fills in alternate details 11:58:56 <04dracoomega> If I recall right 11:59:01 <06pleasingfungus> huh 11:59:02 <06pleasingfungus> interesting 11:59:53 <04dracoomega> I do wonder if the kill_category that clouds already save is sufficient in practice? 12:00:03 <06pleasingfungus> sounds possible! 12:01:15 <04dracoomega> (I am just starting to look into this now, but off the cuff I kind of expect that only killer_types that make any sense here in the first place are the ones that are like "Is it the player, a monster, or a non-actor?" which can be covered elsewhere) 12:03:11 <06pleasingfungus> wow, what if you reflect ghost crab breath with warlock mirror 12:03:18 <06pleasingfungus> gotta get that you blameless killer!! 12:04:10 <04dracoomega> It looks like it may currently be used to differentiate player/monster clouds when the monster is also friendly, but of course, the mid source ought to also cover that 12:09:23 <04dracoomega> I'm not sure it's actually possible for clouds to end up with anything other than KILL_YOU_MISSILE, KILL_MON_MISSILE, or KILL_MISC at present 12:09:45 <04dracoomega> (Despite explicit handling of KILL_YOU_CONF, I don't set how it could ever be set to that) 12:09:50 <06pleasingfungus> huh 12:09:51 <06pleasingfungus> neat 12:10:21 <04dracoomega> This all feels like things that could be unambiguously answered by the source mid, in theory 12:11:51 <04dracoomega> That being said, I'm already trying to disentangle a lot of other things, so I may leave this specific project for some latter time 12:12:11 <04dracoomega> And only actually rearrange the killer_types later on 12:13:54 <04dracoomega> This particular bit of cloud code simplification seems 'good in principle' but also isn't causing actual mechanical issues at present that I know of (unlike the death code stuff) 12:14:07 <04dracoomega> Thanks for noticing that, though! 12:32:56 <06pleasingfungus> sure thing! thanks for devving 🙂 12:36:22 <04dracoomega> Will be happy when I get through this even-slower-than-expected refactoring project and onto more fun things again ^^; 12:42:20 those yaks only get hairier 13:03:09 <04dracoomega> I mean, if there are commit message I wrote 12 years ago complaining about the state of some of this, probably it is actually worth the effort to try and improve somewhat ^^; 13:03:49 <04dracoomega> Even if I'm slow at it 13:04:07 * geekosaur bets there are commit messages like that going back before DCSS 13:31:27 <04dracoomega> I'm not sure KILL_MISCAST does anything relevant these days (if it ever did). It isn't even consistent about being triggered by things which are miscasts. (For instance, if a miscast from Spellbinder or the Wild Magic card kills a monster, that isn't KILL_MISCAST. But if a mummy death curse does it, that is KILL_MISCAST (even though they haven't been miscast effects for years) 13:32:27 <04dracoomega> I don't think KILL_MISCAST even does anything different than KILL_MISC here anyway 13:32:51 <04dracoomega> (Note: this is entirely separate of the kill types used for player deaths, in terms of 'killed by a miscast') 13:41:26 <09gammafunk> I'm going to make 0.32.1 either tonight or tomorrow 13:42:04 <09gammafunk> So if stable is missing any fixes that should be cherry picked, please either do so or let me know about them 14:08:39 <03wheals> perhaps the MISC in KILL_MISC is simply short for MISCAST 14:09:31 gammafunk, fwiw I don't recall my shadow crash fix being cherry-picked 14:09:34 (can check) 14:13:09 yep, not there 14:13:30 (the crash was during t so I thiiiink the relevant code's in 0.32?) 14:14:11 <09gammafunk> geekosaur: OK thx will merge that after I take a look 15:41:04 Unstable branch on underhound.eu updated to: 0.33-a0-132-gd0a131fed7 (34) 16:10:45 New branch created: pull/4051 (6 commits) 13https://github.com/crawl/crawl/pull/4051 16:10:49 03Aliscans02 07https://github.com/crawl/crawl/pull/4051 * 0.33-a0-133-g7c67209dce: Don't let the player use off-level items with CMD_DISPLAY_MAP. 10(6 hours ago, 2 files, 3+ 3-) 13https://github.com/crawl/crawl/commit/7c67209dce03 16:10:49 03Aliscans02 07https://github.com/crawl/crawl/pull/4051 * 0.33-a0-134-g45a2b57079: Replace valid_item_index(item.index()). 10(2 hours ago, 3 files, 6+ 5-) 13https://github.com/crawl/crawl/commit/45a2b570796f 16:10:49 03Aliscans02 07https://github.com/crawl/crawl/pull/4051 * 0.33-a0-135-g9729a0ee99: Don't repeat items if searching for * with duplicate waypoints. 10(2 hours ago, 1 file, 7+ 0-) 13https://github.com/crawl/crawl/commit/9729a0ee99a9 16:10:49 03Aliscans02 07https://github.com/crawl/crawl/pull/4051 * 0.33-a0-136-gbbd8b5b555: Don't search inventory when the user requests a waypoint. 10(2 hours ago, 2 files, 37+ 24-) 13https://github.com/crawl/crawl/commit/bbd8b5b555ad 16:10:49 03Aliscans02 07https://github.com/crawl/crawl/pull/4051 * 0.33-a0-137-g9f9b640b50: Let the user interact with items accessed using ^F. 10(2 hours ago, 2 files, 45+ 43-) 13https://github.com/crawl/crawl/commit/9f9b640b5062 16:10:49 03Aliscans02 07https://github.com/crawl/crawl/pull/4051 * 0.33-a0-138-g3a08839a48: Let the user interact with items accessed using ^F. 10(2 hours ago, 2 files, 59+ 50-) 13https://github.com/crawl/crawl/commit/3a08839a48a1 16:21:35 03Aliscans02 07https://github.com/crawl/crawl/pull/4051 * 0.33-a0-137-gb4ce83e881: Let the user inscribe items on the ground (using xv). 10(67 minutes ago, 3 files, 48+ 46-) 13https://github.com/crawl/crawl/commit/b4ce83e88181 16:21:35 03Aliscans02 07https://github.com/crawl/crawl/pull/4051 * 0.33-a0-138-g54298f310e: Let the user interact with items accessed using ^F. 10(66 minutes ago, 2 files, 59+ 50-) 13https://github.com/crawl/crawl/commit/54298f310ef3 16:32:28 <12ge0ff> that's an epic bug if i ever seen one 16:33:25 <12ge0ff> (on the other Discord, players have confirmed that you can get items from other floors this way) 16:34:18 <06pleasingfungus> uh oh 16:34:49 <06pleasingfungus> ..can you loot unreachables? 16:35:19 <06pleasingfungus> eg ghost vaults, slime:$, ..? 16:38:07 <04dracoomega> Likely, yes 16:40:33 <04dracoomega> (This feels like the kind of thing I'd want to merge righ away, but I'm also deep in the weeds of the previous problem I was working on and I'm not sure how much brain I have left right now to evaluate the whole PR there) 16:40:56 <06pleasingfungus> i would look, but i’m currently trying to lull a 3yo back to sleep 16:52:24 <04dracoomega> I mean, if I don't get to this tonight, I will certainly do so tomorrow 17:03:29 <06regret-⸸nde※> Such future-proofing should be fine, though the count I'd be fine with for explicit Lair decor placement would be really high compared to the Lair branches- like, the 54 or so Zot currently has. 17:10:39 <09gammafunk> you can indeed pick up the orb from d:1 but the caveat is you have to have seen the target level/thing and you have to figure out its coordinates. loot in vaults is fair game and obviously you'll have far easier opportunities with those, but figuring out the coordinates is non-trivial 17:11:30 <09gammafunk> initially I was thinking that what qw does with waypoints to establish global coordinates via clua would make it easier but now I realize it doesn't help, since the two waypoints on different levels would establish totally different coordinate systems 17:12:10 <09gammafunk> you'd have to do some digging to find corners of both levels involved to narrow down the possible coordinates 17:19:41 It's easier than that. You can just look at the other level and move the cursor around until the v/examine thing says "You are here". 17:50:54 <08nicolae> looks like there's about 27 decor vaults currently (well, they're unsorted but i searched for how many times the word "decor" appears already) so hopefully i can knock that much out 17:52:26 <06regret-⸸nde※> I'll get some more decorative options down in a few days, hopefully. 17:52:36 <06regret-⸸nde※> (Currently doing some apis work to go with the new apis tile.) 17:53:48 <08nicolae> actually i'm doing okay with what we've got so far, turns out that for a lair of beasts, you can do some decorating with a lot of blood and/or skellingtons to really sell the vibe 17:54:58 <06regret-⸸nde※> Would be nice to have at least some of those vaults uses patches of flowers, on the other end of that spectrum. 17:56:17 <08nicolae> i could try some stuff with a sacred lotus or two, unless you think that should be kept more rare 18:06:28 <06regret-⸸nde※> You can make Fedhas or Ely-themed decorative vault for Lair if you want (which is the only real context I'd see for using such in Lair). I was thinking more of one of the decorative floor additions being, uh....: 18:06:29 <06regret-⸸nde※> https://cdn.discordapp.com/attachments/747522859361894521/1287943201696645214/flower_patch.png?ex=66f36214&is=66f21094&hm=cacdce4e17f968bcec5fd5cb4c74894ed4c817fd1b6753fb12b5d6b78a7de3d3& 18:07:46 <08nicolae> yeah i figured sacred lotus was a little Too special to just use william-nilliam in Lair 18:08:03 <08nicolae> fr: Scared Lotus for crypt, casts fear 20:45:00 03Aliscans02 {DracoOmega} 07* 0.33-a0-133-ge40546fae5: Don't let the player use off-level items with CMD_DISPLAY_MAP. 10(11 hours ago, 2 files, 3+ 3-) 13https://github.com/crawl/crawl/commit/e40546fae55f 20:45:00 03DracoOmega02 07* 0.33-a0-134-g5e1e37f56a: Don't allow performing actions on features on other levels (angelslayer) 10(6 minutes ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/5e1e37f56a6a 20:45:00 03DracoOmega02 07* 0.33-a0-135-g23b886832e: Don't claim 'You are here.' about tiles on other floors 10(62 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/23b886832e4f 22:07:02 Stable (0.32) branch on underhound.eu updated to: 0.32.0-21-g8347d05f80 22:35:27 Unstable branch on crawl.develz.org updated to: 0.33-a0-135-g23b886832e (34) 22:56:37 Windows builds of master branch on crawl.develz.org updated to: 0.33-a0-135-g23b886832e 23:14:00 Unstable branch on cbro.berotato.org updated to: 0.33-a0-135-g23b886832e (34) 23:54:37 Monster database of master branch on crawl.develz.org updated to: 0.33-a0-135-g23b886832e