00:23:35 Stable (0.32) branch on cbro.berotato.org updated to: 0.32.0-18-gac60e26e73 05:15:10 Stable (0.32) branch on crawl.akrasiac.org updated to: 0.32.0-18-gac60e26 05:45:12 Unstable branch on crawl.akrasiac.org updated to: 0.33-a0-87-gbf3d107 (34) 07:19:18 03gammafunk02 07* 0.33-a0-88-gf9f973bd00: task: Remove the trunk 0.32 tournament reminder 10(67 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/f9f973bd007a 11:31:00 New branch created: pull/4032 (1 commit) 13https://github.com/crawl/crawl/pull/4032 11:31:00 03NormalPerson702 07https://github.com/crawl/crawl/pull/4032 * 0.33-a0-89-g482c225d59: Fix HP/MP not updating when (un)equipping the Charlatan's Orb 10(3 minutes ago, 2 files, 16+ 0-) 13https://github.com/crawl/crawl/commit/482c225d59c8 11:38:33 03DracoOmega02 07* 0.33-a0-89-g55f019ead6: Make exploding sheep properly flee from the player (Lici) 10(2 minutes ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/55f019ead6cc 11:38:34 03DracoOmega02 07[stone_soup-0.32] * 0.32.0-19-gae7c4a8b6e: Make exploding sheep properly flee from the player (Lici) 10(2 minutes ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/ae7c4a8b6edd 11:57:56 03NormalPerson702 {Implojin} 07* 0.33-a0-90-g45882a55ab: Fix HP/MP not updating when (un)equipping the Charlatan's Orb 10(30 minutes ago, 2 files, 16+ 0-) 13https://github.com/crawl/crawl/commit/45882a55abfe 12:09:48 03NormalPerson702 {Implojin} 07[stone_soup-0.32] * 0.32.0-20-g245f4a553c: Fix HP/MP not updating when (un)equipping the Charlatan's Orb 10(42 minutes ago, 2 files, 16+ 0-) 13https://github.com/crawl/crawl/commit/245f4a553c98 12:40:27 -!- hedy[l]5 is now known as hedy[l] 13:11:06 New branch created: pull/4033 (1 commit) 13https://github.com/crawl/crawl/pull/4033 13:11:07 03NormalPerson702 07https://github.com/crawl/crawl/pull/4033 * 0.33-a0-89-gb71b24b45e: Preserve bribe enchantments for reviving bennu 10(5 minutes ago, 3 files, 16+ 5-) 13https://github.com/crawl/crawl/commit/b71b24b45e3a 13:47:41 New branch created: pull/4034 (1 commit) 13https://github.com/crawl/crawl/pull/4034 13:47:41 03NormalPerson702 07https://github.com/crawl/crawl/pull/4034 * 0.33-a0-89-g5a4bb41850: Don't auto-hide currently unmemorisable spells when picking up books 10(11 minutes ago, 1 file, 2+ 3-) 13https://github.com/crawl/crawl/commit/5a4bb41850f4 14:02:45 New branch created: pull/4035 (1 commit) 13https://github.com/crawl/crawl/pull/4035 14:02:46 03NormalPerson702 07https://github.com/crawl/crawl/pull/4035 * 0.33-a0-89-g0f28676fa2: Forbid Cheibriados coglins from making rampaging gizmos 10(7 minutes ago, 1 file, 3+ 1-) 13https://github.com/crawl/crawl/commit/0f28676fa2f2 14:26:28 New branch created: pull/4036 (1 commit) 13https://github.com/crawl/crawl/pull/4036 14:26:29 03NormalPerson702 07https://github.com/crawl/crawl/pull/4036 * 0.33-a0-89-g3b47ceeb01: Don't gain experience from killing allied apostles 10(3 minutes ago, 1 file, 3+ 0-) 13https://github.com/crawl/crawl/commit/3b47ceeb0119 15:38:35 03NormalPerson702 {DracoOmega} 07* 0.33-a0-91-gc4b16875ff: Preserve bribe enchantments for reviving bennu 10(3 hours ago, 3 files, 16+ 5-) 13https://github.com/crawl/crawl/commit/c4b16875ff40 15:38:35 03NormalPerson702 {DracoOmega} 07* 0.33-a0-92-ge7007fb380: Don't gain experience from killing allied apostles 10(75 minutes ago, 1 file, 3+ 0-) 13https://github.com/crawl/crawl/commit/e7007fb38093 15:38:35 03DracoOmega02 07* 0.33-a0-93-gad5dd902bf: Don't generate coglin gizmos with Rampage for Chei worshippers 10(19 minutes ago, 1 file, 10+ 1-) 13https://github.com/crawl/crawl/commit/ad5dd902bf07 15:38:35 03DracoOmega02 07* 0.33-a0-94-g4126433af7: Don't boost !magic from Potion Petition by being an oni/Kyrias (Lici) 10(17 minutes ago, 1 file, 6+ 4-) 13https://github.com/crawl/crawl/commit/4126433af748 15:39:35 Unstable branch on underhound.eu updated to: 0.33-a0-90-g45882a55ab (34) 16:07:34 -!- nabru- is now known as nabru 16:58:13 03Lexi Hattaway02 07https://github.com/crawl/crawl/pull/3984 * 0.32-a0-2136-g07ca752f57: Provide fixes from regret-index's review. 10(83 seconds ago, 3 files, 37+ 50-) 13https://github.com/crawl/crawl/commit/07ca752f5761 18:21:33 <04dracoomega> C++ // A grid feature to prefer when finding a place to create monsters. // For instance, using DNGN_FLOOR when placing flying monsters or // merfolk in the Shoals will force them to appear on land. // preferred_grid_feature will be ignored if it is incompatible with // the monster's native habitat (for instance, if trying to place // a electric eel with preferred_grid_feature DNGN_FLOOR). 18:21:33 dungeon_feature_type preferred_grid_feature = DNGN_UNSEEN; As far as I can tell, the only places this is ever set to anything outside of the default use DNGN_FLOOR (mostly to make amphibious monsters in Shoals not place out in deep water where the player may never encounter them) and it being technically more flexible make some of the code involving it more convoluted down the line. eg, it provides the 'wanted_grid' argument below: C++ /** * Can 18:21:34 monsters of this class survive on actual_grid? * * @param mt the monster class to check against * @param actual_grid the terrain feature being checked * @param wanted_grid if == DNGN_UNSEEN, or if the monster can't survive on it, * ignored. Otherwise, return false even if actual_grid is * survivable, if actual_grid isn't similar to wanted_grid. */ bool monster_habitable_grid(monster_type mt, 18:21:34 dungeon_feature_type actual_grid, dungeon_feature_type wanted_grid) Wondering if there's any good reason I don't just make this a bool for prefer_solid_floor or somesuch and simplify related code. 18:23:12 <04dracoomega> (Am planning on a little refactoring to mgen-data to allow specifying a min/max monster placement radius instead of always using 2, since lots and lots of spells and effects end up partially duplicating placement randomization when they want anything different, and noticed this while reviewing it) 18:28:28 <06pleasingfungus> simplifying sounds good 18:28:35 <06pleasingfungus> also the min/max radius change sounds good 18:34:40 <06pleasingfungus> basically, you have my blessing 18:34:46 <06pleasingfungus> which you do not need in any way 18:34:47 <06pleasingfungus> but it's there! 18:34:56 <04dracoomega> I mean, it's nice to have! ^^; 18:35:33 <04dracoomega> (I'm also planning to try and unify some handling of abjurable/non-abjurable allies, since there's a lot of code that ends up handling the same sort of function for the latter in different ad hoc ways) 18:35:48 you're still going to have to check for an empty vector from trying to place a shadow, though 😛 18:35:52 <04dracoomega> Er, non-abjurable temporary ones, I mean 18:36:20 <04dracoomega> Sorry, yes, I saw that for the first time a couple hours ago ^^; 18:36:52 <06pleasingfungus> never apologize imo 18:39:09 <04dracoomega> (I think there's like... 4 different ways that non-abjurable allies are found/expired and you can't even query the spell that created them very easily - even though that information exists! - since there's some conflation of 'is temporary and made by a spell' with 'is something summoned from another realm that goes poof in a bunch of clouds' in the code in ways that aren't actually very helpful) 18:39:38 <04dracoomega> And Forgecraft seems like an especially good time to try and improve some of this 18:44:51 <04dracoomega> I wonder what practical difference there actually is between ENCH_FAKE_ABJURATION and ENCH_SHORT_LIVED 18:50:43 <06pleasingfungus> these are the big questions... 18:51:51 <04dracoomega> On a quick inspection: ENCH_SHORT_LIVED is used by briars made by monsters (but not the Fedhas ability), ball lightning, ballisto spores, foxfire, blocks of ice from Sculpt Simulacrum, Hoarfrost Cannons, and Hellfire Mortar ENCH_FAKE_ABJURATION is used by player shadows, death scarabs from infestation, death channel spectrals, the actual simulacra from Sculpt Simulacrum, rats from Ratskin cloak, and battlesphere 18:56:02 <04dracoomega> I like how apparently Fedhas briars are abjurable, but thorn hunter ones are not 18:59:49 <04dracoomega> For bonus points, blocks of ice from glaciate/glacial breath use ENCH_SLOWLY_DYING (unlike blocks of ice from simulacrum) 19:00:35 <04dracoomega> A lot of slightly different ways to say "This thing goes away after X turns" 19:00:49 03NormalPerson702 {Implojin} 07* 0.33-a0-95-gdf7c40bf2b: Don't auto-hide currently unmemorisable spells when picking up books 10(5 hours ago, 1 file, 2+ 3-) 13https://github.com/crawl/crawl/commit/df7c40bf2bcc 19:01:24 <04dracoomega> (With, I am sure, a bunch of usually-minor-but-maybe-sometimes-important differences in some part of how they are handled by something) 19:02:23 <04dracoomega> I kind of assume of some of these can be merged somehow, but I do want to study this in some detail first 19:03:51 <04dracoomega> Nice old bugs related to this: 19:03:53 <04dracoomega> %git 4e78098616ad8645235ba4bab1df6c62aa891f8d 19:03:54 <04Cerebot> |amethyst * 0.17-a0-2056-g4e78098616: Properly assign credit for short-lived monster time-outs (#9866) (9 years ago, 1 file, 1+ 0-) https://github.com/crawl/crawl/commit/4e78098616ad 19:04:33 <04dracoomega> So ENCH_SHORT_LIVED monsters actually kill themselves to avoid giving the player XP for them expiring 19:05:10 <04dracoomega> Because apparently nothing elsewhere considers them 'temporary/created' enough to just not actually give XP by having that enchant (unlike, say, normal summons) 19:05:31 <04dracoomega> Back in days when ball lightnings were just sometimes chilling in Swamp 19:06:48 <04dracoomega> C++ case ENCH_SHORT_LIVED: // This should only be used for ball lightning -- bwr Hmmm 19:10:55 <04dracoomega> I think the ship sailed on that one like... 12 years ago? 19:11:01 <04dracoomega> Maybe more! 19:11:36 <06pleasingfungus> rip 19:22:38 <03implojin> hm is there any reason pr 4016 hasn't been merged yet 19:23:09 <03implojin> geekosaur commit so it's probably fine and it looks? fine, maybe just that the pr came during tournament 19:25:52 <04dracoomega> Well, I literally noticed it for the first time earlier today. (Just thought I'd append a note to the commit message about how this only affected placement when the shadow was casting Shadow Puppet) 19:26:14 <04dracoomega> I was on an enforced dev break during the tournament 19:26:25 <04dracoomega> Short of emergencies or something 19:26:50 <03implojin> i'm just going to merge this and take responsibility if something breaks 19:26:52 tournament, plus about the only way you get that situation is a zig floor or yred sending an abandoner a parting gift (I think) 19:27:07 <04dracoomega> I mean, yes, the code looks certainly fine 19:27:45 03geekosaur02 {Implojin} 07* 0.33-a0-96-gfd2f4f1e42: don't crash if shadow can't be placed (ChongLi) 10(9 days ago, 1 file, 6+ 1-) 13https://github.com/crawl/crawl/commit/fd2f4f1e4244 20:23:30 <04dracoomega> As I slowly trace through the ways all of these different related enchants are used, I have discovered that it is possible to gain health from vampirism against giant spores - in probably one of the only ways to ever do this against a 'summon' 20:24:58 <04dracoomega> ENCH_SHORT_LIVED and ENCH_SLOWLY_DYING don't make monsters ineligible to vamp heal off of, unlike ENCH_ABJ and ENCH_FAKE_ABJURATION but it just so happens that basically everything else using them is either firewood or nonliving 22:06:59 Stable (0.32) branch on underhound.eu updated to: 0.32.0-20-g245f4a553c 22:35:26 Unstable branch on crawl.develz.org updated to: 0.33-a0-96-gfd2f4f1e42 (34) 22:58:12 Windows builds of master branch on crawl.develz.org updated to: 0.33-a0-96-gfd2f4f1e42 23:16:23 Unstable branch on cbro.berotato.org updated to: 0.33-a0-96-gfd2f4f1e42 (34) 23:55:05 Monster database of master branch on crawl.develz.org updated to: 0.33-a0-96-gfd2f4f1e42