03:36:02 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5208-geafff8c3b6 08:42:29 Hi, I noticed that I haven't found a demonic rune according to the tourney scripts (exploration category & banner) despite completing a 15-rune game 08:42:38 I bought the demonic rune in a shop 08:42:40 Morgue: https://underhound.eu/crawl/morgue/grothendieck/morgue-grothendieck-20240903-112204.txt 09:11:51 <06mumra> sounds like a @nicolae vault 09:12:15 <06mumra> probably the tourney scripts are only expecting you to find runes on the ground 09:20:37 <08nicolae> 1) you are correct 2) it is nice to finally have confirmation that at least one human being has purchased the demonic rune from the demonic rune store, thank you 3) it would not surprise me if that was a bug 09:20:51 <09gammafunk> hrm, I think the problem is likely that it doesn't generate a rune milestone 09:24:11 <08nicolae> 110855 | Pan | Bought a demonic rune of Zot for 7263 gold pieces i'm so happy 🥲 09:25:55 <09gammafunk> !lm grothendieck rune=demonic t 09:25:56 <04Cerebot> No milestones for grothendieck (rune=demonic t). 09:26:34 <09gammafunk> yeah it's probably something subtle about how the item goes into inventory from shop pickup 09:27:15 <08nicolae> also grothendieck is a prime name 09:35:36 <03semi_tonal> it looks like it's because _purchase() in shopping.cc makes a note about the item being purchased and then sets ISFLAG_NOTED_GET to make sure no further notes get created 09:36:01 <09gammafunk> gah 09:36:02 <09gammafunk> thank you 09:36:11 <09gammafunk> looking at the code, I couldn't see why the milestone wasn't triggered 09:36:12 <03semi_tonal> so then when it gets actually added to your inventory in items.cc, _check_note_item() doesn't do a milestone because it looks like that's already been done 09:38:00 <03semi_tonal> i guess maybe the milestone section in _check_note_item could be generalised for purchased items too in case of future purchasable things that might trigger milestones (gozagsprint where the orb is in a shop) 09:38:49 <09gammafunk> yeah, I imagine you could have an early return case in _check_note_item() that sees if the item is collectible, does its own call to _milestone_check(), then returns 09:39:08 <09gammafunk> and doesn't consider that flag, and for non-collectible items things just proceed normally 09:39:24 <09gammafunk> hrm 09:39:39 <09gammafunk> oh I see, that block is for collectible items 09:39:54 <09gammafunk> well, it's for both those and artefacts, so you break out collectible items to their own case I guess 09:40:21 <09gammafunk> I guess that case only applies to items that are collectible and have the NOTED_GET flag? 09:40:57 <03semi_tonal> i think so yeah, as far as i can see 09:42:22 <09gammafunk> feel free to push a fix if you'd like to, kate; I'll have to clean up the tournament tables for grothendiek I guess, if that doesn't cause much headache. Probably I can just insert a row into the player rune table (or however that works, will have to take a look at the sql) and there being no actual corresponding milestone won't cause any issues 09:43:03 <03semi_tonal> i have to head out right now, but happy to poke at it in a few hours yeah 09:43:20 <09gammafunk> thanks! 09:50:06 don't worry about adjusting my tables by hand if it's too difficult 09:50:18 I'll probably do another trip into pan anyway 09:55:41 <09gammafunk> ok, that's an easier fix, thanks :gammafHeh: If it turns out that don't make said return trip or there's another problem, let me know and I can adjust the tables. It doesn't look too bad, but having an actual milestone go through and populate things the right way is better 09:56:15 <09gammafunk> @grothendieckdcss ^ since I forgot discord replies don't really work for IRC users 10:20:42 -!- cot_ is now known as cot 11:06:46 03DracoOmega02 07* 0.33-a0-47-g9fb28c6a05: Don't trigger chaotic artifact weapons against dead monsters 10(25 minutes ago, 2 files, 4+ 2-) 13https://github.com/crawl/crawl/commit/9fb28c6a05a2 11:06:46 03Alejandro Ramirez02 {DracoOmega} 07* 0.33-a0-48-g321b5f042a: Ensure only actual spells trigger SpellMotor (#4003) 10(2 days ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/321b5f042a10 11:06:46 03DracoOmega02 07* 0.33-a0-49-gfa4ca675df: Fix octopode physiology (dilly, rypofalem, ge0FF) 10(8 minutes ago, 1 file, 2+ 3-) 13https://github.com/crawl/crawl/commit/fa4ca675df83 11:06:46 03DracoOmega02 07* 0.33-a0-50-g1545d69ba7: Fix gravitambourine being able to move orbs of destruction 10(7 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/1545d69ba744 11:06:49 03DracoOmega02 07[stone_soup-0.32] * 0.32.0-6-g61dba5c426: Don't trigger chaotic artifact weapons against dead monsters 10(25 minutes ago, 2 files, 4+ 2-) 13https://github.com/crawl/crawl/commit/61dba5c4261d 11:06:49 03Alejandro Ramirez02 {DracoOmega} 07[stone_soup-0.32] * 0.32.0-7-g9f85324560: Ensure only actual spells trigger SpellMotor (#4003) 10(2 days ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/9f85324560b4 11:06:49 03DracoOmega02 07[stone_soup-0.32] * 0.32.0-8-g2cd428b803: Fix octopode physiology (dilly, rypofalem, ge0FF) 10(8 minutes ago, 1 file, 2+ 3-) 13https://github.com/crawl/crawl/commit/2cd428b80376 11:06:49 03DracoOmega02 07[stone_soup-0.32] * 0.32.0-9-ga5a68c12b4: Fix gravitambourine being able to move orbs of destruction 10(7 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/a5a68c12b454 15:37:41 <06mumra> https://cdn.discordapp.com/attachments/747522859361894521/1281382773155696721/image.png?ex=66db8434&is=66da32b4&hm=4655d87f12d5ae6cf9e9714798ba9fc9063bf75d808352e305e4b701b5bf9447& 15:37:53 <06mumra> This seems slightly buggy ... the quiver slot doesn't show the corrosion? 15:42:41 Unstable branch on underhound.eu updated to: 0.33-a0-50-g1545d69ba7 (34) 15:44:34 <12ge0ff> WebTiles has the same problem, but there's a PR for this already: https://github.com/crawl/crawl/pull/3745. 22:06:53 Stable (0.32) branch on underhound.eu updated to: 0.32.0-9-ga5a68c12b4 22:35:27 Unstable branch on crawl.develz.org updated to: 0.33-a0-50-g1545d69ba7 (34) 22:59:32 Windows builds of master branch on crawl.develz.org updated to: 0.33-a0-50-g1545d69ba7 23:55:48 Monster database of master branch on crawl.develz.org updated to: 0.33-a0-50-g1545d69ba7