03:32:41 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5208-geafff8c3b6 08:46:12 <12asciiphilia> If die in the tutorial, a long message will be displayed that doesn't fully display on the screen. https://github.com/crawl/crawl/blob/516f9d4634153a3e45f7be2d4debac1e279d705d/crawl-ref/source/dat/descript/tutorial.txt#L13 08:46:12 <12asciiphilia> https://cdn.discordapp.com/attachments/747522859361894521/1278742506321743964/image.png?ex=66d1e943&is=66d097c3&hm=2a87baa41f8c6072ee3219cd8926f3766e6086b64e7a90ca421d6c8c24383385& 08:47:57 <12asciiphilia> It looks like the line break isn't happening. 09:18:50 <09gammafunk> good bug 09:19:08 <09gammafunk> we need to release today, so I'm drafting up a release post 09:19:17 <09gammafunk> We also need to decide on a final release name 09:36:01 03DracoOmega02 07* 0.33-a0-36-gdf7718d54d: Describe the pseudopod aux attack when examining the mutation 10(20 hours ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/df7718d54d8e 09:36:01 03DracoOmega02 07* 0.33-a0-37-g30fde11914: Significantly decrease monster Grave Claw damage 10(20 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/30fde119145e 09:36:01 03DracoOmega02 07* 0.33-a0-38-gcf2570bee3: Add Grave Claw to the list of monster smitey spells 10(20 hours ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/cf2570bee3e9 09:36:03 03DracoOmega02 07[stone_soup-0.32] * 0.32-b1-37-g23219147f2: Describe the pseudopod aux attack when examining the mutation 10(20 hours ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/23219147f265 09:36:03 03DracoOmega02 07[stone_soup-0.32] * 0.32-b1-38-gd0e49249a6: Significantly decrease monster Grave Claw damage 10(20 hours ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/d0e49249a6b2 09:36:03 03DracoOmega02 07[stone_soup-0.32] * 0.32-b1-39-gcad5d02b6a: Add Grave Claw to the list of monster smitey spells 10(20 hours ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/cad5d02b6a6b 09:36:04 <09gammafunk> Although it contributed two commits, I'm not adding dependabot[bot] to the list of contributors 09:38:35 <04dracoomega> (Just had those sitting around from yesterday, but got distracted by the Arch Linux issue until my brain was mush >.>) 10:05:36 <12ge0ff> 0.32: "The return of Mountain Dwarves, Wiglaf, and food" 10:10:33 <06mumra> "Dwarven Power Armour" (referencing both dwarves and coglins) 10:18:38 <04dracoomega> I sort of feel like the title has to include a reference god stuff, given the scale and prominence of it. (There was earlier talk about the name a few weeks back, but nothing settled then either, of course) 10:19:12 <09gammafunk> I think I'm going with a pretty brief description of the release in this post, because it feels awkward to try to summarize even the highlights without either 1) giving a short summary that's worse than the changelog or 2) writing something longer than the changelog, which isn't great given the amount of content just in the highlights. So for the "release description" part of the post, I'm just going with: > DCSS 0.32 features 10:19:13 redesigns of four gods, two new playable species, 11 new spells, many new and revamped monsters, as well as new decorations throughout the Dungeon! For the complete list of these and the many other changes included in this version, see the release page here. Where "here" is a link to the eventual release page on github that has the full changelog contents as markdown. If anyone would like to write something else for the post description, let me know, 10:19:13 but I think the changelog is the best detailed writeup we have at the moment 10:20:05 <04dracoomega> That seems reasonable to me 10:22:37 <06regret-⸸nde※> (The two main version title candidates that came up two weeks ago, last time it was discussed, were "Divine Dwarven Renaissance" and "Gods and Makers".) 10:24:01 <09gammafunk> I was going to say that DO can have the final say on release title (after benevolently deciding based on the offered suggestions, of course) since she has the most commits this version, but: > $ top-crawl-commits 0.32-a0..HEAD | more > 776 dolorous > 706 DracoOmega > 161 PleasingFungus > 137 regret-index > 45 advil > 44 elliptic > 40 SentientSupper > 35 NormalPerson7 > 33 Zhang 10:24:01 Kai > 32 gammafunk > 26 wheals > 22 mumra > 21 Monkooky > 17 Implojin > 16 nicolae > 15 nlavsky > 10 Medrano83 > 10 Aliscans > 9 Wizard Ike > 7 |amethyst 10:24:10 <09gammafunk> We're going to have to ask dolorous, it seems 10:24:23 <08nicolae> 0.32: We Added Everything But A Release Name 10:25:13 <09gammafunk> can't believe that elliptic beat me, but at least I easilly took down nicolae 10:25:55 <08nicolae> i prefer quality over quantity 10:26:12 <09gammafunk> Gods and Makers seems the most reasonable way to vaguely incorporate everything in one title 10:26:32 <09gammafunk> Divine Dwarven Renaissance is probably more the recent crawl "house style" for release titles though 10:26:35 <06mumra> Have you ever seen an old film called "The Gods Must Be Crazy" ? i feel a reference to that could work 10:28:52 <04dracoomega> I have, actually (way back in the mists of time), but I'm not sure why we need to reference anything in particular, tbh 10:29:42 Gods and Makers? Better to have 'The Gods and the Creators' 10:32:56 for cool flavor 10:34:03 <06mumra> Doesn't need to be but i feel like the names are usually a bit punny or mildly referencial 10:49:03 <08nicolae> I Redesigned Four Gods, Two Species, Eleven Spells, And Untold Monsters, And All I Got Was This Stupid Release Name. And Also Four Gods, Two Species, Eleven Spells, and Untold Monsters, As Mentioned. 10:49:40 <08nicolae> 0.32: Play This Version Or We'll Kill Nicolae. 11:08:08 <06pleasingfungus> he was probably asking for it. 11:32:56 So what's the decided name? 11:40:23 Of the update? 11:43:00 <08nicolae> it remains undecided 11:44:05 <12ge0ff> 0.32: "Undecided" 12:11:21 <12ge0ff> re: yesterday's Form/Blood properties crash when a MenuEntry text is shorter than 3 characters. It looks like it happens because of an out of bounds access. 12:13:08 <12ge0ff> cpp #ifdef USE_TILE_LOCAL static bool _has_hotkey_prefix(const string &s) { // [enne] - Ugh, hack. Maybe MenuEntry could specify the // presence and length of this substring? bool let = (s[1] >= 'a' && s[1] <= 'z' || s[1] >= 'A' && s[1] <= 'Z'); bool plus = (s[3] == '-' || s[3] == '+' || s[3] == '#'); return let && plus && s[0] == ' ' && s[2] == ' ' && s[4] == ' '; } #endif <-- the "s" parameter here is a 12:13:09 MenuEntry's text 12:14:18 <12ge0ff> replacing everything inside this function with just return false; fixes the crashes 12:57:32 <12ge0ff> So the minimal fix could look like this: diff diff --git a/crawl-ref/source/menu.cc b/crawl-ref/source/menu.cc index 442d8b7a51..91b9d2f41d 100644 --- a/crawl-ref/source/menu.cc +++ b/crawl-ref/source/menu.cc @@ -363,6 +363,9 @@ void UIMenu::update_item(int index) #ifdef USE_TILE_LOCAL static bool _has_hotkey_prefix(const string &s) { + // Don't read out of bounds! + if (s.size() < 5) return false; + // [enne] - Ugh, hack. 12:57:33 Maybe MenuEntry could specify the // presence and length of this substring? bool let = (s[1] >= 'a' && s[1] <= 'z' || s[1] >= 'A' && s[1] <= 'Z'); 13:27:49 <09gammafunk> regarding release name, I'm going with "Gods and Makers" since it best summarizes everything 13:28:11 <09gammafunk> I'm going to tag the release soonish, so if you have anything you want done first before 0.32.0, either or do it now or let me know 13:29:48 "The Gods and the Creators" 13:47:47 <09gammafunk> I guess we never did a 0.31.1 13:48:08 <09gammafunk> perhaps we can do that at some point during the tournament 13:49:26 <12ge0ff> I poked different menus after applying this fix and everything seems to work fine, but i'm not comfortable applying that with so little testing at the last minute. So, rip 0.32 Arch players 😿 13:50:50 <09gammafunk> well we can always do a 0.32.1 after tournament, like we're supposed to 13:51:08 <09gammafunk> so working on a fix is definitely appreciated still 13:55:43 03gammafunk02 07[stone_soup-0.32] * 0.32-b1-40-ge9cc5b35c8: task: Update the debian changelog for 0.32.0 10(40 seconds ago, 1 file, 5+ 0-) 13https://github.com/crawl/crawl/commit/e9cc5b35c883 13:56:49 03gammafunk02 07* 0.33-a0-39-gf63b3e169c: task: Update the debian changelog for 0.32.0 10(2 minutes ago, 1 file, 5+ 0-) 13https://github.com/crawl/crawl/commit/f63b3e169c3c 14:12:55 03gammafunk02 07[stone_soup-0.32] * 0.32.0-1-g2a3b71ecb9: doc: Update the changelog for the 0.32 release 10(5 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/2a3b71ecb9cd 14:14:00 03gammafunk02 07* 0.33-a0-40-g6fe00ff5d4: doc: Update the changelog for the 0.32 release 10(6 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/6fe00ff5d471 14:24:27 <09gammafunk> Release is building, the github workflow seemed to properly start the first time, thankfully 14:26:27 <09gammafunk> oh oops, I made the source packages and uploaded but apprently that's already part of the workflow 14:36:04 -!- om is now known as Guest11 15:20:36 <09gammafunk> Ok, release made! https://crawl.develz.org/wordpress/0-32-gods-and-makers 15:39:12 Unstable branch on underhound.eu updated to: 0.33-a0-40-g6fe00ff5d4 (34) 16:21:50 Monster database of stone_soup-0.32 branch on crawl.develz.org updated to: 0.32.0 17:02:20 -!- MakMorn_ is now known as MakMorn 17:07:43 <09gammafunk> The two issues we have are that 1) sequell doesn't see any of the 0.32 sources despite my adding them and 2) CUE doesn't have 0.32 yet. I think TZer0 often installs 0.32 on CUE the day of the tournament, so that's not a huge concern. But (1) is a bigger concern since sequell is usually a big part of tournament. I contacted greensnark about this last night, but no response yet. Hopefully he sees it and can poke sequell before start of 17:07:43 tournament 18:44:03 <12asciiphilia> How does the dump file loading feature in wizard mode work? Is it parsing the morgue file as a string? I recently tried this feature out of curiosity, but the game crashed when loading some morgue files. https://archive.nemelex.cards/morgue/ASCIIPhilia/morgue-ASCIIPhilia-20240809-172455.txt https://archive.nemelex.cards/morgue/WizardModePhilia/crash-WizardModePhilia-20240829-072513.txt And I've also noticed that a few other games 18:44:03 are having errors reading some of the properties. 18:46:49 <06pleasingfungus> it’s very antique and never worked very well 18:49:19 <09gammafunk> yes, it would be great if we had some sort of dump to json thing that wizard mode could then read 18:49:25 <09gammafunk> to avoid trying to scrape text 18:49:51 <09gammafunk> I think there's even an old PR trying to implement json dumps but I'm not sure what the issues were with it 18:52:19 <09gammafunk> Yeah, this old PR might be of interest, but it never quite made it to completion: https://github.com/crawl/crawl/pull/1122 It's probably the general approach one would need to improve the status quo 18:55:50 Windows builds of master branch on crawl.develz.org updated to: 0.33-a0-40-g6fe00ff5d4 19:00:23 <09gammafunk> Ok, trunk builds on cdo also updated to 0.33 19:00:35 <09gammafunk> we didn't forget to do that for months this time 19:39:54 -!- The topic of #crawl-dev is: Crawl Development | https://github.com/crawl/crawl | Logs: http://s-z.org/crawl-dev/, temporarily http://crawl.akrasiac.org/logs/cheibriados/ | People with +v have commit access, devs on bridged discord as well | General Crawl-related chat to #crawl | Long stuff to a pastebin service, please 19:39:54 -!- The topic of #crawl is: Play Dungeon Crawl Stone Soup online now! Type ??online for instructions, ??lg / !lg for play stats | PM Sequell for long queries | http://crawl.develz.org | FooTV game replays: ??footv for instructions | #crawl-dev for dev discussion, #crawl-offtopic for offtopic 21:36:49 03Alejandro Ramirez02 07https://github.com/crawl/crawl/pull/3996 * 0.33-a0-36-gc4e716de25: * Creatures of extreme rarity and recluse, changelings are hardly ever seen in their base form. Quick to hide, they use their shapeshifting prowess to assume the forms of native creatures and go about their business! 10(2 weeks ago, 60 files, 1447+ 155-) 13https://github.com/crawl/crawl/commit/c4e716de25ca 21:36:49 03Alejandro Ramirez02 07https://github.com/crawl/crawl/pull/3996 * 0.33-a0-37-g84063cbd32: * Spells are now dynamically set by DungeonDenizen transformations, allowing different monsters to have different spell loadouts - further dependent on player XL. * Added a new header file (name pending) with a helper function to map non-player spells to acceptable replacements (caveat, summon spells seem really strong compared to others). * Adding logic check to ensure dungeon denizens populate their spell list on game load. 10(5 days ago, 4 files, 945+ 1-) 13https://github.com/crawl/crawl/commit/84063cbd32ff 21:36:49 03Alejandro Ramirez02 07https://github.com/crawl/crawl/pull/3996 * 0.33-a0-38-gf9ea031874: * Moving monster_info::reach_range internal logic related to innate monster reach out into mons_class_innate_reach in mon-util for easier API usage 10(5 days ago, 3 files, 29+ 13-) 13https://github.com/crawl/crawl/commit/f9ea03187479 21:36:49 03Alejandro Ramirez02 07https://github.com/crawl/crawl/pull/3996 * 0.33-a0-39-g31bb706c7b: * Added support for monster attack verbs while form shifted into a dungeon denizen. * Letting forms provide monster-style attack flavors and types for damage, effects, and verbage. * Allow for dungeon denizens to dynamically determine which slots are blocked or not based on body type (e.g., Centaurs). * Shorting a change to give players a UC brand based on attack flavor (AF_*) since we already can apply AF properties on attack... but right now we miss out on a visual indicator for what AF's you have currently. 10(5 days ago, 5 files, 83+ 8-) 13https://github.com/crawl/crawl/commit/31bb706c7b24 21:36:49 03Alejandro Ramirez02 07https://github.com/crawl/crawl/pull/3996 * 0.33-a0-40-gc477ddff5b: * Adding logic to removal and melding of equipment in transform.cc to manage dungeon denizen (and potentially other forms which can have open equipment slots, but require size wield/wear checks. * Note: Giant/Large entities can still wind up wearing smaller helmets with the current code 10(8 days ago, 1 file, 143+ 33-) 13https://github.com/crawl/crawl/commit/c477ddff5b8f 21:36:49 03Alejandro Ramirez02 07https://github.com/crawl/crawl/pull/3996 * 0.33-a0-41-ga4b2d33c41: Lets Trog or some other god de-transform you if you are hated by them on conversion 10(2 weeks ago, 1 file, 9+ 0-) 13https://github.com/crawl/crawl/commit/a4b2d33c41bc 21:36:49 03Alejandro Ramirez02 07https://github.com/crawl/crawl/pull/3996 * 0.33-a0-42-gc74ecc1c8e: Fixing checks for (A)ttack (F)lavors that do poison to not crash if a player uses them (e.g., we're a Water Mocassin). 10(8 days ago, 1 file, 6+ 3-) 13https://github.com/crawl/crawl/commit/c74ecc1c8e02 21:36:49 03Alejandro Ramirez02 07https://github.com/crawl/crawl/pull/3996 * 0.33-a0-43-g1fe1b142f8: Added Bloodzerking to the supported list of possible player (A)ttack (F)lavours that can be used when transformed into a Skyshark 10(7 days ago, 1 file, 31+ 10-) 13https://github.com/crawl/crawl/commit/1fe1b142f888 21:36:49 03Alejandro Ramirez02 07https://github.com/crawl/crawl/pull/3996 * 0.33-a0-44-g514bb8d3ba: Fixing typos in _god_prevents_berserk_haste description 10(7 days ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/514bb8d3ba11 21:36:49 03Alejandro Ramirez02 07https://github.com/crawl/crawl/pull/3996 * 0.33-a0-45-gcb069ab35e: Making player slimes immune to slime walls 10(7 days ago, 1 file, 3+ 1-) 13https://github.com/crawl/crawl/commit/cb069ab35ea2 21:36:49 ... and 4 more commits 21:38:03 03Alejandro Ramirez02 07https://github.com/crawl/crawl/pull/3996 * 0.33-a0-41-g3a50e43c83: * Creatures of extreme rarity and recluse, changelings are hardly ever seen in their base form. Quick to hide, they use their shapeshifting prowess to assume the forms of native creatures and go about their business! 10(2 weeks ago, 60 files, 1447+ 155-) 13https://github.com/crawl/crawl/commit/3a50e43c8367 21:38:03 03Alejandro Ramirez02 07https://github.com/crawl/crawl/pull/3996 * 0.33-a0-42-ga48f395ecc: * Spells are now dynamically set by DungeonDenizen transformations, allowing different monsters to have different spell loadouts - further dependent on player XL. * Added a new header file (name pending) with a helper function to map non-player spells to acceptable replacements (caveat, summon spells seem really strong compared to others). * Adding logic check to ensure dungeon denizens populate their spell list on game load. 10(5 days ago, 4 files, 945+ 1-) 13https://github.com/crawl/crawl/commit/a48f395eccf1 21:38:03 03Alejandro Ramirez02 07https://github.com/crawl/crawl/pull/3996 * 0.33-a0-43-gd96353c1d1: * Moving monster_info::reach_range internal logic related to innate monster reach out into mons_class_innate_reach in mon-util for easier API usage 10(5 days ago, 3 files, 29+ 13-) 13https://github.com/crawl/crawl/commit/d96353c1d172 21:38:03 03Alejandro Ramirez02 07https://github.com/crawl/crawl/pull/3996 * 0.33-a0-44-ge20666b8c9: * Added support for monster attack verbs while form shifted into a dungeon denizen. * Letting forms provide monster-style attack flavors and types for damage, effects, and verbage. * Allow for dungeon denizens to dynamically determine which slots are blocked or not based on body type (e.g., Centaurs). * Shorting a change to give players a UC brand based on attack flavor (AF_*) since we already can apply AF properties on attack... but right now we miss out on a visual indicator for what AF's you have currently. 10(5 days ago, 5 files, 83+ 8-) 13https://github.com/crawl/crawl/commit/e20666b8c9a0 21:38:03 03Alejandro Ramirez02 07https://github.com/crawl/crawl/pull/3996 * 0.33-a0-45-gfd2d74595c: * Adding logic to removal and melding of equipment in transform.cc to manage dungeon denizen (and potentially other forms which can have open equipment slots, but require size wield/wear checks. * Note: Giant/Large entities can still wind up wearing smaller helmets with the current code 10(8 days ago, 1 file, 143+ 33-) 13https://github.com/crawl/crawl/commit/fd2d74595cba 21:38:03 03Alejandro Ramirez02 07https://github.com/crawl/crawl/pull/3996 * 0.33-a0-46-g356887dd88: Lets Trog or some other god de-transform you if you are hated by them on conversion 10(2 weeks ago, 1 file, 9+ 0-) 13https://github.com/crawl/crawl/commit/356887dd88e1 21:38:03 03Alejandro Ramirez02 07https://github.com/crawl/crawl/pull/3996 * 0.33-a0-47-g2d80e8e632: Fixing checks for (A)ttack (F)lavors that do poison to not crash if a player uses them (e.g., we're a Water Mocassin). 10(8 days ago, 1 file, 6+ 3-) 13https://github.com/crawl/crawl/commit/2d80e8e63265 21:38:03 03Alejandro Ramirez02 07https://github.com/crawl/crawl/pull/3996 * 0.33-a0-48-g1ff2847c7c: Added Bloodzerking to the supported list of possible player (A)ttack (F)lavours that can be used when transformed into a Skyshark 10(7 days ago, 1 file, 31+ 10-) 13https://github.com/crawl/crawl/commit/1ff2847c7c91 21:38:03 03Alejandro Ramirez02 07https://github.com/crawl/crawl/pull/3996 * 0.33-a0-49-gf036a62b50: Fixing typos in _god_prevents_berserk_haste description 10(7 days ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/f036a62b5096 21:38:03 03Alejandro Ramirez02 07https://github.com/crawl/crawl/pull/3996 * 0.33-a0-50-g287c1050d0: Making player slimes immune to slime walls 10(7 days ago, 1 file, 3+ 1-) 13https://github.com/crawl/crawl/commit/287c1050d008 21:38:03 ... and 4 more commits 22:07:16 Stable (0.32) branch on underhound.eu updated to: 0.32.0-0-g2a3b71ecb9 22:20:11 <07acrobat> https://github.com/crawl/crawl/commit/60eeae62d1025496326fcc31bb4b69d4ba79f386 22:20:27 <07acrobat> Evocable invisibility was greatly buffed in 0.32, but seems to be missing from the changelog. It would be nice to see this added. 22:22:08 <07acrobat> 🙏 22:35:35 Unstable branch on crawl.develz.org updated to: 0.33-a0-40-g6fe00ff5d4 (34) 23:14:10 Unstable branch on cbro.berotato.org updated to: 0.33-a0-40-g6fe00ff5d4 (34) 23:55:30 Monster database of master branch on crawl.develz.org updated to: 0.33-a0-40-g6fe00ff5d4 23:56:30 03mumra02 07https://github.com/crawl/crawl/pull/3852 * 0.33-a0-41-g1e5baea320: Revisions to monster wand usage 10(3 months ago, 13 files, 129+ 137-) 13https://github.com/crawl/crawl/commit/1e5baea320e7 23:56:30 03mumra02 07https://github.com/crawl/crawl/pull/3852 * 0.33-a0-42-g3870190bcc: Fix display of wand damage and will chance 10(3 months ago, 4 files, 53+ 35-) 13https://github.com/crawl/crawl/commit/3870190bcc29