02:37:29 -!- Panjera3 is now known as Panjera 03:32:43 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5208-geafff8c3b6 05:40:36 03dolorous02 07* 0.32-a0-1806-g2c1b039590: Shorten -Gavotte status description. 10(4 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/2c1b039590cf 05:46:56 <12g​e0ff> reposting from another Discord: the 0.32 changelog doesn't mention an important change: permanent bazaars no longer spawn, and all bazaars are timed now (e446cd8fad1) 06:07:53 <09g​ammafunk> Thx, can make pr with fix if you like! 07:22:14 <09g​ammafunk> @icoson looks like we have a problem with the recent job to yaml update and CAO: > gammafunk@crawl:/home/crawl-dev/logs$ tail update.log > PYTHON species-data.h > GEN aptitudes.h > GEN species-groups.h > GEN species-type.h > GEN job-data.h > /usr/bin/env: python3: No such file or directory > make: *** [job-data.h] Error 127 > make: Leaving directory 07:22:15 `/home/crawl-dev/dgamelaunch-config/crawl-build/crawl-git-repository/crawl-ref/source' > Done 07:22:24 <09g​ammafunk> oh 07:22:29 <09g​ammafunk> we must have python3 on cao though 07:22:56 <09g​ammafunk> we do, so why isn't /usr/bin/env finding it 07:23:04 <09g​ammafunk> will need to look into this a bit later (if advil doesn't) 08:02:00 03dolorous02 07* 0.32-a0-1807-ga3dc3e8338: Split out body part msgs into their own function. 10(74 minutes ago, 3 files, 101+ 61-) 13https://github.com/crawl/crawl/commit/a3dc3e833817 08:02:00 03dolorous02 07* 0.32-a0-1808-gb31574310d: Add Xom random body part pseudo-miscasts. 10(7 minutes ago, 2 files, 21+ 0-) 13https://github.com/crawl/crawl/commit/b31574310de3 08:02:00 03dolorous02 07* 0.32-a0-1809-gb0289f24ba: Adjust a Xom tail message. 10(4 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/b0289f24ba0d 08:02:00 03dolorous02 07* 0.32-a0-1810-gf64ed195ed: Add another Xom tail message. 10(2 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/f64ed195ed95 08:07:23 -!- Noisytoot is now known as Guest7468 08:13:47 03dolorous02 07* 0.32-a0-1811-gcb7f57b3ea: Properly separate singular/plural body part msgs. 10(3 minutes ago, 2 files, 11+ 2-) 13https://github.com/crawl/crawl/commit/cb7f57b3ea79 08:19:10 <06d​olorous_84348> I know that "your eyes briefly fall off your body" is slightly odd phrasing, but adding a special messaging case for their falling out would have been complex, and separating singular and plural body parts as well as internal/external ones was complex enough. 08:21:57 <06p​leasingfungus> seems fine to me. 08:27:46 <06d​olorous_84348> Good to know. 09:16:58 03dolorous02 07* 0.32-a0-1812-g93245fa936: Add flesh to random body parts. 10(9 minutes ago, 1 file, 7+ 0-) 13https://github.com/crawl/crawl/commit/93245fa9368e 09:16:58 03dolorous02 07* 0.32-a0-1813-gf0725ce4dc: Properly account for form wrt bandages. 10(7 minutes ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/f0725ce4dc0b 09:30:28 <06d​olorous_84348> The flesh described in random body parts uses either the form's name or the species skin name. Petrification is the odd case there, but I'm assuming that, when petrified, you have a stone version of what you normally have, so the message should still work, I think? 09:45:20 <06d​olorous_84348> Never mind; the skin name isn't guaranteed to be singular or plural. 09:45:53 03dolorous02 07* 0.32-a0-1814-ga6c389bb27: Fix flesh name handling. 10(36 minutes ago, 1 file, 9+ 3-) 13https://github.com/crawl/crawl/commit/a6c389bb27ef 09:59:49 03dolorous02 07* 0.32-a0-1815-g47babdb9eb: Fix comment typo. 10(75 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/47babdb9eb39 10:01:59 03dolorous02 07* 0.32-a0-1816-gdb40d755ae: Properly describe gargoyle "flesh" as stone. 10(72 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/db40d755ae36 10:16:58 03dolorous02 07* 0.32-a0-1817-gc59282bd5f: Actually describe gargoyles' skin as stone. 10(2 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/c59282bd5faf 10:21:16 03dolorous02 07* 0.32-a0-1818-g786527281b: Describe flesh as "skin" by default. 10(3 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/786527281bb4 10:22:32 <06d​olorous_84348> The naming of flesh/skin/similar things is not all that consistent, but I've done what I can. 10:33:04 03Implojin02 07* 0.32-a0-1819-g3489c0331a: fix: Draw ghost backgrounds in webtiles 10(8 minutes ago, 4 files, 36+ 12-) 13https://github.com/crawl/crawl/commit/3489c0331a15 11:01:58 03dolorous02 07* 0.32-a0-1820-g2eaa09f63e: Use species::skin_name() for flesh peoperly. 10(2 minutes ago, 1 file, 13+ 5-) 13https://github.com/crawl/crawl/commit/2eaa09f63edb 11:10:15 -!- buki_ is now known as buki 11:30:51 03dolorous02 07* 0.32-a0-1821-g342958b4cc: Decouple being a draconian and lacking hair. 10(9 minutes ago, 11 files, 11+ 1-) 13https://github.com/crawl/crawl/commit/342958b4ccaa 11:37:49 <05i​coson> could you point me to the commit you are alluding to? 11:37:55 <05i​coson> a little out of the loop, sorry 11:51:13 03advil02 07* 0.32-a0-1822-g0624b5bc0c: fix: correctly call job-gen.py in Makefile 10(3 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/0624b5bc0cc7 11:54:20 <05i​coson> I'm not actually 100% sure what version of python is being called on cao, but that commit does fix the build and will prevent problems on other systems too 12:24:00 Unstable branch on crawl.akrasiac.org updated to: 0.32-a0-1822-g0624b5bc0c (34) 12:56:33 <09g​ammafunk> thanks, I was going to make that exact same change after investigating why it was failing in the first place, since it wasn't obvious to me why it would 14:18:44 03nlavsky02 07* 0.32-a0-1823-g0afb396884: fix: treat artefacts with Reflection as unusual items 10(3 minutes ago, 1 file, 2+ 1-) 13https://github.com/crawl/crawl/commit/0afb39688408 15:17:21 Unstable branch on crawl.akrasiac.org updated to: 0.32-a0-1823-g0afb396884 (34) 15:37:06 Unstable branch on underhound.eu updated to: 0.32-a0-1823-g0afb396884 (34) 18:40:11 03DracoOmega02 07* 0.32-a0-1824-g02c4a77254: Merge Minor/Major Destruction into Unleash Destruction 10(3 weeks ago, 29 files, 254+ 156-) 13https://github.com/crawl/crawl/commit/02c4a77254a0 18:40:11 03DracoOmega02 07* 0.32-a0-1825-gac1edcbc3a: Greatly simplify demon summoning from Obsidian Axe 10(3 weeks ago, 5 files, 21+ 124-) 13https://github.com/crawl/crawl/commit/ac1edcbc3ac4 18:40:11 03DracoOmega02 07* 0.32-a0-1826-g2cd86a2a38: Merge Lesser/Greater Servant abilities into Infernal Servant 10(3 weeks ago, 12 files, 89+ 90-) 13https://github.com/crawl/crawl/commit/2cd86a2a3854 18:40:11 03DracoOmega02 07* 0.32-a0-1827-g258319946a: Add code framework for gaining Infernal Marks 10(3 weeks ago, 10 files, 201+ 11-) 13https://github.com/crawl/crawl/commit/258319946a63 18:40:11 03DracoOmega02 07* 0.32-a0-1828-gf17db963b2: Makhleb capstone: Mark of the Tyrant 10(2 weeks ago, 8 files, 143+ 11-) 13https://github.com/crawl/crawl/commit/f17db963b2ed 18:40:11 03DracoOmega02 07* 0.32-a0-1829-gd15373d040: Mahkleb capstone: Mark of Carnage 10(2 weeks ago, 9 files, 184+ 26-) 13https://github.com/crawl/crawl/commit/d15373d04079 18:40:11 03DracoOmega02 07* 0.32-a0-1830-g07ef8100c4: Makhleb capstone: Mark of the Legion 10(2 weeks ago, 15 files, 121+ 12-) 13https://github.com/crawl/crawl/commit/07ef8100c49f 18:40:11 03DracoOmega02 07* 0.32-a0-1831-g9c19790104: Mahkleb capstone: Mark of Annihilation 10(2 weeks ago, 31 files, 280+ 30-) 13https://github.com/crawl/crawl/commit/9c197901040a 18:40:11 03DracoOmega02 07* 0.32-a0-1832-gecea4f0a1a: Different tiles for each flavor of Destruction (regret-index) 10(2 weeks ago, 6 files, 14+ 2-) 13https://github.com/crawl/crawl/commit/ecea4f0a1a26 18:40:11 03DracoOmega02 07* 0.32-a0-1833-g06b347fab1: Makhleb capstone: Mark of Haemoclasm 10(13 days ago, 15 files, 67+ 15-) 13https://github.com/crawl/crawl/commit/06b347fab1d9 18:40:11 ... and 12 more commits 18:50:26 04Build failed for 08master @ fed0f14c 06https://github.com/crawl/crawl/actions/runs/10104247186 18:51:19 https://github.com/crawl/crawl/actions/runs/10104247186/job/27942917243#step:11:123 tag_upgrade problem 18:53:01 03DracoOmega02 07* 0.32-a0-1846-gfd94369f82: Fix tag upgrade build 10(57 seconds ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/fd94369f82c2 19:01:28 <08n​icolae> looking through the commits, the description for Tyrant has a stray "be" in > When you slay enemies, a random servant may be gain one of: Haste, Might, Regeneration, or Brilliance. 19:02:21 <04d​racoomega> Well, there's not much that can be done about that now, alas 19:02:41 <04d​racoomega> Can't edit commits that have already been pushed to master 19:03:10 we've survived worse 🙂 19:03:30 <04d​racoomega> I have definitely had worse typoes in commits, yes >.>; 19:03:37 <02M​onkooky> this will bring ruin upon crawl 19:04:13 <08n​icolae> wasn't that the whole point of this series of commits, though- 19:04:40 no, that would be Vehumet 🙂 19:05:31 <04d​racoomega> No, Kiku is the one with Ruin 19:17:59 <06p​leasingfungus> !clapall hype 19:18:00 <04C​erebot> 👏 h 👏 y 👏 p 👏 e 👏 19:46:49 <08n​icolae> this is the first time in a while i've fired up local crawl for not-wizmode purposes 19:57:57 <04d​racoomega> I'll take that as a compliment ^^; 21:03:28 03dolorous02 07* 0.32-a0-1847-gd8dc43ca6b: Fix typos/spelling/wording/punctuation. 10(53 minutes ago, 10 files, 28+ 28-) 13https://github.com/crawl/crawl/commit/d8dc43ca6bb7 21:03:28 03dolorous02 07* 0.32-a0-1848-g08024717e7: Add comment regarding now-unused ability flag. 10(47 minutes ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/08024717e7f5 21:03:28 03dolorous02 07* 0.32-a0-1849-ge8675a7101: Rewrap Fugue status description. 10(21 minutes ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/e8675a710153 21:03:28 03dolorous02 07* 0.32-a0-1850-g7e27316db8: Add another Makhleb executioner line. 10(15 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/7e27316db8fe 21:03:28 03dolorous02 07* 0.32-a0-1851-g4064a0edb0: Update a few Donald lines for new Makhleb. 10(4 minutes ago, 1 file, 8+ 2-) 13https://github.com/crawl/crawl/commit/4064a0edb0e2 21:03:28 03DracoOmega02 07* 0.32-a0-1852-gfaf5e19491: Flag Brand Self abilities as hurting the player 10(63 seconds ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/faf5e1949106 21:17:33 <04d​racoomega> @dolorous_84348 Unless this is some rule of Australian English I'm not aware of, I think a number of the commas you added in that editing pass are incorrect. For instance "You consecrate your suffering, and invoke the rites of blood!" (and a number of similar instances.) Those aren't actually independent clauses (ie: you can't say a non-imperative "invoke the rites of blood" on its own) which means they're not supposed to have a 21:17:33 comma there. 21:22:06 <06d​olorous_84348> Hmmm. I'll look at these again, then. Thanks for the info. 21:25:37 <06d​olorous_84348> Although I'm not entirely certain regarding independent clauses. "You consecrate your suffering, and you invoke the rites of blood!" seems to be imperative, but if the second "you" is left out (as it's implied), it's not imperative? 21:27:00 03dolorous02 07* 0.32-a0-1853-gdde1e95dc1: Add another ghost line for new Makhleb. 10(13 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/dde1e95dc1c3 21:27:35 <04d​racoomega> Well, the point is that 'invoke the rites of blood' here doesn't have an explicit you in it. It's referencing the 'you' in the first line. ie: "You consecrate your suffering and [you] invoke the rites of blood.". Or rather "You [consecrate your suffering] and [invoke the rites of blood]" rather than "[You conseccrate your suffering] and [invoke the rites of blood.]" 21:27:54 <04d​racoomega> This sure feels like an absurd sentence to be using as grammar examples 21:29:34 <04d​racoomega> But a quick search on commas and dependent clauses brings up specific comparable examples as explicitly incorrect. (eg: "Sam tossed the ball, and watched the dog chase it.") 21:29:42 <04d​racoomega> Which is the same sentence structure, albeit a lot more pedestrian ^^; 21:30:03 <06d​olorous_84348> Ah. 21:31:05 I think that's cohortative, not imperative (you aren't commanding it, you're doing it) 21:31:18 03DracoOmega02 07* 0.32-a0-1854-gcde62734c2: Fix missing Vessel of Slaughter ability (Lightli) 10(36 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/cde62734c28d 21:48:25 03dolorous02 07* 0.32-a0-1855-ge40bc53d54: Revert some incorrectly added commas (DracoOmega). 10(14 minutes ago, 5 files, 11+ 11-) 13https://github.com/crawl/crawl/commit/e40bc53d5443 21:49:31 03DracoOmega02 07* 0.32-a0-1856-gfff831dfa0: Fix a crash upon using Vessel of Slaughter (Lightli) 10(80 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/fff831dfa035 21:54:35 04Build failed for 08master @ e40bc53d 06https://github.com/crawl/crawl/actions/runs/10105869235 21:55:44 04Build failed for 08master @ fff831df 06https://github.com/crawl/crawl/actions/runs/10105876153 21:59:10 03dolorous02 07* 0.32-a0-1857-gf333cd237d: Revert one more incorrectly added comma (DracoOmega). 10(2 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/f333cd237d13 21:59:10 03dolorous02 07* 0.32-a0-1858-g5e83875c39: Fix incorrect comma in inexperienced mutation. 10(81 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/5e83875c3936 22:01:19 <06d​olorous_84348> Okay, I think I got them all. 22:03:54 <04d​racoomega> Thanks. (I wouldn't have minded going in and reverting them myself, but it felt better to explain myself first, at the very least ^^; ) 22:04:47 <06d​olorous_84348> No problem. It's good to keep learning these things. 22:35:34 Unstable branch on crawl.develz.org updated to: 0.32-a0-1858-g5e83875c39 (34) 22:59:01 Windows builds of master branch on crawl.develz.org updated to: 0.32-a0-1858-g5e83875c39 23:34:27 Unstable branch on cbro.berotato.org updated to: 0.32-a0-1858-g5e83875c39 (34) 23:55:44 Monster database of master branch on crawl.develz.org updated to: 0.32-a0-1858-g5e83875c39