03:04:41 <Discord|> <12g​e0ff> reposting from another Discord: the book of spontaneous combustion has pages that "smell faintly of sulfer", but the Australian spelling is "sulphur" (spotted by Graveyardigan)
03:33:26 <Lantell> Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5208-geafff8c3b6
05:59:51 <NotCheibriados> 03dolorous02 07* 0.32-a0-1787-g1d9136647e: Fix spelling (sulfur -> sulphur) (Graveyardigan). 10(12 minutes ago, 5 files, 5+ 5-) 13https://github.com/crawl/crawl/commit/1d9136647e68
07:48:38 <Discord|> <12g​e0ff> @dolorous_84348, re: https://github.com/crawl/crawl/issues/3935
07:48:45 <Discord|> <12g​e0ff> After 4f4802e42, players keep their blood state even after transforming into a bloodless form. E.g., humans still have blood in statue and storm forms
07:49:28 <Discord|> <12g​e0ff> Currently player::has_blood() checks forms via  cpp if (temp && form_has_blood(form)) return true;      but it should be cpp if (temp && !form_has_blood(form)) return false;      to make it work as prior to that commit
07:53:11 <NotCheibriados> 03dolorous02 07* 0.32-a0-1788-g3eefd6cc51: Fix body part checks for forms (#3935). 10(7 minutes ago, 1 file, 19+ 13-) 13https://github.com/crawl/crawl/commit/3eefd6cc516a
07:55:37 <Discord|> <06d​olorous_84348> Got it; thanks. (Although I noticed the bug report before your message.) form_has_feet() also wasn't being used in the check for feet, and that should be fixed now too.
07:56:39 <Discord|> <12g​e0ff> cpp  if (temp)         return form_has_blood(form);  <--- this means Gr in Dragon Form has blood now
07:57:14 <Discord|> <06d​olorous_84348> Dragon form overrides physiology; dragons have blood, so players in dragon form get blood too.
07:57:42 <Discord|> <06d​olorous_84348> So that's intentional.
07:58:19 <Discord|> <12g​e0ff> previously there was no way to Gr to get blood, iirc
07:58:53 <Discord|> <12g​e0ff> in 0.31, even Dragon form gargoyles were bloodless
07:58:55 <dcss-ci> 04Build failed for 08master @ 3eefd6cc 06https://github.com/crawl/crawl/actions/runs/10078984405
07:59:47 <Discord|> <06d​olorous_84348> True, but previously the logic for player_can_bleed() returned a yes/no/maybe value, but only the yes value was acknowledged for anything.
08:00:22 <Discord|> <06d​olorous_84348> Which is why I moved it into has_blood(), which properly acknowledged the "maybe" case.
08:01:03 <Discord|> <12g​e0ff> anyway, i'm just pointing out that a refactor shouldn't bring a gameplay change without at least mentioning that in a commit message or something
08:02:50 <Discord|> <06d​olorous_84348> Ideally, yes, but the can_bleed() -> has_blood() change fixed an underlying deficiency, and physiology-overriding mutations get weird. Should a gargoyle player in pig form also be a pig that doesn't have blood, unlike other pigs?
08:03:15 <Discord|> <12g​e0ff> yeah, it should be a stone 🐷 !
08:03:55 <Discord|> <06d​olorous_84348> It seems weird to me that a creature made of living stone can change form at all, though.
08:08:01 <Discord|> <12g​e0ff> (djinn are bloodless too, so it's not just Gr)
08:08:17 <Discord|> <06d​olorous_84348> Point. It's easy enough to change, at least.
08:09:15 <Discord|> <03i​mplojin> i agree with ge0ff that we need to be slightly careful with reordering the logic in these refactors, for example right now we're claiming that mutated merfolk can have feet despite merfolk's ingame mutation description explicitly claiming that tail shifting overrides that
08:11:26 <Discord|> <12g​e0ff> (also, it's kinda random which species' properties are overridden by forms, so there could be an argument that having blood/being bloodless should be defined by forms)
08:13:21 <Discord|> <06d​olorous_84348> On a similar note, beast form explicitly says a hairy were-beast, so that form currently always gets hair.
08:19:45 <Discord|> <03i​mplojin> actually, can merfolk get feet mutations? maybe this is ok
08:21:33 <Discord|> <06d​olorous_84348> I'm not certain; the fishtail is weird.
08:21:55 <Discord|> <03i​mplojin> a couple of wizmode tests seem to indicate hooves and talons are blocked for merfolk, anyway
08:22:04 <Discord|> <03i​mplojin> so maybe this is fine
08:23:02 <Discord|> <06d​olorous_84348> For now, I'll put the fishtail logic back where it was, just in case.
08:24:03 <Discord|> <12g​e0ff> fr: blood elemental form!
08:24:13 <NotCheibriados> 03dolorous02 07* 0.32-a0-1789-g4a3ce621dc: Disallow gaining blood w/form changes (ge0ff). 10(10 minutes ago, 1 file, 6+ 6-) 13https://github.com/crawl/crawl/commit/4a3ce621dcd7
08:24:13 <NotCheibriados> 03dolorous02 07* 0.32-a0-1790-gab7c848782: Fix merfolk fishtail checks wrt feet (Implojin). 10(6 minutes ago, 1 file, 3+ 5-) 13https://github.com/crawl/crawl/commit/ab7c84878221
08:24:16 <Discord|> <06d​olorous_84348> 😈
08:28:45 <Discord|> <03i​mplojin> also, extremely minor nit re the now-removed has_blood unliving check: petrified players being attacked by skysharks will now bleed all over the place which might be corner case relevant in deep lair re catoblepas clouds? this is so minor that it's probably completely fine to have removed it but i'm just pointing it out for the sake of completeness
08:30:23 <Discord|> <06d​olorous_84348> Hmmm.
08:41:23 <NotCheibriados> 03dolorous02 07* 0.32-a0-1791-g6bbb805001: Keep the petrified from bleeding (Implojin). 10(8 minutes ago, 2 files, 8+ 0-) 13https://github.com/crawl/crawl/commit/6bbb80500152
13:47:26 <NotCheibriados> 03Implojin02 07* 0.32-a0-1792-gd8bda1bd53: Slightly improve ghost visibility 10(3 minutes ago, 2 files, 2+ 2-) 13https://github.com/crawl/crawl/commit/d8bda1bd53b3
15:36:41 <Lantell> Unstable branch on underhound.eu updated to: 0.32-a0-1792-gd8bda1bd53 (34)
16:23:41 <NotCheibriados> 03Aliscans02 {dolorous} 07* 0.32-a0-1793-g081d225295: Improve wrapping for monster_item_view_coordinates. 10(30 hours ago, 1 file, 7+ 6-) 13https://github.com/crawl/crawl/commit/081d225295e4
16:37:38 <NotCheibriados> 03dolorous02 07* 0.32-a0-1794-g5e739b3c72: Add another mythical creature to artefacts. 10(2 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/5e739b3c72e6
17:51:28 <NotCheibriados> 03DevJac02 {dolorous} 07* 0.32-a0-1795-g8bde0a30e5: Distinguish explore mode deaths from Felid deaths 10(4 days ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/8bde0a30e515
18:21:27 <NotCheibriados> 03dolorous02 07* 0.32-a0-1796-g6575a434b8: Account for missing a hand in random body parts. 10(15 minutes ago, 1 file, 3+ 1-) 13https://github.com/crawl/crawl/commit/6575a434b866
18:21:27 <NotCheibriados> 03dolorous02 07* 0.32-a0-1797-g3ba28113cd: Add @random_body_part_external@. 10(8 minutes ago, 2 files, 18+ 4-) 13https://github.com/crawl/crawl/commit/3ba28113cde5
18:28:57 <NotCheibriados> 03dolorous02 07* 0.32-a0-1798-g55c3cb5494: Add another acrobatic move to Xom dances. 10(2 minutes ago, 1 file, 2+ 0-) 13https://github.com/crawl/crawl/commit/55c3cb5494d9
18:47:09 <NotCheibriados> 03dolorous02 07* 0.32-a0-1799-g353f8a747c: Remember that players generally have heads. 10(6 minutes ago, 1 file, 3+ 0-) 13https://github.com/crawl/crawl/commit/353f8a747cc1
18:51:54 <dcss-ci> 04Build failed for 08master @ 353f8a74 06https://github.com/crawl/crawl/actions/runs/10086746191
18:54:04 <geekosaur> https://www.mistys-internet.website/blog/blog/2024/07/12/github-is-starting-to-feel-like-legacy-software/
19:07:30 <NotCheibriados> 03dolorous02 07* 0.32-a0-1800-g3df9983ad0: Account for player tails in Xom/body part msgs. 10(5 minutes ago, 3 files, 18+ 0-) 13https://github.com/crawl/crawl/commit/3df9983ad033
19:27:51 <NotCheibriados> 03dolorous02 07* 0.32-a0-1801-gc0dcec2120: Use booleans instead of numbers in has_tail(). 10(15 minutes ago, 1 file, 4+ 4-) 13https://github.com/crawl/crawl/commit/c0dcec212047
19:27:51 <NotCheibriados> 03dolorous02 07* 0.32-a0-1802-ga15e480964: Give felids tails (only cosmetic). 10(6 minutes ago, 3 files, 8+ 3-) 13https://github.com/crawl/crawl/commit/a15e480964a4
19:39:58 -!- The topic of #crawl-dev is: Crawl Development | https://github.com/crawl/crawl | Logs: http://s-z.org/crawl-dev/, temporarily http://crawl.akrasiac.org/logs/cheibriados/ | People with +v have commit access, devs on bridged discord as well | General Crawl-related chat to #crawl | Long stuff to a pastebin service, please
19:39:58 -!- The topic of #crawl is: Play Dungeon Crawl Stone Soup online now! Type ??online for instructions, ??lg / !lg for play stats | PM Sequell for long queries | http://crawl.develz.org | FooTV game replays: ??footv for instructions | #crawl-dev for dev discussion, #crawl-offtopic for offtopic
22:10:19 <NotCheibriados> 03regret-index02 07* 0.32-a0-1803-g767fb09e7d: More adjustments to ghost visibility 10(4 minutes ago, 10 files, 73+ 11-) 13https://github.com/crawl/crawl/commit/767fb09e7d20
22:35:28 <Gretell> Unstable branch on crawl.develz.org updated to: 0.32-a0-1803-g767fb09e7d (34)
22:48:51 <NotCheibriados> 03dolorous02 07* 0.32-a0-1804-gf366dc3c9d: Add missing -Gavotte status description. 10(6 minutes ago, 1 file, 5+ 0-) 13https://github.com/crawl/crawl/commit/f366dc3c9d75
22:48:51 <NotCheibriados> 03dolorous02 07* 0.32-a0-1805-g5617537c2f: Remove obsolete Stiff status description. 10(4 minutes ago, 1 file, 0+ 5-) 13https://github.com/crawl/crawl/commit/5617537c2f8b
22:58:10 <Gretell> Windows builds of master branch on crawl.develz.org updated to: 0.32-a0-1803-g767fb09e7d
23:25:40 -!- Noisytoot is now known as Guest9845
23:27:09 <Cbrotell> Unstable branch on cbro.berotato.org updated to: 0.32-a0-1805-g5617537c2f (34)
23:55:16 <Gretell> Monster database of master branch on crawl.develz.org updated to: 0.32-a0-1805-g5617537c2f