02:54:26 MAN (L27 MiFi) ERROR in 'mon-util.cc' at line 696: bogus mc (no monster data): invalid monster_type 1000 (1000) (Pan) 03:33:51 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5208-geafff8c3b6 05:29:13 Unstable branch on crawl.akrasiac.org updated to: 0.32-a0-1643-g611ce37 (34) 06:02:17 <12asciiphilia> I created the SoundSupport module, a successor to the CWZ sound patch, using DWEM. This module was designed with respect to the existing RC settings of Crawl as much as possible. (It is currently applied to CNC) 07:49:35 03dolorous02 07* 0.32-a0-1644-g4f4802e42f: Indicate whether species/forms have blood. 10(52 minutes ago, 24 files, 100+ 77-) 13https://github.com/crawl/crawl/commit/4f4802e42f86 07:51:44 03dolorous02 07* 0.32-a0-1645-g38ac799c93: Update comment. 10(80 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/38ac799c9362 08:21:47 03dolorous02 07* 0.32-a0-1646-gb4b85c6ba5: Move player_has_bones() into actor. 10(7 minutes ago, 8 files, 19+ 12-) 13https://github.com/crawl/crawl/commit/b4b85c6ba519 08:28:14 <08nicolae> i started re-work on the bazaar update and realized i didn't like the results... back to the drawing board 09:39:36 does that mean the rework didn't work? 09:53:42 <08nicolae> needs work 😔 10:53:46 03elliptic02 07* 0.32-a0-1647-gf62c45d80e: Tweak Hedge Wizard start (acrobat) 10(9 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/f62c45d80e09 12:02:37 <04dracoomega> I've been meaning to ask about this for a while, but is the usual #if TAG_MAJOR_VERSION == 34 stuff we do to dummy out unused spells and enchants and such actually needed for removing god abilities? It's been done consistently there, except that the enums for each god already have a defined numerical start (instead of just being an ordered list) and (most importantly) whether or not the player has a given ability is dynamically 12:02:38 calculated from current piety and such so a character's ability list should just automatically correct itself. Am I wrong here? 12:04:55 <06pleasingfungus> the key question is whether the god abilities are marshalled anywhere. 12:05:34 <06pleasingfungus> i suspect they are marshalled for some things (quiver logic? morgue notes?), which would mean that we couldn't remove them without breaking save compat. 12:05:42 <06pleasingfungus> but i haven't checked. 12:06:16 <04dracoomega> That might be true. (It's just that the most obvious concerns that apply to spells don't apply here, so I had wondered.) 12:06:36 <04dracoomega> Was wondering if there was something obvious I was overlooking 12:07:03 <04dracoomega> Since no code is needed to make a player stop having a removed god ability on save upgrade aready (unlike spells) 12:10:47 <04dracoomega> Now that you mention it, it is possible that skill use tables would have been affected by some of these removals, if you upgraded your save from one god version to the next (but that seems fairly unimportant, imo) 12:11:48 <04dracoomega> (We already didn't keep around data for names of removed god abilities and such) 13:01:24 <04dracoomega> I ran a few tests (as well as looking at code) and for what it's worth, while action counts do get messed up in an upgraded save (though this already happens for abilities which get replaced), everything otherwise seems fine. If you were quivering a removed ability, you just end up quivering nothing. (I think the only thing that gets marshalled regarding abilities here is the keybindings for them, which are ignored if you don't 13:01:25 actually have the ability bound to that letter) 13:03:27 <04dracoomega> (As it is, the current method replaces removed abilities with "Invoke: No ability" in the action counts in the log) 13:32:55 <04dracoomega> I find it kind of funny that scaling_cost is currently never used in any way that scales. I presume at some point in the past it was used that way for some ability, as evidently the functionality still exists (though the formula is weird) 13:33:22 <04dracoomega> Wai 13:33:48 <04dracoomega> Okay, my mistake, it just implicitly constructed so I didn't notice 13:35:28 <04dracoomega> Still used that way by demonspawn Hurl Damnation, evoking the Orb of Dispater, and (funnily enough) Shadowslip 14:54:57 <08nicolae> let's do it. let's break save combat. 14:55:06 <08nicolae> that should be compat but let's also break save combat. 15:04:18 <03wheals> id rather we combat save breakage 15:06:35 <04dracoomega> My point is that I don't think this actually does break save compat ^^; 15:06:42 <06pleasingfungus> this seems like a thing we can check. 15:06:49 <06pleasingfungus> hold for a few minutes, please. 15:10:43 <04dracoomega> I mean, I'm just doing Makhleb stuff on a branch. I'm not on the verge of doing anything at all ^^; 15:11:41 <04dracoomega> It's just I was reminded of this as I squash abilities here 15:14:24 <06pleasingfungus> tentatively looks like ability_type is only marshalled for - action counts, as noted (and as noted, those are already a little broken when abilities are removed) - ability_letter_table 15:16:57 <06pleasingfungus> the latter is what maps from a keys (e.g. a X) to abilities? So if you shifted an enum by removing a god ability (that's not the last ability for that god), then your letter assignments for the god's other abilities would be wrong? Probably not the end of the world... 15:17:47 <04dracoomega> I mean, it effectively re-compacts the defaults 15:18:04 <04dracoomega> (Less predictable if someone has actually remapped them, of course) 15:18:47 <06pleasingfungus> assuming that the ability isn't one of the weird ones that goes to a non-lowercase letter, like ABIL_HEPLIAKLQANA_IDENTITY? (Not sure how many other weird abilities there are) 15:23:05 <04dracoomega> I think capstone gift stuff is weird in some cases? (Beogh recruit/dismiss ones also are) 15:23:12 <04dracoomega> Er, in terms of default binding 15:24:42 <06pleasingfungus> sounds plausible 15:25:41 <04dracoomega> Like, none of this is really a big deal; it's just minorly nice to be able to remove things that are actually removed, if it's actually safe to do so 15:26:45 <06pleasingfungus> yep 15:28:56 <04dracoomega> Unrelated bug I have just discovered while working on this: if you are a demonspawn with ignite blood and receive Kiku's pain weapon gift, the blood that splatters all over the place can't catch fire 15:39:08 Unstable branch on underhound.eu updated to: 0.32-a0-1647-gf62c45d80e (34) 16:09:45 Airwolf (L5 MDEn) ERROR in 'mon-util.cc' at line 4955: invalid kill category (D:4) 16:12:29 -!- wantyapps is now known as ghost 16:12:58 -!- ghost is now known as wantyapps 16:21:39 !crashlog Airwolf 16:21:40 39. Airwolf, XL5 MDEn, T:4345 (milestone): http://crawl.akrasiac.org/rawdata/Airwolf/crash-Airwolf-20240702-230944.txt 16:23:15 huh. did something break that kiku altar vault with the human that gets zombified? 19:39:56 -!- The topic of #crawl-dev is: Crawl Development | https://github.com/crawl/crawl | Logs: http://s-z.org/crawl-dev/, temporarily http://crawl.akrasiac.org/logs/cheibriados/ | People with +v have commit access, devs on bridged discord as well | General Crawl-related chat to #crawl | Long stuff to a pastebin service, please 19:39:56 -!- The topic of #crawl is: Play Dungeon Crawl Stone Soup online now! Type ??online for instructions, ??lg / !lg for play stats | PM Sequell for long queries | http://crawl.develz.org | FooTV game replays: ??footv for instructions | #crawl-dev for dev discussion, #crawl-offtopic for offtopic 20:33:07 03dolorous02 07* 0.32-a0-1648-g54083d67a5: Fix incorrect possessive in merfolk siren msg. 10(4 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/54083d67a529 22:35:31 Unstable branch on crawl.develz.org updated to: 0.32-a0-1648-g54083d67a5 (34) 22:59:07 Windows builds of master branch on crawl.develz.org updated to: 0.32-a0-1648-g54083d67a5 23:11:13 03dolorous02 07* 0.32-a0-1649-g23c286355e: Avoid spurious blinding msgs from TSO's shield. 10(7 minutes ago, 1 file, 6+ 3-) 13https://github.com/crawl/crawl/commit/23c286355e0c 23:31:33 Unstable branch on cbro.berotato.org updated to: 0.32-a0-1648-g54083d67a5 (34) 23:55:28 Monster database of master branch on crawl.develz.org updated to: 0.32-a0-1649-g23c286355e