03:33:33 Experimental (bcrawl) branch on underhound.eu updated to: 0.23-a0-5208-geafff8c3b6 05:07:42 Unstable branch on crawl.akrasiac.org updated to: 0.32-a0-1329-gbc65bc1 (34) 09:43:06 03elliptic02 07* 0.32-a0-1330-ga65b6e8950: Fix fluxform glow description on A screen 10(2 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/a65b6e8950f4 09:44:11 03elliptic02 07* 0.32-a0-1331-gbe264ac2b7: Let Vehumet support Rimeblight 10(59 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/be264ac2b7f5 14:52:25 Btw dracoomega, one thing I forgot to mention, there's a minor bug with the text when trying to aim marionette on a summon: https://imgur.com/a/euwCT9M 15:10:08 <04dracoomega> Oh, er. Hmm... I wonder how I fix that. Apparently passing an empty string through that function doesn't mean 'Don't add a message' but rather 'Add an empty message' 15:11:14 <04dracoomega> Oh, wait 15:11:21 <04dracoomega> Oops, nevermind 15:13:17 <04dracoomega> (Also staring at some javascript UI layout code that I do not especially like to try and make the xv Marionette indicators work properly in webtiles) 15:37:49 Unstable branch on underhound.eu updated to: 0.32-a0-1331-gbe264ac2b7 (34) 15:37:53 <04dracoomega> Going great: 15:37:53 <04dracoomega> https://cdn.discordapp.com/attachments/747522859361894521/1248405530133663834/image.png?ex=66638bc0&is=66623a40&hm=96af9572baf01c77e3eb8aee4d7413e7732c281e5861ff1f7557a0eea76f4360& 15:52:53 <04dracoomega> Well, I got it working. Now my issue is that webtiles colors are bad 15:53:43 <04dracoomega> (Or more specifically, the two magentas are very obviously not even slightly the same shade as used in local tiles - and both have much worse contrast for the purpose I was using them for >.>) 15:58:52 <04dracoomega> Local colors vs. webtiles colors: 15:58:52 <04dracoomega> https://cdn.discordapp.com/attachments/747522859361894521/1248410810339037326/image.png?ex=666390ab&is=66623f2b&hm=c5065bea6dc036851b6bfe31ffc98f0347d6376822339cf92f5c9bee3e4dee6a& 16:06:18 -!- aoei2 is now known as aoei 16:10:53 <04dracoomega> %git cb359bb5f2446cc7f1cce9b74ce87cdfac09e9b0 16:10:54 <04Cerebot> edlothiol * 0.12-a0-595-gcb359bb5f2: Change the colour scheme for webtiles text (in particular, glyph mode). (12 years ago, 3 files, 51+ 17-) https://github.com/crawl/crawl/commit/cb359bb5f244 16:11:14 <04dracoomega> We'll see if anyone cares. I am caring from 12 years in the future, apparently 16:12:40 <09hellmonk> rip 16:15:36 <04dracoomega> The contrast is so bad T.T (I have no idea about glyph mode for webtiles - or whether or not it improves anything there.) 16:16:45 <04dracoomega> Tempted to add a secret 17th webtiles color for "No, really, please actually make this bright so people can notice it" ^^; 16:17:22 <04dracoomega> But actually, I remember complaints about some other indicator lights being hard to see in webtiles 16:17:51 <04dracoomega> Too dark text and whatnot 16:18:05 <04dracoomega> Was this some Yred torch stuff when it was first added, maybe? 16:19:06 <04dracoomega> I am not personally sure at the logic at the time of making important UI lights more dark/pastel but also it's apparently been this way for most of the time webtiles has even been around so is just 'normal' for a bazillion people I guess >.>; 16:28:29 <06pleasingfungus> normal is for normies 16:28:32 <06pleasingfungus> smash the norms! 16:34:32 <04dracoomega> What, are you actually suggesting I change all of webtiles text colors back and just hope everyone is fine with that? ^^; 16:36:02 <06regret-⸸nde※> I'm personally voting for "webtiles isn't a console terminal and if each tile is offered up all of these different colours then we should just be allowed to use additional colours past 16 solely for actually readable UIs". 16:36:42 <06dolorous_84348> That sounds good to me too. 16:41:05 <04dracoomega> That is pretty reasonable, but also: a lot of UI code directly uses console color codes which are directly mapped by this taple to html colors and I kind of suspect that what I'm working on right now isn't the only thing suffering from contrast issues 16:41:35 <04dracoomega> Whether or not people are used to it 16:44:38 <06pleasingfungus> yes. yolo 16:46:12 <04dracoomega> Wow. Bold. 16:47:43 <04dracoomega> (I was honestly wondering if it made any sense to have like 'color sets' that webtiles could use to map things, so that that someone could switch back to the current defaults if they preferred them over the higher-contrast colors (or even edit them to their own preferences), but I really don't think I know how to go about that, web-dev-wise) 16:48:39 <04dracoomega> (The colors really are just a simple blob in css) 16:52:26 New branch created: dependabot/pip/crawl-ref/source/webserver/requirements/tornado-6.4.1 (1 commit) 13https://github.com/crawl/crawl/tree/dependabot/pip/crawl-ref/source/webserver/requirements/tornado-6.4.1 16:52:27 03dependabot[bot]02 {GitHub} 07[dependabot/pip/crawl-ref/source/webserver/requirements/tornado-6.4.1] * 0.32-a0-1332-gecdcacc91f: Bump tornado in /crawl-ref/source/webserver/requirements 10(47 seconds ago, 2 files, 2+ 2-) 13https://github.com/crawl/crawl/commit/ecdcacc91f99 16:52:27 New branch created: pull/3857 (1 commit) 13https://github.com/crawl/crawl/pull/3857 16:52:27 Branch pull/3857 updated to be equal with dependabot/pip/crawl-ref/source/webserver/requirements/tornado-6.4.1: 13https://github.com/crawl/crawl/pull/3857 17:11:10 <04dracoomega> So, I went to the trouble to make a swatch of local vs. webtiles colors. At least in this context, many of the current webtiles colors feel fairly reasonable, but magenta definitely seems like it's the worst off. (Not really a fan of webtiles blue by comparison either). Though local magenta/darkmagenta feels awfully similar, too. 17:11:11 <04dracoomega> https://cdn.discordapp.com/attachments/747522859361894521/1248429009386082375/color_comparison.png?ex=6663a19e&is=6662501e&hm=db2239eef9596430b3ee268c418326f4b62e28e45db41da73aad72887d7dc50a& 17:11:53 local = your terminal colours? 17:12:05 <04dracoomega> Pretty sure this is local tiles 17:12:24 <04dracoomega> As I understand it, terminal colors can easily be set by an individual anyway, if they're playing that way? 17:12:52 unless crawl specifically sets the colours, and I don't think it does 17:13:09 <04dracoomega> (Like, I have no doubt that local tiles colors were chosen based off some default terminal colors at some point, but I'm pretty sure they're essentially baked in now?) 17:35:22 <06pleasingfungus> can we just change magenta, then? 17:35:37 <06pleasingfungus> and blue, i guess 17:40:22 <04dracoomega> Yeah, that's basically what I'm leaning towards 17:40:52 <04dracoomega> Which should improve clarity on a few things and otherwise probably not even draw that much attention? 17:43:33 <06pleasingfungus> they will be coming after you with pitchforks! 17:44:57 <09hellmonk> 200000 upvote on Reddit insta 17:45:08 <09hellmonk> game ruined by devs once again 17:45:16 <04dracoomega> Heh 17:54:19 <06dolorous_84348> Just tell them that Blorkula approves, despite their puny mortal misgivings 🧛🌈 17:54:32 <04dracoomega> Haha 17:54:46 <04dracoomega> Clearly I will credit them in the commit to deflect potential blame 18:35:08 <04dracoomega> Gee, I sure like how apparently this css apparently has a whole lot of places where it copy-pastes a color code for a color (with a commenting indicating which thing it's copied from!) that need to all be found and replaced 18:36:17 <04dracoomega> Oh, hmmm, is the magenta used for Silence still currently actually bright because that one got overlooked when doing this very same process? 18:36:22 <04dracoomega> Oh, no, it's even brighter 18:36:40 credit a fitting unique for every commit! 18:36:45 (the webtiles vs local magenta difference has bothered me forever, I just assumed there was some sort of special reason for the extra UI asymmetry and it seems, no, there was not) 18:37:27 <04dracoomega> Actually, there seem to be more one-off exceptions here than I realized. Like, the red for the noise bar is brighter, too 18:37:46 <04dracoomega> But a bunch of other things were kept in sync, it looks like 18:44:28 <04dracoomega> Even scarier: JS function determine_colours() { [...] // FIXME: CSS lookup doesn't work on Chrome after saving and loading a // game, style information is missing for some reason. // Use hard coded values instead. healthy = "#8ae234"; hp_spend = "#a40000"; magic = "#729fcf"; 19:07:14 <06pleasingfungus> wow 19:07:26 <06pleasingfungus> good ‘for some reason’ 19:08:42 <04dracoomega> I am not a web dev, so I am not even slightly attempting to figure out what the problem there is, and am just replacing a color code 😛 19:09:08 <04dracoomega> Today may be literally the first time I have edited a css file in my life 19:11:23 <09gammafunk> proposed release highlight: New magenta and blue colors 19:11:26 <09gammafunk> (for webtiles) 19:11:54 <06mumra> Probably there is a stale ref to some DOM elements that no longer exist 19:13:30 <04dracoomega> (Index leaned over and expressed some surprise that I'd never even touched a css file in school and I was like "When we first did webpage editing in school, CSS hadn't been invented yet" >.>) 19:13:59 <09gammafunk> did you use the lynx browser? 19:14:04 <09gammafunk> (terminal-based web browser) 19:14:19 <04dracoomega> Not quite that old, no 😛 19:15:15 when I was in school, web pages hadn't been invented yet 😛 19:15:38 <04dracoomega> (First browser I remember was Netscape Navigator) 19:15:56 <09gammafunk> geekosaur confirmed gopher user 19:16:04 <06mumra> hmm no it shouldn't be stale refs. the comment might not even be true in modern browsers tbh. but as a professional web dev, i am frankly scared to touch the webtiles js without first doing a bit of overall stack modernisation so there is actually some build time checking a few other safety nets 😂 19:16:22 <06mumra> and there are probably a dozen better ways to handle these colorus 19:16:22 <04dracoomega> And some teacher having us go to some specific page on the NASA website by manually typing in a URL that was far, far too long to want to do that with 19:16:53 <09gammafunk> wow gopher is actually younger than http, TIL 19:16:54 gopher hadn't been invented yet either. neither had the internet 19:17:39 <06mumra> i would probably move all the colours to css variables and then they can just be looked up directly without having to juggle elements around like this 19:18:12 wasn't someone working on a modernized webtiles? 19:18:24 <09gammafunk> yeah, alex 19:18:50 <09gammafunk> but he recently stopped working on it and then declared that cpo will also go offline soonish :yogidaFeels: 19:19:08 <09gammafunk> in fact, I DMed someone about being a potential replacement admin but sadly that person never responded, rip 19:19:19 <04dracoomega> Really? I must have missed the latter bit, too 19:19:54 yeh, just found that in logs 19:19:54 <09gammafunk> yeah, cpo is fairly low traffic, but users in australia, new zealand, and the asia-pacific in general appreciate having it 19:20:08 <09gammafunk> however asciiphilia is apparently starting a new south korean server, so that's good 19:20:46 <06mumra> yeah i looked at their branch, it's basically a complete rewrite in react/typescript. but i am rather thinking about a slightly lighter touch of just converting the existing code to typescript and using a bundler. so we get all the benefits of build checking and an optimised but without having to completely rebuild the wheel. 19:21:32 <06mumra> and that would make it far easier to actually refactor some of the worse parts of the code and add new stuff moving forward 19:21:35 <09gammafunk> we would absolutely appreciate having a web dev make webtiles client stuff more sane 19:22:11 <09gammafunk> I know advil is tired of being the only person who really tries to do web dev (server side and sometimes client as well) 19:22:31 <09gammafunk> well not really tired of it, but I'm sure he'd be glad to have help with the client 19:23:06 <06mumra> yeah i did start poking at doing this but it's a fairly big task, and there's still a fairly hard problem of ensuring that old versions can still be loaded in correctly 19:23:20 <09gammafunk> right 19:24:25 <06mumra> but in principle not a lot of code needs rewriting, eslint and auto formatters do a lot of the work 19:28:04 <06mumra> the other slightly daunting thing about doing it is the potential for having to resolve conflicts if any other js changes are made in master before it's finished 19:41:58 <04dracoomega> This doesn't feel like it happens very often, especially in ways that aren't quite localized at least 20:10:06 03DracoOmega02 07[dith_experimental] * 0.32-a0-1344-g7f84b6ce9f: Adjust some Webtiles text colors 10(70 minutes ago, 2 files, 27+ 27-) 13https://github.com/crawl/crawl/commit/7f84b6ce9fca 20:10:06 03DracoOmega02 07[dith_experimental] * 0.32-a0-1345-g96b928a9db: Differentiate Magenta and Lightmagenta a little better in local tiles 10(68 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/96b928a9dbb8 20:10:06 03DracoOmega02 07[dith_experimental] * 0.32-a0-1346-g13a77f800f: Fix Marionette indicators near xv spells not displaying in Webtiles 10(66 minutes ago, 2 files, 11+ 3-) 13https://github.com/crawl/crawl/commit/13a77f800fd1 20:10:06 03DracoOmega02 07[dith_experimental] * 0.32-a0-1347-g7e248dd539: Fix a superfluous comma when aiming Marionette at a summon (NormalPerson7) 10(65 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/7e248dd539b2 20:10:06 03DracoOmega02 07[dith_experimental] * 0.32-a0-1348-g05b14185a8: Adjust Dithmenos welcome message 10(19 minutes ago, 1 file, 1+ 5-) 13https://github.com/crawl/crawl/commit/05b14185a86e 20:10:09 03DracoOmega02 07* 0.32-a0-1332-g58043dd47d: Differentiate Magenta and Lightmagenta a little better in local tiles 10(68 minutes ago, 1 file, 2+ 2-) 13https://github.com/crawl/crawl/commit/58043dd47d4f 20:10:09 03DracoOmega02 07* 0.32-a0-1333-g995e409d96: Adjust some Webtiles text colors 10(70 minutes ago, 2 files, 27+ 27-) 13https://github.com/crawl/crawl/commit/995e409d96c7 20:10:09 03DracoOmega02 07* 0.32-a0-1334-g38bec8a339: Don't show a warning for moving while confused near ancestors 10(2 weeks ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/38bec8a3399f 20:10:09 03DracoOmega02 07* 0.32-a0-1335-g088aa39380: Rescale Drain status light colors 10(9 days ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/088aa393804e 20:10:09 03DracoOmega02 07* 0.32-a0-1336-gd392c7bc3d: Fix a couple monster spells using 'true' attitudes instead of current ones 10(4 days ago, 2 files, 4+ 12-) 13https://github.com/crawl/crawl/commit/d392c7bc3d2d 20:10:09 03DracoOmega02 07* 0.32-a0-1337-g2b8f59dbc9: Fix monster Bind Soul tracer including the caster as an eligible target 10(4 days ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/2b8f59dbc9d7 20:10:09 03DracoOmega02 07* 0.32-a0-1338-g95f95faf5e: Tweak how piety costs are described in ability descriptions 10(63 seconds ago, 1 file, 7+ 3-) 13https://github.com/crawl/crawl/commit/95f95faf5edb 20:29:28 <06mumra> No, thankfully because the code is so hard to work with, hardly anyone ever changes it 🙂 20:29:49 <04dracoomega> Upsides and downsides 😛 20:33:41 03dolorous02 07[dith_experimental] * 0.32-a0-1349-g4f75befd72: Improve speech regarding random classes of gods. 10(2 days ago, 2 files, 30+ 25-) 13https://github.com/crawl/crawl/commit/4f75befd7202 20:34:02 <06dolorous_84348> Cherry-picked the one commit so there's one less potential conflict later. 20:41:45 <04dracoomega> Sure 20:44:22 03DracoOmega02 07* 0.32-a0-1339-g925b980f54: Give Wiglaf's hat a proper tile (regret-index) 10(53 seconds ago, 5 files, 6+ 0-) 13https://github.com/crawl/crawl/commit/925b980f5429 20:46:54 <06pleasingfungus> @dracoomega when do we whirlwind slam new dith into old trunk? 20:50:04 <04dracoomega> I want to refactor at least one thing about how Marionette works in the backend first (shouldn't be too hard, tomorrow or the next day). Mostly things have worked pretty smoothly with it, and there's been few significant bugs, even. It kind of felt like I ought to wait at least a week from putting it on experimental in the first place or it almost feels like "What was the point?" but I could be convinced otherwise. 20:55:13 <04dracoomega> (Response among people actually playing Dith, that I've had the chance to read or talk with, has been pretty positive) 21:05:45 03dolorous02 07[dith_experimental] * 0.32-a0-1350-g1531088bb2: Remove now-obsolete Dith penance message. 10(2 minutes ago, 1 file, 0+ 4-) 13https://github.com/crawl/crawl/commit/1531088bb2b0 22:35:21 Unstable branch on crawl.develz.org updated to: 0.32-a0-1339-g925b980f54 (34) 22:58:12 Windows builds of master branch on crawl.develz.org updated to: 0.32-a0-1339-g925b980f54 23:26:28 Unstable branch on cbro.berotato.org updated to: 0.32-a0-1339-g925b980f54 (34) 23:55:13 Monster database of master branch on crawl.develz.org updated to: 0.32-a0-1339-g925b980f54